prompt
stringlengths 24
70.5k
| response
stringlengths 271
16.7k
| metadata
stringlengths 145
152
|
|---|---|---|
feat(analytics): add `sessionized_metrics` for disputes (backwards compatibility)
## Current Behaviour
- There is no `sessionized_metrics` module for disputes like there is for `payments` and `payment_intents`
## Proposed Changes
- create `sessionized_metrics` module for disputes
|
<think>
PR Context:
- Title: feat(analytics): add `sessionized_metrics` for disputes analytics
- Merged: 2024-11-26T13:58:33Z
- Files changed: 13 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Add sessionized metrics module and implement backwards compatibility.
- Add the `sessionizer_dispute` table support for Sessionized metrics.
### Fixes #6572
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(analytics): add `sessionized_metrics` for disputes analytics (#6573)
Co-authored-by: hyperswitc
Files to modify:
**crates/analytics/src/clickhouse.rs**
Modify existing code
**crates/analytics/src/disputes/accumulators.rs**
Modify existing code
**crates/analytics/src/disputes/core.rs**
Modify existing code
**crates/analytics/src/disputes/metrics.rs**
Add:
- mod: private::sessionized_metrics
**crates/analytics/src/disputes/metrics/sessionized_metrics/dispute_status_metric.rs**
Add:
- function: private::load_metrics
- struct: pub::DisputeStatusMetric
- impl: impl super::DisputeMetric<T> for DisputeStatusMetric
**crates/analytics/src/disputes/metrics/sessionized_metrics/mod.rs**
Add:
- mod: private::dispute_status_metric
- mod: private::total_amount_disputed
- mod: private::total_dispute_lost_amount
**crates/analytics/src/disputes/metrics/sessionized_metrics/total_amount_disputed.rs**
Add:
- function: private::load_metrics
- struct: pub::TotalAmountDisputed
- impl: impl super::DisputeMetric<T> for TotalAmountDisputed
**crates/analytics/src/disputes/metrics/sessionized_metrics/total_dispute_lost_amount.rs**
Add:
- function: private::load_metrics
- struct: pub::TotalDisputeLostAmount
- impl: impl super::DisputeMetric<T> for TotalDisputeLostAmount
**crates/analytics/src/sqlx.rs**
Modify existing code
**crates/analytics/src/types.rs**
Modify existing code
**crates/api_models/src/analytics.rs**
Add:
- struct: pub::DisputesAnalyticsMetadata
- struct: pub::DisputesMetricsResponse
**crates/api_models/src/analytics/disputes.rs**
Modify existing code
**crates/api_models/src/events.rs**
Add:
- function: private::get_api_event_type
- impl: impl ApiEventMetric for DisputesMetricsResponse<T>
|
{"issue_number": 6572, "pr_number": 6573, "commits_count": 1, "files_changed": 13, "response_length": 2614, "file_count": 15, "needs_breakdown": false}
|
[FEATURE] add tokenization action handling to payment flow in v2
### Feature Description
This feature add connector-level tokenization to Hyperswitch V2, allowing secure storage of card data as tokens at payment connectors like Braintree.
### Possible Implementation
For connector-level tokenization:
1.When a payment comes with raw card data and the connector supports tokenization, send the card details to the connector’s tokenization API.
2. Receive the tokenized payment method ID.
3. Use the token for the subsequent authorization or capture call.
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(payments): add tokenization action handling to payment flow for braintree
- Merged: 2025-09-30T08:07:13Z
- Files changed: 3 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This feature add connector-level tokenization to Hyperswitch V2, allowing secure storage of card data as tokens at payment connectors like Braintree.
Additionally Tokenization in router is not implemented, because of temp locker mechanism whi
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payments): add tokenization action handling to payment flow for braintree (#9506)
Files to modify:
**crates/router/src/core/payments.rs**
Add:
- function: private::is_payment_method_tokenization_enabled_for_connector
- function: private::is_payment_flow_allowed_for_connector
- enum: pub::TokenizationAction
**crates/router/src/core/payments/operations.rs**
Add:
- function: private::get_connector_tokenization_action
**crates/router/src/core/payments/operations/payment_confirm_intent.rs**
Add:
- function: private::get_connector_tokenization_action
|
{"issue_number": 9501, "pr_number": 9506, "commits_count": 1, "files_changed": 3, "response_length": 1396, "file_count": 5, "needs_breakdown": false}
|
chore(codeowners): add codeowners data for PR reviews
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
Adding a CODEOWNERS file for facilitating PR reviews for teams
### Additional Changes
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!-- Provide links to the files with corresponding changes -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
This leads to better ownership boundaries & increased efficiency for reviewers
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Doesn't need to be tested
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: feat(core): Add click to pay support in hyperswitch
- Merged: 2024-12-16T14:25:44Z
- Files changed: 30 files
- Commits: 30 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] New feature
## Description
<!-- Describe your changes in detail -->
Add click to pay and unified authentication service integration in core
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
check payments sanity
#1 : Create Business profile with `"is_click_to_pay_enabled": true`
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(core): Add click to pay support in hyperswitch (#6769)
Co-authored-by: sai-harsha-vardhan <hars
Files to modify:
**crates/api_models/src/connector_enums.rs**
Modify existing code
**crates/common_enums/src/enums.rs**
Modify existing code
**crates/connector_configs/src/connector.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors.rs**
Add:
- mod: pub::ctp_mastercard
**crates/hyperswitch_connectors/src/connectors/ctp_mastercard.rs**
Add:
- function: private::build_headers
- function: private::id
- function: private::base_url
- function: private::get_webhook_object_reference_id
- function: private::get_webhook_event_type
- function: private::get_webhook_resource_object
- struct: pub::CtpMastercard
- impl: impl api::Payment for CtpMastercard
- impl: impl api::PaymentSession for CtpMastercard
- impl: impl api::ConnectorAccessToken for CtpMastercard
- impl: impl api::MandateSetup for CtpMastercard
- impl: impl api::PaymentAuthorize for CtpMastercard
- impl: impl api::PaymentSync for CtpMastercard
- impl: impl api::PaymentCapture for CtpMastercard
- impl: impl api::PaymentVoid for CtpMastercard
- impl: impl api::Refund for CtpMastercard
- impl: impl api::RefundExecute for CtpMastercard
- impl: impl api::RefundSync for CtpMastercard
- impl: impl api::PaymentToken for CtpMastercard
- impl: impl ConnectorIntegration<PaymentMethodToken, PaymentMethodTokenizationData, PaymentsResponseData> for CtpMastercard
- impl: impl ConnectorCommonExt<Flow, Request, Response> for CtpMastercard
- impl: impl ConnectorCommon for CtpMastercard
- impl: impl ConnectorValidation for CtpMastercard
- impl: impl ConnectorIntegration<Session, PaymentsSessionData, PaymentsResponseData> for CtpMastercard
- impl: impl ConnectorIntegration<AccessTokenAuth, AccessTokenRequestData, AccessToken> for CtpMastercard
- impl: impl ConnectorIntegration<SetupMandate, SetupMandateRequestData, PaymentsResponseData> for CtpMastercard
- impl: impl ConnectorIntegration<Authorize, PaymentsAuthorizeData, PaymentsResponseData> for CtpMastercard
- impl: impl ConnectorIntegration<PSync, PaymentsSyncData, PaymentsResponseData> for CtpMastercard
- impl: impl ConnectorIntegration<Capture, PaymentsCaptureData, PaymentsResponseData> for CtpMastercard
- impl: impl ConnectorIntegration<RSync, RefundsData, RefundsResponseData> for CtpMastercard
- impl: impl ConnectorIntegration<Void, PaymentsCancelData, PaymentsResponseData> for CtpMastercard
- impl: impl ConnectorIntegration<Execute, RefundsData, RefundsResponseData> for CtpMastercard
- impl: impl webhooks::IncomingWebhook for CtpMastercard
**crates/hyperswitch_connectors/src/connectors/unified_authentication_service.rs**
Remove:
- function: private::get_auth_header
- function: private::get_headers
- function: private::get_content_type
- impl: impl ConnectorIntegration<Authorize, PaymentsAuthorizeData, PaymentsResponseData> for unified_authentication_service::UnifiedAuthenticationServicePaymentsRequest::try_from(
req: &PaymentsAuthorizeRouterData,
.url(&types::PaymentsAuthorizeType::get_url(
.headers(types::PaymentsAuthorizeType::get_headers(
.set_body(types::PaymentsAuthorizeType::get_request_body(
data: &PaymentsAuthorizeRouterData,
) -> CustomResult<PaymentsAuthorizeRouterData, errors::ConnectorError> {
let response: unified_authentication_service::UnifiedAuthenticationServicePaymentsResponse =
.parse_struct("UnifiedAuthenticationService PaymentsAuthorizeResponse")
impl ConnectorIntegration<PSync, PaymentsSyncData, PaymentsResponseData>
for UnifiedAuthenticationService
req: &PaymentsSyncRouterData,
_req: &PaymentsSyncRouterData,
_connectors: &Connectors,
) -> CustomResult<String, errors::ConnectorError> {
Err(errors::ConnectorError::NotImplemented("get_url method".to_string()).into())
}
fn build_request(
&self,
req: &PaymentsSyncRouterData,
connectors: &Connectors,
) -> CustomResult<Option<Request>, errors::ConnectorError> {
Ok(Some(
RequestBuilder::new()
.method(Method::Get)
.url(&types::PaymentsSyncType::get_url(self, req, connectors)?)
.attach_default_headers()
.headers(types::PaymentsSyncType::get_headers(self, req, connectors)?)
.build(),
))
}
fn handle_response(
&self,
data: &PaymentsSyncRouterData,
event_builder: Option<&mut ConnectorEvent>,
res: Response,
) -> CustomResult<PaymentsSyncRouterData, errors::ConnectorError> {
let response: unified_authentication_service::UnifiedAuthenticationServicePaymentsResponse =
res.response
.parse_struct("unified_authentication_service PaymentsSyncResponse")
.change_context(errors::ConnectorError::ResponseDeserializationFailed)?;
event_builder.map(|i| i.set_response_body(&response));
router_env::logger::info!(connector_response=?response);
RouterData::try_from(ResponseRouterData {
response,
data: data.clone(),
http_code: res.status_code,
})
}
fn get_error_response(
&self,
res: Response,
event_builder: Option<&mut ConnectorEvent>,
) -> CustomResult<ErrorResponse, errors::ConnectorError>
- impl: impl ConnectorIntegration<Capture, PaymentsCaptureData, PaymentsResponseData> for UnifiedAuthenticationService
Add:
- impl: impl api::UnifiedAuthenticationService for UnifiedAuthenticationService
- impl: impl api::UasPreAuthentication for UnifiedAuthenticationService
- impl: impl api::UasPostAuthentication for UnifiedAuthenticationService
**crates/hyperswitch_connectors/src/connectors/unified_authentication_service/transformers.rs**
Remove:
- function: private::from
- function: private::from
- struct: pub::UnifiedAuthenticationServicePaymentsRequest
- struct: pub::UnifiedAuthenticationServicePaymentsResponse
- enum: pub::UnifiedAuthenticationServicePaymentStatus
- impl: impl From<(StringMinorUnit, T)> for UnifiedAuthenticationServiceRouterData<T>
- impl: impl From<UnifiedAuthenticationServicePaymentStatus> for common_enums::AttemptStatus
Add:
- struct: pub::UnifiedAuthenticationServicePreAuthenticateRequest
- struct: pub::PaymentDetails
- struct: pub::TransactionDetails
- struct: pub::ThreeDSData
- struct: pub::Acquirer
- struct: pub::BrowserInfo
- struct: pub::AuthenticationInfo
- struct: pub::CtpServiceDetails
- struct: pub::ServiceSessionIds
- struct: pub::MerchantDetails
- struct: pub::Address
- enum: pub::AuthType
**crates/hyperswitch_connectors/src/constants.rs**
Modify existing code
**crates/hyperswitch_connectors/src/default_implementations.rs**
Modify existing code
**crates/hyperswitch_connectors/src/default_implementations_v2.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payment_method_data.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/router_flow_types.rs**
Add:
- mod: pub::unified_authentication_service
**crates/hyperswitch_domain_models/src/router_flow_types/unified_authentication_service.rs**
Add:
- struct: pub::PreAuthenticate
- struct: pub::PostAuthenticate
**crates/hyperswitch_domain_models/src/router_request_types/unified_authentication_service.rs**
Remove:
- struct: pub::UasPostAuthenticationRequestData
Add:
- struct: pub::UasPostAuthenticationRequestData
**crates/hyperswitch_domain_models/src/types.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/api.rs**
Add:
- trait: pub::UnifiedAuthenticationService
- trait: pub::UasPreAuthentication
- trait: pub::UasPostAuthentication
- trait: pub::UnifiedAuthenticationServiceV2
- trait: pub::UasPreAuthenticationV2
- trait: pub::UasPostAuthenticationV2
**crates/hyperswitch_interfaces/src/configs.rs**
Add:
- function: pub::validate
- struct: pub::NoParams
- impl: impl NoParams
**crates/hyperswitch_interfaces/src/types.rs**
Modify existing code
**crates/router/src/connector.rs**
Modify existing code
**crates/router/src/connector/adyen/transformers.rs**
Remove:
- function: private::get_optional_shopper_email
Add:
- function: private::try_from
- function: private::try_from
- impl: impl TryFrom<(&domain::NetworkTokenData, Option<Secret<String>>)> for AdyenPaymentMethod<'_>
- impl: impl TryFrom<(
&AdyenRouterData<&types::PaymentsAuthorizeRouterData>,
&domain::NetworkTokenData,
)> for AdyenPaymentRequest<'_>
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/payment_methods.rs**
Modify existing code
**crates/router/src/core/payment_methods/network_tokenization.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/connector_integration_v2_impls.rs**
Remove:
- impl: impl api::UasPreAuthenticationV2 for $connector
- impl: impl api::UasPostAuthenticationV2 for $connector
Add:
- impl: impl UasPreAuthenticationV2 for $connector
- impl: impl UasPostAuthenticationV2 for $connector
**crates/router/src/core/payments/flows.rs**
Remove:
- impl: impl api::UnifiedAuthenticationService for connector::DummyConnector<T>
**crates/router/src/core/payments/helpers.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_complete_authorize.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_confirm.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_create.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_update.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/core/unified_authentication_service.rs**
Modify existing code
**crates/router/src/core/unified_authentication_service/transformers.rs**
Modify existing code
**crates/router/src/core/unified_authentication_service/types.rs**
Modify existing code
**crates/router/src/types/api.rs**
Remove:
- mod: pub::unified_authentication_service
- mod: pub::unified_authentication_service_v2
**crates/router/src/types/api/authentication.rs**
Modify existing code
**crates/router/src/types/api/unified_authentication_service.rs**
Remove:
- struct: pub::PreAuthenticate
- struct: pub::PostAuthenticate
- trait: pub::UnifiedAuthenticationService
- trait: pub::UasPreAuthentication
- trait: pub::UasPostAuthentication
**crates/router/src/types/api/unified_authentication_service_v2.rs**
Remove:
- trait: pub::UnifiedAuthenticationServiceV2
- trait: pub::UasPreAuthenticationV2
- trait: pub::UasPostAuthenticationV2
**crates/router/src/types/transformers.rs**
Modify existing code
|
{"issue_number": 1, "pr_number": 6769, "commits_count": 1, "files_changed": 30, "response_length": 11983, "file_count": 42, "needs_breakdown": true}
|
docs: Adding Unified error codes to the API - Ref
Adding Unified error codes to the API - Ref
|
<think>
PR Context:
- Title: docs(error_codes): add unified error codes
- Merged: 2024-10-15T14:02:06Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [X] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Helps closing - #6318
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6318, "pr_number": 6319, "commits_count": 0, "files_changed": 1, "response_length": 772, "file_count": 0, "needs_breakdown": false}
|
[FEATURE] add payments get-intent API for v2
# Feature Description
Add payments `get-intent` API for v2
|
<think>
PR Context:
- Title: feat(router): Add payments get-intent API for v2
- Merged: 2024-10-30T16:28:52Z
- Files changed: 18 files
- Commits: 8 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Added `get-intent` API for payments
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(router): Add payments get-intent API for v2 (#6396)
Co-authored-by: hyperswitch-bot[bot] <14852
Files to modify:
**crates/api_models/src/events/payment.rs**
Remove:
- impl: impl ApiEventMetric for PaymentsCreateIntentResponse
Add:
- function: private::get_api_event_type
- impl: impl ApiEventMetric for PaymentsGetIntentRequest
- impl: impl ApiEventMetric for PaymentsIntentResponse
**crates/api_models/src/payments.rs**
Remove:
- struct: pub::PaymentsCreateIntentResponse
Add:
- struct: pub::PaymentsGetIntentRequest
- struct: pub::PaymentsIntentResponse
**crates/hyperswitch_domain_models/src/router_flow_types/payments.rs**
Remove:
- struct: pub::CreateIntent
Add:
- struct: pub::PaymentCreateIntent
- struct: pub::PaymentGetIntent
**crates/openapi/src/openapi_v2.rs**
Modify existing code
**crates/openapi/src/routes/payments.rs**
Add:
- function: pub::payments_get_intent
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/operations.rs**
Remove:
- mod: pub::payment_confirm_intent
Add:
- mod: pub::payment_confirm_intent
- mod: pub::payment_get_intent
**crates/router/src/core/payments/operations/payment_get_intent.rs**
Add:
- function: private::to_validate_request
- function: private::to_get_tracker
- function: private::to_domain
- function: private::to_update_tracker
- function: private::to_validate_request
- function: private::to_get_tracker
- function: private::to_domain
- function: private::to_update_tracker
- function: private::get_trackers
- function: private::update_trackers
- function: private::validate_request
- function: private::get_customer_details
- function: private::make_pm_data
- function: private::get_connector
- function: private::guard_payment_against_blocklist
- struct: pub::PaymentGetIntent
- impl: impl Operation<F, PaymentsGetIntentRequest> for &PaymentGetIntent
- impl: impl Operation<F, PaymentsGetIntentRequest> for PaymentGetIntent
- impl: impl GetTracker<F, payments::PaymentIntentData<F>, PaymentsGetIntentRequest> for PaymentGetIntent
- impl: impl UpdateTracker<F, payments::PaymentIntentData<F>, PaymentsGetIntentRequest> for PaymentGetIntent
- impl: impl ValidateRequest<F, PaymentsGetIntentRequest, payments::PaymentIntentData<F>> for PaymentGetIntent
- impl: impl Domain<F, PaymentsGetIntentRequest, payments::PaymentIntentData<F>> for PaymentGetIntent
**crates/router/src/core/payments/transformers.rs**
Remove:
- impl: impl ToResponse<F, D, Op> for api::PaymentsCreateIntentResponse
Add:
- impl: impl ToResponse<F, D, Op> for api::PaymentsIntentResponse
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/lock_utils.rs**
Modify existing code
**crates/router/src/routes/payments.rs**
Add:
- function: pub::payments_get_intent
**crates/router/src/services/api.rs**
Remove:
- impl: impl Authenticate for api_models::payments::PaymentsCreateIntentRequest
**crates/router/src/types/api/payments.rs**
Modify existing code
**crates/router_env/src/logger/types.rs**
Modify existing code
|
{"issue_number": 6395, "pr_number": 6396, "commits_count": 1, "files_changed": 18, "response_length": 4012, "file_count": 17, "needs_breakdown": true}
|
fix(connector): [AUTHORIZEDOTNET] customer id population fixed in authorize flow
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Fixed customer ID population in the Authorize flow.
- Previously, when passing customer details for normal payments, the createConnectorCustomer flow correctly created the customer.
- However, in the `Authorize` flow, we were passing the payment_id as the customer_id. If the length validation failed, a random string was being passed instead.
- This resulted in a random string always being sent as the customer_id, which caused a new customer to be created on Authorize.NET’s dashboard for every transaction.
- As a result, duplicate customers were being created.
Fix:
- Updated the flow to pass the correct customer_id in the customer details instead of payment_id.
- This prevents duplicate customer creation on Authorize.NET.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_HcJT7607MkJ2yANWr7PUgr8djox0jNozuRQSSW40guBXj5RQnH0CPKvbtjZ4MKBA' \
--data-raw '
{
"amount": 1,
"currency": "USD",
"confirm": true,
// "customer_id": "cus_sweta2",
// "email": "johndoe@gmail.com",
"capture_method": "manual",
"description": "test payment",
"customer": {
"id": "sweta33",
"name": "Sweta Sharma",
"email": "sweta33@gmail.com",
"phone": "1234567890",
"phone_country_code": "+1"
},
"setup_future_usage": "off_session",
"payment_type": "normal",
"off_session": true,
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "07",
"card_exp_year": "26",
"card_holder_name": "Joseph Does",
"card_cvc": "123"
}
},
"customer_acceptance": {
"acceptance_type": "offline",
"accepted_at": "1963-05-03T04:07:52.723Z",
"online": {
"ip_address": "125.0.0.1",
"user_agent": "amet irure esse"
}
},
"billing": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "John",
"last_name": "Doe"
},
"email": "johndoe@gmail.com"
},
"shipping": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "John",
"last_name": "Doe"
},
"email": "cus_sweta@gmail.com"
}
}
'
```
Response
```
{"payment_id":"pay_Itc4g0ujKGRW0tWhku2e","merchant_id":"merchant_1756373651","status":"requires_capture","amount":1,"net_amount":1,"shipping_cost":null,"amount_capturable":1,"amount_received":null,"connector":"authorizedotnet","client_secret":"pay_Itc4g0ujKGRW0tWhku2e_secret_7YHCDDZ805TWhxdirnfP","created":"2025-08-28T12:33:37.236Z","currency":"USD","customer_id":"sweta33","customer":{"id":"sweta33","name":"Sweta Sharma","email":"sweta33@gmail.com","phone":"1234567890","phone_country_code":"+1"},"description":"test payment","refunds":null,"disputes":null,"mandate_id":null,"mandate_data":null,"setup_future_usage":"off_session","off_session":true,"capture_on":null,"capture_method":"manual","payment_method":"card","payment_method_data":{"card":{"last4":"4242","card_type":null,"card_network":null,"card_issuer":null,"card_issuing_country":null,"card_isin":"424242","card_extended_bin":null,"card_exp_month":"07","card_exp_year":"26","card_holder_name":"Joseph Does","payment_checks":{"description":"The street address and postal code matched.","avs_result_code":"Y"},"authentication_data":null},"billing":null},"payment_token":null,"shipping":{"address":{"city":"San Fransico","country":"US","line1":"1467","line2":"Harrison Street","line3":"Harrison Street","zip":"94122","state":"California","first_name":"John","last_name":"Doe","origin_zip":null},"phone":null,"email":"cus_sweta@gmail.com"},"billing":{"address":{"city":"San Fransico","country":"US","line1":"1467","line2":"Harrison Street","line3":"Harrison Street","zip":"94122","state":"California","first_name":"John","last_name":"Doe","origin_zip":null},"phone":null,"email":"johndoe@gmail.com"},"order_details":null,"email":"sweta33@gmail.com","name":"Sweta Sharma","phone":"1234567890","return_url":null,"authentication_type":"no_three_ds","statement_descriptor_name":null,"statement_descriptor_suffix":null,"next_action":null,"cancellation_reason":null,"error_code":null,"error_message":null,"unified_code":null,"unified_message":null,"payment_experience":null,"payment_method_type":"credit","connector_label":null,"business_country":null,"business_label":"default","business_sub_label":null,"allowed_payment_method_types":null,"ephemeral_key":{"customer_id":"sweta33","created_at":1756384417,"expires":1756388017,"secret":"epk_5af34f19e9754bd79f97846e3ef3c2c9"},"manual_retry_allowed":false,"connector_transaction_id":"120069967875","frm_message":null,"metadata":null,"connector_metadata":null,"feature_metadata":{"redirect_response":null,"search_tags":null,"apple_pay_recurring_details":null,"gateway_system":"direct"},"reference_id":"120069967875","payment_link":null,"profile_id":"pro_uSL0fZR2ECJYAD8I2u1r","surcharge_details":null,"attempt_count":1,"merchant_decision":null,"merchant_connector_id":"mca_yyPYHyKpU13WHygZFtpl","incremental_authorization_allowed":false,"authorization_count":null,"incremental_authorizations":null,"external_authentication_details":null,"external_3ds_authentication_attempted":false,"expires_on":"2025-08-28T12:48:37.235Z","fingerprint":null,"browser_info":null,"payment_channel":null,"payment_method_id":"pm_dcrhr0yU9aq5L3qwH90J","network_transaction_id":"HWAN991WJ003XPFWKEF1T5E","payment_method_status":"active","updated":"2025-08-28T12:33:40.138Z","split_payments":null,"frm_metadata":null,"extended_authorization_applied":null,"capture_before":null,"merchant_order_reference_id":null,"order_tax_amount":null,"connector_mandate_id":null,"card_discovery":"manual","force_3ds_challenge":false,"force_3ds_challenge_trigger":false,"issuer_error_code":null,"issuer_error_message":null,"is_iframe_redirection_enabled":null,"whole_connector_response":null,"enable_partial_authorization":null}
```
customer created only once for normal payments
<img width="597" height="525" alt="Screenshot 2025-08-28 at 6 09 09 PM" src="https://github.com/user-attachments/assets/6184684f-b99a-43d1-8b8f-f77b0d6bf16c" />
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [ ] I formatted the code `cargo +nightly fmt --all`
- [ ] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(connector): Revert [AUTHORIZEDOTNET] customer id population fixed in authorize flow
- Merged: 2025-09-04T07:19:18Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
Reverts juspay/hyperswitch#9079
If a customer profile is not created during the Authorize call, the customer_profile_id and customer_payment_profile_id are not returned in the transaction response. As a result, the connector_mandate_id is populated as null, causing subsequent MIT transactions with "payment_type": "normal" to fail.
To avoid this issue, we are reverting this PR.
Impact of revert:
Reverting will ensure MIT transactions work as expected, but it will lead to two customer re
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): Revert [AUTHORIZEDOTNET] customer id population fixed in authorize flow (#9253)
Files to modify:
**crates/hyperswitch_connectors/src/connectors/authorizedotnet/transformers.rs**
Modify existing code
|
{"issue_number": 9079, "pr_number": 9253, "commits_count": 1, "files_changed": 1, "response_length": 1038, "file_count": 3, "needs_breakdown": false}
|
[BUG] mandate details are not persisted for Adyen connector
### Bug Description
This is specific to Adyen's connector integration.
In case mandate details were not present in the response of payment sync with Adyen, these details are sent through webhooks. However, these details are not being persisted in DB leading to MIT failures.
### Expected Behavior
Mandate details sent in the webhook's request should be persisted in payment_methods table for future MITs
### Actual Behavior
Mandate details sent in the webhook's request are not persisted in `payment_methods` table.
### Steps To Reproduce
Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to reproduce, if relevant.
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
### Context For The Bug
_No response_
### Environment
Are you using hyperswitch hosted version? Yes/No
If yes, please provide the value of the `x-request-id` response header to help us debug your issue.
If not (or if building/running locally), please provide the following details:
1. Operating System or Linux distribution:
2. Rust version (output of `rustc --version`): ``
3. App version (output of `cargo r --features vergen -- --version`): ``
### Have you spent some time checking if this bug has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: fix(connector): adyen - propagate connector mandate details in incoming webhooks
- Merged: 2024-12-02T18:30:38Z
- Files changed: 2 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in the linked #6719
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Fo
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): adyen - propagate connector mandate details in incoming webhooks (#6720)
Files to modify:
**crates/router/src/connector/adyen.rs**
Add:
- function: private::get_mandate_details
**crates/router/src/connector/adyen/transformers.rs**
Modify existing code
|
{"issue_number": 6719, "pr_number": 6720, "commits_count": 1, "files_changed": 2, "response_length": 1091, "file_count": 4, "needs_breakdown": false}
|
CI DB Migration consistency checks failing after diesel_cli 2.3.0 update
After the release of diesel_cli version `2.3.0`, the CI checks for DB migration consistency are failing due to a formatting difference in the output.
diesel_cli version 2.3.0 expects to call rustfmt to format its output. If rustfmt is not installed on the system it will give an error.
Need to add a step to install rustfmt to fix the workflow
|
<think>
PR Context:
- Title: ci(migration-check): install rustfmt to address migration run failures
- Merged: 2025-09-15T12:52:03Z
- Files changed: 1 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
- `diesel_cli` version `2.3.0` expects to call `rustfmt` to format its output. If `rustfmt` is not installed on the system it will give an error.
- Added a step to install `rustfmt` to fix the workflow
### Additional Changes
- [ ] This
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 9385, "pr_number": 9386, "commits_count": 0, "files_changed": 1, "response_length": 800, "file_count": 0, "needs_breakdown": false}
|
fix: merchant order ref id filter and refund_id filter
- Add merchant_order reference id filter for payments list
- Fix refunds list filter, search by refund id. (It is construction a totally new filter ignoring the merchant id when searching)
|
<think>
PR Context:
- Title: feat(payments): add merchant order ref id filter
- Merged: 2024-11-25T14:06:30Z
- Files changed: 5 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
The PR
- Add merchant order reference id filter for payments list
- Fix bug for search by refund id (or payment_id), using `or` instead of `or_filter`. Earlier we were searching in whole list, ignoring the filter previously applied in the query.
However this was the only case for w
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payments): add merchant order ref id filter (#6630)
Files to modify:
**crates/api_models/src/payments.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments/payment_intent.rs**
Modify existing code
**crates/router/src/types/storage/dispute.rs**
Modify existing code
**crates/router/src/types/storage/refund.rs**
Modify existing code
**crates/storage_impl/src/payments/payment_intent.rs**
Modify existing code
|
{"issue_number": 6629, "pr_number": 6630, "commits_count": 1, "files_changed": 5, "response_length": 1229, "file_count": 7, "needs_breakdown": false}
|
refactor(tenant): use tenant id type
Refactor: Use tenant_id type instead of string for better type safety
|
<think>
PR Context:
- Title: refactor(tenant): use tenant id type
- Merged: 2024-11-26T09:12:05Z
- Files changed: 30 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Use tenant_id type for better type safety
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding c
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(tenant): use tenant id type (#6643)
Co-authored-by: hyperswitch-bot[bot] <148525504+hypersw
Files to modify:
**crates/common_utils/src/id_type.rs**
Add:
- mod: private::tenant
**crates/common_utils/src/id_type/organization.rs**
Modify existing code
**crates/common_utils/src/id_type/tenant.rs**
Add:
- function: pub::try_from_string
- impl: impl TenantId
**crates/common_utils/src/types/theme.rs**
Modify existing code
**crates/diesel_models/src/user/theme.rs**
Modify existing code
**crates/diesel_models/src/user_role.rs**
Modify existing code
**crates/drainer/src/handler.rs**
Modify existing code
**crates/drainer/src/health_check.rs**
Modify existing code
**crates/drainer/src/lib.rs**
Modify existing code
**crates/drainer/src/settings.rs**
Remove:
- struct: pub::TenantConfig
Add:
- struct: pub::TenantConfig
**crates/router/src/configs/settings.rs**
Remove:
- struct: pub::TenantConfig
Add:
- struct: pub::TenantConfig
**crates/router/src/core/payment_methods/transformers.rs**
Modify existing code
**crates/router/src/core/routing/helpers.rs**
Modify existing code
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/db/events.rs**
Modify existing code
**crates/router/src/db/merchant_connector_account.rs**
Modify existing code
**crates/router/src/db/merchant_key_store.rs**
Modify existing code
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/services/api.rs**
Modify existing code
**crates/router/src/services/authentication.rs**
Modify existing code
**crates/router/src/services/authorization.rs**
Modify existing code
**crates/router/src/types/domain/user.rs**
Modify existing code
**crates/router/src/utils/user.rs**
Modify existing code
**crates/router/tests/cache.rs**
Modify existing code
**crates/router/tests/connectors/aci.rs**
Modify existing code
**crates/router/tests/connectors/utils.rs**
Modify existing code
**crates/router/tests/payments.rs**
Modify existing code
**crates/router/tests/payments2.rs**
Modify existing code
**crates/router/tests/services.rs**
Modify existing code
**crates/scheduler/src/consumer.rs**
Modify existing code
**crates/scheduler/src/producer.rs**
Modify existing code
**crates/scheduler/src/scheduler.rs**
Modify existing code
|
{"issue_number": 6642, "pr_number": 6643, "commits_count": 1, "files_changed": 30, "response_length": 3142, "file_count": 34, "needs_breakdown": true}
|
[FIX]: Make v2 endpoints follow standard API conventions
There are a lot of minor inconsistencies in v2 endpoints. Fix them in accordance with https://google.aip.dev/general
|
<think>
PR Context:
- Title: fix(router): Make v2 endpoints follow standard naming conventions
- Merged: 2025-07-21T15:41:20Z
- Files changed: 24 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Consistently use kebab case in endpoint URLs
- Use plural form of resources in URLs, i.e. instead of `/v2/organization`, use `/v2/organizations`
Renamed (current version removed) endpoints:
`/v2/organization` -> `/v2/organizations`
`/v
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(router): Make v2 endpoints follow standard naming conventions (#8630)
Co-authored-by: hyperswitc
Files to modify:
**crates/hyperswitch_connectors/src/connectors/hyperswitch_vault.rs**
Modify existing code
**crates/openapi/src/routes/organization.rs**
Modify existing code
**crates/openapi/src/routes/payment_method.rs**
Modify existing code
**crates/openapi/src/routes/refunds.rs**
Modify existing code
**crates/openapi/src/routes/revenue_recovery.rs**
Modify existing code
**crates/openapi/src/routes/routing.rs**
Modify existing code
**crates/router/src/lib.rs**
Modify existing code
**crates/router/src/routes.rs**
Modify existing code
**crates/router/src/routes/app.rs**
Remove:
- struct: pub::User
Add:
- function: pub::server
- function: pub::server
- struct: pub::User
- struct: pub::ProcessTrackerDeprecated
- impl: impl User
- impl: impl ProcessTrackerDeprecated
|
{"issue_number": 8629, "pr_number": 8630, "commits_count": 1, "files_changed": 24, "response_length": 1732, "file_count": 11, "needs_breakdown": false}
|
feat(config): update vector config
# Current Behaviour
- Sdk logs pushes `publishable_key` in the `merchant_id` field.
- open search logs have some irrelevant fields.
# Proposed Changes
- transform sdk logs and update the correct corresponding `merchant_id` of the pre-existing `publishable_key` value
- add some more except/ignore fields in open search sinks.
|
<think>
PR Context:
- Title: feat(config): update vector config
- Merged: 2024-11-05T07:38:03Z
- Files changed: 1 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Fixes #6364
## Description
<!-- Describe your changes in detail -->
- adding a transform for `sdk` logs that fetches a value from an enrichment table `sdk_map` populated by file `sdk_map.csv` and updates the fields using this value.
- adding some fields to ignore/except in `opensearch` lo
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6364, "pr_number": 6365, "commits_count": 0, "files_changed": 1, "response_length": 764, "file_count": 0, "needs_breakdown": false}
|
Adding Contributors Guide to the Readme of the repository
Being an open source project, we look forward to contributors from across the world. For that we have outlined few changes which will make it easier for contributors to navigate through the project with more ease, and quickly develop a better understanding of the working of different components of Hyperswitch.
|
<think>
PR Context:
- Title: docs: upload new logos
- Merged: 2024-10-18T14:34:22Z
- Files changed: 5 files
- Commits: 9 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [x] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Closes - #5175
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with c
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 5175, "pr_number": 6368, "commits_count": 0, "files_changed": 5, "response_length": 752, "file_count": 0, "needs_breakdown": false}
|
[FEATURE] Add delete merchant account endpoint in v2
### Feature Description
[FEATURE] Add delete merchant account endpoint in v2
### Possible Implementation
Add a new endpoint in routes for delete merchant account in v2
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(merchant): Add delete endpoint for merchant accounts v2
- Merged: None
- Files changed: 4 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Add merchant account delete route in ```app.rs```
- Update openapi spec to include the newly added route
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modif
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 8717, "pr_number": 8718, "commits_count": 0, "files_changed": 4, "response_length": 774, "file_count": 0, "needs_breakdown": false}
|
fix(connector): [Cybersource] Add type_selection_indicator as 1 for all cards
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [X] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Added `type_selection_indicator` as 1 for all cards
Reason for this change - Without this field Mastercard card payments are currently failing for a france-based merchant acquirer CMCIC in prod for cybersource, it expects type_selection_indicator as 1.
Please note, this change is a fix on top of this [PR](https://github.com/juspay/hyperswitch/pull/7828)
This change not only makes type_selection_indicator as 1 for co-badged cards, but for all cards in general.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
### call /payment for Mastercard via cybersource
`{
"amount": 700,
"currency": "EUR",
"confirm": true,
"payment_link": false,
"capture_on": "2029-09-10T10:11:12Z",
"amount_to_capture": 700,
"name": "John Doe",
"email": "dg@example.com",
"phone": "999999999",
"phone_country_code": "+1",
"description": "Its my first payment request",
"authentication_type": "no_three_ds",
"return_url": "https://google.com",
"payment_method_data": {
"card": {
"card_number": "5512459816707531",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "joseph Doe",
"card_cvc": "737"
},
"billing": {
"address": {
"line1": "1467",
"line2": "CA",
"city": "Thise",
"state": "Alsace",
"zip": "94122",
"country": "FR",
"first_name": "Henry",
"last_name": "Henry"
}
}
},
"payment_method": "card",
"payment_method_type": "credit",
"browser_info": {
"color_depth": 24,
"java_enabled": true,
"java_script_enabled": true,
"language": "en-GB",
"screen_height": 720,
"screen_width": 1280,
"time_zone": -330,
"ip_address": "208.127.127.193",
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0"
},
"metadata": {
"disable_avs": true,
"udf1": "value1",
"new_customer": "true",
"login_date": "2019-09-10T10:11:12Z"
},
"order_details": [
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
},
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
},
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
}
]
}`
<img width="880" height="762" alt="Screenshot 2025-07-16 at 3 47 00 PM" src="https://github.com/user-attachments/assets/f1806a41-1ed6-4ea5-a84d-27b8ad9ca2f8" />
### call /payment for Cobadged card via cybersource
`{
"amount": 700,
"currency": "EUR",
"confirm": true,
"payment_link": false,
"capture_on": "2029-09-10T10:11:12Z",
"amount_to_capture": 700,
"name": "John Doe",
"email": "dg@example.com",
"phone": "999999999",
"phone_country_code": "+1",
"description": "Its my first payment request",
"authentication_type": "no_three_ds",
"return_url": "https://google.com",
"payment_method_data": {
"card": {
"card_number": "4010061700000021",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "joseph Doe",
"card_cvc": "737"
},
"billing": {
"address": {
"line1": "1467",
"line2": "CA",
"city": "Thise",
"state": "Alsace",
"zip": "94122",
"country": "FR",
"first_name": "Henry",
"last_name": "Henry"
}
}
},
"payment_method": "card",
"payment_method_type": "credit",
"browser_info": {
"color_depth": 24,
"java_enabled": true,
"java_script_enabled": true,
"language": "en-GB",
"screen_height": 720,
"screen_width": 1280,
"time_zone": -330,
"ip_address": "208.127.127.193",
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0"
},
"metadata": {
"disable_avs": true,
"udf1": "value1",
"new_customer": "true",
"login_date": "2019-09-10T10:11:12Z"
},
"order_details": [
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
},
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
},
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
}
]
}`
<img width="880" height="762" alt="Screenshot 2025-07-16 at 3 46 05 PM" src="https://github.com/user-attachments/assets/c9471fdb-fbc0-431d-9dee-b8c3fb014c1f" />
### call /payment for Visa card via cybersource
`curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_wJkBplfvotDkAw5pv07JsMffdYFmnZTWKf0Rn6fWokE05NNZatQ4V2uEK0y1Re7e' \
--data-raw '{
"amount": 700,
"currency": "EUR",
"confirm": true,
"payment_link": false,
"capture_on": "2029-09-10T10:11:12Z",
"amount_to_capture": 700,
"name": "John Doe",
"email": "dg@example.com",
"phone": "999999999",
"phone_country_code": "+1",
"description": "Its my first payment request",
"authentication_type": "no_three_ds",
"return_url": "https://google.com",
"payment_method_data": {
"card": {
"card_number": "4111 1111 1111 1111",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "joseph Doe",
"card_cvc": "737"
},
"billing": {
"address": {
"line1": "1467",
"line2": "CA",
"city": "Thise",
"state": "Alsace",
"zip": "94122",
"country": "FR",
"first_name": "Henry",
"last_name": "Henry"
}
}
},
"payment_method": "card",
"payment_method_type": "credit",
"browser_info": {
"color_depth": 24,
"java_enabled": true,
"java_script_enabled": true,
"language": "en-GB",
"screen_height": 720,
"screen_width": 1280,
"time_zone": -330,
"ip_address": "208.127.127.193",
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0"
},
"metadata": {
"disable_avs": true,
"udf1": "value1",
"new_customer": "true",
"login_date": "2019-09-10T10:11:12Z"
},
"order_details": [
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
},
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
},
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
}
]
}'`
<img width="841" height="752" alt="Screenshot 2025-07-21 at 5 49 40 PM" src="https://github.com/user-attachments/assets/1763b260-5e20-4e72-85ad-cc199b688011" />
### call /payment for Mastercard card via cybersource for 3ds external authentication
**Step 1:**
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_wJkBplfvotDkAw5pv07JsMffdYFmnZTWKf0Rn6fWokE05NNZatQ4V2uEK0y1Re7e' \
--data-raw '{
"amount": 10000,
"currency": "EUR",
"confirm": true,
"payment_link": false,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"amount_to_capture": 10000,
"customer_id": "StripeCustomer",
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"phone_country_code": "+1",
"description": "Its my first payment request",
"request_external_three_ds_authentication": true,
"authentication_type": "three_ds",
"return_url": "https://google.com",
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "5512459816707531",
"card_exp_month": "12",
"card_exp_year": "2025",
"card_cvc": "000",
"card_network": "Mastercard"
}
},
"billing": {
"address": {
"line1": "1467",
"line2": "CA",
"line3": "CA",
"city": "Musterhausen",
"state": "California",
"zip": "12345",
"country": "US",
"first_name": "Debarati",
"last_name": "Ghatak"
},
"phone": {
"number": "8056594427",
"country_code": "+91"
}
},
"browser_info": {
"user_agent": "Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
"accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,\/;q=0.8",
"language": "nl-NL",
"color_depth": 24,
"ip_address": "103.77.139.95",
"screen_height": 723,
"screen_width": 1536,
"time_zone": 0,
"java_enabled": true,
"java_script_enabled": true
},
"statement_descriptor_name": "joseph",
"statement_descriptor_suffix": "JS",
"connector": ["cybersource"],
"metadata": {
"dg": "value1",
"new_customer": "true",
"login_date": "2019-09-10T10:11:12Z"
}
}'
```
<img width="880" height="762" alt="Screenshot 2025-07-16 at 3 49 17 PM" src="https://github.com/user-attachments/assets/980ceb6b-a634-45e0-a0bc-40db4379bfbf" />
**Step 2:**
```
curl --location 'http://localhost:8080/payments/pay_TxOCC3qWDM0tsOzBuYgK/3ds/authentication' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: pk_dev_66166a663cb4429c88ab4f6d9990698d' \
--data '{
"client_secret": "pay_TxOCC3qWDM0tsOzBuYgK_secret_Zop3d4G9eQ2qUh47Z60N",
"device_channel": "BRW",
"threeds_method_comp_ind": "Y"
}
'
```
<img width="880" height="762" alt="Screenshot 2025-07-16 at 3 51 16 PM" src="https://github.com/user-attachments/assets/2b116033-351a-43ef-a76b-92aa4458d9cf" />
**Step 3:**
`curl --location --request POST 'http://localhost:8080/payments/pay_HJ3ZfWWCFSRgMLk3Q0iT/merchant_1752829376/authorize/cybersource'`
<img width="880" height="762" alt="Screenshot 2025-07-16 at 3 49 27 PM" src="https://github.com/user-attachments/assets/27b4af0b-4b51-4989-a6cd-9bfceaff4119" />
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [X] I formatted the code `cargo +nightly fmt --all`
- [X] I addressed lints thrown by `cargo clippy`
- [X] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(connector): [Cybersource] Add type_selection_indicator as 1 for all cards
- Merged: None
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
…ll cards (#8663)
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Hotfix for https://github.com/juspay/hyperswitch/pull/8663
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide li
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 8663, "pr_number": 8761, "commits_count": 0, "files_changed": 1, "response_length": 791, "file_count": 0, "needs_breakdown": false}
|
[FIX] Add fallback connectors instead of active routing rule connectors if straight through connector is ineligible
Add the fallback connectors to the list of eligible connectors instead of adding connectors configured in the active routing rule in case straight through connector is ineligible
|
<think>
PR Context:
- Title: revert(routing): Add connectors from current active routing algorithm before adding fallback connectors
- Merged: None
- Files changed: 7 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Add fallback connectors to the list of eligible connectors for routing instead of connectors configured in the active routing rules
this PR reverts https://github.com/juspay/hyperswitch/pull/7921
To address failing CI checks, a commit was ch
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 8210, "pr_number": 8211, "commits_count": 0, "files_changed": 7, "response_length": 817, "file_count": 0, "needs_breakdown": false}
|
chore(codeowners): add codeowners data for PR reviews
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
Adding a CODEOWNERS file for facilitating PR reviews for teams
### Additional Changes
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!-- Provide links to the files with corresponding changes -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
This leads to better ownership boundaries & increased efficiency for reviewers
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Doesn't need to be tested
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: feat(core): add bulk tokenization flows
- Merged: 2025-03-07T13:24:06Z
- Files changed: 26 files
- Commits: 30 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR introduces below changes
- Exposes two endpoints for
- Single card tokenization
- Tokenizing raw card details with the network
- Tokenizing an existing payment method in HS with the network (card only)
- Bulk tokenization
- Tokenizing us
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(core): add bulk tokenization flows (#7066)
Co-authored-by: hyperswitch-bot[bot] <148525504+hype
Files to modify:
**crates/api_models/src/payment_methods.rs**
Add:
- function: private::from
- struct: pub::CardNetworkTokenizeRequest
- struct: pub::TokenizeCardRequest
- struct: pub::TokenizePaymentMethodRequest
- struct: pub::CardNetworkTokenizeResponse
- enum: pub::TokenizeDataRequest
- impl: impl common_utils::events::ApiEventMetric for CardNetworkTokenizeRequest
- impl: impl common_utils::events::ApiEventMetric for CardNetworkTokenizeResponse
- impl: impl From<&Card> for MigrateCardDetail
**crates/hyperswitch_domain_models/src/bulk_tokenization.rs**
Add:
- function: private::foreign_from
- function: private::foreign_from
- function: private::foreign_try_from
- function: private::foreign_from
- function: private::foreign_try_from
- function: private::foreign_from
- function: private::foreign_from
- function: private::foreign_from
- function: private::foreign_from
- function: private::foreign_from
- function: private::foreign_from
- struct: pub::CardNetworkTokenizeRequest
- struct: pub::TokenizeCardRequest
- struct: pub::TokenizePaymentMethodRequest
- struct: pub::CardNetworkTokenizeRecord
- enum: pub::TokenizeDataRequest
- impl: impl ForeignFrom<&CardNetworkTokenizeRecord> for payments_api::CustomerDetails
- impl: impl ForeignFrom<&CardNetworkTokenizeRecord> for payments_api::Address
- impl: impl ForeignTryFrom<CardNetworkTokenizeRecord> for payment_methods_api::CardNetworkTokenizeRequest
- impl: impl ForeignFrom<&TokenizeCardRequest> for payment_methods_api::MigrateCardDetail
- impl: impl ForeignTryFrom<CustomerDetails> for payments_api::CustomerDetails
- impl: impl ForeignFrom<payment_methods_api::CardNetworkTokenizeRequest> for CardNetworkTokenizeRequest
- impl: impl ForeignFrom<payment_methods_api::TokenizeDataRequest> for TokenizeDataRequest
- impl: impl ForeignFrom<payments_api::CustomerDetails> for CustomerDetails
- impl: impl ForeignFrom<payments_api::Address> for Address
- impl: impl ForeignFrom<payments_api::AddressDetails> for AddressDetails
- impl: impl ForeignFrom<payments_api::PhoneDetails> for PhoneDetails
**crates/hyperswitch_domain_models/src/lib.rs**
Add:
- mod: pub::bulk_tokenization
**crates/hyperswitch_domain_models/src/network_tokenization.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payment_method_data.rs**
Add:
- function: private::from
- struct: pub::CardDetail
- impl: impl From<&Card> for CardDetail
**crates/openapi/src/openapi.rs**
Modify existing code
**crates/openapi/src/openapi_v2.rs**
Modify existing code
**crates/openapi/src/routes/payment_method.rs**
Add:
- function: pub::tokenize_card_api
- function: pub::tokenize_card_using_pm_api
**crates/router/src/core/errors.rs**
Add:
- enum: pub::BulkNetworkTokenizationError
**crates/router/src/core/payment_methods.rs**
Add:
- mod: pub::tokenize
**crates/router/src/core/payment_methods/cards.rs**
Add:
- function: pub::tokenize_card_flow
- function: pub::execute_card_tokenization
- function: pub::execute_payment_method_tokenization
**crates/router/src/core/payment_methods/network_tokenization.rs**
Modify existing code
**crates/router/src/core/payment_methods/tokenize.rs**
Add:
- function: pub::parse_csv
- function: pub::get_tokenize_card_form_records
- function: pub::tokenize_cards
- function: private::new
- function: private::encrypt_card
- function: private::encrypt_network_token
- function: private::fetch_bin_details_and_validate_card_network
- function: private::tokenize_card
- function: private::validate_card_network
- function: private::store_network_token_in_locker
- struct: pub::CardNetworkTokenizeForm
- struct: pub::StoreLockerResponse
- struct: pub::NetworkTokenizationBuilder
- struct: pub::CardNetworkTokenizeExecutor
- trait: pub::State
- trait: pub::TransitionTo
- trait: pub::NetworkTokenizationProcess
- impl: impl NetworkTokenizationProcess<'a, D> for CardNetworkTokenizeExecutor<'a, D>
- mod: pub::card_executor
- mod: pub::payment_method_executor
**crates/router/src/core/payment_methods/tokenize/card_executor.rs**
Add:
- function: private::default
- function: pub::new
- function: pub::set_validate_result
- function: pub::set_card_details
- function: pub::set_customer
- function: pub::get_optional_card_and_cvc
- function: pub::set_token_details
- function: pub::set_stored_card_response
- function: pub::set_stored_token_response
- function: pub::set_payment_method_response
- function: pub::build
- function: pub::validate_request_and_fetch_optional_customer
- function: pub::create_customer
- function: pub::store_card_and_token_in_locker
- function: pub::store_card_in_locker
- function: pub::create_payment_method
- struct: pub::TokenizeWithCard
- struct: pub::CardRequestValidated
- struct: pub::CardDetailsAssigned
- struct: pub::CustomerAssigned
- struct: pub::CardTokenized
- struct: pub::CardStored
- struct: pub::CardTokenStored
- struct: pub::PaymentMethodCreated
- impl: impl State for TokenizeWithCard
- impl: impl State for CustomerAssigned
- impl: impl State for CardRequestValidated
- impl: impl State for CardDetailsAssigned
- impl: impl State for CardTokenized
- impl: impl State for CardStored
- impl: impl State for CardTokenStored
- impl: impl State for PaymentMethodCreated
- impl: impl TransitionTo<CardRequestValidated> for TokenizeWithCard
- impl: impl TransitionTo<CardDetailsAssigned> for CardRequestValidated
- impl: impl TransitionTo<CustomerAssigned> for CardDetailsAssigned
- impl: impl TransitionTo<CardTokenized> for CustomerAssigned
- impl: impl TransitionTo<CardTokenStored> for CardTokenized
- impl: impl TransitionTo<PaymentMethodCreated> for CardTokenStored
- impl: impl Default for NetworkTokenizationBuilder<'_, TokenizeWithCard>
- impl: impl NetworkTokenizationBuilder<'a, TokenizeWithCard>
- impl: impl NetworkTokenizationBuilder<'a, CardRequestValidated>
- impl: impl NetworkTokenizationBuilder<'a, CardDetailsAssigned>
- impl: impl NetworkTokenizationBuilder<'a, CustomerAssigned>
- impl: impl NetworkTokenizationBuilder<'a, CardTokenized>
- impl: impl NetworkTokenizationBuilder<'a, CardStored>
- impl: impl NetworkTokenizationBuilder<'a, CardTokenStored>
- impl: impl NetworkTokenizationBuilder<'_, PaymentMethodCreated>
- impl: impl CardNetworkTokenizeExecutor<'_, domain::TokenizeCardRequest>
**crates/router/src/core/payment_methods/tokenize/payment_method_executor.rs**
Add:
- function: private::default
- function: pub::new
- function: pub::set_payment_method
- function: pub::set_validate_result
- function: pub::set_card_details
- function: pub::get_optional_card_and_cvc
- function: pub::set_token_details
- function: pub::set_stored_token_response
- function: pub::set_payment_method
- function: pub::build
- function: pub::fetch_payment_method
- function: pub::validate_request_and_locker_reference_and_customer
- function: pub::update_payment_method
- struct: pub::TokenizeWithPmId
- struct: pub::PmValidated
- struct: pub::PmFetched
- struct: pub::PmAssigned
- struct: pub::PmTokenized
- struct: pub::PmTokenStored
- struct: pub::PmTokenUpdated
- impl: impl State for TokenizeWithPmId
- impl: impl State for PmValidated
- impl: impl State for PmFetched
- impl: impl State for PmAssigned
- impl: impl State for PmTokenized
- impl: impl State for PmTokenStored
- impl: impl State for PmTokenUpdated
- impl: impl TransitionTo<PmFetched> for TokenizeWithPmId
- impl: impl TransitionTo<PmValidated> for PmFetched
- impl: impl TransitionTo<PmAssigned> for PmValidated
- impl: impl TransitionTo<PmTokenized> for PmAssigned
- impl: impl TransitionTo<PmTokenStored> for PmTokenized
- impl: impl TransitionTo<PmTokenUpdated> for PmTokenStored
- impl: impl Default for NetworkTokenizationBuilder<'_, TokenizeWithPmId>
- impl: impl NetworkTokenizationBuilder<'a, TokenizeWithPmId>
- impl: impl NetworkTokenizationBuilder<'a, PmFetched>
- impl: impl NetworkTokenizationBuilder<'a, PmValidated>
- impl: impl NetworkTokenizationBuilder<'a, PmAssigned>
- impl: impl NetworkTokenizationBuilder<'a, PmTokenized>
- impl: impl NetworkTokenizationBuilder<'a, PmTokenStored>
- impl: impl NetworkTokenizationBuilder<'_, PmTokenUpdated>
- impl: impl CardNetworkTokenizeExecutor<'_, domain::TokenizePaymentMethodRequest>
**crates/router/src/core/payments/tokenization.rs**
Modify existing code
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/lock_utils.rs**
Modify existing code
**crates/router/src/routes/payment_methods.rs**
Add:
- function: pub::tokenize_card_api
- function: pub::tokenize_card_using_pm_api
- function: pub::tokenize_card_batch_api
**crates/router/src/types/api/payment_methods.rs**
Modify existing code
**crates/router/src/types/api/payments.rs**
Modify existing code
**crates/router/src/types/domain.rs**
Modify existing code
**crates/router/src/types/domain/payments.rs**
Modify existing code
**crates/router_env/src/logger/types.rs**
Modify existing code
|
{"issue_number": 1, "pr_number": 7066, "commits_count": 1, "files_changed": 26, "response_length": 10421, "file_count": 26, "needs_breakdown": true}
|
[BUG] Facilitapay env connector configs breaking WASM
It is `BodyKey` and not `Bodykey`.
Affected files:
`crates/connector_configs/toml/production.toml`
`crates/connector_configs/toml/sandbox.toml`
`crates/connector_configs/toml/integration_test.toml`
this isn't affecting the current wasm as Facilitapay is not yet on dashboard.
|
<think>
PR Context:
- Title: chore(env): fix Facilitapay connector config
- Merged: 2025-05-05T13:07:47Z
- Files changed: 3 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR fixes Facilitapay payment method env that broke WASM.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment vari
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 7957, "pr_number": 7958, "commits_count": 0, "files_changed": 3, "response_length": 774, "file_count": 0, "needs_breakdown": false}
|
docs(openapi): Show API version selection dropdown in API Reference
Add a version selection dropdown in API reference to allow exploring v2 APIs
|
<think>
PR Context:
- Title: docs(openapi): Show API version selection dropdown in Mintlify
- Merged: 2025-06-13T09:03:06Z
- Files changed: 30 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [x] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Moved both `v1` and `v2` API docs under `api-reference` directory
- Renamed `openapi_spec.json` files for v1 and v2
- Updated OpenAPI spec file paths in `openapi` crate
- Modified OpenAPI spec path in CI pipeline
### Additional Changes
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** docs(openapi): Show API version selection dropdown in Mintlify (#8333)
Files to modify:
**crates/openapi/src/main.rs**
Modify existing code
|
{"issue_number": 8332, "pr_number": 8333, "commits_count": 1, "files_changed": 30, "response_length": 939, "file_count": 3, "needs_breakdown": false}
|
Use `MinorUnit` for Novalnet Amount
you can use `MinorUnit` here right?
_Originally posted by @Narayanbhat166 in https://github.com/juspay/hyperswitch/pull/6631#discussion_r1901088306_
|
<think>
PR Context:
- Title: refactor(config): update base URLs for connectors in production
- Merged: None
- Files changed: 11 files
- Commits: 3 commits
Implementation approach:
📌 Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [X ] Enhancement
- [ X] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
📝 Description
Updated config/deployments/production.toml by replacing demo/test/sandbox base_url with live/production URLs.
Ensured all affected connectors now use the correct live URLs.
Closes #7583 ✅
Fixes #7582
Closes #6981
🛠️ Additional Changes
- [ ] This PR modifies the API contra
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6981, "pr_number": 7584, "commits_count": 0, "files_changed": 11, "response_length": 778, "file_count": 0, "needs_breakdown": false}
|
fix(authz): Proper descriptions for parents
Currently descriptions for parent groups in invite page of control center are not entity specific. That means, customers in description will be visible for profile level users when it shouldn't.
|
<think>
PR Context:
- Title: feat(authz): Make info APIs support `ParentGroup`
- Merged: 2024-10-30T10:42:37Z
- Files changed: 13 files
- Commits: 8 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Make new APIs to replace
- `/user/role/{{role_id}}` -> `/user/role/{{role_id}}/v2`
- `/user/role` -> `/user/role/v2`
- `/user/module/list` -> `/user/parent/list`
The new APIs will have proper description and parent info which has entity
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(authz): Make info APIs support `ParentGroup` (#6440)
Co-authored-by: hyperswitch-bot[bot] <1485
Files to modify:
**crates/api_models/src/events/user_role.rs**
Modify existing code
**crates/api_models/src/user_role/role.rs**
Add:
- struct: pub::RoleInfoWithParents
- struct: pub::ParentGroupInfo
- struct: pub::GroupsAndResources
**crates/common_enums/src/enums.rs**
Modify existing code
**crates/router/src/core/user_role.rs**
Add:
- function: pub::get_parent_group_info
**crates/router/src/core/user_role/role.rs**
Add:
- function: pub::get_groups_and_resources_for_role_from_token
- function: pub::get_parent_info_for_role
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/lock_utils.rs**
Modify existing code
**crates/router/src/routes/user_role.rs**
Add:
- function: pub::get_groups_and_resources_for_role_from_token
- function: pub::get_parent_info_for_role
- function: pub::get_parent_group_info
**crates/router/src/services/authorization/info.rs**
Remove:
- function: pub::get_parent_name
**crates/router/src/services/authorization/permission_groups.rs**
Add:
- function: private::get_descriptions_for_groups
**crates/router/src/services/authorization/permissions.rs**
Add:
- function: pub::get_resource_name
- function: pub::get_scope_name
**crates/router/src/services/authorization/roles/predefined_roles.rs**
Modify existing code
**crates/router_env/src/logger/types.rs**
Modify existing code
|
{"issue_number": 6439, "pr_number": 6440, "commits_count": 1, "files_changed": 13, "response_length": 2316, "file_count": 15, "needs_breakdown": false}
|
feat(analytics): add `smart_retries` only metrics
## Proposed changes
There should be fields in PaymentDistribution, for the case where we only want to extract metric for Subsequent smart retried attempts.
For example, we have `success_rate` and `success_rate_without_retries`
Now missing field is `success_rate_with_only_smart_retries`.
This change should be extended to all fields
|
<think>
PR Context:
- Title: feat(analytics): add `smart_retries` only metrics for analytics v2 dashboard
- Merged: 2024-11-19T19:21:45Z
- Files changed: 2 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Added support for calculating new metrics based on smart retries for Analytics v2 dashboard.
The 2 metrics are:
- Payment Processed Amount and Count for smart retries
- Payments Success Rate and Failure Rate distribution for Smart Retries
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(analytics): add `smart_retries` only metrics for analytics v2 dashboard (#6575)
Files to modify:
**crates/analytics/src/payments/accumulator.rs**
Modify existing code
**crates/api_models/src/analytics/payments.rs**
Modify existing code
|
{"issue_number": 6574, "pr_number": 6575, "commits_count": 1, "files_changed": 2, "response_length": 1056, "file_count": 4, "needs_breakdown": false}
|
Use SignatureKey as auth_type for VGS connector
We need to collect a 3rd key (vault_id) apart from `username` and `password` in case of VGS for SDK use case
|
<think>
PR Context:
- Title: fix(connector): Use SignatureKey for VGS auth_type
- Merged: 2025-08-28T02:44:22Z
- Files changed: 1 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Change VGS auth type from BodyKey to SignatureKey
### Additional Changes
- [] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): Use SignatureKey for VGS auth_type (#9068)
Files to modify:
**crates/hyperswitch_connectors/src/connectors/vgs/transformers.rs**
Modify existing code
|
{"issue_number": 9067, "pr_number": 9068, "commits_count": 1, "files_changed": 1, "response_length": 952, "file_count": 3, "needs_breakdown": false}
|
bug(users): Check lineage across entities in invite
Currently in invites we don't check if user exists across entities.
This will be a problem when inviting a user with higher entity from different lineage.
We should check if user exists across lineage before allowing invite in this case.
|
<think>
PR Context:
- Title: fix(users): Check lineage across entities in invite
- Merged: 2024-11-27T14:33:37Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently in invites we don't check if user exists across entities.
This will be a problem when inviting a user with higher entity from different lineage.
This PR fixes it.
### Additional Changes
- [ ] This PR modifies the API contract
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(users): Check lineage across entities in invite (#6677)
Files to modify:
**crates/router/src/core/user.rs**
Modify existing code
|
{"issue_number": 6679, "pr_number": 6677, "commits_count": 1, "files_changed": 1, "response_length": 920, "file_count": 3, "needs_breakdown": false}
|
feat: Add schema to store chat request response
- add schema for chat, to store request and response
- store chats to chat schema asynchronously
- encrypt the sensitive data
- have endpoint to list the chat data and decrypt it properly
|
<think>
PR Context:
- Title: feat: add hyperswitch ai chats table
- Merged: 2025-09-16T09:14:36Z
- Files changed: 30 files
- Commits: 27 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Store the user query and response from the ai service for the analysis.
- Allow the api only for internal user
### Additional Changes
This pull request introduces support for encrypted chat conversations and adds database models and A
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat: add hyperswitch ai chats table (#8831)
Co-authored-by: Apoorv Dixit <apoorv.dixit@juspay.in>
C
Files to modify:
**crates/api_models/src/chat.rs**
Add:
- struct: pub::ChatListRequest
- struct: pub::ChatConversation
- struct: pub::ChatListResponse
**crates/api_models/src/events/chat.rs**
Modify existing code
**crates/common_utils/src/consts.rs**
Modify existing code
**crates/diesel_models/src/hyperswitch_ai_interaction.rs**
Add:
- struct: pub::HyperswitchAiInteraction
- struct: pub::HyperswitchAiInteractionNew
**crates/diesel_models/src/lib.rs**
Add:
- mod: pub::hyperswitch_ai_interaction
**crates/diesel_models/src/query.rs**
Add:
- mod: pub::hyperswitch_ai_interaction
**crates/diesel_models/src/query/hyperswitch_ai_interaction.rs**
Add:
- function: pub::insert
- function: pub::filter_by_optional_merchant_id
- impl: impl HyperswitchAiInteractionNew
- impl: impl HyperswitchAiInteraction
**crates/diesel_models/src/query/utils.rs**
Add:
- function: private::get_local_unique_key
- impl: impl CompositeKey for <schema::hyperswitch_ai_interaction::table as diesel::Table>::PrimaryKey
**crates/diesel_models/src/schema.rs**
Modify existing code
**crates/diesel_models/src/schema_v2.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/chat.rs**
Modify existing code
**crates/router/src/configs/secrets_transformers.rs**
Add:
- function: private::convert_to_raw_secret
- impl: impl SecretsHandler for settings::ChatSettings
**crates/router/src/configs/settings.rs**
Modify existing code
**crates/router/src/core/chat.rs**
Modify existing code
**crates/router/src/core/errors/chat.rs**
Modify existing code
**crates/router/src/db.rs**
Add:
- mod: pub::hyperswitch_ai_interaction
**crates/router/src/db/hyperswitch_ai_interaction.rs**
Add:
- function: private::insert_hyperswitch_ai_interaction
- function: private::list_hyperswitch_ai_interactions
- function: private::insert_hyperswitch_ai_interaction
- function: private::list_hyperswitch_ai_interactions
- trait: pub::HyperswitchAiInteractionInterface
- impl: impl HyperswitchAiInteractionInterface for Store
- impl: impl HyperswitchAiInteractionInterface for MockDb
**crates/router/src/db/kafka_store.rs**
Add:
- function: private::insert_hyperswitch_ai_interaction
- function: private::list_hyperswitch_ai_interactions
- impl: impl HyperswitchAiInteractionInterface for KafkaStore
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/chat.rs**
Add:
- function: pub::get_all_conversations
**crates/router/src/routes/lock_utils.rs**
Modify existing code
**crates/router/src/types/storage.rs**
Add:
- mod: pub::hyperswitch_ai_interaction
**crates/router/src/types/storage/hyperswitch_ai_interaction.rs**
Modify existing code
**crates/router/src/utils.rs**
Add:
- mod: pub::chat
**crates/router/src/utils/chat.rs**
Add:
- function: pub::construct_hyperswitch_ai_interaction
**crates/router_env/src/logger/types.rs**
Modify existing code
**crates/storage_impl/src/mock_db.rs**
Modify existing code
|
{"issue_number": 8847, "pr_number": 8831, "commits_count": 1, "files_changed": 30, "response_length": 3973, "file_count": 29, "needs_breakdown": true}
|
Add audit events for CompleteAuthorize update
Created from #4525
This covers adding events for Complete Authorize operation
This event should include the payment data similar to [PaymentCancel](https://github.com/juspay/hyperswitch/pull/4166)
It should also include any metadata for the event
e.g reason for payment rejection, error codes, rejection source etc
### Submission Process:
- Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
- Once assigned, submit a pull request (PR).
- Maintainers will review and provide feedback, if any.
- Maintainers can unassign issues due to inactivity, [read more here](https://github.com/juspay/hyperswitch/wiki/Hacktoberfest-Contribution-Rules).
Refer [here](https://github.com/juspay/hyperswitch/blob/main/docs/TERMS_OF_CONTEST.md) for Terms and conditions for the contest.
|
<think>
PR Context:
- Title: feat(events): add audit event for CompleteAuthorize
- Merged: 2024-12-05T07:46:26Z
- Files changed: 2 files
- Commits: 4 commits
Implementation approach:
## Type of Change
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Created from #4674
This covers adding events for `CompleteAuthorize` operation
## How did you test it
Use `globalpay` as connector, `wallet` as payment_method and `paypal` as payment_method_type
```bash
"payment_method": "wallet",
"payment_method_types": [
{
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(events): add audit event for CompleteAuthorize (#6310)
Co-authored-by: Sandeep Kumar <83278309+
Files to modify:
**crates/router/src/core/payments/operations/payment_complete_authorize.rs**
Modify existing code
**crates/router/src/events/audit_events.rs**
Modify existing code
|
{"issue_number": 4674, "pr_number": 6310, "commits_count": 1, "files_changed": 2, "response_length": 1072, "file_count": 4, "needs_breakdown": false}
|
bug(users): Mark users as verified if user comes from SSO
- Currently we are not marking users as verified if they use SSO to login.
- But if there is only SSO to login, then they won't be able to verify their email unless they come from the accept invite email.
- Instead, we will mark users coming from SSO as verified.
|
<think>
PR Context:
- Title: fix(users): Mark user as verified if user logins from SSO
- Merged: 2024-11-29T10:52:38Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently we are not marking users as verified if the user comes from SSO and there is no other way to verify if SSO is the only login method that is available.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This P
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(users): Mark user as verified if user logins from SSO (#6694)
Files to modify:
**crates/router/src/core/user.rs**
Modify existing code
|
{"issue_number": 6693, "pr_number": 6694, "commits_count": 1, "files_changed": 1, "response_length": 932, "file_count": 3, "needs_breakdown": false}
|
[FEATURE] Implement V2 UCS (Unified Connector Service) Integration for Authorization Flow
### Feature Description
# [Feature Request] Implement V2 UCS (Unified Connector Service) Integration for Authorization Flow
## Issue Type
- [x] Feature Request
- [ ] Bug Report
- [ ] Enhancement
- [ ] Documentation
## Priority
- [x] High
- [ ] Medium
- [ ] Low
## Labels
`A-core` `C-feature` `payment-flows` `ucs-integration` `v2-api`
## Summary
Implement V2 UCS (Unified Connector Service) integration for the authorization payment flow, upgrading from the existing V1 UCS integration to support the updated gRPC schema and enhanced V2 payment architecture.
## Background
Currently, Hyperswitch has V1 UCS integration that works with the legacy gRPC schema. However, the UCS service has evolved to V2 with improved:
- Enhanced gRPC schema with better type safety
- Improved field structures for card details, addresses, and identifiers
- Better error handling and response parsing
- Enhanced payment method data transformation
## Problem Statement
### Current State
- V1 UCS integration uses outdated `PaymentsAuthorizeRequest` schema
- Limited support for V2 payment flow architecture
- Outdated transformer implementations for V2 data structures
- Monolithic UCS function structure affecting maintainability
### Pain Points
1. **Schema Incompatibility**: V1 gRPC schema doesn't support V2 enhanced data models
2. **Limited Error Handling**: V1 response parsing lacks V2 identifier structure support
3. **Technical Debt**: Monolithic UCS functions make debugging and enhancement difficult
4. **Missing V2 Features**: Cannot leverage V2 payment flow improvements through UCS
### Possible Implementation
## Proposed Solution
### High-Level Approach
Implement V2 UCS integration that:
1. **Updates gRPC Schema**: Migrate to `PaymentServiceAuthorizeRequest` with V2 field structure
2. **Enhances Architecture**: Refactor payment flow with better separation of concerns
3. **Improves Transformers**: Update V2 transformers for new schema compatibility
4. **Maintains Backward Compatibility**: Preserve V1 integration with feature flag separation
### Technical Requirements
#### 1. gRPC Schema Migration
- [ ] Update `rust-grpc-client` dependency to latest version
- [ ] Migrate from `PaymentsAuthorizeRequest` to `PaymentServiceAuthorizeRequest`
- [ ] Update authentication headers and request metadata handling
- [ ] Implement new identifier structure for response parsing
#### 2. Payment Flow Architecture
- [ ] Refactor `call_connector_service()` into separate prerequisite and decision functions
- [ ] Implement `call_connector_service_prerequisites()` for V2 flow preparation
- [ ] Create `decide_unified_connector_service_call()` for UCS routing logic
- [ ] Maintain feature flag separation between V1 and V2 implementations
#### 3. V2 Transformer Enhancements
- [ ] Update card data transformation for new schema structure
- [ ] Enhance address handling with improved field mapping
- [ ] Implement customer ID support in V2 transformers
#### 4. Error Handling & Response Parsing
- [ ] Update response handlers for new identifier structure
- [ ] Enhance error context and fallback mechanisms
- [ ] Maintain automatic fallback to traditional connector flow
#### 5. Testing & Validation
- [ ] Create comprehensive test cases for V2 UCS flow
- [ ] Test schema compatibility and field mapping
- [ ] Validate fallback mechanisms and error handling
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(core): Hyperswitch <|> UCS integration v2
- Merged: 2025-07-11T14:44:46Z
- Files changed: 13 files
- Commits: 30 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
### Fixes #8440
## Description
<!-- Describe your changes in detail -->
This PR implements **V2 UCS (Unified Connector Service) Integration** for authorization and synchronization flows, building upon the existing V1 UCS integration (PR#[8280](https://github.com/juspay/
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(core): Hyperswitch <|> UCS integration v2 (#8439)
Co-authored-by: debarshi.gupta <debarshi.gupt
Files to modify:
**crates/external_services/src/grpc_client/unified_connector_service.rs**
Add:
- function: pub::payment_get
**crates/hyperswitch_domain_models/src/merchant_connector_account.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/flows.rs**
Modify existing code
**crates/router/src/core/payments/flows/authorize_flow.rs**
Modify existing code
**crates/router/src/core/payments/flows/psync_flow.rs**
Add:
- function: private::call_unified_connector_service
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/core/unified_connector_service.rs**
Modify existing code
**crates/router/src/core/unified_connector_service/transformers.rs**
Add:
- function: private::foreign_try_from
- impl: impl ForeignTryFrom<&RouterData<PSync, PaymentsSyncData, PaymentsResponseData>> for payments_grpc::PaymentServiceGetRequest
**crates/router/src/types.rs**
Modify existing code
|
{"issue_number": 8440, "pr_number": 8439, "commits_count": 1, "files_changed": 13, "response_length": 1911, "file_count": 13, "needs_breakdown": false}
|
[REFACTOR]: [WISE] Add amount conversion framework to Wise
### :memo: Feature Description
Currently, amounts are represented as `i64` values throughout the application. We want to introduce a `Unit` struct that explicitly states the denomination. A new type, `MinorUnit`, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.
Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.
### :hammer: Possible Implementation
- For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
- Connectors should invoke the `convert` function to receive the amount in their required format.
- Refer to the [connector documentation](https://docs.wise.com/api-docs/api-reference/card) to determine the required amount format for each connector.
- You can refer [this PR](https://github.com/juspay/hyperswitch/pull/4825) for more context.
🔖 Note: All the changes needed should be contained within `hyperswitch/crates/router/src/connector/` , `crates/router/src/types/api.rs` , `crates/router/tests/connectors/`
### :package: Have you spent some time checking if this feature request has been raised before?
- [ ] I checked and didn't find a similar issue
### :package: Have you read the Contributing Guidelines?
- [ ] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### :package: Submission Process:
- Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
- Once assigned, submit a pull request (PR).
- Maintainers will review and provide feedback, if any.
- Maintainers can unassign issues due to inactivity, [read more here](https://github.com/juspay/hyperswitch/wiki/Hacktoberfest-Contribution-Rules).
Refer [here](https://github.com/juspay/hyperswitch/blob/main/docs/TERMS_OF_CONTEST.md) for Terms and conditions for the contest.
### :sparkles: Are you willing to submit a PR?
|
<think>
PR Context:
- Title: refactor(connector): Added amount conversion framework to Wise.
- Merged: 2024-11-07T07:36:11Z
- Files changed: 4 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This pull request introduces significant changes to the Wise connector in the `crates/router` module, focusing on the integration of a new amount conversion utility and refactoring to utilize a new `WiseRouterData` struct. The changes enhance
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): Added amount conversion framework to Wise. (#6469)
Files to modify:
**crates/router/src/connector/wise.rs**
Remove:
- struct: pub::Wise
Add:
- function: pub::new
- struct: pub::Wise
- impl: impl Wise
**crates/router/src/connector/wise/transformers.rs**
Add:
- function: private::from
- struct: pub::WiseRouterData
- impl: impl From<(MinorUnit, T)> for WiseRouterData<T>
**crates/router/src/types/api.rs**
Modify existing code
**crates/router/tests/connectors/wise.rs**
Modify existing code
|
{"issue_number": 6121, "pr_number": 6469, "commits_count": 1, "files_changed": 4, "response_length": 1349, "file_count": 6, "needs_breakdown": false}
|
chore(masking): add peek_mut to PeekInterface
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Enhancement
## Description
<!-- Describe your changes in detail -->
Add `peek_mut` function to PeekInterface to get mutable reference for the inner data.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
To get the mutable reference for inner data in StrongSecret.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
** THIS CANNOT BE TESTED IN ENVIRONMENTS **
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
|
<think>
PR Context:
- Title: Feat(connector): [JP MORGAN] Added Template code for cards integration
- Merged: 2024-11-05T15:51:59Z
- Files changed: 25 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Template code added for new connector JP Morgan
https://developer.payments.jpmorgan.com/docs/commerce/online-payments/capabilities/online-payments/payment-methods/cards
### Additional Changes
- [ ] This PR modifies the API contract
-
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** Feat(connector): [JP MORGAN] Added Template code for cards integration (#6467)
Co-authored-by: Sayak
Files to modify:
**crates/api_models/src/connector_enums.rs**
Modify existing code
**crates/common_enums/src/connector_enums.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors.rs**
Add:
- mod: pub::jpmorgan
**crates/hyperswitch_connectors/src/connectors/jpmorgan.rs**
Add:
- function: pub::new
- function: private::build_headers
- function: private::id
- function: private::get_currency_unit
- function: private::common_get_content_type
- function: private::base_url
- function: private::get_auth_header
- function: private::build_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_webhook_object_reference_id
- function: private::get_webhook_event_type
- function: private::get_webhook_resource_object
- struct: pub::Jpmorgan
- impl: impl Jpmorgan
- impl: impl api::Payment for Jpmorgan
- impl: impl api::PaymentSession for Jpmorgan
- impl: impl api::ConnectorAccessToken for Jpmorgan
- impl: impl api::MandateSetup for Jpmorgan
- impl: impl api::PaymentAuthorize for Jpmorgan
- impl: impl api::PaymentSync for Jpmorgan
- impl: impl api::PaymentCapture for Jpmorgan
- impl: impl api::PaymentVoid for Jpmorgan
- impl: impl api::Refund for Jpmorgan
- impl: impl api::RefundExecute for Jpmorgan
- impl: impl api::RefundSync for Jpmorgan
- impl: impl api::PaymentToken for Jpmorgan
- impl: impl ConnectorIntegration<PaymentMethodToken, PaymentMethodTokenizationData, PaymentsResponseData> for Jpmorgan
- impl: impl ConnectorCommonExt<Flow, Request, Response> for Jpmorgan
- impl: impl ConnectorCommon for Jpmorgan
- impl: impl ConnectorValidation for Jpmorgan
- impl: impl ConnectorIntegration<Session, PaymentsSessionData, PaymentsResponseData> for Jpmorgan
- impl: impl ConnectorIntegration<AccessTokenAuth, AccessTokenRequestData, AccessToken> for Jpmorgan
- impl: impl ConnectorIntegration<SetupMandate, SetupMandateRequestData, PaymentsResponseData> for Jpmorgan
- impl: impl ConnectorIntegration<Authorize, PaymentsAuthorizeData, PaymentsResponseData> for Jpmorgan
- impl: impl ConnectorIntegration<PSync, PaymentsSyncData, PaymentsResponseData> for Jpmorgan
- impl: impl ConnectorIntegration<Capture, PaymentsCaptureData, PaymentsResponseData> for Jpmorgan
- impl: impl ConnectorIntegration<Void, PaymentsCancelData, PaymentsResponseData> for Jpmorgan
- impl: impl ConnectorIntegration<Execute, RefundsData, RefundsResponseData> for Jpmorgan
- impl: impl ConnectorIntegration<RSync, RefundsData, RefundsResponseData> for Jpmorgan
- impl: impl webhooks::IncomingWebhook for Jpmorgan
- mod: pub::transformers
**crates/hyperswitch_connectors/src/connectors/jpmorgan/transformers.rs**
Add:
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- struct: pub::JpmorganRouterData
- struct: pub::JpmorganPaymentsRequest
- struct: pub::JpmorganCard
- struct: pub::JpmorganAuthType
- struct: pub::JpmorganPaymentsResponse
- struct: pub::JpmorganRefundRequest
- struct: pub::RefundResponse
- struct: pub::JpmorganErrorResponse
- enum: pub::JpmorganPaymentStatus
- enum: pub::RefundStatus
- impl: impl From<(StringMinorUnit, T)> for JpmorganRouterData<T>
- impl: impl TryFrom<&JpmorganRouterData<&PaymentsAuthorizeRouterData>> for JpmorganPaymentsRequest
- impl: impl TryFrom<&ConnectorAuthType> for JpmorganAuthType
- impl: impl From<JpmorganPaymentStatus> for common_enums::AttemptStatus
- impl: impl TryFrom<ResponseRouterData<F, JpmorganPaymentsResponse, T, PaymentsResponseData>> for RouterData<F, T, PaymentsResponseData>
- impl: impl TryFrom<&JpmorganRouterData<&RefundsRouterData<F>>> for JpmorganRefundRequest
- impl: impl From<RefundStatus> for enums::RefundStatus
- impl: impl TryFrom<RefundsResponseRouterData<Execute, RefundResponse>> for RefundsRouterData<Execute>
- impl: impl TryFrom<RefundsResponseRouterData<RSync, RefundResponse>> for RefundsRouterData<RSync>
**crates/hyperswitch_connectors/src/default_implementations.rs**
Modify existing code
**crates/hyperswitch_connectors/src/default_implementations_v2.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/configs.rs**
Modify existing code
**crates/router/src/connector.rs**
Modify existing code
**crates/router/src/core/payments/connector_integration_v2_impls.rs**
Modify existing code
**crates/router/src/core/payments/flows.rs**
Modify existing code
**crates/router/src/types/api.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
**crates/router/tests/connectors/jpmorgan.rs**
Add:
- function: private::new
- function: private::get_data
- function: private::get_auth_token
- function: private::get_name
- function: private::get_default_payment_info
- function: private::payment_method_details
- function: private::should_only_authorize_payment
- function: private::should_capture_authorized_payment
- function: private::should_partially_capture_authorized_payment
- function: private::should_sync_authorized_payment
- function: private::should_void_authorized_payment
- function: private::should_refund_manually_captured_payment
- function: private::should_partially_refund_manually_captured_payment
- function: private::should_sync_manually_captured_refund
- function: private::should_make_payment
- function: private::should_sync_auto_captured_payment
- function: private::should_refund_auto_captured_payment
- function: private::should_partially_refund_succeeded_payment
- function: private::should_refund_succeeded_payment_multiple_times
- function: private::should_sync_refund
- function: private::should_fail_payment_for_incorrect_cvc
- function: private::should_fail_payment_for_invalid_exp_month
- function: private::should_fail_payment_for_incorrect_expiry_year
- function: private::should_fail_void_payment_for_auto_capture
- function: private::should_fail_capture_for_invalid_payment
- function: private::should_fail_for_refund_amount_higher_than_payment_amount
- struct: private::JpmorganTest
- impl: impl JpmorganTest
- impl: impl ConnectorActions for JpmorganTest
- impl: impl utils::Connector for JpmorganTest
**crates/router/tests/connectors/main.rs**
Add:
- mod: private::jpmorgan
**crates/test_utils/src/connector_auth.rs**
Modify existing code
|
{"issue_number": 7281, "pr_number": 6467, "commits_count": 1, "files_changed": 25, "response_length": 8958, "file_count": 18, "needs_breakdown": true}
|
[FEATURE] add permissions for operations in recon module
### Feature Description
Reconciliation module in HyperSwitch provides various operations. Every operation needs to permitted for the end user to use it.
As of today, recon has a single permission - which gives access to the entire recon module, this is not granular. Recon module's permission suite needs to be extended to be able to assign granular access for different operations.
### Possible Implementation
Add permissions for below operations
- Upload files - RW
- Run recon - RW
- View and update recon configs - RW
- View and add file processing - RW
- View Reports - R
- View Analytics - R
These are to be included in JWT in the response of `/recon/verify_token`
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat: add resources and granular permission groups for reconciliation
- Merged: 2024-12-04T09:55:05Z
- Files changed: 18 files
- Commits: 29 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #6524
This PR includes below changes
- Extending resources enum (for specifying the resource being consumed from the dashboard)
- Extending granular permission groups for recon
- Populating `acl` field in the recon token
### Additional Changes
- [ ] This PR m
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat: add resources and granular permission groups for reconciliation (#6591)
Co-authored-by: hypers
Files to modify:
**crates/api_models/src/enums.rs**
Add:
- function: private::from
- enum: pub::ReconPermissionScope
- impl: impl From<PermissionScope> for ReconPermissionScope
**crates/api_models/src/events/recon.rs**
Add:
- function: private::get_api_event_type
- impl: impl ApiEventMetric for VerifyTokenResponse
**crates/api_models/src/events/user.rs**
Remove:
- function: private::get_api_event_type
- impl: impl ApiEventMetric for VerifyTokenResponse
**crates/api_models/src/recon.rs**
Add:
- struct: pub::VerifyTokenResponse
**crates/api_models/src/user.rs**
Remove:
- struct: pub::VerifyTokenResponse
**crates/common_enums/src/enums.rs**
Modify existing code
**crates/router/src/core/recon.rs**
Add:
- function: pub::verify_recon_token
**crates/router/src/core/user.rs**
Remove:
- function: pub::verify_token
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/recon.rs**
Modify existing code
**crates/router/src/routes/user.rs**
Remove:
- function: pub::verify_recon_token
**crates/router/src/services/authentication.rs**
Add:
- function: private::authenticate_and_fetch
- function: pub::new_token
- struct: pub::UserFromTokenWithRoleInfo
- struct: pub::ReconToken
- impl: impl AuthenticateAndFetch<UserFromTokenWithRoleInfo, A> for JWTAuth
- impl: impl ReconToken
**crates/router/src/services/authorization/info.rs**
Modify existing code
**crates/router/src/services/authorization/permission_groups.rs**
Modify existing code
**crates/router/src/services/authorization/permissions.rs**
Modify existing code
**crates/router/src/services/authorization/roles.rs**
Add:
- function: pub::get_recon_acl
**crates/router/src/services/authorization/roles/predefined_roles.rs**
Modify existing code
**crates/router/src/services/email/types.rs**
Modify existing code
|
{"issue_number": 6524, "pr_number": 6591, "commits_count": 1, "files_changed": 18, "response_length": 2832, "file_count": 20, "needs_breakdown": true}
|
feat(connector): Add recovery support for stripebilling
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Context: In case of some billing connectors we dont get the enough data in the webhook itself to support creation of payment intent and payment attempt in our system. So previously we derived a flow named "AdditionalRevenuerecoveryDetails" in this PR:#7402 which name is now changed to "BillingConnectorPaymentSync". This flow is used to fetch payment details of the invoices from the billing connectors using an API call to that billing connector. In this pr we are calling the flow and getting the details which are needed to create payment intent and attempt in our system.
1. Creates a connector integration in stripe billing that supports the API call.
2. Call the flow in recovery_incoming.rs file and using that details further we are creating the payment intent and attempt and verifying them.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
3. `crates/router/src/configs`
4. `loadtest/config`
-->
## Motivation and Context
## Testing
1. Go to stripe create a new webhook endpoint with a dummy url to get webhook secret key.
2. create a payment processor stripe
```
curl --location 'http://localhost:8080/v2/connector-accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'x-merchant-id: cloth_seller_mQRYaJduFokPeZ54W6bN' \
--header 'x-profile-id: pro_me6dnNKlhwuq32xhfjCA' \
--header 'Authorization: admin-api-key=test_admin' \
--header 'api-key: test_admin' \
--data '{
"connector_type": "payment_processor",
"connector_name": "stripe",
"connector_account_details": {
"auth_type": "HeaderKey",
"api_key": "api-key
},
"payment_methods_enabled": [
{
"payment_method_type": "card_redirect",
"payment_method_subtypes": [
{
"payment_method_subtype": "card_redirect",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": 1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "card",
"payment_method_subtypes": [
{
"payment_method_subtype": "credit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "debit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "wallet",
"payment_method_subtypes": [
{
"payment_method_subtype": "google_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "apple_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "we_chat_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "ali_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "paypal",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "mb_way",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "pay_later",
"payment_method_subtypes": [
{
"payment_method_subtype": "klarna",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "affirm",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "afterpay_clearpay",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "walley",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "bank_redirect",
"payment_method_subtypes": [
{
"payment_method_subtype": "giropay",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "ideal",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "eps",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "bancontact_card",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "przelewy24",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "sofort",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "blik",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "trustly",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "online_banking_finland",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "online_banking_poland",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "bank_transfer",
"payment_method_subtypes": [
{
"payment_method_subtype": "ach",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "sepa",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "bacs",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "bank_debit",
"payment_method_subtypes": [
{
"payment_method_subtype": "ach",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "sepa",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "bacs",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "becs",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
}
],
"metadata": {
"status_url": "https://2753-2401-4900-1cb8-2ff9-24dd-1ccf-ed12-b464.in.ngrok.io/webhooks/merchant_1678699058/globalpay",
"account_name": "transaction_processing",
"pricing_type": "fixed_price",
"acquirer_bin": "438309",
"acquirer_merchant_id": "00002000000"
},
"frm_configs": null,
"connector_webhook_details": {
"merchant_secret": ""
},
"profile_id": "pro_me6dnNKlhwuq32xhfjCA"
}'
```
change the profile id and other feilds while creating you own one
3. copy the mca id of stripe and paste it in the billing mca curl in feature metadata
```
curl --location 'http://localhost:8080/v2/connector-accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'x-merchant-id: cloth_seller_mQRYaJduFokPeZ54W6bN' \
--header 'x-profile-id: pro_me6dnNKlhwuq32xhfjCA' \
--header 'Authorization: admin-api-key=test_admin' \
--header 'api-key: test_admin' \
--data '{
"connector_type": "billing_processor",
"connector_name": "stripebilling",
"connector_account_details": {
"auth_type": "HeaderKey",
"api_key": "{your api key}"
},
"payment_methods_enabled": [
{
"payment_method_type": "card",
"payment_method_subtypes": [
{
"payment_method_subtype": "credit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "debit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
}
],
"metadata": {
"status_url": "https://2753-2401-4900-1cb8-2ff9-24dd-1ccf-ed12-b464.in.ngrok.io/webhooks/merchant_1678699058/globalpay",
"account_name": "transaction_processing",
"pricing_type": "fixed_price",
"acquirer_bin": "438309",
"acquirer_merchant_id": "00002000000"
},
"frm_configs": null,
"feature_metadata" : {
"revenue_recovery":{
"max_retry_count" : 16,
"billing_connector_retry_threshold": 2,
"billing_account_reference": {
"{your stripe mca id here}": "stripebilling"
}
}
},
"connector_webhook_details": {
"merchant_secret": "{webhook secret you have copied here}"
},
"profile_id": "pro_me6dnNKlhwuq32xhfjCA"
}'
```
4. copy the mca id, profile id and merchant id to construct the endpoint of the webhook.
5. install ngrok and run the service it will give you a https url for your local host port.
6. copy the https url of ngrok
7. construct the webhook endpoint : url/v2/webhooks/merchant_id/profile_id/billing_mca_id
8. paste this endpoint in the place of dummy url you have used to create endpoint in stripe dashboard
9. now create a test subscription use this card "4000 0000 0000 0341" while creating a test subscription and the billing day should start from the next day. If you are creating a test subscription today billing date should start from tommorow.
10. now move the clock past one month.
11. no observe the payment intent table and payment attempt table in db and verify those details with ones we are getting.
Images of the logs:
<img width="1728" alt="Screenshot 2025-03-11 at 5 52 53 PM" src="https://github.com/user-attachments/assets/0a97b656-2417-4812-b9cd-a808183411ea" />
<img width="1728" alt="Screenshot 2025-03-11 at 5 53 10 PM" src="https://github.com/user-attachments/assets/5a9872f1-45a3-4bf5-978c-6e477df36c9f" />
<img width="1728" alt="Screenshot 2025-03-11 at 5 53 21 PM" src="https://github.com/user-attachments/assets/5cbac559-09d8-4939-b2a6-04bc8f50a1bc" />
<img width="1728" alt="Screenshot 2025-03-11 at 5 54 32 PM" src="https://github.com/user-attachments/assets/3eb3fb41-afd4-4a05-8c8b-715310a79d7d" />
<img width="1710" alt="Screenshot 2025-03-10 at 4 52 08 PM" src="https://github.com/user-attachments/assets/05477fdc-656b-42cd-ba27-880d5748cc19" />
<img width="1190" alt="Screenshot 2025-03-10 at 4 52 20 PM" src="https://github.com/user-attachments/assets/d9900f24-2b8f-45c5-b6c5-bd5dcd62357d" />
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: feat(connector): [stripebilling] consume necessary fields in stripe billing from webhooks for transaction monitoring support
- Merged: 2025-05-06T07:36:19Z
- Files changed: 1 files
- Commits: 30 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Consuming the following fields in the webhook which will support the transaction monitoring feature further.
In stripebilling the subscribed webhook contains an object of that particular invoice. The details needed in the issue are available in the invoice object. Consume Billing add
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [stripebilling] consume necessary fields in stripe billing from webhooks for transa
Files to modify:
**crates/hyperswitch_connectors/src/connectors/stripebilling/transformers.rs**
Add:
- function: private::from
- function: private::from
- struct: pub::StripebillingWebhookLinesObject
- struct: pub::StripebillingWebhookLinesData
- struct: pub::StripebillingWebhookLineDataPeriod
- struct: pub::StripebillingInvoiceBillingAddress
- impl: impl From<StripebillingInvoiceBillingAddress> for api_models::payments::AddressDetails
|
{"issue_number": 7461, "pr_number": 7722, "commits_count": 1, "files_changed": 1, "response_length": 1430, "file_count": 3, "needs_breakdown": false}
|
feat(themes): Setup DB for themes
There should a separate table for themes for storing the `theme_id`s for a particular lineage. This should be the schema:
| org_id | merchant_id | profile_id | theme_id |
| ------ | ----------- | ---------- | -------- |
| o1 | m1 | p1 | t1 |
| o1 | m1 | p2 | t2 |
This will be used for changing theme automatically when user switches any entities.
|
<think>
PR Context:
- Title: feat(themes): Setup themes table
- Merged: 2024-11-14T09:16:40Z
- Files changed: 15 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR creates a new table named `themes` in the DB. This will be used to store the `theme_id` for any lineage of `tenant_id`, `org_id`, `merchant_id` and `profile_id`.
### Additional Changes
- [ ] This PR modifies the API contract
- [
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(themes): Setup themes table (#6533)
Files to modify:
**crates/common_utils/src/types.rs**
Add:
- mod: pub::theme
**crates/common_utils/src/types/theme.rs**
Add:
- enum: pub::ThemeLineage
**crates/diesel_models/src/query/user.rs**
Add:
- mod: pub::theme
**crates/diesel_models/src/query/user/theme.rs**
Add:
- function: pub::insert
- function: private::lineage_filter
- function: pub::find_by_lineage
- function: pub::delete_by_theme_id_and_lineage
- impl: impl ThemeNew
- impl: impl Theme
**crates/diesel_models/src/schema.rs**
Modify existing code
**crates/diesel_models/src/schema_v2.rs**
Modify existing code
**crates/diesel_models/src/user.rs**
Add:
- mod: pub::theme
**crates/diesel_models/src/user/theme.rs**
Add:
- struct: pub::Theme
- struct: pub::ThemeNew
**crates/router/src/db.rs**
Modify existing code
**crates/router/src/db/kafka_store.rs**
Add:
- function: private::insert_theme
- function: private::find_theme_by_lineage
- function: private::delete_theme_by_lineage_and_theme_id
- impl: impl ThemeInterface for KafkaStore
**crates/router/src/db/user.rs**
Add:
- mod: pub::theme
**crates/router/src/db/user/theme.rs**
Add:
- function: private::insert_theme
- function: private::find_theme_by_lineage
- function: private::delete_theme_by_lineage_and_theme_id
- function: private::check_theme_with_lineage
- function: private::insert_theme
- function: private::find_theme_by_lineage
- function: private::delete_theme_by_lineage_and_theme_id
- trait: pub::ThemeInterface
- impl: impl ThemeInterface for Store
- impl: impl ThemeInterface for MockDb
**crates/storage_impl/src/mock_db.rs**
Modify existing code
|
{"issue_number": 6532, "pr_number": 6533, "commits_count": 1, "files_changed": 15, "response_length": 2537, "file_count": 15, "needs_breakdown": false}
|
Get Plan prices
**Request to Subscription Povider to get plans prices**
api/v2/item_prices?item_id[is]=cbdemo_enterprise-suite'
**Response from Subscription Provider**
```
{
"list": [
{
"item_price": {
"id": "cbdemo_enterprise-suite-INR-Daily",
"name": "Enterprise Suite INR Daily",
"item_family_id": "cbdemo_omnisupport-solutions",
"item_id": "cbdemo_enterprise-suite",
"status": "active",
"external_name": "Enterprise Suite",
"pricing_model": "flat_fee",
"price": 10000,
"period": 1,
"currency_code": "INR",
"period_unit": "day",
"free_quantity": 0,
"channel": "web",
"resource_version": 1755510951486,
"updated_at": 1755510951,
"created_at": 1755510951,
"is_taxable": true,
"item_type": "plan",
"show_description_in_invoices": false,
"show_description_in_quotes": false,
"deleted": false,
"object": "item_price"
}
},
{
"item_price": {
"id": "cbdemo_enterprise-suite-monthly",
"name": "Enterprise Suite Monthly",
"item_family_id": "cbdemo_omnisupport-solutions",
"item_id": "cbdemo_enterprise-suite",
"description": "Enterprise Suite billed monthly",
"status": "active",
"external_name": "Enterprise Suite Monthly",
"pricing_model": "flat_fee",
"price": 14100,
"period": 1,
"currency_code": "INR",
"period_unit": "month",
"free_quantity": 0,
"channel": "web",
"resource_version": 1754897341938,
"updated_at": 1754897341,
"created_at": 1754897341,
"is_taxable": true,
"item_type": "plan",
"show_description_in_invoices": false,
"show_description_in_quotes": false,
"deleted": false,
"object": "item_price"
}
},
{
"item_price": {
"id": "cbdemo_enterprise-suite-annual",
"name": "Enterprise Suite Annual",
"item_family_id": "cbdemo_omnisupport-solutions",
"item_id": "cbdemo_enterprise-suite",
"description": "Enterprise Suite billed annually",
"status": "active",
"external_name": "Enterprise Suite Annual",
"pricing_model": "flat_fee",
"price": 169000,
"period": 1,
"currency_code": "INR",
"period_unit": "year",
"free_quantity": 0,
"channel": "web",
"resource_version": 1754897341789,
"updated_at": 1754897341,
"created_at": 1754897341,
"is_taxable": true,
"item_type": "plan",
"show_description_in_invoices": false,
"show_description_in_quotes": false,
"deleted": false,
"object": "item_price"
}
}
]
}
```
|
<think>
PR Context:
- Title: feat(connector): Add support for get plan prices for Chargebee
- Merged: 2025-09-19T08:20:28Z
- Files changed: 16 files
- Commits: 25 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR integrates the get plan prices endpoint for chargebee, required to be called in the respective API handler for the same (not yet implemented)
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): Add support for get plan prices for Chargebee (#9300)
Co-authored-by: hyperswitch-b
Files to modify:
**crates/hyperswitch_connectors/src/connectors/chargebee.rs**
Add:
- function: private::get_chargebee_plan_prices_query_params
- function: private::get_headers
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- impl: impl api::subscriptions::GetSubscriptionPlanPricesFlow for Chargebee
- impl: impl ConnectorIntegration<
GetSubscriptionPlanPrices,
GetSubscriptionPlanPricesRequest,
GetSubscriptionPlanPricesResponse,
> for Chargebee
- impl: impl GetSubscriptionPlanPricesV2 for Chargebee
- impl: impl ConnectorIntegrationV2<
GetSubscriptionPlanPrices,
hyperswitch_domain_models::router_data_v2::flow_common_types::GetSubscriptionPlanPricesData,
GetSubscriptionPlanPricesRequest,
GetSubscriptionPlanPricesResponse,
> for Chargebee
**crates/hyperswitch_connectors/src/connectors/chargebee/transformers.rs**
Add:
- function: private::try_from
**crates/hyperswitch_connectors/src/connectors/recurly.rs**
Add:
- impl: impl api::subscriptions_v2::GetSubscriptionPlanPricesV2 for Recurly
- impl: impl ConnectorIntegrationV2<
GetSubscriptionPlanPrices,
GetSubscriptionPlanPricesData,
GetSubscriptionPlanPricesRequest,
GetSubscriptionPlanPricesResponse,
> for Recurly
**crates/hyperswitch_connectors/src/default_implementations.rs**
Remove:
- impl: impl Subscriptions for connectors::DummyConnector<T>
Add:
- impl: impl GetSubscriptionPlanPricesFlow for $connector
- impl: impl ConnectorIntegration<
GetSubscriptionPlanPrices,
GetSubscriptionPlanPricesRequest,
GetSubscriptionPlanPricesResponse
> for $connector
- impl: impl Subscriptions for connectors::DummyConnector<T>
- impl: impl GetSubscriptionPlanPricesFlow for connectors::DummyConnector<T>
- impl: impl ConnectorIntegration<
GetSubscriptionPlanPrices,
GetSubscriptionPlanPricesRequest,
GetSubscriptionPlanPricesResponse,
> for connectors::DummyConnector<T>
**crates/hyperswitch_domain_models/src/router_data_v2/flow_common_types.rs**
Add:
- struct: pub::GetSubscriptionPlanPricesData
**crates/hyperswitch_domain_models/src/router_flow_types.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/router_flow_types/subscriptions.rs**
Add:
- struct: pub::GetSubscriptionPlanPrices
**crates/hyperswitch_domain_models/src/router_request_types/subscriptions.rs**
Add:
- struct: pub::GetSubscriptionPlanPricesRequest
**crates/hyperswitch_domain_models/src/router_response_types/subscriptions.rs**
Add:
- struct: pub::GetSubscriptionPlanPricesResponse
- struct: pub::SubscriptionPlanPrices
- enum: pub::PeriodUnit
**crates/hyperswitch_domain_models/src/types.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/api.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/api/subscriptions.rs**
Add:
- trait: pub::GetSubscriptionPlanPricesFlow
- trait: private::GetSubscriptionPlanPricesFlow
**crates/hyperswitch_interfaces/src/api/subscriptions_v2.rs**
Remove:
- trait: pub::SubscriptionsV2
Add:
- trait: pub::SubscriptionsV2
- trait: pub::GetSubscriptionPlanPricesV2
**crates/hyperswitch_interfaces/src/conversion_impls.rs**
Remove:
- function: private::from_old_router_data
- function: private::to_old_router_data
- impl: impl RouterDataConversion<T, Req, Resp> for GetSubscriptionPlansData
**crates/hyperswitch_interfaces/src/types.rs**
Modify existing code
**crates/router/src/services/api.rs**
Modify existing code
|
{"issue_number": 9054, "pr_number": 9300, "commits_count": 1, "files_changed": 16, "response_length": 4657, "file_count": 18, "needs_breakdown": true}
|
[FIX] Remove ToSchema from RefundAggregateResponse and exclude it from OpenAPI documentation
### Feature Description
The RefundAggregateResponse type used by the [/refunds/aggregate](https://github.com/juspay/hyperswitch/blob/37925626e6446900f1d16e0e5f184ee472d4be3e/crates/router/src/routes/app.rs#L1004) API is currently annotated with ToSchema, which generates OpenAPI schema documentation for it. However, since this API is internal and should not be exposed to external users, the schema should not be generated or included in the OpenAPI documentation.
Current Behavior:
- The `RefundAggregateResponse` struct is annotated with ToSchema, which automatically generates OpenAPI documentation.
- This results in the exposure of internal API details that should remain hidden from external consumers.
Expected Behavior:
- Remove the `ToSchema` derive macro from the RefundAggregateResponse struct.
- Ensure that this struct and its associated API are excluded from OpenAPI documentation generation.
### Possible Implementation
The Api [refunds/aggregate](https://github.com/juspay/hyperswitch/blob/37925626e6446900f1d16e0e5f184ee472d4be3e/crates/router/src/core/refunds.rs#L1098) returns `RefundAggregateResponse`
The following code should be modified to remove ToSchema and update the OpenAPI documentation accordingly:
```
#[derive(Clone, Debug, serde::Serialize, ToSchema)]
pub struct RefundAggregateResponse {
/// The list of refund status with their count
pub status_with_count: HashMap<enums::RefundStatus, i64>,
}
```
Tasks:
- Remove the ToSchema derive macro from the RefundAggregateResponse struct.
- Remove any references to RefundAggregateResponse from openapi.rs to ensure it is not documented.
- Test to verify that this type is no longer included in the OpenAPI schema.
Additional Context:
Since the `/refunds/aggregate` API is for internal use only, removing the OpenAPI schema ensures that this internal API remains undocumented for merchants.
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Submission Process:
- Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
- Once assigned, submit a pull request (PR).
- Maintainers will review and provide feedback, if any.
- Maintainers can unassign issues due to inactivity, [read more here](https://github.com/juspay/hyperswitch/wiki/Hacktoberfest-Contribution-Rules).
Refer [here](https://github.com/juspay/hyperswitch/blob/main/docs/TERMS_OF_CONTEST.md) for Terms and conditions for the contest.
|
<think>
PR Context:
- Title: fix(refunds): remove to schema from refund aggregate response and exclude it from open api documentation
- Merged: 2024-11-05T09:26:13Z
- Files changed: 5 files
- Commits: 11 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Removed all the openapi references to `RefundAggregateResponse`.
1. Removed `ToSchema` trait for `RefundAggregateResponse`.
2. Removed references from `openapi` and `openapi_v2` to `RefundAggregateResponse`.
3. Generated new `openapi_spec
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(refunds): remove to schema from refund aggregate response and exclude it from open api documenta
Files to modify:
**crates/api_models/src/refunds.rs**
Modify existing code
**crates/openapi/src/openapi.rs**
Modify existing code
**crates/openapi/src/openapi_v2.rs**
Modify existing code
|
{"issue_number": 5990, "pr_number": 6405, "commits_count": 1, "files_changed": 5, "response_length": 1136, "file_count": 5, "needs_breakdown": false}
|
[CI] cypress checks for wise failing
wise is returning status as `forbidden`. it is better to replace that with adyen payouts
|
<think>
PR Context:
- Title: ci(cypress-ci): remove wise payout from running in github ci
- Merged: 2025-04-08T08:31:18Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
this pr updates the `adyen` payouts credentials and it also replaces wise from running in github ci
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies appl
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 7755, "pr_number": 7756, "commits_count": 0, "files_changed": 1, "response_length": 790, "file_count": 0, "needs_breakdown": false}
|
feat(single_use): add extra fields in `Mandate` table and `MandateData` [Blocked on #61]
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
This PR adds single use mandate support and a 2 new fields to the mandate table (i.e. singe_use_amount, single_use_currency)
<!-- Describe your changes in detail -->
### Additional Changes
- [x] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
The change includes the following files.
- migrations/2022-12-05-090521_single_use_mandate_fields/up.sql
- migrations/2022-12-05-090521_single_use_mandate_fields/down.sql
## Motivation and Context
Here, the intension is adding a new Validation feature in PaymentsCore, for that reason following are the steps that the change is broken down to.
1. Create new types for the change #45
2. Introduce the Flow and Connector Integration #47
3. Add Stripe POC #50
4. Introduce the new operation and all the related components in the payments core #53 + #61
5. Changing the `MandateData` type
6. Move the mandate related behaviour to domain
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: feat(payouts): add payout currency in wasm crate
- Merged: 2025-09-30T14:41:56Z
- Files changed: 4 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds two changes
1. Updates `Sepa` to `SepaBankTransfer` for dynamic required fields for payouts
2. Adds PayoutCurrency as a rule to be set while configuring payout routing on dashboard
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modif
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payouts): add payout currency in wasm crate (#9626)
Files to modify:
**crates/euclid/src/frontend/dir.rs**
Modify existing code
**crates/euclid/src/types.rs**
Modify existing code
**crates/euclid_wasm/src/lib.rs**
Modify existing code
**crates/router/src/configs/defaults/payout_required_fields.rs**
Modify existing code
|
{"issue_number": 66, "pr_number": 9626, "commits_count": 1, "files_changed": 4, "response_length": 1119, "file_count": 6, "needs_breakdown": false}
|
Adding new logo in API ref and Readme
|
<think>
PR Context:
- Title: docs: add new logos for README and API reference
- Merged: 2024-12-10T11:57:39Z
- Files changed: 6 files
- Commits: 15 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [X] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding ch
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6782, "pr_number": 6783, "commits_count": 0, "files_changed": 6, "response_length": 779, "file_count": 0, "needs_breakdown": false}
|
feat(connector): [Peach Payments] add network token support for connector
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
add network token support for peach payments connector
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
- Create MCA for peach payments
- Enable network tokenization for profile
```
curl --location 'http://localhost:8080/account/merchant_id/business_profile/prof_id' \
--header 'Content-Type: application/json' \
--header 'api-key: api key' \
--data '{
"profile_name": "US_default",
"is_network_tokenization_enabled": true
}'
```
- Create payment
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_CNdykrXQ50vzfqwZtbakrK0awo6TkkdQHDXv0QnpB8tA05z3sVIKLAEUGqIEXWE8' \
--data-raw '
{
"amount": 200,
"currency": "EUR",
"confirm": true,
"capture_method": "manual",
"capture_on": "2022-09-10T10:11:12Z",
"customer_id": "<customer_id>",
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Its my first payment request",
"authentication_type": "no_three_ds",
"return_url": "https://google.com",
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "card_number",
"card_exp_month": "12",
"card_exp_year": "2026",
"card_holder_name": "joseph Doe",
"card_cvc": "123",
"card_network": "VISA"
}
},
"setup_future_usage": "on_session",
"customer_acceptance": {
"acceptance_type": "offline",
"accepted_at": "1963-05-03T04:07:52.723Z",
"online": {
"ip_address": "in sit",
"user_agent": "amet irure esse"
}
},
"billing": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "PiX",
"last_name": "ss"
}
},
"shipping": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "John",
"last_name": "Doe"
},
"phone": {
"number": "8056594427",
"country_code": "+91"
}
},
"browser_info": {
"user_agent": "Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
"accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8",
"language": "nl-NL",
"color_depth": 24,
"screen_height": 723,
"screen_width": 1536,
"time_zone": 0,
"java_enabled": true,
"java_script_enabled": true,
"ip_address": "125.0.0.1"
},
"statement_descriptor_name": "joseph",
"statement_descriptor_suffix": "JS",
"metadata": {},
"order_details": [
{
"product_name": "Apple iphone 15",
"quantity": 1,
"amount": 0,
"account_name": "transaction_processing"
}
],
"profile_id": "<profile_id>"
}'
```
- Do repeat CIT [Saved Card flow]
using saved card,
payment method data sent to connector in logs should be network token data.
ps. please search for raw_connector_request
create payment-
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_CNdykrXQ50vzfqwZtbakrK0awo6TkkdQHDXv0QnpB8tA05z3sVIKLAEUGqIEXWE8' \
--data '{
"amount": 200,
"currency": "EUR",
"capture_method": "manual",
"authentication_type": "no_three_ds",
"confirm": false,
"setup_future_usage": "on_session",
"customer_id": "cu_1760091918",
"billing": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US"
}
},
"profile_id": "pro_55Ey3rupyS9BnqWKLkG3"
}'
```
confirm -
```
curl --location 'http://localhost:8080/payments/<payment_id>/confirm' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: api key' \
--data '
{
"payment_token": "payment_token",
"client_secret": "client_secret",
"browser_info": {
"user_agent": "Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
"accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8",
"language": "nl-NL",
"color_depth": 24,
"screen_height": 723,
"screen_width": 1536,
"time_zone": 0,
"java_enabled": true,
"java_script_enabled": true,
"ip_address": "125.0.0.1"
},
"payment_method": "card",
"payment_method_data":{
"card_token":{
"card_cvc": "737"
}
}
}'
```
<img width="1728" height="140" alt="Screenshot 2025-10-13 at 3 58 40 PM" src="https://github.com/user-attachments/assets/e75f7977-77cd-4022-b99f-e13ec478913a" />
<img width="952" height="576" alt="Screenshot 2025-10-13 at 4 42 39 PM" src="https://github.com/user-attachments/assets/64623865-5fbb-4152-8e48-68909809f439" />
<img width="876" height="739" alt="Screenshot 2025-10-13 at 4 42 58 PM" src="https://github.com/user-attachments/assets/69fb00b2-4183-4187-b5f5-b2b3d7b8f366" />
three test cases are failing due to incorrect assertion. this is currently on main.
How to replicate this -
in create call, confirm is set to falsem capture method to automatic, and payment method data is not sent. in create response, requires_payment_method status is given.
now in confirm api, send payment method data.
expected - Throw error saying automatic capture is not supported
current output - Trying to make a call to connector.
Can be taken up in seperate pr.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [ ] I formatted the code `cargo +nightly fmt --all`
- [ ] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: feat(connector): [Peach Payments] add network token support for connector
- Merged: 2025-10-13T14:00:59Z
- Files changed: 8 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
add network token support for peach payments connector
hotfix for - #9754
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/envir
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [Peach Payments] add network token support for connector (#9814)
Co-authored-by: hy
Files to modify:
**crates/hyperswitch_connectors/src/connectors/peachpayments/transformers.rs**
Remove:
- struct: pub::PeachpaymentsPaymentsRequest
Add:
- function: private::from
- function: private::try_from
- function: private::try_from
- struct: pub::PeachpaymentsPaymentsCardRequest
- struct: pub::CardOnFileData
- struct: pub::EcommerceNetworkTokenPaymentOnlyTransactionData
- struct: pub::NetworkTokenDetails
- enum: pub::PeachpaymentsPaymentsRequest
- enum: pub::EcommercePaymentOnlyTransactionData
- enum: pub::CardNetworkLowercase
- impl: impl From<common_enums::CardNetwork> for CardNetworkLowercase
- impl: impl TryFrom<(
&PeachpaymentsRouterData<&PaymentsAuthorizeRouterData>,
NetworkTokenData,
)> for PeachpaymentsPaymentsRequest
- impl: impl TryFrom<(&PeachpaymentsRouterData<&PaymentsAuthorizeRouterData>, Card)> for PeachpaymentsPaymentsRequest
**crates/router/src/core/payment_methods/network_tokenization.rs**
Modify existing code
|
{"issue_number": 9754, "pr_number": 9814, "commits_count": 1, "files_changed": 8, "response_length": 1940, "file_count": 4, "needs_breakdown": false}
|
[FEATURE] add payment method filter in v2
### Feature Description
List all the available currencies and countries for the given connector and payment method type.
### Possible Implementation
Add the filter route to the V2 PaymentMethods implementation.
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(payment_methods): add payment-methods/filter endpoint to list countries and currencies for connector payment method in v2
- Merged: 2025-08-22T13:26:14Z
- Files changed: 2 files
- Commits: 4 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Add the payment method filter route to the V2 PaymentMethods implementation which list all available countries and currencies based on connector and payment method type.
### Additional Changes
- [X] This PR modifies the API contract
-
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payment_methods): add payment-methods/filter endpoint to list countries and currencies for conn
Files to modify:
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/payment_methods.rs**
Add:
- function: pub::list_countries_currencies_for_connector_payment_method
|
{"issue_number": 8977, "pr_number": 8978, "commits_count": 1, "files_changed": 2, "response_length": 1169, "file_count": 4, "needs_breakdown": false}
|
fix(connector): [Worldpay] add root CA certificate
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds below changes for the Worldpay connector
1. Add a root CA certificate for Worldpay's request client
2. Add a new AuthType for Worldpay - MultiAuthType
3. Use `MultiAuthType` in wasm crate for Worldpay
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
4. `crates/router/src/configs`
5. `loadtest/config`
-->
## Motivation and Context
This fixes the self signed certificate not trusted errors for Worldpay in production.
## How did you test it?
Cannot be tested in non prod env.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert(connector): [Worldpay] add root CA certificate
- Merged: 2025-06-10T08:33:22Z
- Files changed: 5 files
- Commits: 1 commits
Implementation approach:
Reverts juspay/hyperswitch#8205
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert(connector): [Worldpay] add root CA certificate (#8224)
Files to modify:
**crates/hyperswitch_connectors/src/connectors/worldpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs**
Modify existing code
|
{"issue_number": 8205, "pr_number": 8224, "commits_count": 1, "files_changed": 5, "response_length": 579, "file_count": 4, "needs_breakdown": false}
|
[BUG] [NOON] 3ds payment have `next_action` as `null`
3ds card payments in noon connector receive `next_action` as `null`.
this can be resolved by unifying both the responses (paypal and card) into one and use it else where.
|
<think>
PR Context:
- Title: fix(connector): [noon] address `next_action_url` being `null` for cards in 3ds payment
- Merged: 2025-04-21T08:20:04Z
- Files changed: 2 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
previously, when making a 3ds card transaction via noon connector, we would get `next_action` as `null` which is not intended. and that is because, paypal response would override the transaction data. this pr fixes this by unifying both of t
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [noon] address `next_action_url` being `null` for cards in 3ds payment (#7832)
Files to modify:
**crates/hyperswitch_connectors/src/connectors/noon.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/noon/transformers.rs**
Remove:
- function: private::try_from
- struct: pub::NoonPaypalResponse
- struct: pub::NoonPaypalResponseResult
- enum: pub::NoonAuthPaymentResponse
- impl: impl TryFrom<ResponseRouterData<F, NoonPaypalResponse, T, PaymentsResponseData>> for RouterData<F, T, PaymentsResponseData>
|
{"issue_number": 7831, "pr_number": 7832, "commits_count": 1, "files_changed": 2, "response_length": 1386, "file_count": 4, "needs_breakdown": false}
|
[FEATURE] [CONNECTOR] Payload
Integrate a new connector Payload.
Developer Docs: https://docs.payload.com
Login Dashboard: https://app.payload.com
|
<think>
PR Context:
- Title: feat(connector): [payload] introduce no-3ds cards
- Merged: 2025-07-05T15:10:04Z
- Files changed: 14 files
- Commits: 15 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR introduces the below given flows for Payload connector:
- [x] Cards (No 3DS)
- [x] PSync
- [x] Void
- [x] Refunds
- [x] AVS Checks
- [x] Cypress
Connector does not support 3DS transactions.
### Additional Changes
- [
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [payload] introduce no-3ds cards (#8545)
Files to modify:
**crates/common_enums/src/connector_enums.rs**
Modify existing code
**crates/connector_configs/src/connector.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payload.rs**
Remove:
- impl: impl ConnectorIntegration<Void, PaymentsCancelData, PaymentsResponseData> for Payload
Add:
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- impl: impl ConnectorIntegration<Void, PaymentsCancelData, PaymentsResponseData> for Payload
- mod: private::requests
- mod: private::responses
**crates/hyperswitch_connectors/src/connectors/payload/requests.rs**
Add:
- struct: pub::BillingAddress
- struct: pub::PayloadCardsRequestData
- struct: pub::PayloadCard
- struct: pub::PayloadCancelRequest
- struct: pub::PayloadCaptureRequest
- struct: pub::PayloadRefundRequest
- enum: pub::PayloadPaymentsRequest
- enum: pub::TransactionTypes
**crates/hyperswitch_connectors/src/connectors/payload/responses.rs**
Add:
- struct: pub::PayloadCardsResponseData
- struct: pub::PayloadCardResponse
- struct: pub::RefundsLedger
- struct: pub::PayloadRefundResponse
- struct: pub::PayloadErrorResponse
- enum: pub::PayloadPaymentStatus
- enum: pub::PayloadPaymentsResponse
- enum: pub::AvsResponse
- enum: pub::RefundStatus
**crates/hyperswitch_connectors/src/connectors/payload/transformers.rs**
Remove:
- struct: pub::PayloadPaymentsRequest
- struct: pub::PayloadCard
- struct: pub::PayloadPaymentsResponse
- struct: pub::RefundResponse
- struct: pub::PayloadErrorResponse
- enum: pub::PayloadPaymentStatus
Add:
- function: private::from
- function: private::from
- function: private::try_from
- impl: impl From<(StringMajorUnit, T)> for PayloadRouterData<T>
- impl: impl From<responses::PayloadPaymentStatus> for common_enums::AttemptStatus
**crates/payment_methods/src/configs/payment_connector_required_fields.rs**
Modify existing code
**crates/router/src/core/connector_validation.rs**
Modify existing code
**crates/router/src/types/api.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
|
{"issue_number": 8527, "pr_number": 8545, "commits_count": 1, "files_changed": 14, "response_length": 3275, "file_count": 12, "needs_breakdown": false}
|
`nmi` tests shows different error messages for the same request
Postman Tests for nmi behaves like the following while running `Flow Testcases/Variation Cases/Scenario9-Create a mandate payment`
## Creating a mandate payment for `nmi`
```curl
curl --location '{{baseUrl}}/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: {{apiKey}}' \
--data-raw '{
"amount": 47074,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"amount_to_capture": 47074,
"customer_id": "StripeCustomer",
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Its my first payment request",
"authentication_type": "no_three_ds",
"return_url": "https://duck.com",
"payment_method": "card",
"payment_method_data": {
"card": {
"card_number": "4111111111111111",
"card_exp_month": "10",
"card_exp_year": "69",
"card_holder_name": "joseph Doe",
"card_cvc": "123"
}
},
"setup_future_usage": "off_session",
"mandate_data": {
"customer_acceptance": {
"acceptance_type": "offline",
"accepted_at": "1963-05-03T04:07:52.723Z",
"online": {
"ip_address": "127.0.0.1",
"user_agent": "amet irure esse"
}
},
"mandate_type": {
"single_use": {
"amount": 7000,
"currency": "USD"
}
}
},
"customer_acceptance": {
"acceptance_type": "online",
"accepted_at": "2022-09-10T10:11:12Z",
"online": {
"ip_address": "123.32.25.123",
"user_agent": "Mozilla/5.0 (Linux; Android 12; SM-S906N Build/QP1A.190711.020; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/80.0.3987.119 Mobile Safari/537.36"
}
},
"billing": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "John"
}
},
"shipping": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "John"
}
},
"statement_descriptor_name": "joseph",
"statement_descriptor_suffix": "JS",
"metadata": {
"udf1": "value1",
"new_customer": "true",
"login_date": "2019-09-10T10:11:12Z"
}
}'
```
### Integ Response
```json
{
"error": {
"type": "invalid_request",
"message": "Payment method type not supported",
"code": "IR_19",
"reason": "credit mandate payment is not supported by nmi"
}
}
```
### SBX Response
```json
{
"error": {
"type": "invalid_request",
"message": "Payment method type not supported",
"code": "IR_19",
"reason": "debit mandate payment is not supported by nmi"
}
}
```
It shows different error messages for two environments.
|
<think>
PR Context:
- Title: ci(postman): update assertion error message for nmi collection
- Merged: 2025-04-17T07:51:28Z
- Files changed: 2 files
- Commits: 10 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
Postman Tests for `nmi` were failing on SBX (but not on Integ) because `Flow Testcases/Variation Cases/Scenario9-Create a mandate payment` responded an error message as `debit mandate payment is not supported by nmi` on SBX and `credit mandate
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 7764, "pr_number": 7765, "commits_count": 0, "files_changed": 2, "response_length": 793, "file_count": 0, "needs_breakdown": false}
|
Migrate from cargo2nix to rust-flake
Migrate the Nix build/shell system from cargo2nix to rust-flake.
**Parent Issue:** #57
**Related PR:** #8503
## Acceptance Criteria
- [x] Migrate from cargo2nix to rust-flake
- [x] Verify nix CI/CD compatibility
|
<think>
PR Context:
- Title: refactor(nix): Migrate from cargo2nix to rust-flake
- Merged: 2025-07-15T08:20:23Z
- Files changed: 7 files
- Commits: 6 commits
Implementation approach:
# Migrate Nix Configuration to rust-flake
This PR refactors the existing Nix setup by migrating from `cargo2nix` to `rust-flake`.
Resolves: #8538
## TODO:
- [x] **Initial port** - Port current `flake.nix` functionality using rust-flake
- [x] @kashif-m The current [`flake.nix`](https://github.com/juspay/hyperswitch/blob/d305fad2e6c403fde11b9eea785fddefbf3477df/flake.nix#L63-L78) has `default`, `dev`, and `qa` shells. Are all three required? Typically we use `default` for development
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 8538, "pr_number": 8503, "commits_count": 0, "files_changed": 7, "response_length": 781, "file_count": 1, "needs_breakdown": false}
|
feat(connector): Add recovery support for stripebilling
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Context: In case of some billing connectors we dont get the enough data in the webhook itself to support creation of payment intent and payment attempt in our system. So previously we derived a flow named "AdditionalRevenuerecoveryDetails" in this PR:#7402 which name is now changed to "BillingConnectorPaymentSync". This flow is used to fetch payment details of the invoices from the billing connectors using an API call to that billing connector. In this pr we are calling the flow and getting the details which are needed to create payment intent and attempt in our system.
1. Creates a connector integration in stripe billing that supports the API call.
2. Call the flow in recovery_incoming.rs file and using that details further we are creating the payment intent and attempt and verifying them.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
3. `crates/router/src/configs`
4. `loadtest/config`
-->
## Motivation and Context
## Testing
1. Go to stripe create a new webhook endpoint with a dummy url to get webhook secret key.
2. create a payment processor stripe
```
curl --location 'http://localhost:8080/v2/connector-accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'x-merchant-id: cloth_seller_mQRYaJduFokPeZ54W6bN' \
--header 'x-profile-id: pro_me6dnNKlhwuq32xhfjCA' \
--header 'Authorization: admin-api-key=test_admin' \
--header 'api-key: test_admin' \
--data '{
"connector_type": "payment_processor",
"connector_name": "stripe",
"connector_account_details": {
"auth_type": "HeaderKey",
"api_key": "api-key
},
"payment_methods_enabled": [
{
"payment_method_type": "card_redirect",
"payment_method_subtypes": [
{
"payment_method_subtype": "card_redirect",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": 1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "card",
"payment_method_subtypes": [
{
"payment_method_subtype": "credit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "debit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "wallet",
"payment_method_subtypes": [
{
"payment_method_subtype": "google_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "apple_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "we_chat_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "ali_pay",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "paypal",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "mb_way",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "pay_later",
"payment_method_subtypes": [
{
"payment_method_subtype": "klarna",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "affirm",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "afterpay_clearpay",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "walley",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "bank_redirect",
"payment_method_subtypes": [
{
"payment_method_subtype": "giropay",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "ideal",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "eps",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "bancontact_card",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "przelewy24",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "sofort",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "blik",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "trustly",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "online_banking_finland",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "online_banking_poland",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "bank_transfer",
"payment_method_subtypes": [
{
"payment_method_subtype": "ach",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "sepa",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "bacs",
"payment_experience": "redirect_to_url",
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
},
{
"payment_method_type": "bank_debit",
"payment_method_subtypes": [
{
"payment_method_subtype": "ach",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "sepa",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "bacs",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "becs",
"payment_experience": null,
"card_networks": null,
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
}
],
"metadata": {
"status_url": "https://2753-2401-4900-1cb8-2ff9-24dd-1ccf-ed12-b464.in.ngrok.io/webhooks/merchant_1678699058/globalpay",
"account_name": "transaction_processing",
"pricing_type": "fixed_price",
"acquirer_bin": "438309",
"acquirer_merchant_id": "00002000000"
},
"frm_configs": null,
"connector_webhook_details": {
"merchant_secret": ""
},
"profile_id": "pro_me6dnNKlhwuq32xhfjCA"
}'
```
change the profile id and other feilds while creating you own one
3. copy the mca id of stripe and paste it in the billing mca curl in feature metadata
```
curl --location 'http://localhost:8080/v2/connector-accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'x-merchant-id: cloth_seller_mQRYaJduFokPeZ54W6bN' \
--header 'x-profile-id: pro_me6dnNKlhwuq32xhfjCA' \
--header 'Authorization: admin-api-key=test_admin' \
--header 'api-key: test_admin' \
--data '{
"connector_type": "billing_processor",
"connector_name": "stripebilling",
"connector_account_details": {
"auth_type": "HeaderKey",
"api_key": "{your api key}"
},
"payment_methods_enabled": [
{
"payment_method_type": "card",
"payment_method_subtypes": [
{
"payment_method_subtype": "credit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
},
{
"payment_method_subtype": "debit",
"payment_experience": null,
"card_networks": [
"Visa",
"Mastercard"
],
"accepted_currencies": null,
"accepted_countries": null,
"minimum_amount": -1,
"maximum_amount": 68607706,
"recurring_enabled": true,
"installment_payment_enabled": true
}
]
}
],
"metadata": {
"status_url": "https://2753-2401-4900-1cb8-2ff9-24dd-1ccf-ed12-b464.in.ngrok.io/webhooks/merchant_1678699058/globalpay",
"account_name": "transaction_processing",
"pricing_type": "fixed_price",
"acquirer_bin": "438309",
"acquirer_merchant_id": "00002000000"
},
"frm_configs": null,
"feature_metadata" : {
"revenue_recovery":{
"max_retry_count" : 16,
"billing_connector_retry_threshold": 2,
"billing_account_reference": {
"{your stripe mca id here}": "stripebilling"
}
}
},
"connector_webhook_details": {
"merchant_secret": "{webhook secret you have copied here}"
},
"profile_id": "pro_me6dnNKlhwuq32xhfjCA"
}'
```
4. copy the mca id, profile id and merchant id to construct the endpoint of the webhook.
5. install ngrok and run the service it will give you a https url for your local host port.
6. copy the https url of ngrok
7. construct the webhook endpoint : url/v2/webhooks/merchant_id/profile_id/billing_mca_id
8. paste this endpoint in the place of dummy url you have used to create endpoint in stripe dashboard
9. now create a test subscription use this card "4000 0000 0000 0341" while creating a test subscription and the billing day should start from the next day. If you are creating a test subscription today billing date should start from tommorow.
10. now move the clock past one month.
11. no observe the payment intent table and payment attempt table in db and verify those details with ones we are getting.
Images of the logs:
<img width="1728" alt="Screenshot 2025-03-11 at 5 52 53 PM" src="https://github.com/user-attachments/assets/0a97b656-2417-4812-b9cd-a808183411ea" />
<img width="1728" alt="Screenshot 2025-03-11 at 5 53 10 PM" src="https://github.com/user-attachments/assets/5a9872f1-45a3-4bf5-978c-6e477df36c9f" />
<img width="1728" alt="Screenshot 2025-03-11 at 5 53 21 PM" src="https://github.com/user-attachments/assets/5cbac559-09d8-4939-b2a6-04bc8f50a1bc" />
<img width="1728" alt="Screenshot 2025-03-11 at 5 54 32 PM" src="https://github.com/user-attachments/assets/3eb3fb41-afd4-4a05-8c8b-715310a79d7d" />
<img width="1710" alt="Screenshot 2025-03-10 at 4 52 08 PM" src="https://github.com/user-attachments/assets/05477fdc-656b-42cd-ba27-880d5748cc19" />
<img width="1190" alt="Screenshot 2025-03-10 at 4 52 20 PM" src="https://github.com/user-attachments/assets/d9900f24-2b8f-45c5-b6c5-bd5dcd62357d" />
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: feat(core): consume card details from billing connectors and first error codes and store them in payment intent table
- Merged: 2025-06-16T11:39:32Z
- Files changed: 16 files
- Commits: 30 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
The following details are needed to be stored in the payment intent feature metadata as a part of transaction monitoring system for revenue recovery.
1. Card Network
2. Card Issuer
3. First Payment Gateway Error Code
4. First Network Error Code
5. First Network Advice Cod
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(core): consume card details from billing connectors and first error codes and store them in pay
Files to modify:
**crates/api_models/src/payments.rs**
Add:
- struct: pub::BillingConnectorAdditionalCardInfo
- enum: pub::BillingConnectorPaymentMethodDetails
**crates/diesel_models/src/types.rs**
Add:
- struct: pub::BillingConnectorAdditionalCardInfo
- enum: pub::BillingConnectorPaymentMethodDetails
**crates/hyperswitch_connectors/src/connectors/chargebee/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/recurly/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/stripebilling/transformers.rs**
Remove:
- struct: pub::StripeCardFundingTypeDetails
Add:
- function: private::from
- struct: pub::StripeBillingCardDetails
**crates/hyperswitch_domain_models/src/lib.rs**
Add:
- function: private::convert_from
- function: private::convert_back
- function: private::convert_from
- function: private::convert_back
- impl: impl ApiModelToDieselModelConvertor<ApiBillingConnectorAdditionalCardInfo> for BillingConnectorAdditionalCardInfo
- impl: impl ApiModelToDieselModelConvertor<ApiBillingConnectorPaymentMethodDetails> for BillingConnectorPaymentMethodDetails
**crates/hyperswitch_domain_models/src/payments.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/revenue_recovery.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/router_response_types/revenue_recovery.rs**
Modify existing code
**crates/openapi/src/openapi_v2.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_attempt_record.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Add:
- function: private::foreign_from
- impl: impl ForeignFrom<&diesel_models::types::BillingConnectorPaymentMethodDetails> for api_models::payments::BillingConnectorPaymentMethodDetails
**crates/router/src/core/revenue_recovery.rs**
Modify existing code
**crates/router/src/core/revenue_recovery/api.rs**
Modify existing code
**crates/router/src/core/webhooks/recovery_incoming.rs**
Modify existing code
|
{"issue_number": 7461, "pr_number": 8250, "commits_count": 1, "files_changed": 16, "response_length": 3062, "file_count": 17, "needs_breakdown": true}
|
[FEATURE] [DEUTSCHEBANK] Integrate SEPA Payments
### Feature Description
Integrate SEPA Payments for connector Deutsche Bank
### Possible Implementation
https://testmerch.directpos.de/rest-api/apidoc/v2.1/index.html#chap_sdd
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(payments): propagate additional payment method data for google pay during MIT
- Merged: 2024-11-26T14:14:16Z
- Files changed: 5 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #5858 # 2 point
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Fo
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payments): propagate additional payment method data for google pay during MIT (#6644)
Co-author
Files to modify:
**crates/api_models/src/payment_methods.rs**
Add:
- function: private::from
- function: private::from
- struct: pub::PaymentMethodDataWalletInfo
- impl: impl From<payments::additional_info::WalletAdditionalDataForCard> for PaymentMethodDataWalletInfo
- impl: impl From<PaymentMethodDataWalletInfo> for payments::additional_info::WalletAdditionalDataForCard
**crates/hyperswitch_domain_models/src/payment_method_data.rs**
Add:
- function: private::from
- impl: impl From<GooglePayWalletData> for payment_methods::PaymentMethodDataWalletInfo
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_create.rs**
Modify existing code
**crates/router/src/core/payments/tokenization.rs**
Modify existing code
|
{"issue_number": 5858, "pr_number": 6644, "commits_count": 1, "files_changed": 5, "response_length": 1748, "file_count": 7, "needs_breakdown": false}
|
[BUG]Noon Connector V2 API Failure - Missing order_category in Authorize flow
### Bug Description
The Noon Connector V2 API is failing in the payment flow with the error “Missing required param: order_category.” This happens because the connector_metadata is not being extracted properly in the V2 confirm-intent flow, which causes the order_category field to be None.
### Expected Behavior
The Noon Connector V2 API should extract order_category from connector_metadata during the payment flow. When a request with valid connector_metadata is sent, the order_category value should be passed correctly to the connector, and the payment should proceed without errors.
### Actual Behavior
The connector_metadata is not being extracted in the V2 payment flow, causing the `order_category` field to be None. As a result, the API returns the error `Missing required param: order_category`, and the payment flow fails to complete.
### Steps To Reproduce
Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to reproduce, if relevant.
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
### Context For The Bug
_No response_
### Environment
Are you using hyperswitch hosted version? Yes/No
If yes, please provide the value of the `x-request-id` response header to help us debug your issue.
If not (or if building/running locally), please provide the following details:
1. Operating System or Linux distribution:
2. Rust version (output of `rustc --version`): ``
3. App version (output of `cargo r --features vergen -- --version`): ``
### Have you spent some time checking if this bug has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: fix(payments): add connector metadata parsing and order category to payment router data
- Merged: 2025-10-16T10:25:01Z
- Files changed: 8 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
The Noon Connector V2 API is failing in the payment flow with the error `Missing required param: order_category.` This happens because the connector_metadata is not being extracted in the V2 confirm-intent flow, which causes the order_category field to be None. The fix involves co
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(payments): add connector metadata parsing and order category to payment router data (#9825)
Files to modify:
**crates/api_models/src/payments.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments.rs**
Remove:
- function: pub::get_optional_connector_metadata
**crates/hyperswitch_domain_models/src/payments/payment_intent.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_update_intent.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/core/utils.rs**
Modify existing code
**crates/router/src/services/kafka/payment_intent.rs**
Modify existing code
**crates/router/src/services/kafka/payment_intent_event.rs**
Modify existing code
|
{"issue_number": 9824, "pr_number": 9825, "commits_count": 1, "files_changed": 8, "response_length": 1600, "file_count": 10, "needs_breakdown": false}
|
[FIX] Add fallback connectors instead of active routing rule connectors if straight through connector is ineligible
Add the fallback connectors to the list of eligible connectors instead of adding connectors configured in the active routing rule in case straight through connector is ineligible
|
<think>
PR Context:
- Title: revert(routing): Add connectors from current active routing algorithm before adding fallback connectors
- Merged: 2025-06-04T16:36:28Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Reverts https://github.com/juspay/hyperswitch/pull/7921
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert(routing): Add connectors from current active routing algorithm before adding fallback connect
Files to modify:
**crates/router/src/core/payments.rs**
Modify existing code
|
{"issue_number": 8208, "pr_number": 8207, "commits_count": 1, "files_changed": 1, "response_length": 1017, "file_count": 3, "needs_breakdown": false}
|
[FEATURE] Add Facilitapay connector
Facilitapay connector is yet another payment processor.
Docs: https://sandbox-portal.facilitapay.com/#/docs
|
<think>
PR Context:
- Title: feat(connector): Introduce connector template code for Facilitapay
- Merged: 2025-03-27T13:33:42Z
- Files changed: 24 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR introduces template code for new connector named `Facilitapay`.
Docs: https://sandbox-portal.facilitapay.com/#/docs
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): Introduce connector template code for Facilitapay (#7631)
Files to modify:
**crates/common_enums/src/connector_enums.rs**
Modify existing code
**crates/connector_configs/src/connector.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors.rs**
Add:
- mod: pub::facilitapay
**crates/hyperswitch_connectors/src/connectors/facilitapay.rs**
Add:
- function: pub::new
- function: private::build_headers
- function: private::id
- function: private::get_currency_unit
- function: private::common_get_content_type
- function: private::base_url
- function: private::get_auth_header
- function: private::build_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_webhook_object_reference_id
- function: private::get_webhook_event_type
- function: private::get_webhook_resource_object
- struct: pub::Facilitapay
- impl: impl Facilitapay
- impl: impl api::Payment for Facilitapay
- impl: impl api::PaymentSession for Facilitapay
- impl: impl api::ConnectorAccessToken for Facilitapay
- impl: impl api::MandateSetup for Facilitapay
- impl: impl api::PaymentAuthorize for Facilitapay
- impl: impl api::PaymentSync for Facilitapay
- impl: impl api::PaymentCapture for Facilitapay
- impl: impl api::PaymentVoid for Facilitapay
- impl: impl api::Refund for Facilitapay
- impl: impl api::RefundExecute for Facilitapay
- impl: impl api::RefundSync for Facilitapay
- impl: impl api::PaymentToken for Facilitapay
- impl: impl ConnectorIntegration<PaymentMethodToken, PaymentMethodTokenizationData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorCommonExt<Flow, Request, Response> for Facilitapay
- impl: impl ConnectorCommon for Facilitapay
- impl: impl ConnectorValidation for Facilitapay
- impl: impl ConnectorIntegration<Session, PaymentsSessionData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<AccessTokenAuth, AccessTokenRequestData, AccessToken> for Facilitapay
- impl: impl ConnectorIntegration<SetupMandate, SetupMandateRequestData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<Authorize, PaymentsAuthorizeData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<PSync, PaymentsSyncData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<Capture, PaymentsCaptureData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<Void, PaymentsCancelData, PaymentsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<Execute, RefundsData, RefundsResponseData> for Facilitapay
- impl: impl ConnectorIntegration<RSync, RefundsData, RefundsResponseData> for Facilitapay
- impl: impl webhooks::IncomingWebhook for Facilitapay
- impl: impl ConnectorSpecifications for Facilitapay
- mod: pub::transformers
**crates/hyperswitch_connectors/src/connectors/facilitapay/transformers.rs**
Add:
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- struct: pub::FacilitapayRouterData
- struct: pub::FacilitapayPaymentsRequest
- struct: pub::FacilitapayCard
- struct: pub::FacilitapayAuthType
- struct: pub::FacilitapayPaymentsResponse
- struct: pub::FacilitapayRefundRequest
- struct: pub::RefundResponse
- struct: pub::FacilitapayErrorResponse
- enum: pub::FacilitapayPaymentStatus
- enum: pub::RefundStatus
- impl: impl From<(StringMinorUnit, T)> for FacilitapayRouterData<T>
- impl: impl TryFrom<&FacilitapayRouterData<&PaymentsAuthorizeRouterData>> for FacilitapayPaymentsRequest
- impl: impl TryFrom<&ConnectorAuthType> for FacilitapayAuthType
- impl: impl From<FacilitapayPaymentStatus> for common_enums::AttemptStatus
- impl: impl TryFrom<ResponseRouterData<F, FacilitapayPaymentsResponse, T, PaymentsResponseData>> for RouterData<F, T, PaymentsResponseData>
- impl: impl TryFrom<&FacilitapayRouterData<&RefundsRouterData<F>>> for FacilitapayRefundRequest
- impl: impl From<RefundStatus> for enums::RefundStatus
- impl: impl TryFrom<RefundsResponseRouterData<Execute, RefundResponse>> for RefundsRouterData<Execute>
- impl: impl TryFrom<RefundsResponseRouterData<RSync, RefundResponse>> for RefundsRouterData<RSync>
**crates/hyperswitch_connectors/src/default_implementations.rs**
Modify existing code
**crates/hyperswitch_connectors/src/default_implementations_v2.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/configs.rs**
Modify existing code
**crates/router/src/connector.rs**
Modify existing code
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/payments/flows.rs**
Modify existing code
**crates/router/src/types/api.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
**crates/router/tests/connectors/facilitapay.rs**
Add:
- function: private::get_data
- function: private::get_auth_token
- function: private::get_name
- function: private::get_default_payment_info
- function: private::payment_method_details
- function: private::should_only_authorize_payment
- function: private::should_capture_authorized_payment
- function: private::should_partially_capture_authorized_payment
- function: private::should_sync_authorized_payment
- function: private::should_void_authorized_payment
- function: private::should_refund_manually_captured_payment
- function: private::should_partially_refund_manually_captured_payment
- function: private::should_sync_manually_captured_refund
- function: private::should_make_payment
- function: private::should_sync_auto_captured_payment
- function: private::should_refund_auto_captured_payment
- function: private::should_partially_refund_succeeded_payment
- function: private::should_refund_succeeded_payment_multiple_times
- function: private::should_sync_refund
- function: private::should_fail_payment_for_incorrect_cvc
- function: private::should_fail_payment_for_invalid_exp_month
- function: private::should_fail_payment_for_incorrect_expiry_year
- function: private::should_fail_void_payment_for_auto_capture
- function: private::should_fail_capture_for_invalid_payment
- function: private::should_fail_for_refund_amount_higher_than_payment_amount
- struct: private::FacilitapayTest
- impl: impl ConnectorActions for FacilitapayTest
- impl: impl utils::Connector for FacilitapayTest
**crates/router/tests/connectors/main.rs**
Add:
- mod: private::facilitapay
**crates/test_utils/src/connector_auth.rs**
Modify existing code
|
{"issue_number": 7630, "pr_number": 7631, "commits_count": 1, "files_changed": 24, "response_length": 9052, "file_count": 18, "needs_breakdown": true}
|
[FEATURE] allow payout_id to be configurable
### Feature Description
`payout_id` is an unique identifier for payout resource which is auto generated during payout creation. This field needs to be configurable during payout creation by accepting in the API.
Along with this, a `merchant_order_reference_id` needs to be added which is an unique identifier for the consumer of the API.
### Possible Implementation
Below changes are needed in payout flow across different components -
- Add `payout_id` to API models
- Add `PayoutId` domain type
- Add `merchant_order_reference_id` to API and diesel models
- Add DB queries for fetching orders using `merchant_order_reference_id`
- Add `merchant_order_reference_id` as a filter for OLAP APIs
- Use uuidv4 for payout ID creation for Wise
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
None
|
<think>
PR Context:
- Title: feat(payouts): add domain type for PayoutId
- Merged: 2025-07-01T14:45:02Z
- Files changed: 30 files
- Commits: 16 commits
Implementation approach:
feat(payouts): allow payout_id to be configurable in API request
feat(payouts): add merchant_order_reference_id for referencing payouts
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This pull request introduces two main features for payouts:
1. **Configurable `payout_id` in API Requests**:
* The `payout_id` field i
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payouts): add domain type for PayoutId (#8395)
Co-authored-by: hyperswitch-bot[bot] <148525504+
Files to modify:
**crates/api_models/src/events/payouts.rs**
Modify existing code
**crates/api_models/src/payouts.rs**
Modify existing code
**crates/api_models/src/webhooks.rs**
Modify existing code
**crates/common_utils/src/events.rs**
Modify existing code
**crates/common_utils/src/id_type.rs**
Add:
- mod: private::payout
**crates/common_utils/src/id_type/payout.rs**
Modify existing code
**crates/common_utils/src/link_utils.rs**
Modify existing code
**crates/diesel_models/src/events.rs**
Modify existing code
**crates/diesel_models/src/generic_link.rs**
Modify existing code
**crates/diesel_models/src/payout_attempt.rs**
Modify existing code
**crates/diesel_models/src/payouts.rs**
Modify existing code
**crates/diesel_models/src/query/generic_link.rs**
Modify existing code
**crates/diesel_models/src/query/payout_attempt.rs**
Add:
- function: pub::find_by_merchant_id_merchant_order_reference_id
**crates/diesel_models/src/query/payouts.rs**
Modify existing code
**crates/diesel_models/src/schema.rs**
Modify existing code
**crates/diesel_models/src/schema_v2.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/adyen/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/adyenplatform/transformers/payouts.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cybersource/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/nomupay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/paypal/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/stripe/transformers/connect.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/wise/transformers.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/errors/api_error_response.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payouts.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payouts/payout_attempt.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payouts/payouts.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/router_request_types.rs**
Modify existing code
**crates/router/src/compatibility/stripe/errors.rs**
Modify existing code
**crates/router/src/compatibility/stripe/webhooks.rs**
Modify existing code
**crates/router/src/core/payments/routing.rs**
Modify existing code
**crates/router/src/core/payout_link.rs**
Modify existing code
**crates/router/src/core/payouts.rs**
Modify existing code
**crates/router/src/core/payouts/helpers.rs**
Modify existing code
**crates/router/src/core/payouts/retry.rs**
Modify existing code
**crates/router/src/core/payouts/transformers.rs**
Modify existing code
**crates/router/src/core/payouts/validator.rs**
Modify existing code
**crates/router/src/core/utils.rs**
Remove:
- function: pub::get_or_generate_uuid
- function: pub::validate_uuid
**crates/router/src/core/webhooks/incoming.rs**
Modify existing code
**crates/router/src/db/kafka_store.rs**
Add:
- function: private::find_payout_attempt_by_merchant_id_merchant_order_reference_id
**crates/router/src/events/outgoing_webhook_logs.rs**
Modify existing code
**crates/router/src/routes/payout_link.rs**
Modify existing code
**crates/router/src/routes/payouts.rs**
Modify existing code
**crates/router/src/services/kafka/payout.rs**
Modify existing code
**crates/router/src/utils.rs**
Remove:
- function: pub::generate_uuid
**crates/router/src/workflows/outgoing_webhook_retry.rs**
Modify existing code
**crates/router/tests/connectors/utils.rs**
Modify existing code
**crates/storage_impl/src/lib.rs**
Modify existing code
**crates/storage_impl/src/mock_db/payout_attempt.rs**
Add:
- function: private::find_payout_attempt_by_merchant_id_merchant_order_reference_id
**crates/storage_impl/src/mock_db/payouts.rs**
Modify existing code
**crates/storage_impl/src/payouts/payout_attempt.rs**
Add:
- function: private::find_payout_attempt_by_merchant_id_merchant_order_reference_id
- function: private::find_payout_attempt_by_merchant_id_merchant_order_reference_id
**crates/storage_impl/src/payouts/payouts.rs**
Modify existing code
**crates/storage_impl/src/redis/kv_store.rs**
Modify existing code
|
{"issue_number": 8392, "pr_number": 8395, "commits_count": 1, "files_changed": 30, "response_length": 5301, "file_count": 56, "needs_breakdown": true}
|
[TASK] Missing `payment_link` config in `docker_compose.toml` breaks SDK loading
## Problem
The `docker_compose.toml` file is missing the following required block:
```toml
[payment_link]
sdk_url = "http://localhost:9050/HyperLoader.js"
```
Without this config, when generating payment links the SDK tries to fetch from `https://beta.hyperswitch.io` instead of the locally running backend. This results in failed `payment_methods` calls and the payment link not loading correctly for users.
## Solution
Add the missing `[payment_link]` block to `docker_compose.toml` with the correct `sdk_url` pointing to the local service (`http://localhost:9050/HyperLoader.js`).
## Expected Outcome
- Payment links generated locally should correctly load the SDK from the configured local URL.
- The `payment_methods` call should hit the backend specified in the `hyperswitch-web` service config instead of `https://beta.hyperswitch.io`.
- Users should be able to open a generated payment link and see it working without SDK load failures.
## Files to Modify
- `config/docker_compose.toml`
## Verification
1. Run `docker compose up`
2. Generate a payment link with:
```bash
curl --location 'http://localhost:8081/payments' \
--header 'Content-Type: application/json' \
--header 'api-key: snd_5jYonmRK338pDuk1FqxSYfpPNutQUuVFEVV23qzpqzbQ4DYfbksIgdwIkgjb3vnP' \
--data '{
"amount": 100,
"currency": "USD",
"payment_link": true,
"profile_id": "pro_ARVaflLlXRmGS5i8jfq5",
"return_url": "http://www.google.com"
}'
```
3. Open the generated payment link in a browser
4. Confirm that the SDK loads successfully and the `payment_methods` API call hits the local backend
|
<think>
PR Context:
- Title: Fix: Add missing payment_method_collect config in docker_compose.toml (#9324)
- Merged: None
- Files changed: 0 files
- Commits: 0 commits
Implementation approach:
## Type of Change
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
---
## Description
This PR fixes a bug where local payment links failed to load the HyperLoader SDK correctly due to a missing configuration in `docker_compose.toml`.
### Changes Made:
- Configured `sdk_url` to point to the local instance: `http://localhost:9090/0.16.7/v0/HyperLoader.js`
- Enabled payment methods (e.g. `c
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 9324, "pr_number": 9368, "commits_count": 0, "files_changed": 0, "response_length": 791, "file_count": 0, "needs_breakdown": false}
|
feat(core): implement `NameType` for name validation
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
for card holder name in cards, validation is added before creation of request to flag invalid data in case it is present.
Reference is taken from Visa Documetation
<img width="889" alt="image" src="https://github.com/user-attachments/assets/02859794-8313-46fb-a2b2-33a009a03600">
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Tested through Postman:
- Create a MCA (Cybersource):
Case 1: Create a Payment with valid name:
```
{
"amount": 499,
"currency": "EUR",
"confirm": true,
"capture_method": "automatic",
"customer_id": "test_rec7",
"email": "guest@example.com",
"customer_acceptance": {
"acceptance_type": "online"
},
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "Sakil Mostak",
"card_cvc": "737",
"card_network": "Visa"
}
},
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here is some \n there is some \n none is some? \n ",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "Sakil",
"last_name": "Mostak"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "guest@example.com"
},
"authentication_type": "no_three_ds"
}
```
- The payment should succeed, below is an example:
```
{
"payment_id": "pay_7YANCrkBMUVJngRBg36l",
"merchant_id": "merchant_1737373987",
"status": "succeeded",
"amount": 499,
"net_amount": 499,
"shipping_cost": null,
"amount_capturable": 0,
"amount_received": 499,
"connector": "cybersource",
"client_secret": "pay_7YANCrkBMUVJngRBg36l_secret_jp4t6pcoJTnMFrQsGd1R",
"created": "2025-01-20T17:52:24.651Z",
"currency": "EUR",
"customer_id": "test_rec7",
"customer": {
"id": "test_rec7",
"name": null,
"email": "guest@example.com",
"phone": null,
"phone_country_code": null
},
"description": null,
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": null,
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "card",
"payment_method_data": {
"card": {
"last4": "4242",
"card_type": null,
"card_network": null,
"card_issuer": null,
"card_issuing_country": null,
"card_isin": "424242",
"card_extended_bin": null,
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "Sakil Mostak",
"payment_checks": {
"avs_response": {
"code": "X",
"codeRaw": "I1"
},
"card_verification": null
},
"authentication_data": null
},
"billing": null
},
"payment_token": "token_7usZJrOsD3Qoy6kLGDnQ",
"shipping": null,
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here is some \n there is some \n none is some? \n ",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "Sakil",
"last_name": "Mostak"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "guest@example.com"
},
"order_details": null,
"email": "guest@example.com",
"name": null,
"phone": null,
"return_url": null,
"authentication_type": "no_three_ds",
"statement_descriptor_name": null,
"statement_descriptor_suffix": null,
"next_action": null,
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "credit",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "test_rec7",
"created_at": 1737395544,
"expires": 1737399144,
"secret": "epk_b4c0b9ee60c844dd88e6cbc9daa9e7cb"
},
"manual_retry_allowed": false,
"connector_transaction_id": "7373955459786405604807",
"frm_message": null,
"metadata": null,
"connector_metadata": null,
"feature_metadata": null,
"reference_id": "pay_7YANCrkBMUVJngRBg36l_1",
"payment_link": null,
"profile_id": "pro_VcDn0jWTcCmofCpz2CAH",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_KXO79qkYuOXsSZCYByGz",
"incremental_authorization_allowed": false,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2025-01-20T18:07:24.651Z",
"fingerprint": null,
"browser_info": null,
"payment_method_id": null,
"payment_method_status": null,
"updated": "2025-01-20T17:52:26.511Z",
"charges": null,
"frm_metadata": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null
}
```
Case 2: Create a Payment with invalid name:
```
{
"amount": 499,
"currency": "EUR",
"confirm": true,
"capture_method": "automatic",
"customer_id": "test_rec7",
"email": "guest@example.com",
"customer_acceptance": {
"acceptance_type": "online"
},
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "S@k*l M0st@k",
"card_cvc": "737",
"card_network": "Visa"
}
},
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here is some \n there is some \n none is some? \n ",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "Sakil",
"last_name": "Mostak"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "guest@example.com"
},
"authentication_type": "no_three_ds"
}
```
Response should contain 400 error with below response:
```
{
"error": {
"error_type": "invalid_request",
"message": "Json deserialize error: invalid character found in card holder name: @ at line 23 column 5",
"code": "IR_06"
}
}
```
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [x] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert: implement `NameType` for name validation (#6734)
- Merged: 2025-04-03T13:50:46Z
- Files changed: 30 files
- Commits: 1 commits
Implementation approach:
This reverts commit 1100dcc6053990cf832c00cf29db700d77f78480.
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR revert #6734 in main
Reason: digit couldn't be added to nickname because nickname have the same validation as cardholder name.
### Additional Changes
- [ ] This P
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6734, "pr_number": 7717, "commits_count": 0, "files_changed": 30, "response_length": 787, "file_count": 0, "needs_breakdown": false}
|
[REFACTOR] Worldpay payments integration
### Feature Description
WorldPay payments integration currently makes use of modular APIs which gives more control over the integration. This approach is not best compatible with HyperSwitch due to WP's 3DS flows - which requires sending PAN (card numbers) in multiple places. For `on_session` transactions, this would contribute to the added complexity since data is not stored in such transactions (or stored for ~15mins in redis cache).
Migrating to WP's standard payments API follows payment resource creation in an uniform way.
### Possible Implementation
Migrate from modular APIs [[ref](https://developer.worldpay.com/products/access/card-payments)] to standard payment APIs [[ref](https://developer.worldpay.com/products/access/payments/openapi)].
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: refactor(connector): [WorldPay] migrate from modular to standard payment APIs
- Merged: 2024-10-21T10:24:32Z
- Files changed: 12 files
- Commits: 30 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #6316
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following a
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(connector): [WorldPay] migrate from modular to standard payment APIs (#6317)
Co-authored-by
Files to modify:
**crates/router/src/connector/utils.rs**
Add:
- function: private::get_capture_method
**crates/router/src/connector/worldpay.rs**
Modify existing code
**crates/router/src/connector/worldpay/requests.rs**
Remove:
- struct: pub::WorldpayPaymentsRequest
- struct: pub::Instruction
- struct: pub::RequestAutoSettlement
- struct: pub::CardToken
- struct: pub::WalletPayment
- struct: pub::ExpiryDate
- enum: pub::PaymentInstrument
- enum: pub::PaymentType
Add:
- struct: pub::WorldpayPaymentsRequest
- struct: pub::Merchant
- struct: pub::Instruction
- struct: pub::CardPayment
- struct: pub::CardToken
- struct: pub::WalletPayment
- struct: pub::ExpiryDate
- struct: pub::AutoSettlement
- enum: pub::PaymentInstrument
- enum: pub::PaymentType
**crates/router/src/connector/worldpay/response.rs**
Remove:
- function: private::try_from
- function: private::foreign_try_from
- enum: pub::RefundOutcome
- impl: impl ForeignTryFrom<Option<PaymentLinks>> for types::ResponseId
Add:
- struct: pub::AuthorizedResponse
- struct: pub::FraudHighRiskResponse
- struct: pub::RefusedResponse
- struct: pub::ThreeDsResponse
- struct: pub::DDCResponse
- struct: pub::DDCToken
- struct: pub::DDCActionLink
- struct: pub::SelfLinkInner
- struct: pub::ActionLinks
- struct: pub::ActionLink
- struct: pub::Fraud
- enum: pub::WorldpayPaymentResponseFields
- enum: pub::IssuerResponse
- enum: pub::FraudOutcome
**crates/router/src/connector/worldpay/transformers.rs**
Add:
- function: private::try_from
- struct: pub::WorldpayConnectorMetadataObject
- impl: impl TryFrom<&Option<pii::SecretSerdeValue>> for WorldpayConnectorMetadataObject
**crates/router/src/consts.rs**
Modify existing code
**crates/router/src/lib.rs**
Modify existing code
|
{"issue_number": 6316, "pr_number": 6317, "commits_count": 1, "files_changed": 12, "response_length": 2831, "file_count": 9, "needs_breakdown": false}
|
Payment Intent and MCA changes for split payments
- Add split_txns_enabled field in PaymentIntent
- Add split_enabled field to MCA payment_method
- Code changes to modify split_enabled for a payment method when creating or updating an MCA (similar to recurring_enabled)
- PML changes to filter payment methods based on split_enabled in MCA and split_txns_enabled in Intent
|
<think>
PR Context:
- Title: feat(router): Payment Intent and MCA changes for split payments
- Merged: 2025-09-01T13:47:28Z
- Files changed: 20 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Add split_txns_enabled field to business_profile DB, create+update API calls
- Add split_txns_enabled field in PaymentIntent
- PML changes to filter payment methods based on split_enabled in MCA and split_txns_enabled in Intent
### Addi
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(router): Payment Intent and MCA changes for split payments (#9049)
Files to modify:
**crates/api_models/src/admin.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/common_enums/src/enums.rs**
Add:
- enum: pub::SplitTxnsEnabled
**crates/diesel_models/src/business_profile.rs**
Modify existing code
**crates/diesel_models/src/payment_intent.rs**
Modify existing code
**crates/diesel_models/src/schema_v2.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/business_profile.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments/payment_intent.rs**
Modify existing code
**crates/openapi/src/openapi_v2.rs**
Modify existing code
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/services/kafka/payment_intent.rs**
Modify existing code
**crates/router/src/services/kafka/payment_intent_event.rs**
Modify existing code
**crates/router/src/types/api/admin.rs**
Modify existing code
|
{"issue_number": 9047, "pr_number": 9049, "commits_count": 1, "files_changed": 20, "response_length": 1976, "file_count": 17, "needs_breakdown": true}
|
feat(connector): add template code for stripebilling
add a template code for stripe billing connector
|
<think>
PR Context:
- Title: feat(connector): add template code for stripebilling
- Merged: 2025-03-03T10:35:30Z
- Files changed: 24 files
- Commits: 12 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
connector integration template code for stripe billing.
Issue: This PR closes the issue #7212
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): add template code for stripebilling (#7228)
Co-authored-by: Nishanth Challa <nishan
Files to modify:
**crates/common_enums/src/connector_enums.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors.rs**
Add:
- mod: pub::stripebilling
**crates/hyperswitch_connectors/src/connectors/stripebilling.rs**
Add:
- function: pub::new
- function: private::build_headers
- function: private::id
- function: private::get_currency_unit
- function: private::common_get_content_type
- function: private::base_url
- function: private::get_auth_header
- function: private::build_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_webhook_object_reference_id
- function: private::get_webhook_event_type
- function: private::get_webhook_resource_object
- struct: pub::Stripebilling
- impl: impl Stripebilling
- impl: impl api::Payment for Stripebilling
- impl: impl api::PaymentSession for Stripebilling
- impl: impl api::ConnectorAccessToken for Stripebilling
- impl: impl api::MandateSetup for Stripebilling
- impl: impl api::PaymentAuthorize for Stripebilling
- impl: impl api::PaymentSync for Stripebilling
- impl: impl api::PaymentCapture for Stripebilling
- impl: impl api::PaymentVoid for Stripebilling
- impl: impl api::Refund for Stripebilling
- impl: impl api::RefundExecute for Stripebilling
- impl: impl api::RefundSync for Stripebilling
- impl: impl api::PaymentToken for Stripebilling
- impl: impl ConnectorIntegration<PaymentMethodToken, PaymentMethodTokenizationData, PaymentsResponseData> for Stripebilling
- impl: impl ConnectorCommonExt<Flow, Request, Response> for Stripebilling
- impl: impl ConnectorCommon for Stripebilling
- impl: impl ConnectorValidation for Stripebilling
- impl: impl ConnectorIntegration<Session, PaymentsSessionData, PaymentsResponseData> for Stripebilling
- impl: impl ConnectorIntegration<AccessTokenAuth, AccessTokenRequestData, AccessToken> for Stripebilling
- impl: impl ConnectorIntegration<SetupMandate, SetupMandateRequestData, PaymentsResponseData> for Stripebilling
- impl: impl ConnectorIntegration<Authorize, PaymentsAuthorizeData, PaymentsResponseData> for Stripebilling
- impl: impl ConnectorIntegration<PSync, PaymentsSyncData, PaymentsResponseData> for Stripebilling
- impl: impl ConnectorIntegration<Capture, PaymentsCaptureData, PaymentsResponseData> for Stripebilling
- impl: impl ConnectorIntegration<Void, PaymentsCancelData, PaymentsResponseData> for Stripebilling
- impl: impl ConnectorIntegration<Execute, RefundsData, RefundsResponseData> for Stripebilling
- impl: impl ConnectorIntegration<RSync, RefundsData, RefundsResponseData> for Stripebilling
- impl: impl webhooks::IncomingWebhook for Stripebilling
- impl: impl ConnectorSpecifications for Stripebilling
- mod: pub::transformers
**crates/hyperswitch_connectors/src/connectors/stripebilling/transformers.rs**
Add:
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- struct: pub::StripebillingRouterData
- struct: pub::StripebillingPaymentsRequest
- struct: pub::StripebillingCard
- struct: pub::StripebillingAuthType
- struct: pub::StripebillingPaymentsResponse
- struct: pub::StripebillingRefundRequest
- struct: pub::RefundResponse
- struct: pub::StripebillingErrorResponse
- enum: pub::StripebillingPaymentStatus
- enum: pub::RefundStatus
- impl: impl From<(StringMinorUnit, T)> for StripebillingRouterData<T>
- impl: impl TryFrom<&StripebillingRouterData<&PaymentsAuthorizeRouterData>> for StripebillingPaymentsRequest
- impl: impl TryFrom<&ConnectorAuthType> for StripebillingAuthType
- impl: impl From<StripebillingPaymentStatus> for common_enums::AttemptStatus
- impl: impl TryFrom<ResponseRouterData<F, StripebillingPaymentsResponse, T, PaymentsResponseData>> for RouterData<F, T, PaymentsResponseData>
- impl: impl TryFrom<&StripebillingRouterData<&RefundsRouterData<F>>> for StripebillingRefundRequest
- impl: impl From<RefundStatus> for enums::RefundStatus
- impl: impl TryFrom<RefundsResponseRouterData<Execute, RefundResponse>> for RefundsRouterData<Execute>
- impl: impl TryFrom<RefundsResponseRouterData<RSync, RefundResponse>> for RefundsRouterData<RSync>
**crates/hyperswitch_connectors/src/default_implementations.rs**
Modify existing code
**crates/hyperswitch_connectors/src/default_implementations_v2.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/configs.rs**
Modify existing code
**crates/router/src/connector.rs**
Modify existing code
**crates/router/src/core/payments/connector_integration_v2_impls.rs**
Modify existing code
**crates/router/src/core/payments/flows.rs**
Modify existing code
**crates/router/src/types/api.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
**crates/router/tests/connectors/main.rs**
Add:
- mod: private::stripebilling
**crates/router/tests/connectors/stripebilling.rs**
Add:
- function: private::get_data
- function: private::get_auth_token
- function: private::get_name
- function: private::get_default_payment_info
- function: private::payment_method_details
- function: private::should_only_authorize_payment
- function: private::should_capture_authorized_payment
- function: private::should_partially_capture_authorized_payment
- function: private::should_sync_authorized_payment
- function: private::should_void_authorized_payment
- function: private::should_refund_manually_captured_payment
- function: private::should_partially_refund_manually_captured_payment
- function: private::should_sync_manually_captured_refund
- function: private::should_make_payment
- function: private::should_sync_auto_captured_payment
- function: private::should_refund_auto_captured_payment
- function: private::should_partially_refund_succeeded_payment
- function: private::should_refund_succeeded_payment_multiple_times
- function: private::should_sync_refund
- function: private::should_fail_payment_for_incorrect_cvc
- function: private::should_fail_payment_for_invalid_exp_month
- function: private::should_fail_payment_for_incorrect_expiry_year
- function: private::should_fail_void_payment_for_auto_capture
- function: private::should_fail_capture_for_invalid_payment
- function: private::should_fail_for_refund_amount_higher_than_payment_amount
- struct: private::StripebillingTest
- impl: impl ConnectorActions for StripebillingTest
- impl: impl utils::Connector for StripebillingTest
**crates/test_utils/src/connector_auth.rs**
Modify existing code
|
{"issue_number": 7212, "pr_number": 7228, "commits_count": 1, "files_changed": 24, "response_length": 9132, "file_count": 17, "needs_breakdown": true}
|
feat(analytics): add `sessionized_metrics` for refunds (backwards compatibility) and `currency_conversion`
## Current Behaviour
- There is no `sessionized_metrics` module for refunds like there is for `payments` and `payment_intents`
- Update the existing metrics with `currency_conversion` usage.
## Proposed Changes
- create `sessionized_metrics` module for refunds
- implement `currency_conversion` for refunds analytics
|
<think>
PR Context:
- Title: feat(analytics): add `sessionized_metrics` and `currency_conversion` for refunds analytics
- Merged: 2024-11-14T09:13:34Z
- Files changed: 17 files
- Commits: 8 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Add sessionized metrics module and implement backwards compatibility.
- Implement currency conversion for refunds analytics
### Minor unrelated changes
- refactor inconsistent naming of fields in some places => [commit](https://github.c
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(analytics): add `sessionized_metrics` and `currency_conversion` for refunds analytics (#6419)
Files to modify:
**crates/analytics/src/payment_intents/core.rs**
Modify existing code
**crates/analytics/src/payments/accumulator.rs**
Modify existing code
**crates/analytics/src/payments/core.rs**
Modify existing code
**crates/analytics/src/refunds/accumulator.rs**
Modify existing code
**crates/analytics/src/refunds/core.rs**
Modify existing code
**crates/analytics/src/refunds/metrics.rs**
Add:
- mod: private::sessionized_metrics
**crates/analytics/src/refunds/metrics/refund_processed_amount.rs**
Modify existing code
**crates/analytics/src/refunds/metrics/sessionized_metrics/mod.rs**
Add:
- mod: private::refund_count
- mod: private::refund_processed_amount
- mod: private::refund_success_count
- mod: private::refund_success_rate
**crates/analytics/src/refunds/metrics/sessionized_metrics/refund_count.rs**
Add:
- function: private::load_metrics
- struct: pub::RefundCount
- impl: impl super::RefundMetric<T> for RefundCount
**crates/analytics/src/refunds/metrics/sessionized_metrics/refund_processed_amount.rs**
Add:
- function: private::load_metrics
- struct: pub::RefundProcessedAmount
- impl: impl super::RefundMetric<T> for RefundProcessedAmount
**crates/analytics/src/refunds/metrics/sessionized_metrics/refund_success_count.rs**
Add:
- function: private::load_metrics
- struct: pub::RefundSuccessCount
- impl: impl super::RefundMetric<T> for RefundSuccessCount
**crates/analytics/src/refunds/metrics/sessionized_metrics/refund_success_rate.rs**
Add:
- function: private::load_metrics
- struct: pub::RefundSuccessRate
- impl: impl super::RefundMetric<T> for RefundSuccessRate
**crates/api_models/src/analytics.rs**
Add:
- struct: pub::RefundsAnalyticsMetadata
- struct: pub::RefundsMetricsResponse
**crates/api_models/src/analytics/payments.rs**
Modify existing code
**crates/api_models/src/analytics/refunds.rs**
Modify existing code
**crates/api_models/src/events.rs**
Add:
- function: private::get_api_event_type
- impl: impl ApiEventMetric for RefundsMetricsResponse<T>
**crates/router/src/analytics.rs**
Modify existing code
|
{"issue_number": 6417, "pr_number": 6419, "commits_count": 1, "files_changed": 17, "response_length": 3107, "file_count": 19, "needs_breakdown": true}
|
fix(connector): [noon] address `next_action_url` being `null` for cards in 3ds payment
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
ORIGINAL PR: https://github.com/juspay/hyperswitch/pull/7832
previously, when making a 3ds card transaction via noon connector, we would get `next_action` as `null` which is not intended. and that is because, paypal response would override the transaction data. this pr fixes this by unifying both of them.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
3ds transactions are expected to have an object in next action while at present, we are getting it as null for card payments and this is not intended.
closes #7831
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
3ds card payment:
```curl
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_dSMvDZeLPCEUIv7ZV4JQxAQIoTuE0kdlKZEhxK7gn15IY7WkcKKAgbvSEG8FEuOY' \
--data-raw '{
"amount": 390,
"currency": "AED",
"confirm": true,
"capture_method": "automatic",
"customer_id": "sammantest2722",
"capture_on": "2022-09-10T10:11:12Z",
"authentication_type": "three_ds",
"return_url": "https://google.com",
"email": "something@gmail.com",
"name": "Joseph Doe",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Its my first payment",
"statement_descriptor_name": "Juspay",
"statement_descriptor_suffix": "Router",
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4000000000002701",
"card_exp_month": "01",
"card_exp_year": "2035",
"card_holder_name": "joseph Doe",
"card_cvc": "100"
}
},
"billing": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "AE",
"first_name": "joseph",
"last_name": "Doe"
},
"phone": {
"number": "8056594427",
"country_code": "+91"
}
},
"browser_info": {
"user_agent": "Mozilla\/5.0 (iPhone NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
"accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8",
"language": "nl-NL",
"color_depth": 24,
"screen_height": 723,
"screen_width": 1536,
"time_zone": 0,
"java_enabled": true,
"java_script_enabled": true,
"ip_address": "128.0.0.1"
},
"connector_metadata": {
"noon": {
"order_category": "pay"
}
},
"order_details": [
{
"product_name": "Apple iphone 15",
"quantity": 1,
"amount": 390,
"account_name": "transaction_processing"
}
]
}'
```
```json
{
"payment_id": "pay_kgxQFsLwpvRE5DN7pOjF",
"merchant_id": "postman_merchant_GHAction_7ec10174-0196-450e-a39a-4f9b61a32def",
"status": "requires_customer_action",
"amount": 390,
"net_amount": 390,
"shipping_cost": null,
"amount_capturable": 390,
"amount_received": null,
"connector": "noon",
"client_secret": "pay_kgxQFsLwpvRE5DN7pOjF_secret_JwwEA4oIyoD2w8lyNkuw",
"created": "2025-04-16T12:07:18.695Z",
"currency": "AED",
"customer_id": "sammantest2722",
"customer": {
"id": "sammantest2722",
"name": "Joseph Doe",
"email": "something@gmail.com",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": "Its my first payment",
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": null,
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "card",
"payment_method_data": {
"card": {
"last4": "2701",
"card_type": "CREDIT",
"card_network": "Visa",
"card_issuer": "INTL HDQTRS-CENTER OWNED",
"card_issuing_country": "UNITEDSTATES",
"card_isin": "400000",
"card_extended_bin": null,
"card_exp_month": "01",
"card_exp_year": "2035",
"card_holder_name": "joseph Doe",
"payment_checks": null,
"authentication_data": null
},
"billing": null
},
"payment_token": null,
"shipping": null,
"billing": {
"address": {
"city": "San Fransico",
"country": "AE",
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"zip": "94122",
"state": "California",
"first_name": "joseph",
"last_name": "Doe"
},
"phone": {
"number": "8056594427",
"country_code": "+91"
},
"email": null
},
"order_details": [
{
"brand": null,
"amount": 390,
"category": null,
"quantity": 1,
"tax_rate": null,
"product_id": null,
"product_name": "Apple iphone 15",
"product_type": null,
"sub_category": null,
"product_img_link": null,
"product_tax_code": null,
"total_tax_amount": null,
"requires_shipping": null
}
],
"email": "something@gmail.com",
"name": "Joseph Doe",
"phone": "999999999",
"return_url": "https://google.com/",
"authentication_type": "three_ds",
"statement_descriptor_name": "Juspay",
"statement_descriptor_suffix": "Router",
"next_action": {
"type": "redirect_to_url",
"redirect_to_url": "http://localhost:8080/payments/redirect/pay_kgxQFsLwpvRE5DN7pOjF/postman_merchant_GHAction_7ec10174-0196-450e-a39a-4f9b61a32def/pay_kgxQFsLwpvRE5DN7pOjF_1"
},
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "credit",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "sammantest2722",
"created_at": 1744805238,
"expires": 1744808838,
"secret": "epk_77e21be22ea44e7cbc97ea1893092c71"
},
"manual_retry_allowed": null,
"connector_transaction_id": "783189382167",
"frm_message": null,
"metadata": null,
"connector_metadata": {
"apple_pay": null,
"airwallex": null,
"noon": {
"order_category": "pay"
},
"braintree": null
},
"feature_metadata": null,
"reference_id": "pay_kgxQFsLwpvRE5DN7pOjF_1",
"payment_link": null,
"profile_id": "pro_x1xo34goINdpBDkYDEhK",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_bPPkbMzjo94rCiHfRJyu",
"incremental_authorization_allowed": null,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2025-04-16T12:22:18.695Z",
"fingerprint": null,
"browser_info": {
"language": "nl-NL",
"time_zone": 0,
"ip_address": "128.0.0.1",
"user_agent": "Mozilla/5.0 (iPhone NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
"color_depth": 24,
"java_enabled": true,
"screen_width": 1536,
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"screen_height": 723,
"java_script_enabled": true
},
"payment_method_id": null,
"payment_method_status": null,
"updated": "2025-04-16T12:07:21.111Z",
"split_payments": null,
"frm_metadata": null,
"extended_authorization_applied": null,
"capture_before": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null,
"card_discovery": "manual",
"force_3ds_challenge": false,
"force_3ds_challenge_trigger": false,
"issuer_error_code": null,
"issuer_error_message": null
}
```
paypal payment:
```curl
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_dSMvDZeLPCEUIv7ZV4JQxAQIoTuE0kdlKZEhxK7gn15IY7WkcKKAgbvSEG8FEuOY' \
--data-raw '{
"amount": 1000,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"customer_id": "sammantest2722",
"capture_on": "2022-09-10T10:11:12Z",
"authentication_type": "three_ds",
"return_url": "https://google.com",
"email": "something@gmail.com",
"name": "Joseph Doe",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Its my first payment",
"statement_descriptor_name": "Juspay",
"statement_descriptor_suffix": "Router",
"payment_method": "wallet",
"payment_method_type": "paypal",
"payment_method_data": {
"wallet": {
"paypal_redirect": {}
}
},
"browser_info": {
"user_agent": "Mozilla\/5.0 (iPhone NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
"accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8",
"language": "nl-NL",
"color_depth": 24,
"screen_height": 723,
"screen_width": 1536,
"time_zone": 0,
"java_enabled": true,
"java_script_enabled": true,
"ip_address": "128.0.0.1"
},
"connector_metadata": {
"noon": {
"order_category": "pay"
}
},
"order_details": [
{
"product_name": "Apple iphone 15",
"quantity": 1,
"amount": 390,
"account_name": "transaction_processing"
}
]
}'
```
```json
{
"payment_id": "pay_ZMSscM4kmOOYEGrwuRoC",
"merchant_id": "postman_merchant_GHAction_7ec10174-0196-450e-a39a-4f9b61a32def",
"status": "requires_customer_action",
"amount": 1000,
"net_amount": 1000,
"shipping_cost": null,
"amount_capturable": 1000,
"amount_received": null,
"connector": "noon",
"client_secret": "pay_ZMSscM4kmOOYEGrwuRoC_secret_I9V3GqB1X1emQncgY8Bt",
"created": "2025-04-16T12:02:55.230Z",
"currency": "USD",
"customer_id": "sammantest2722",
"customer": {
"id": "sammantest2722",
"name": "Joseph Doe",
"email": "something@gmail.com",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": "Its my first payment",
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": null,
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "wallet",
"payment_method_data": {
"wallet": {},
"billing": null
},
"payment_token": null,
"shipping": null,
"billing": null,
"order_details": [
{
"brand": null,
"amount": 390,
"category": null,
"quantity": 1,
"tax_rate": null,
"product_id": null,
"product_name": "Apple iphone 15",
"product_type": null,
"sub_category": null,
"product_img_link": null,
"product_tax_code": null,
"total_tax_amount": null,
"requires_shipping": null
}
],
"email": "something@gmail.com",
"name": "Joseph Doe",
"phone": "999999999",
"return_url": "https://google.com/",
"authentication_type": "three_ds",
"statement_descriptor_name": "Juspay",
"statement_descriptor_suffix": "Router",
"next_action": {
"type": "redirect_to_url",
"redirect_to_url": "http://localhost:8080/payments/redirect/pay_ZMSscM4kmOOYEGrwuRoC/postman_merchant_GHAction_7ec10174-0196-450e-a39a-4f9b61a32def/pay_ZMSscM4kmOOYEGrwuRoC_1"
},
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "paypal",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "sammantest2722",
"created_at": 1744804975,
"expires": 1744808575,
"secret": "epk_2483fa5baf0a4b91b294a5a8df1da3d6"
},
"manual_retry_allowed": null,
"connector_transaction_id": "493715212829",
"frm_message": null,
"metadata": null,
"connector_metadata": {
"apple_pay": null,
"airwallex": null,
"noon": {
"order_category": "pay"
},
"braintree": null
},
"feature_metadata": null,
"reference_id": "pay_ZMSscM4kmOOYEGrwuRoC_1",
"payment_link": null,
"profile_id": "pro_x1xo34goINdpBDkYDEhK",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_bPPkbMzjo94rCiHfRJyu",
"incremental_authorization_allowed": null,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2025-04-16T12:17:55.230Z",
"fingerprint": null,
"browser_info": {
"language": "nl-NL",
"time_zone": 0,
"ip_address": "128.0.0.1",
"user_agent": "Mozilla/5.0 (iPhone NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
"color_depth": 24,
"java_enabled": true,
"screen_width": 1536,
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"screen_height": 723,
"java_script_enabled": true
},
"payment_method_id": null,
"payment_method_status": null,
"updated": "2025-04-16T12:02:57.669Z",
"split_payments": null,
"frm_metadata": null,
"extended_authorization_applied": null,
"capture_before": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null,
"card_discovery": null,
"force_3ds_challenge": false,
"force_3ds_challenge_trigger": false,
"issuer_error_code": null,
"issuer_error_message": null
}
```
in 3ds card payment, we now get the next action url and it works as intended.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `just clippy && just clippy_v2`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: revert: fix(connector): [noon] address `next_action_url` being `null` for cards in 3ds payment
- Merged: 2025-04-21T14:52:28Z
- Files changed: 2 files
- Commits: 2 commits
Implementation approach:
Reverts juspay/hyperswitch#7856
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** revert: fix(connector): [noon] address `next_action_url` being `null` for cards in 3ds payment (#786
Files to modify:
**crates/hyperswitch_connectors/src/connectors/noon.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/noon/transformers.rs**
Add:
- function: private::try_from
- struct: pub::NoonPaypalResponse
- struct: pub::NoonPaypalResponseResult
- enum: pub::NoonAuthPaymentResponse
- impl: impl TryFrom<ResponseRouterData<F, NoonPaypalResponse, T, PaymentsResponseData>> for RouterData<F, T, PaymentsResponseData>
|
{"issue_number": 7856, "pr_number": 7860, "commits_count": 1, "files_changed": 2, "response_length": 928, "file_count": 4, "needs_breakdown": false}
|
Adding Deep health check for Hyperswitch
Goal is to create a deep health check endpoint which will verify that the Hyperswitch application is up and running and the connections to all the necessary services are healthy
- [x] Failure of health check should emit logs providing evidential data regarding the failure
The deep health will verify the following services
- [x] #3267
- [x] #3268
- [x] #3269
- [x] #3270
- [x] [Deep health check for Hyperswitch Control Center](https://github.com/juspay/hyperswitch-control-center/issues/374)
|
<think>
PR Context:
- Title: feat(connector): add functionality for transforming QR image color
- Merged: 2025-03-04T11:14:11Z
- Files changed: 9 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR adds functionality to
- Create QR image data URI for a given hex color
- Send back the border color and display text message along with the QR data in `NextActionData` - which is consumed by SDK to take next action
Described in #7405
### Additional Changes
- [ ]
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): add functionality for transforming QR image color (#7414)
Files to modify:
**crates/api_models/src/payments.rs**
Modify existing code
**crates/common_utils/src/errors.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/fiuu/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/constants.rs**
Modify existing code
**crates/hyperswitch_connectors/src/utils.rs**
Add:
- function: pub::new_colored_from_data
- function: pub::parse_hex_color
**crates/router/src/compatibility/stripe/payment_intents/types.rs**
Modify existing code
**crates/router/src/compatibility/stripe/setup_intents/types.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
|
{"issue_number": 3264, "pr_number": 7414, "commits_count": 1, "files_changed": 9, "response_length": 1577, "file_count": 10, "needs_breakdown": false}
|
refactor(core): filter default routing config response based on connector type
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
We are filtering the response for payment and payout processors.
So this works as follows:
If Payment's route is hit only PaymentProcessors will be listed and nothing else like PayoutConnectors etc.
Payment :
```
curl --location 'http://localhost:8080/routing/default/profile' \
--header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWMyMTJhODgtOGFmYy00YjJjLWIwYWQtODY3MmQ2NTI3MzdlIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzQxMDAzMjgwIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTc0MTE3NjE1Miwib3JnX2lkIjoib3JnX1c4MkFMNTZ6VVE1dXFHcEEyYzFkIiwicHJvZmlsZV9pZCI6InByb19NcUlMcDAwdUFJeW5JZDdtUTNUTyIsInRlbmFudF9pZCI6InB1YmxpYyJ9.RoPyIG-JGrH6QmM6Gqd9gh03hOqy6MuC9Our9EHYGNk' \
--header 'Cookie: login_token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWMyMTJhODgtOGFmYy00YjJjLWIwYWQtODY3MmQ2NTI3MzdlIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzQxMDAzMjgwIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTc0MTE3NjE1Miwib3JnX2lkIjoib3JnX1c4MkFMNTZ6VVE1dXFHcEEyYzFkIiwicHJvZmlsZV9pZCI6InByb19NcUlMcDAwdUFJeW5JZDdtUTNUTyIsInRlbmFudF9pZCI6InB1YmxpYyJ9.RoPyIG-JGrH6QmM6Gqd9gh03hOqy6MuC9Our9EHYGNk'
```
If Payout's route is hit, only Payout's connector will be shown and nothing else.
Payout :
```
curl --location 'http://localhost:8080/routing/payout/default/profile' \
--header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWMyMTJhODgtOGFmYy00YjJjLWIwYWQtODY3MmQ2NTI3MzdlIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzQxMDAzMjgwIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTc0MTE3NjE1Miwib3JnX2lkIjoib3JnX1c4MkFMNTZ6VVE1dXFHcEEyYzFkIiwicHJvZmlsZV9pZCI6InByb19NcUlMcDAwdUFJeW5JZDdtUTNUTyIsInRlbmFudF9pZCI6InB1YmxpYyJ9.RoPyIG-JGrH6QmM6Gqd9gh03hOqy6MuC9Our9EHYGNk' \
--header 'Cookie: login_token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWMyMTJhODgtOGFmYy00YjJjLWIwYWQtODY3MmQ2NTI3MzdlIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzQxMDAzMjgwIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTc0MTE3NjE1Miwib3JnX2lkIjoib3JnX1c4MkFMNTZ6VVE1dXFHcEEyYzFkIiwicHJvZmlsZV9pZCI6InByb19NcUlMcDAwdUFJeW5JZDdtUTNUTyIsInRlbmFudF9pZCI6InB1YmxpYyJ9.RoPyIG-JGrH6QmM6Gqd9gh03hOqy6MuC9Our9EHYGNk'
```
<img width="1333" alt="Screenshot 2025-03-04 at 1 02 15 PM" src="https://github.com/user-attachments/assets/a587b7c3-ee87-4caf-8b29-dcb281a1e6f4" />
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Tested after creating JWT locally and adding 1 payment and 1 payout connector.
Payment :
```
curl --location 'http://localhost:8080/routing/default/profile' \
--header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWMyMTJhODgtOGFmYy00YjJjLWIwYWQtODY3MmQ2NTI3MzdlIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzQxMDAzMjgwIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTc0MTE3NjE1Miwib3JnX2lkIjoib3JnX1c4MkFMNTZ6VVE1dXFHcEEyYzFkIiwicHJvZmlsZV9pZCI6InByb19NcUlMcDAwdUFJeW5JZDdtUTNUTyIsInRlbmFudF9pZCI6InB1YmxpYyJ9.RoPyIG-JGrH6QmM6Gqd9gh03hOqy6MuC9Our9EHYGNk' \
--header 'Cookie: login_token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWMyMTJhODgtOGFmYy00YjJjLWIwYWQtODY3MmQ2NTI3MzdlIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzQxMDAzMjgwIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTc0MTE3NjE1Miwib3JnX2lkIjoib3JnX1c4MkFMNTZ6VVE1dXFHcEEyYzFkIiwicHJvZmlsZV9pZCI6InByb19NcUlMcDAwdUFJeW5JZDdtUTNUTyIsInRlbmFudF9pZCI6InB1YmxpYyJ9.RoPyIG-JGrH6QmM6Gqd9gh03hOqy6MuC9Our9EHYGNk'
```
Payout :
```
curl --location 'http://localhost:8080/routing/payout/default/profile' \
--header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWMyMTJhODgtOGFmYy00YjJjLWIwYWQtODY3MmQ2NTI3MzdlIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzQxMDAzMjgwIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTc0MTE3NjE1Miwib3JnX2lkIjoib3JnX1c4MkFMNTZ6VVE1dXFHcEEyYzFkIiwicHJvZmlsZV9pZCI6InByb19NcUlMcDAwdUFJeW5JZDdtUTNUTyIsInRlbmFudF9pZCI6InB1YmxpYyJ9.RoPyIG-JGrH6QmM6Gqd9gh03hOqy6MuC9Our9EHYGNk' \
--header 'Cookie: login_token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWMyMTJhODgtOGFmYy00YjJjLWIwYWQtODY3MmQ2NTI3MzdlIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzQxMDAzMjgwIiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTc0MTE3NjE1Miwib3JnX2lkIjoib3JnX1c4MkFMNTZ6VVE1dXFHcEEyYzFkIiwicHJvZmlsZV9pZCI6InByb19NcUlMcDAwdUFJeW5JZDdtUTNUTyIsInRlbmFudF9pZCI6InB1YmxpYyJ9.RoPyIG-JGrH6QmM6Gqd9gh03hOqy6MuC9Our9EHYGNk'
```
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: refactor(core): Revert "filter default routing config response based on connector type"
- Merged: 2025-03-18T15:06:40Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
Reverts juspay/hyperswitch#7199
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
We are reverting the filtering of response for payment and payout processors.
So this works as follows:
If Payment's route is hit all the PaymentProcessors will be listed like PayoutConnectors etc.
###
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(core): Revert "filter default routing config response based on connector type" (#7556)
Files to modify:
**crates/router/src/core/routing.rs**
Modify existing code
|
{"issue_number": 7199, "pr_number": 7556, "commits_count": 1, "files_changed": 1, "response_length": 995, "file_count": 3, "needs_breakdown": false}
|
fix(router): populate card network in the network transaction id based MIT flow
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
In the PG agnostic MIT flow (card details with network transaction id) the card network is being passed a null in the response. As the card network fetched form the card info lookup is not being used.
Additionally this pr also contains the changes to include the `network_transaction_id_supported_connectors` in `production.toml`. And pass internet as the commerce_indicator for discover cards in cybersource.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
-> Create merchant account and merchant connector account
-> enable `is_connector_agnostic_mit_enabled` flag
```
curl --location 'http://localhost:8080/account/merchant_1732783890/business_profile/pro_lNl3x8up5RJTzGLgq0cC' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '{
"is_connector_agnostic_mit_enabled": true
}'
```
```
{
"merchant_id": "merchant_1732783890",
"profile_id": "pro_lNl3x8up5RJTzGLgq0cC",
"profile_name": "US_default",
"return_url": "https://google.com/success",
"enable_payment_response_hash": true,
"payment_response_hash_key": "EHpgSu6g2VWesxu9L3tPGXVI7XuL1lqZ4CAwjYH3PUHr6VTiO1gyVuPsLSQoCGCO",
"redirect_to_merchant_with_http_post": false,
"webhook_details": {
"webhook_version": "1.0.1",
"webhook_username": "ekart_retail",
"webhook_password": "password_ekart@123",
"webhook_url": null,
"payment_created_enabled": true,
"payment_succeeded_enabled": true,
"payment_failed_enabled": true
},
"metadata": null,
"routing_algorithm": null,
"intent_fulfillment_time": 900,
"frm_routing_algorithm": null,
"payout_routing_algorithm": null,
"applepay_verified_domains": null,
"session_expiry": 900,
"payment_link_config": null,
"authentication_connector_details": null,
"use_billing_as_payment_method_billing": true,
"extended_card_info_config": null,
"collect_shipping_details_from_wallet_connector": false,
"collect_billing_details_from_wallet_connector": false,
"always_collect_shipping_details_from_wallet_connector": false,
"always_collect_billing_details_from_wallet_connector": false,
"is_connector_agnostic_mit_enabled": true,
"payout_link_config": null,
"outgoing_webhook_custom_http_headers": null,
"tax_connector_id": null,
"is_tax_connector_enabled": false,
"is_network_tokenization_enabled": false,
"is_auto_retries_enabled": false,
"max_auto_retries_enabled": null
}
```
-> Create a payment with `"setup_future_usage": "off_session",`
```
{
"amount": 100,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"customer_id": "cu_{{$timestamp}}",
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Its my first payment request",
"authentication_type": "no_three_ds",
"return_url": "https://google.com",
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "name name",
"card_cvc": "737"
}
},
"setup_future_usage": "off_session",
"customer_acceptance": {
"acceptance_type": "offline",
"accepted_at": "1963-05-03T04:07:52.723Z",
"online": {
"ip_address": "in sit",
"user_agent": "amet irure esse"
}
},
"billing": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "PiX",
"last_name": "ss"
}
},
"shipping": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "John",
"last_name": "Doe"
},
"phone": {
"number": "8056594427",
"country_code": "+91"
}
},
"browser_info": {
"user_agent": "Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
"accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8",
"language": "nl-NL",
"color_depth": 24,
"screen_height": 723,
"screen_width": 1536,
"time_zone": 0,
"java_enabled": true,
"java_script_enabled": true,
"ip_address": "125.0.0.1"
},
"statement_descriptor_name": "joseph",
"statement_descriptor_suffix": "JS",
"metadata": {},
"order_details": [
{
"product_name": "Apple iphone 15",
"quantity": 1,
"amount": 0,
"account_name": "transaction_processing"
}
]
}
```
```
{
"payment_id": "pay_fnfBuSFwvwVMzmk0OZM3",
"merchant_id": "merchant_1732784068",
"status": "succeeded",
"amount": 100,
"net_amount": 100,
"shipping_cost": null,
"amount_capturable": 0,
"amount_received": 100,
"connector": "cybersource",
"client_secret": "pay_fnfBuSFwvwVMzmk0OZM3_secret_VoTLxuhAVA1mYPyTQyN4",
"created": "2024-11-28T08:55:25.492Z",
"currency": "USD",
"customer_id": "cu_1732784125",
"customer": {
"id": "cu_1732784125",
"name": "John Doe",
"email": "guest@example.com",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": "Its my first payment request",
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": "off_session",
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "card",
"payment_method_data": {
"card": {
"last4": "4242",
"card_type": "CREDIT",
"card_network": "Visa",
"card_issuer": "STRIPE PAYMENTS UK LIMITED",
"card_issuing_country": "UNITEDKINGDOM",
"card_isin": "424242",
"card_extended_bin": null,
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": null,
"payment_checks": {
"avs_response": {
"code": "Y",
"codeRaw": "Y"
},
"card_verification": null
},
"authentication_data": null
},
"billing": null
},
"payment_token": "token_hrw68v72wmWkd6uDjNCl",
"shipping": {
"address": {
"city": "San Fransico",
"country": "US",
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"zip": "94122",
"state": "California",
"first_name": "John",
"last_name": "Doe"
},
"phone": {
"number": "8056594427",
"country_code": "+91"
},
"email": null
},
"billing": {
"address": {
"city": "San Fransico",
"country": "US",
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"zip": "94122",
"state": "California",
"first_name": "PiX",
"last_name": "ss"
},
"phone": null,
"email": null
},
"order_details": [
{
"brand": null,
"amount": 0,
"category": null,
"quantity": 1,
"product_id": null,
"product_name": "Apple iphone 15",
"product_type": null,
"sub_category": null,
"product_img_link": null,
"product_tax_code": null,
"requires_shipping": null
}
],
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"return_url": "https://google.com/",
"authentication_type": "no_three_ds",
"statement_descriptor_name": "joseph",
"statement_descriptor_suffix": "JS",
"next_action": null,
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "credit",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "cu_1732784125",
"created_at": 1732784125,
"expires": 1732787725,
"secret": "epk_06284b9a905f4c3aa196b00ad8112174"
},
"manual_retry_allowed": false,
"connector_transaction_id": "7327841265636354504951",
"frm_message": null,
"metadata": {},
"connector_metadata": null,
"feature_metadata": null,
"reference_id": "pay_fnfBuSFwvwVMzmk0OZM3_1",
"payment_link": null,
"profile_id": "pro_ENrgK0m9AXuOtOMzxFju",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_N3lWoDG7yvB9rbvJFyrb",
"incremental_authorization_allowed": false,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2024-11-28T09:10:25.492Z",
"fingerprint": null,
"browser_info": {
"language": "nl-NL",
"time_zone": 0,
"ip_address": "125.0.0.1",
"user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
"color_depth": 24,
"java_enabled": true,
"screen_width": 1536,
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"screen_height": 723,
"java_script_enabled": true
},
"payment_method_id": "pm_qUyvJqDRB16ItLjiBATM",
"payment_method_status": "active",
"updated": "2024-11-28T08:55:27.234Z",
"charges": null,
"frm_metadata": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": "27F62F9C4E44ACD0E063AF598E0A7075"
}
```
-> Create a payment for the same customer
```
curl --location 'http://localhost:8080/payments' \
--header 'Accept: application/json' \
--header 'api-key: dev_JZ5SfN6HmdFyVadqiq6iO6cZD9JDnWNT0bVhEEbOFLbw9NXkYNNr3MaXXTpVjFEY' \
--header 'Content-Type: application/json' \
--data '{
"amount": 10000,
"currency": "USD",
"capture_method": "automatic",
"authentication_type": "three_ds",
"confirm": false,
"setup_future_usage": "off_session",
"customer_id": "cu_1732784125"
}'
```
```
{
"payment_id": "pay_Nxx6173Q7F2ES49eeMYr",
"merchant_id": "merchant_1732784068",
"status": "requires_payment_method",
"amount": 10000,
"net_amount": 10000,
"shipping_cost": null,
"amount_capturable": 0,
"amount_received": null,
"connector": null,
"client_secret": "pay_Nxx6173Q7F2ES49eeMYr_secret_2qPhrFGrz8F4ODupztNl",
"created": "2024-11-28T08:58:33.763Z",
"currency": "USD",
"customer_id": "cu_1732784125",
"customer": {
"id": "cu_1732784125",
"name": "John Doe",
"email": "guest@example.com",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": null,
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": "off_session",
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": null,
"payment_method_data": null,
"payment_token": null,
"shipping": null,
"billing": null,
"order_details": null,
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"return_url": null,
"authentication_type": "three_ds",
"statement_descriptor_name": null,
"statement_descriptor_suffix": null,
"next_action": null,
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": null,
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "cu_1732784125",
"created_at": 1732784313,
"expires": 1732787913,
"secret": "epk_9ed01dde281f46a0966f1c0d779f6099"
},
"manual_retry_allowed": null,
"connector_transaction_id": null,
"frm_message": null,
"metadata": null,
"connector_metadata": null,
"feature_metadata": null,
"reference_id": null,
"payment_link": null,
"profile_id": "pro_ENrgK0m9AXuOtOMzxFju",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": null,
"incremental_authorization_allowed": null,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2024-11-28T09:13:33.763Z",
"fingerprint": null,
"browser_info": null,
"payment_method_id": null,
"payment_method_status": null,
"updated": "2024-11-28T08:58:33.784Z",
"charges": null,
"frm_metadata": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null
}
```
-> List customer pml with the client_secret
```
curl --location 'http://localhost:8080/customers/payment_methods?client_secret=pay_Nxx6173Q7F2ES49eeMYr_secret_2qPhrFGrz8F4ODupztNl' \
--header 'Accept: application/json' \
--header 'api-key: pk_dev_2cbdf84777ed4b15827d8bc8e6b19622'
```
```
{
"customer_payment_methods": [
{
"payment_token": "token_GN84Zv1iv1sbEpE9Fupv",
"payment_method_id": "pm_qUyvJqDRB16ItLjiBATM",
"customer_id": "cu_1732784125",
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_issuer": "STRIPE PAYMENTS UK LIMITED",
"payment_method_issuer_code": null,
"recurring_enabled": true,
"installment_payment_enabled": false,
"payment_experience": [
"redirect_to_url"
],
"card": {
"scheme": "Visa",
"issuer_country": "UNITEDKINGDOM",
"last4_digits": "4242",
"expiry_month": "03",
"expiry_year": "2030",
"card_token": null,
"card_holder_name": "name name",
"card_fingerprint": null,
"nick_name": null,
"card_network": "Visa",
"card_isin": "424242",
"card_issuer": "STRIPE PAYMENTS UK LIMITED",
"card_type": "CREDIT",
"saved_to_locker": true
},
"metadata": null,
"created": "2024-11-28T08:55:27.197Z",
"bank": null,
"surcharge_details": null,
"requires_cvv": false,
"last_used_at": "2024-11-28T08:55:27.197Z",
"default_payment_method_set": true,
"billing": {
"address": {
"city": "San Fransico",
"country": "US",
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"zip": "94122",
"state": "California",
"first_name": "name",
"last_name": "name"
},
"phone": null,
"email": null
}
}
],
"is_guest_customer": false
}
```
-> Confirm the payment
```
curl --location 'http://localhost:8080/payments/pay_Nxx6173Q7F2ES49eeMYr/confirm' \
--header 'api-key: pk_dev_2cbdf84777ed4b15827d8bc8e6b19622' \
--header 'Content-Type: application/json' \
--data-raw '{
"payment_token": "token_GN84Zv1iv1sbEpE9Fupv",
"payment_method_type": "credit",
"payment_method": "card",
"client_secret": "pay_Nxx6173Q7F2ES49eeMYr_secret_2qPhrFGrz8F4ODupztNl",
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "One",
"last_name": "Two"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "guest@example.com"
}
}'
```
```
{
"payment_id": "pay_Nxx6173Q7F2ES49eeMYr",
"merchant_id": "merchant_1732784068",
"status": "succeeded",
"amount": 10000,
"net_amount": 10000,
"shipping_cost": null,
"amount_capturable": 0,
"amount_received": 10000,
"connector": "cybersource",
"client_secret": "pay_Nxx6173Q7F2ES49eeMYr_secret_2qPhrFGrz8F4ODupztNl",
"created": "2024-11-28T08:58:33.763Z",
"currency": "USD",
"customer_id": "cu_1732784125",
"customer": {
"id": "cu_1732784125",
"name": "John Doe",
"email": "guest@example.com",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": null,
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": "off_session",
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "card",
"payment_method_data": {
"card": {
"last4": "4242",
"card_type": "CREDIT",
"card_network": "Visa",
"card_issuer": "STRIPE PAYMENTS UK LIMITED",
"card_issuing_country": "UNITEDKINGDOM",
"card_isin": "424242",
"card_extended_bin": null,
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": null,
"payment_checks": null,
"authentication_data": null
},
"billing": null
},
"payment_token": "token_GN84Zv1iv1sbEpE9Fupv",
"shipping": null,
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "One",
"last_name": "Two"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "guest@example.com"
},
"order_details": null,
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"return_url": null,
"authentication_type": "three_ds",
"statement_descriptor_name": null,
"statement_descriptor_suffix": null,
"next_action": null,
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "credit",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": null,
"manual_retry_allowed": false,
"connector_transaction_id": "7327843962556379004951",
"frm_message": null,
"metadata": null,
"connector_metadata": null,
"feature_metadata": null,
"reference_id": "pay_Nxx6173Q7F2ES49eeMYr_1",
"payment_link": null,
"profile_id": "pro_ENrgK0m9AXuOtOMzxFju",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_N3lWoDG7yvB9rbvJFyrb",
"incremental_authorization_allowed": false,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2024-11-28T09:13:33.763Z",
"fingerprint": null,
"browser_info": {
"language": null,
"time_zone": null,
"ip_address": "::1",
"user_agent": null,
"color_depth": null,
"java_enabled": null,
"screen_width": null,
"accept_header": null,
"screen_height": null,
"java_script_enabled": null
},
"payment_method_id": "pm_qUyvJqDRB16ItLjiBATM",
"payment_method_status": "active",
"updated": "2024-11-28T08:59:56.654Z",
"charges": null,
"frm_metadata": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null
}
```
-> Create a cit with stripe and perform the recurring with cybersource
```
{
"amount": 100,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"customer_id": "cu_{{$timestamp}}",
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Its my first payment request",
"authentication_type": "no_three_ds",
"return_url": "https://google.com",
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "name name",
"card_cvc": "737"
}
},
"setup_future_usage": "off_session",
"customer_acceptance": {
"acceptance_type": "offline",
"accepted_at": "1963-05-03T04:07:52.723Z",
"online": {
"ip_address": "in sit",
"user_agent": "amet irure esse"
}
},
"billing": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "PiX",
"last_name": "ss"
}
},
"shipping": {
"address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "John",
"last_name": "Doe"
},
"phone": {
"number": "8056594427",
"country_code": "+91"
}
},
"browser_info": {
"user_agent": "Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
"accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8",
"language": "nl-NL",
"color_depth": 24,
"screen_height": 723,
"screen_width": 1536,
"time_zone": 0,
"java_enabled": true,
"java_script_enabled": true,
"ip_address": "125.0.0.1"
},
"statement_descriptor_name": "joseph",
"statement_descriptor_suffix": "JS",
"metadata": {},
"order_details": [
{
"product_name": "Apple iphone 15",
"quantity": 1,
"amount": 0,
"account_name": "transaction_processing"
}
]
}
```
```
{
"payment_id": "pay_mKYKX3ChuavzS7atiqrC",
"merchant_id": "merchant_1732786757",
"status": "succeeded",
"amount": 100,
"net_amount": 100,
"shipping_cost": null,
"amount_capturable": 0,
"amount_received": 100,
"connector": "stripe",
"client_secret": "pay_mKYKX3ChuavzS7atiqrC_secret_aI23DBV8qxTNg2WPESAt",
"created": "2024-11-28T09:41:01.957Z",
"currency": "USD",
"customer_id": "cu_1732786862",
"customer": {
"id": "cu_1732786862",
"name": "John Doe",
"email": "guest@example.com",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": "Its my first payment request",
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": "off_session",
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "card",
"payment_method_data": {
"card": {
"last4": "4242",
"card_type": "CREDIT",
"card_network": "Visa",
"card_issuer": "STRIPE PAYMENTS UK LIMITED",
"card_issuing_country": "UNITEDKINGDOM",
"card_isin": "424242",
"card_extended_bin": null,
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": null,
"payment_checks": {
"cvc_check": "pass",
"address_line1_check": "pass",
"address_postal_code_check": "pass"
},
"authentication_data": null
},
"billing": null
},
"payment_token": null,
"shipping": {
"address": {
"city": "San Fransico",
"country": "US",
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"zip": "94122",
"state": "California",
"first_name": "John",
"last_name": "Doe"
},
"phone": {
"number": "8056594427",
"country_code": "+91"
},
"email": null
},
"billing": {
"address": {
"city": "San Fransico",
"country": "US",
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"zip": "94122",
"state": "California",
"first_name": "PiX",
"last_name": "ss"
},
"phone": null,
"email": null
},
"order_details": [
{
"brand": null,
"amount": 0,
"category": null,
"quantity": 1,
"product_id": null,
"product_name": "Apple iphone 15",
"product_type": null,
"sub_category": null,
"product_img_link": null,
"product_tax_code": null,
"requires_shipping": null
}
],
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"return_url": "https://google.com/",
"authentication_type": "no_three_ds",
"statement_descriptor_name": "joseph",
"statement_descriptor_suffix": "JS",
"next_action": null,
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "credit",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "cu_1732786862",
"created_at": 1732786861,
"expires": 1732790461,
"secret": "epk_2ee23c3779a54e56b9c15816e56d47af"
},
"manual_retry_allowed": false,
"connector_transaction_id": "pi_3QQ4DaEOqOywnAIx00EgTOEA",
"frm_message": null,
"metadata": {},
"connector_metadata": null,
"feature_metadata": null,
"reference_id": "pi_3QQ4DaEOqOywnAIx00EgTOEA",
"payment_link": null,
"profile_id": "pro_LHl9xKTts4FUwsDgPIAA",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_PohIcY4T0yRYB4FRQpsG",
"incremental_authorization_allowed": null,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2024-11-28T09:56:01.957Z",
"fingerprint": null,
"browser_info": {
"language": "nl-NL",
"time_zone": 0,
"ip_address": "125.0.0.1",
"user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
"color_depth": 24,
"java_enabled": true,
"screen_width": 1536,
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"screen_height": 723,
"java_script_enabled": true
},
"payment_method_id": "pm_GuFw64hE9GdwBaAdu60R",
"payment_method_status": "active",
"updated": "2024-11-28T09:41:04.190Z",
"charges": null,
"frm_metadata": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": "pm_1QQ4DaEOqOywnAIxeM9Q73Pt"
}
```
-> Create payment for same customer
```
curl --location 'http://localhost:8080/payments' \
--header 'Accept: application/json' \
--header 'api-key: dev_vEvPY8nOxGDtjC1IfIgOVDVouV4bfDK1MPyTB2vqPCDjf3QTSaW4lP0UkjDORWi1' \
--header 'Content-Type: application/json' \
--data '{
"amount": 10000,
"currency": "USD",
"capture_method": "automatic",
"authentication_type": "three_ds",
"confirm": false,
"setup_future_usage": "off_session",
"customer_id": "cu_1732786862"
}'
```
```
{
"payment_id": "pay_PiKxSAcgYv1SCRuTgbNW",
"merchant_id": "merchant_1732786757",
"status": "requires_payment_method",
"amount": 10000,
"net_amount": 10000,
"shipping_cost": null,
"amount_capturable": 0,
"amount_received": null,
"connector": null,
"client_secret": "pay_PiKxSAcgYv1SCRuTgbNW_secret_6PMdd9eOqqYm0XyBvRCs",
"created": "2024-11-28T09:41:24.895Z",
"currency": "USD",
"customer_id": "cu_1732786862",
"customer": {
"id": "cu_1732786862",
"name": "John Doe",
"email": "guest@example.com",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": null,
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": "off_session",
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": null,
"payment_method_data": null,
"payment_token": null,
"shipping": null,
"billing": null,
"order_details": null,
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"return_url": null,
"authentication_type": "three_ds",
"statement_descriptor_name": null,
"statement_descriptor_suffix": null,
"next_action": null,
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": null,
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": {
"customer_id": "cu_1732786862",
"created_at": 1732786884,
"expires": 1732790484,
"secret": "epk_89b1364c0b6048d9aba374bfee2c68e6"
},
"manual_retry_allowed": null,
"connector_transaction_id": null,
"frm_message": null,
"metadata": null,
"connector_metadata": null,
"feature_metadata": null,
"reference_id": null,
"payment_link": null,
"profile_id": "pro_LHl9xKTts4FUwsDgPIAA",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": null,
"incremental_authorization_allowed": null,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2024-11-28T09:56:24.895Z",
"fingerprint": null,
"browser_info": null,
"payment_method_id": null,
"payment_method_status": null,
"updated": "2024-11-28T09:41:24.934Z",
"charges": null,
"frm_metadata": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null
}
```
-> Customer pml
```
curl --location 'http://localhost:8080/customers/payment_methods?client_secret=pay_PiKxSAcgYv1SCRuTgbNW_secret_6PMdd9eOqqYm0XyBvRCs' \
--header 'Accept: application/json' \
--header 'api-key: pk_dev_c7c7295d08b54d589459ec0e8de731aa'
```
```
{
"customer_payment_methods": [
{
"payment_token": "token_WTkWv5zRyilJVfcZFZB4",
"payment_method_id": "pm_GuFw64hE9GdwBaAdu60R",
"customer_id": "cu_1732786862",
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_issuer": "STRIPE PAYMENTS UK LIMITED",
"payment_method_issuer_code": null,
"recurring_enabled": true,
"installment_payment_enabled": false,
"payment_experience": [
"redirect_to_url"
],
"card": {
"scheme": "Visa",
"issuer_country": "UNITEDKINGDOM",
"last4_digits": "4242",
"expiry_month": "03",
"expiry_year": "2030",
"card_token": null,
"card_holder_name": "name name",
"card_fingerprint": null,
"nick_name": null,
"card_network": "Visa",
"card_isin": "424242",
"card_issuer": "STRIPE PAYMENTS UK LIMITED",
"card_type": "CREDIT",
"saved_to_locker": true
},
"metadata": null,
"created": "2024-11-28T09:41:04.160Z",
"bank": null,
"surcharge_details": null,
"requires_cvv": false,
"last_used_at": "2024-11-28T09:41:04.160Z",
"default_payment_method_set": true,
"billing": {
"address": {
"city": "San Fransico",
"country": "US",
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"zip": "94122",
"state": "California",
"first_name": "name",
"last_name": "name"
},
"phone": null,
"email": null
}
}
],
"is_guest_customer": false
}
```
-> Confirm with cybersource
```
curl --location 'http://localhost:8080/payments/pay_PiKxSAcgYv1SCRuTgbNW/confirm' \
--header 'api-key: pk_dev_c7c7295d08b54d589459ec0e8de731aa' \
--header 'Content-Type: application/json' \
--data-raw '{
"payment_token": "token_WTkWv5zRyilJVfcZFZB4",
"payment_method_type": "credit",
"payment_method": "card",
"client_secret": "pay_PiKxSAcgYv1SCRuTgbNW_secret_6PMdd9eOqqYm0XyBvRCs",
"routing": {
"type": "single",
"data": {
"connector": "cybersource",
"merchant_connector_id": "mca_XcYZAcIAg28iKuSfTVOm"
}
},
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "One",
"last_name": "Two"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "guest@example.com"
}
}'
```
```
{
"payment_id": "pay_PiKxSAcgYv1SCRuTgbNW",
"merchant_id": "merchant_1732786757",
"status": "succeeded",
"amount": 10000,
"net_amount": 10000,
"shipping_cost": null,
"amount_capturable": 0,
"amount_received": 10000,
"connector": "cybersource",
"client_secret": "pay_PiKxSAcgYv1SCRuTgbNW_secret_6PMdd9eOqqYm0XyBvRCs",
"created": "2024-11-28T09:41:24.895Z",
"currency": "USD",
"customer_id": "cu_1732786862",
"customer": {
"id": "cu_1732786862",
"name": "John Doe",
"email": "guest@example.com",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": null,
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": "off_session",
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "card",
"payment_method_data": {
"card": {
"last4": "4242",
"card_type": "CREDIT",
"card_network": "Visa",
"card_issuer": "STRIPE PAYMENTS UK LIMITED",
"card_issuing_country": "UNITEDKINGDOM",
"card_isin": "424242",
"card_extended_bin": null,
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": null,
"payment_checks": null,
"authentication_data": null
},
"billing": null
},
"payment_token": "token_WTkWv5zRyilJVfcZFZB4",
"shipping": null,
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "One",
"last_name": "Two"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "guest@example.com"
},
"order_details": null,
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"return_url": null,
"authentication_type": "three_ds",
"statement_descriptor_name": null,
"statement_descriptor_suffix": null,
"next_action": null,
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "credit",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": null,
"manual_retry_allowed": false,
"connector_transaction_id": "7327869509776879404951",
"frm_message": null,
"metadata": null,
"connector_metadata": null,
"feature_metadata": null,
"reference_id": "pay_PiKxSAcgYv1SCRuTgbNW_1",
"payment_link": null,
"profile_id": "pro_LHl9xKTts4FUwsDgPIAA",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_XcYZAcIAg28iKuSfTVOm",
"incremental_authorization_allowed": false,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2024-11-28T09:56:24.895Z",
"fingerprint": null,
"browser_info": {
"language": null,
"time_zone": null,
"ip_address": "::1",
"user_agent": null,
"color_depth": null,
"java_enabled": null,
"screen_width": null,
"accept_header": null,
"screen_height": null,
"java_script_enabled": null
},
"payment_method_id": "pm_GuFw64hE9GdwBaAdu60R",
"payment_method_status": "active",
"updated": "2024-11-28T09:42:31.429Z",
"charges": null,
"frm_metadata": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null
}
```
-> Psync
```
curl --location 'http://localhost:8080/payments/pay_PiKxSAcgYv1SCRuTgbNW?force_sync=true' \
--header 'Accept: application/json' \
--header 'api-key: dev_vEvPY8nOxGDtjC1IfIgOVDVouV4bfDK1MPyTB2vqPCDjf3QTSaW4lP0UkjDORWi1'
```
```
{
"payment_id": "pay_PiKxSAcgYv1SCRuTgbNW",
"merchant_id": "merchant_1732786757",
"status": "succeeded",
"amount": 10000,
"net_amount": 10000,
"shipping_cost": null,
"amount_capturable": 0,
"amount_received": 10000,
"connector": "cybersource",
"client_secret": "pay_PiKxSAcgYv1SCRuTgbNW_secret_6PMdd9eOqqYm0XyBvRCs",
"created": "2024-11-28T09:41:24.895Z",
"currency": "USD",
"customer_id": "cu_1732786862",
"customer": {
"id": "cu_1732786862",
"name": "John Doe",
"email": "guest@example.com",
"phone": "999999999",
"phone_country_code": "+65"
},
"description": null,
"refunds": null,
"disputes": null,
"mandate_id": null,
"mandate_data": null,
"setup_future_usage": "off_session",
"off_session": null,
"capture_on": null,
"capture_method": "automatic",
"payment_method": "card",
"payment_method_data": {
"card": {
"last4": "4242",
"card_type": "CREDIT",
"card_network": "Visa",
"card_issuer": "STRIPE PAYMENTS UK LIMITED",
"card_issuing_country": "UNITEDKINGDOM",
"card_isin": "424242",
"card_extended_bin": null,
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": null,
"payment_checks": null,
"authentication_data": null
},
"billing": null
},
"payment_token": "token_WTkWv5zRyilJVfcZFZB4",
"shipping": null,
"billing": {
"address": {
"city": "test",
"country": "US",
"line1": "here",
"line2": "there",
"line3": "anywhere",
"zip": "560095",
"state": "Washington",
"first_name": "One",
"last_name": "Two"
},
"phone": {
"number": "1234567890",
"country_code": "+1"
},
"email": "guest@example.com"
},
"order_details": null,
"email": "guest@example.com",
"name": "John Doe",
"phone": "999999999",
"return_url": null,
"authentication_type": "three_ds",
"statement_descriptor_name": null,
"statement_descriptor_suffix": null,
"next_action": null,
"cancellation_reason": null,
"error_code": null,
"error_message": null,
"unified_code": null,
"unified_message": null,
"payment_experience": null,
"payment_method_type": "credit",
"connector_label": null,
"business_country": null,
"business_label": "default",
"business_sub_label": null,
"allowed_payment_method_types": null,
"ephemeral_key": null,
"manual_retry_allowed": false,
"connector_transaction_id": "7327869509776879404951",
"frm_message": null,
"metadata": null,
"connector_metadata": null,
"feature_metadata": null,
"reference_id": "pay_PiKxSAcgYv1SCRuTgbNW_1",
"payment_link": null,
"profile_id": "pro_LHl9xKTts4FUwsDgPIAA",
"surcharge_details": null,
"attempt_count": 1,
"merchant_decision": null,
"merchant_connector_id": "mca_XcYZAcIAg28iKuSfTVOm",
"incremental_authorization_allowed": false,
"authorization_count": null,
"incremental_authorizations": null,
"external_authentication_details": null,
"external_3ds_authentication_attempted": false,
"expires_on": "2024-11-28T09:56:24.895Z",
"fingerprint": null,
"browser_info": {
"language": null,
"time_zone": null,
"ip_address": "::1",
"user_agent": null,
"color_depth": null,
"java_enabled": null,
"screen_width": null,
"accept_header": null,
"screen_height": null,
"java_script_enabled": null
},
"payment_method_id": "pm_GuFw64hE9GdwBaAdu60R",
"payment_method_status": "active",
"updated": "2024-11-28T09:42:31.429Z",
"charges": null,
"frm_metadata": null,
"merchant_order_reference_id": null,
"order_tax_amount": null,
"connector_mandate_id": null
}
```
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(connector): [Cybersource] change commerce indicator for discover cards in apple pay
- Merged: 2024-12-03T10:39:13Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
commerce indicator for discover card in applepay is changed since the payments are failing in production for cybersource
Note: This is hotifx against [#6690](https://github.com/juspay/hyperswitch/pull/6690)
### Additional Changes
- [
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [Cybersource] change commerce indicator for discover cards in apple pay (#6728)
Files to modify:
**crates/router/src/connector/cybersource/transformers.rs**
Modify existing code
|
{"issue_number": 6690, "pr_number": 6728, "commits_count": 1, "files_changed": 1, "response_length": 1017, "file_count": 3, "needs_breakdown": false}
|
feat(payments_v2): implement create and confirm intent flow
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR introduces a new endpoint that handles payments create intent v2 and confirm intent v2 steps. Note that the API contract is not finalized and is possibly subject to change.
Additionally, the endpoint can also call the setup intent flow, if the order amount is zero. This is done so as to allow the payment methods v2 endpoints to create multiple-use tokens for a specified customer's payment method.
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
This PR introduces a new endpoint for payments v2, that can handle create intent and confirm intent steps.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
The endpoint introduced in this PR would allow the creation of multiple-use tokens by the payments methods v2 endpoints.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
1. Using the v2 endpoints, create an organization, merchant account, profile, API key and merchant connector account.
2. Call the setup intent endpoint:
- Since the request body is a union of the payment create intent v2 and payment confirm intent v2 request bodies, the required fields for this endpoint are `amount_details`, `payment_method_data`, `payment_method_type` and `payment_method_subtype`.
The request and response are included below:
```shell
$ curl --location 'http://localhost:8080/v2/payments' \
--header 'x-profile-id: pro_9UhMqBMEOooRIvJFFdeW' \
--header 'Content-Type: application/json' \
--header 'api-key: <API key>' \
--data '{
"amount_details": {
"order_amount": 0,
"currency": "USD"
},
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "01",
"card_exp_year": "25",
"card_holder_name": "John Doe",
"card_cvc": "100"
}
},
"payment_method_type": "card",
"payment_method_subtype": "credit"
}'
{
"id": "12345_pay_0194aedd2b087ec1a960242f3ad8f2c1",
"status": "succeeded",
"amount": {
"order_amount": 0,
"currency": "USD",
"shipping_cost": null,
"order_tax_amount": null,
"external_tax_calculation": "skip",
"surcharge_calculation": "skip",
"surcharge_amount": null,
"tax_on_surcharge": null,
"net_amount": 0,
"amount_to_capture": null,
"amount_capturable": 0,
"amount_captured": 0
},
"customer_id": null,
"connector": "stripe",
"client_secret": "12345_pay_0194aedd2b087ec1a960242f3ad8f2c1_secret_0194aedd2b127f6190e5090a1527ad3e",
"created": "2025-01-28T21:41:57.650Z",
"payment_method_data": {
"billing": null
},
"payment_method_type": "card",
"payment_method_subtype": "credit",
"next_action": null,
"connector_transaction_id": "seti_1QmMXiD5R7gDAGffKPUlM0HT",
"connector_reference_id": null,
"connector_token_details": {
"token": "pm_1QmMXiD5R7gDAGffCf03AULQ"
},
"merchant_connector_id": "mca_oC8RE28uRRcVKDjgwfzG",
"browser_info": null,
"error": null
}
```
- Note that the `order_amount` is zero in the above request. Also, note that the `connector_token_details.token` field is populated in the response, and the `connector_transaction_id` being `seti_*` indicates that Stripe's setup intent flow was called.
- Additional fields may be passed in the request, such as `customer_id`, etc. which would be reflected in the response and database entries.
- Passing in a non-zero value for the `order_amount` causes it to follow the regular create intent + confirm intent flow:
```shell
$ curl --location 'http://localhost:8080/v2/payments' \
--header 'x-profile-id: pro_9UhMqBMEOooRIvJFFdeW' \
--header 'Content-Type: application/json' \
--header 'api-key: <API key>' \
--data '{
"amount_details": {
"order_amount": 6540,
"currency": "USD"
},
"payment_method_data": {
"card": {
"card_number": "4242424242424242",
"card_exp_month": "01",
"card_exp_year": "25",
"card_holder_name": "John Doe",
"card_cvc": "100"
}
},
"payment_method_type": "card",
"payment_method_subtype": "credit"
}'
{
"id": "12345_pay_0194aedff4c57e008edc28cbd3881dee",
"status": "succeeded",
"amount": {
"order_amount": 6540,
"currency": "USD",
"shipping_cost": null,
"order_tax_amount": null,
"external_tax_calculation": "skip",
"surcharge_calculation": "skip",
"surcharge_amount": null,
"tax_on_surcharge": null,
"net_amount": 6540,
"amount_to_capture": null,
"amount_capturable": 0,
"amount_captured": 6540
},
"customer_id": null,
"connector": "stripe",
"client_secret": "12345_pay_0194aedff4c57e008edc28cbd3881dee_secret_0194aedff4cc719381629d4aacf19adb",
"created": "2025-01-28T21:45:00.364Z",
"payment_method_data": {
"billing": null
},
"payment_method_type": "card",
"payment_method_subtype": "credit",
"next_action": null,
"connector_transaction_id": "pi_3QmMaeD5R7gDAGff0GRZPicn",
"connector_reference_id": null,
"connector_token_details": {
"token": "pm_1QmMaeD5R7gDAGffZenIs1fg"
},
"merchant_connector_id": "mca_oC8RE28uRRcVKDjgwfzG",
"browser_info": null,
"error": null
}
```
In this case, the `connector_transaction_id` is `pi_*`, indicating that Stripe's authorize flow was called.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: refactor(payments_v2): create customer at connector end and populate connector customer ID
- Merged: 2025-02-14T10:19:09Z
- Files changed: 11 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR updates the payments v2 flows to create a customer at connector's end, where applicable, and populate the connector's customer ID in `RouterData`, so that the connector integrations which need the connector customer ID can access the
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(payments_v2): create customer at connector end and populate connector customer ID (#7246)
Files to modify:
**crates/diesel_models/src/customers.rs**
Add:
- function: private::deref
- function: private::deref_mut
- struct: pub::ConnectorCustomerMap
- impl: impl std::ops::Deref for ConnectorCustomerMap
- impl: impl std::ops::DerefMut for ConnectorCustomerMap
**crates/hyperswitch_domain_models/src/business_profile.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/customer.rs**
Add:
- function: pub::get_connector_customer_id
- function: pub::get_connector_customer_id
- struct: pub::CustomerGeneralUpdate
**crates/router/src/core/customers.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/customers.rs**
Add:
- function: pub::update_connector_customer_in_customers
**crates/router/src/core/payments/operations/payment_confirm_intent.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/core/payouts.rs**
Add:
- function: pub::create_recipient
**crates/router/src/core/payouts/helpers.rs**
Modify existing code
**crates/router/src/types/storage/customers.rs**
Modify existing code
|
{"issue_number": 7106, "pr_number": 7246, "commits_count": 1, "files_changed": 11, "response_length": 2140, "file_count": 13, "needs_breakdown": false}
|
router: Get browser info from payment request
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
<!-- Describe your changes in detail -->
Add browser info to PaymentRequest to get it from merchants.
### Additional Changes
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
Added browser info field to payment request for getting it from merchants.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: feat(themes): Create APIs for managing themes
- Merged: 2024-12-04T11:06:34Z
- Files changed: 26 files
- Commits: 24 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR adds APIs to manage themes.
These are the following APIs
1. Create Theme
2. Delete Theme
3. Update Theme
4. Upload Asset
5. Find Theme by Theme ID
6. Find Theme by Lineage
### Additional Changes
- [x] This PR modifies the
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(themes): Create APIs for managing themes (#6658)
Co-authored-by: hyperswitch-bot[bot] <14852550
Files to modify:
**crates/api_models/src/events/user.rs**
Modify existing code
**crates/api_models/src/user.rs**
Add:
- mod: pub::theme
**crates/api_models/src/user/theme.rs**
Add:
- struct: pub::GetThemeResponse
- struct: pub::UploadFileAssetData
- struct: pub::UploadFileRequest
- struct: pub::CreateThemeRequest
- struct: pub::UpdateThemeRequest
- struct: pub::ThemeData
- struct: private::Settings
- struct: private::Colors
- struct: private::Typography
- struct: private::Buttons
- struct: private::PrimaryButton
- struct: private::SecondaryButton
- struct: private::Borders
- struct: private::Spacing
- struct: private::Urls
**crates/common_utils/src/types/theme.rs**
Add:
- function: pub::entity_type
- function: pub::tenant_id
- function: pub::org_id
- function: pub::merchant_id
- function: pub::profile_id
- impl: impl ThemeLineage
**crates/diesel_models/src/query/user/theme.rs**
Add:
- function: pub::find_by_theme_id
**crates/diesel_models/src/user/theme.rs**
Add:
- function: pub::new
- impl: impl ThemeNew
**crates/router/src/configs/secrets_transformers.rs**
Modify existing code
**crates/router/src/configs/settings.rs**
Modify existing code
**crates/router/src/core/errors/user.rs**
Modify existing code
**crates/router/src/core/user.rs**
Add:
- mod: pub::theme
**crates/router/src/core/user/theme.rs**
Add:
- function: pub::get_theme_using_lineage
- function: pub::get_theme_using_theme_id
- function: pub::upload_file_to_theme_storage
- function: pub::create_theme
- function: pub::update_theme
- function: pub::delete_theme
**crates/router/src/db/kafka_store.rs**
Add:
- function: private::find_theme_by_theme_id
**crates/router/src/db/user/theme.rs**
Add:
- function: private::find_theme_by_theme_id
- function: private::find_theme_by_theme_id
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/lock_utils.rs**
Modify existing code
**crates/router/src/routes/user.rs**
Add:
- mod: pub::theme
**crates/router/src/routes/user/theme.rs**
Add:
- function: pub::get_theme_using_lineage
- function: pub::get_theme_using_theme_id
- function: pub::upload_file_to_theme_storage
- function: pub::create_theme
- function: pub::update_theme
- function: pub::delete_theme
**crates/router/src/utils/user.rs**
Add:
- mod: pub::theme
**crates/router/src/utils/user/theme.rs**
Add:
- function: private::get_theme_dir_key
- function: pub::get_specific_file_key
- function: pub::get_theme_file_key
- function: private::path_buf_to_str
- function: pub::retrieve_file_from_theme_bucket
- function: pub::upload_file_to_theme_bucket
- function: pub::validate_lineage
- function: private::validate_tenant
- function: private::validate_org
- function: private::validate_merchant_and_get_key_store
- function: private::validate_merchant
- function: private::validate_profile
**crates/router_env/src/logger/types.rs**
Modify existing code
|
{"issue_number": 27, "pr_number": 6658, "commits_count": 1, "files_changed": 26, "response_length": 4028, "file_count": 22, "needs_breakdown": true}
|
fix(connector): [Cybersource] change commerce indicator for applepay
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Change the commerce indicator for cybersource applepay payment which was failing payment in production
Note: This pr is crucial for flowbird
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Tested through postman:
- Create an MCA for Cybersource:
- Create a Payment with Applepay:
```
{
"amount": 650,
"currency": "USD",
"confirm": true,
"amount_to_capture": 650,
"customer_id": "test_fb",
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"authentication_type": "three_ds",
"return_url": "https://google.com",
"email": "something@gmail.com",
"name": "Joseph Doe",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Its my first payment request",
"statement_descriptor_name": "Juspay",
"statement_descriptor_suffix": "Router",
"payment_method": "wallet",
"payment_method_type": "apple_pay",
"payment_method_data": {
"wallet": {
"apple_pay": {
"payment_data": "{{payment_data}}",
"payment_method": {
"display_name": "MasterCard 7599",
"network": "MasterCard",
"type": "credit"
},
"transaction_identifier": "{{transaction_identifier}}"
}
},
"billing": {
"address": {
"line1": "jhkdsa",
"zip": "10000",
"last_name": "chikke",
"city": "adf",
"country": "US",
"first_name": "srujan",
"state": "Alabama"
},
"email": "chikke.srujan@juspay.in"
}
}
}
```
- The payment should `succeed`
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(connector): [Cybersource] change commerce indicator for applepay
- Merged: 2024-11-27T11:30:18Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Change the commerce indicator for cybersource applepay payment which was failing payment in production
Hotfix correspond to PR - [#6634](https://github.com/juspay/hyperswitch/pull/6634)
Note: This pr is crucial for flowbird
### Additi
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [Cybersource] change commerce indicator for applepay (#6675)
Files to modify:
**crates/router/src/connector/cybersource/transformers.rs**
Modify existing code
|
{"issue_number": 6634, "pr_number": 6675, "commits_count": 1, "files_changed": 1, "response_length": 979, "file_count": 3, "needs_breakdown": false}
|
[chore]: use crates.io version of async-bb8-diesel crate
Currently we are using a [forked](https://github.com/jarnura/async-bb8-diesel) version of this dependency. We need to migrate to the crates.io version
|
<think>
PR Context:
- Title: chore: Move async-bb8-diesel crate to crates.io version
- Merged: 2025-05-15T12:05:55Z
- Files changed: 5 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [x] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Changed `async-bb8-diesel crate from custom [fork](https://github.com/jarnura/async-bb8-diesel) to crates.io [version](https://github.com/oxidecomputer/async-bb8-diesel)
### Additional Changes
- [ ] This PR modifies the API contract
- [
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 8026, "pr_number": 8028, "commits_count": 0, "files_changed": 5, "response_length": 785, "file_count": 0, "needs_breakdown": false}
|
feat(router): Add support for network token migration
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Add support for network token migration.
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
test migration api.
req -
```
curl --location 'http://localhost:8080/payment_methods/migrate' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: api-key' \
--data '{
"merchant_id": "merchant_id",
"card": {
"card_number": "card_number",
"card_exp_month": "12",
"card_exp_year": "21",
"card_holder_name": "joseph Doe"
},
"customer_id": "customer_id",
"network_transaction_id": "nt-transaction-id",
"payment_method": "card",
"network_token": {
"network_token_data": {
"network_token_number": "network_token_number",
"network_token_exp_month": "12",
"network_token_exp_year": "21"
},
"network_token_requestor_ref_id": "test-ref-id"
}
}'
```
expected response -
```
{
"payment_method_response": {
"merchant_id": "merchant_1731400520",
"customer_id": "cust-1731400905",
"payment_method_id": "pm_LSk7YuLskFS8aBdWNvzk",
"payment_method": "card",
"payment_method_type": null,
"card": {
"scheme": null,
"issuer_country": null,
"last4_digits": "0000",
"expiry_month": "12",
"expiry_year": "21",
"card_token": null,
"card_holder_name": "joseph Doe",
"card_fingerprint": null,
"nick_name": null,
"card_network": null,
"card_isin": "420000",
"card_issuer": null,
"card_type": null,
"saved_to_locker": true
},
"recurring_enabled": false,
"installment_payment_enabled": false,
"payment_experience": [
"redirect_to_url"
],
"metadata": null,
"created": "2024-11-12T09:00:50.948Z",
"last_used_at": "2024-11-12T09:00:50.949Z",
"client_secret": "pm_LSk7YuLskFS8aBdWNvzk_secret_6B5AfKanyCDhy5hjeUce"
},
"card_migrated": true,
"network_token_migrated": true,
"connector_mandate_details_migrated": null,
"network_transaction_id_migrated": true
}
```
<img width="1148" alt="Screenshot 2024-11-12 at 2 31 12 PM" src="https://github.com/user-attachments/assets/e3661f77-075e-4768-bac1-c2b23e0c12ce">
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(router): validate each field for migration request body
- Merged: 2024-12-06T11:44:36Z
- Files changed: 1 files
- Commits: 15 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
#6300 has inconsistent response due to no validations for each field in migration api request body.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies applic
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(router): validate each field for migration request body (#6525)
Co-authored-by: hyperswitch-bot[
Files to modify:
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
|
{"issue_number": 6300, "pr_number": 6525, "commits_count": 1, "files_changed": 1, "response_length": 987, "file_count": 3, "needs_breakdown": false}
|
[FEAT] Multiple credential support for a connector in Cypress
## Requirement
Execute cypress tests for a connector having **multiple credentials** which can be used for different scenarios (one api key for `cards`, another for `bank redirects` and etc.,).
## Implementation
### Introduce new format for `creds.json`
`creds.json` should include both the formats. if a connector requires us passing **multiple credentials**, then that connector api key object **should** include multiple `connector_account_details` object all named under a generic name `connector_<number>` where `number` is an `integer`.
Refer example given below for more clarity:
```json
// connector having multiple credentials
<connector_name_1>: {
"connector_1": {
"connector_account_details": {
"auth_type": "KeyType",
"api_key": "",
"api_secret": "",
"key1": "",
"key2": ""
},
"metadata": {}
},
"connector_2": {
"connector_account_details": {
"auth_type": "KeyType",
"api_key": "",
"api_secret": "",
"key1": "",
"key2": ""
},
"metadata": {}
},
},
// connector with a single credential
<connector_name_2>: {
"connector_account_details": {
"auth_type": "KeyType",
"api_key": "",
"api_secret": "",
"key1": "",
"key2": ""
}
}
```
### Introduce new `object` (`Configs`) for `connector.js`
Within `connector.js`, introduce new object called as `Configs` alongside to `Request` and `Response` where user can define `flags` to achieve granular control over what test is being run.
An example implementation given below for reference:
```js
getCustomExchange({
Configs: {
TRIGGER_SKIP: true, // skips redirection flow from running. takes in a boolean
DELAY: {
STATUS: true, // flag to turn delay feature on or off. takes in a boolean
TIMEOUT: 5000, // timeout in milliseconds
},
CONNECTOR_CREDENTIAL: connector_1 / connector_2 // flag to route tests to a specific profile
// etc.,
},
Requst: {},
Response: {}
}),
```
### Modify `getValueByKey` function in `Utils.js`
Validate if `connector_account_details` dot exist within `<connector>` object in creds.
If it does not, start a loop and see if `connector_account_details` exist within every object. If true, return the `connector_account_details` while setting an object as a Cypress environment flag (`MULTIPLE_CONNECTORS`) with status `true` and length. If any validation fails, directly return the object (`data[key]`).
An example implementation given below for reference:
```js
if (data && typeof data === "object" && key in data) {
// Connector object has multiple keys
if (typeof data[key].connector_account_details === "undefined") {
const keys = Object.keys(data[key]);
for (let i = 0; i < keys.length; i++) {
const currentItem = data[key][keys[i]];
if (currentItem.hasOwnProperty("connector_account_details")) {
Cypress.env("MULTIPLE_CONNECTORS", {
status: true,
count: keys.length,
});
return currentItem;
}
}
}
return data[key];
} else {
return null;
}
```
### Add a new test to MCA create call
If `MULTIPLE_CONNECTORS.status` is `TRUE`. Check `MULTIPLE_CONNECTORS.count` and create `profile` and `mca` beneath that `profile` based on the number of `count`.
An example of possible implementation given below for reference:
```js
if (Cypress.env("MULTIPLE_CONNECTORS")?.status) {
for (let i = 0; i < Cypress.env("MULTIPLE_CONNECTORS").count; i++) {
cy.createBusinessProfileTest(
createBusinessProfileBody,
globalState,
"profile" + i // new optional fields
);
cy.createConnectorCallTest(
"payment_processor",
createConnectorBody,
payment_methods_enabled,
globalState,
"profile" + i, // new optional fields
"merchantConnector" + i // new optional fields
);
}
}
```
Store these created `profile_id`s and `mca`s in `globalState` for future usage.
Pass `CONNECTOR_CREDENTIAL` value as `connector_1` or `connector_2` in `<connector>.js`
In `commands.js`, `execute` these configs before a `request` has been made.
`execute` here means to make these configs work.
Preferably, make this execution of configs a function and pass the values accordingly along with trace to find from where the function has been called.
## Limitations
- Cypress cannot call itself unless a wrapper around Cypress is written (`Rustpress`?)
- This stops us from running the entire test suite against every credentials
- One possible work around for this is to have multiple keys (`cybersource_1`, `cybersource_2`) but this will result in a lot of confusion
- Current implementation **requires** the user to mandatorily pass a `CONNECTOR_CREDENTIAL` config to pass a different `profileId`
- Hence, the tests will only run once but, specific tests like `incremental auth` will be forced to run against different credential
- `00025-IncrementalAuth.cy.js` can be stopped from execution based on `MULTIPLE_CONNECTORS` environment variable as it is set during run time and the file is read asynchronously when the execution starts (to address this, we will have to make a function call to see if it is set during run time and it is, then skip)
|
<think>
PR Context:
- Title: ci: update cypress creds
- Merged: 2024-12-03T17:19:14Z
- Files changed: 1 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
Updates creds. closes #6645
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to th
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6645, "pr_number": 6726, "commits_count": 0, "files_changed": 1, "response_length": 754, "file_count": 0, "needs_breakdown": false}
|
One click docker setup
A script is needed to ensure one click docker setup, to minimise issues faced by users.
> Run the whole setup with simple command
> Show output with localhost links for different setups
|
<think>
PR Context:
- Title: fix: script for one click docker setup
- Merged: 2025-04-13T21:08:39Z
- Files changed: 2 files
- Commits: 15 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [X] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Script for one click docker setup, to minimise issues faced by users.
>Run the whole setup with simple command
>Show output with localhost links for different setups
### Additional Changes
- [ ] This PR modifies the API contract
- [
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 7761, "pr_number": 7762, "commits_count": 0, "files_changed": 2, "response_length": 769, "file_count": 0, "needs_breakdown": false}
|
fix(connector): [CYBERSOURCE] fix CartesBancaires card_type for Cybersource
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [X] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Payment via CartesBancaires were failing via Cybersource, since the card_type passed was wrong. It was previously "006" ,but should be "036" - this PR introduces this fix.
source
https://developer.cybersource.com/library/documentation/dev_guides/Retail_SO_API/html/Topics/app_card_types.htm
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
### Enable CartesBancaires card_network for credit, debit pmt for Cybersource
### Request
**/payments curl via Cybersource**
`curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_5xoZZGCiGtFDREHNPd9l2i9CRJowAtZlrDRmuy0LTNBLBjtQlH661r0VTMNBXPgm' \
--data-raw '{
"amount": 700,
"currency": "EUR",
"confirm": true,
"payment_link": false,
"capture_on": "2029-09-10T10:11:12Z",
"amount_to_capture": 700,
"name": "John Doe",
"email": "dg@example.com",
"phone": "999999999",
"phone_country_code": "+1",
"description": "Its my first payment request",
"authentication_type": "no_three_ds",
"return_url": "https://google.com",
"payment_method_data": {
"card": {
"card_number": "4035 5014 2814 6300",
"card_exp_month": "03",
"card_exp_year": "2030",
"card_holder_name": "joseph Doe",
"card_cvc": "737",
"card_network": "CartesBancaires"
},
"billing": {
"address": {
"line1": "1467",
"line2": "CA",
"city": "Thise",
"state": "Alsace",
"zip": "94122",
"country": "FR",
"first_name": "Henry",
"last_name": "Henry"
}
}
},
"payment_method": "card",
"payment_method_type": "credit",
"browser_info": {
"color_depth": 24,
"java_enabled": true,
"java_script_enabled": true,
"language": "en-GB",
"screen_height": 720,
"screen_width": 1280,
"time_zone": -330,
"ip_address": "208.127.127.193",
"accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
"user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Edg/126.0.0.0"
},
"metadata": {
"disable_avs": true,
"udf1": "value1",
"new_customer": "true",
"login_date": "2019-09-10T10:11:12Z"
},
"order_details": [
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
},
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
},
{
"product_name": "Tea",
"quantity": 1,
"amount": 110,
"product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
}
]
}'`
**After PR changes**
<img width="1066" alt="Screenshot 2025-05-20 at 2 26 17 PM" src="https://github.com/user-attachments/assets/c0d7fbb6-cca7-479c-b0aa-3c1bccb55df8" />
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [X] I formatted the code `cargo +nightly fmt --all`
- [X] I addressed lints thrown by `cargo clippy`
- [X] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: fix(connector): [CYBERSOURCE] fix CartesBancaires card_type for Cybersource
- Merged: 2025-05-22T09:47:47Z
- Files changed: 6 files
- Commits: 1 commits
Implementation approach:
…source (#8031)
## Type of Change
<!-- Put an `x` in the boxes that apply -->
Hotfix for [8031](https://github.com/juspay/hyperswitch/pull/8031)
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Clippy screenshot
### Addi
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(connector): [CYBERSOURCE] fix CartesBancaires card_type for Cybersource (#8108)
Co-authored-by:
Files to modify:
**crates/hyperswitch_connectors/src/connectors/adyen/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/cybersource/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/multisafepay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payeezy/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/payone/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/utils.rs**
Modify existing code
|
{"issue_number": 8031, "pr_number": 8108, "commits_count": 1, "files_changed": 6, "response_length": 1488, "file_count": 8, "needs_breakdown": false}
|
ci(cypress): fix `archipel` cypress test cases
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
Enhancements for `archipel` Cypress Tests.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
`archipel` Cypress Tests were failing.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
<!-- img width="720" alt="image" src="https://github.com/user-attachments/assets/23559711-59e2-41d7-8fb4-1572e524fc49" /-->
<img width="726" height="962" alt="image" src="https://github.com/user-attachments/assets/ee72bc01-69a1-4afb-ac76-8c3edec1c124" />
_PS: There is an issue with Incremental Auth, not anything related to the configs, but the spec itself, addressing it in another PR because that would affect 1 other connector as well, and after it is fixed, it would affect 3 connectors in total._
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [ ] I formatted the code `cargo +nightly fmt --all`
- [ ] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: refactor(cypress): update skip logic and test flow for cypress incremental auth tests
- Merged: 2025-07-11T02:04:29Z
- Files changed: 4 files
- Commits: 11 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR introduces a set of improvements and refactors in the Cypress test suite specifically for **Incremental Authorization** test cases.
---
### ✅ Key Changes:
1. **Connector Inclusion List for Incremental Auth**
* Introduc
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 8189, "pr_number": 8594, "commits_count": 0, "files_changed": 4, "response_length": 816, "file_count": 2, "needs_breakdown": false}
|
feat(CI/CD):Implement Code Cov for CI checks
Tracked in #1587
Implement Code coverage for PR's via CI
Objectives
- run tests as part of CI
- generate codeCov for these tests & auto-publish the report as part of PR Comment...
- [Optionally] be able to specify that atleast x% of new code should be test-covered (the CI test fails if this is not met)
|
<think>
PR Context:
- Title: ci(workflows): Add code coverage reporting for v2
- Merged: 2025-01-24T07:21:44Z
- Files changed: 7 files
- Commits: 8 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
Added a CI pipeline that will run cypress tests and generate code coverage reports for v2
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application conf
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 1593, "pr_number": 6884, "commits_count": 0, "files_changed": 7, "response_length": 779, "file_count": 0, "needs_breakdown": false}
|
[REFACTOR] reduce duplicate code in config in cypress
- too much chaos and confusion
- boiler plate and duplicate code
- move memory cache test out of payments and make it a separate service
|
<think>
PR Context:
- Title: refactor(cypress): move memory cache tests out of payment for misc
- Merged: 2025-01-24T17:23:22Z
- Files changed: 30 files
- Commits: 21 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR aims at refactoring:
- `cypress-tests` folder structure to reduce confusion and chaos in within `e2e` directory
- previous:
```sh
.
└── cypress
├── e2e
│ ├── PaymentMethodListTest
│ ├── PaymentMet
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6993, "pr_number": 6992, "commits_count": 0, "files_changed": 30, "response_length": 798, "file_count": 0, "needs_breakdown": false}
|
docs(analytics): Instructions to set up `currency_conversion` (third party dependency API)
## Requirements
After the changes by [this](#6418) PR, we need to update the documentation for `analytics` crate setup process.
## Reason
Due to the third party dependency on `currency_conversion` crate, we need to ensure the proper setup of this service as well.
|
<think>
PR Context:
- Title: docs(analytics): add setup instructions for currency_conversion service
- Merged: 2024-11-13T09:54:17Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [x] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Now that `analytics` depends on `currency_conversion` crate after this [PR](#6418), we need to include instructions in `analytics` documentation to set up this service.
## Fixes #6513
### Additional Changes
- [ ] This PR modifies the API
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6513, "pr_number": 6516, "commits_count": 0, "files_changed": 1, "response_length": 801, "file_count": 0, "needs_breakdown": false}
|
[FEATURE] Add Payments - List endpoint for v2
### Feature Description
This feature adds support for retrieving a filtered list of payments via a GET /v2/payments/list endpoint where multiple values can be provided for a single filter key (e.g. connector, etc.).
### Possible Implementation
Add PaymentListFilterConstraints and payments_list_by_filter endpoint for v2
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(payments): add PaymentListFilterConstraints and payments_list_by_filter endpoint for v2
- Merged: 2025-08-21T14:04:23Z
- Files changed: 10 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
**Enhanced Payment Listing API with Multi-Value Filtering**
This feature adds support for retrieving a filtered list of payments via a `GET /v2/payments/list` endpoint where multiple values can be provided for a single filter key (e.g. `sta
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payments): add PaymentListFilterConstraints and payments_list_by_filter endpoint for v2 (#8794)
Files to modify:
**crates/api_models/src/payments.rs**
Add:
- function: private::parse_comma_separated
**crates/common_utils/src/id_type/merchant_connector_account.rs**
Add:
- function: private::from_str
- impl: impl FromStr for MerchantConnectorAccountId
**crates/diesel_models/src/query/payment_attempt.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments/payment_attempt.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payments/payment_intent.rs**
Modify existing code
**crates/router/src/db/kafka_store.rs**
Modify existing code
**crates/storage_impl/src/mock_db/payment_attempt.rs**
Modify existing code
**crates/storage_impl/src/payments/payment_attempt.rs**
Modify existing code
**crates/storage_impl/src/payments/payment_intent.rs**
Modify existing code
|
{"issue_number": 8792, "pr_number": 8794, "commits_count": 1, "files_changed": 10, "response_length": 1766, "file_count": 12, "needs_breakdown": false}
|
[FEATURE] [CONNECTOR] Nordea
Integrate a new connector Nordea.
Developer Docs: https://developer.nordeaopenbanking.com/documentation
Login Dashboard: https://developer.nordeaopenbanking.com/login
|
<think>
PR Context:
- Title: feat(connector): [nordea] template code
- Merged: 2025-05-21T07:49:27Z
- Files changed: 24 files
- Commits: 4 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Connector template code for new connector `Nordea`.
Developer Docs: https://developer.nordeaopenbanking.com/documentation
Login Dashboard: https://developer.nordeaopenbanking.com/login
### Additional Changes
- [x] This PR modifies
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [nordea] template code (#8056)
Co-authored-by: hyperswitch-bot[bot] <148525504+hype
Files to modify:
**crates/common_enums/src/connector_enums.rs**
Modify existing code
**crates/connector_configs/src/connector.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors.rs**
Add:
- mod: pub::nordea
**crates/hyperswitch_connectors/src/connectors/nordea.rs**
Add:
- function: pub::new
- function: private::build_headers
- function: private::id
- function: private::get_currency_unit
- function: private::common_get_content_type
- function: private::base_url
- function: private::get_auth_header
- function: private::build_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_webhook_object_reference_id
- function: private::get_webhook_event_type
- function: private::get_webhook_resource_object
- struct: pub::Nordea
- impl: impl Nordea
- impl: impl api::Payment for Nordea
- impl: impl api::PaymentSession for Nordea
- impl: impl api::ConnectorAccessToken for Nordea
- impl: impl api::MandateSetup for Nordea
- impl: impl api::PaymentAuthorize for Nordea
- impl: impl api::PaymentSync for Nordea
- impl: impl api::PaymentCapture for Nordea
- impl: impl api::PaymentVoid for Nordea
- impl: impl api::Refund for Nordea
- impl: impl api::RefundExecute for Nordea
- impl: impl api::RefundSync for Nordea
- impl: impl api::PaymentToken for Nordea
- impl: impl ConnectorIntegration<PaymentMethodToken, PaymentMethodTokenizationData, PaymentsResponseData> for Nordea
- impl: impl ConnectorCommonExt<Flow, Request, Response> for Nordea
- impl: impl ConnectorCommon for Nordea
- impl: impl ConnectorValidation for Nordea
- impl: impl ConnectorIntegration<Session, PaymentsSessionData, PaymentsResponseData> for Nordea
- impl: impl ConnectorIntegration<AccessTokenAuth, AccessTokenRequestData, AccessToken> for Nordea
- impl: impl ConnectorIntegration<SetupMandate, SetupMandateRequestData, PaymentsResponseData> for Nordea
- impl: impl ConnectorIntegration<Authorize, PaymentsAuthorizeData, PaymentsResponseData> for Nordea
- impl: impl ConnectorIntegration<PSync, PaymentsSyncData, PaymentsResponseData> for Nordea
- impl: impl ConnectorIntegration<Capture, PaymentsCaptureData, PaymentsResponseData> for Nordea
- impl: impl ConnectorIntegration<Void, PaymentsCancelData, PaymentsResponseData> for Nordea
- impl: impl ConnectorIntegration<Execute, RefundsData, RefundsResponseData> for Nordea
- impl: impl ConnectorIntegration<RSync, RefundsData, RefundsResponseData> for Nordea
- impl: impl webhooks::IncomingWebhook for Nordea
- impl: impl ConnectorSpecifications for Nordea
- mod: pub::transformers
**crates/hyperswitch_connectors/src/connectors/nordea/transformers.rs**
Add:
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- struct: pub::NordeaRouterData
- struct: pub::NordeaPaymentsRequest
- struct: pub::NordeaCard
- struct: pub::NordeaAuthType
- struct: pub::NordeaPaymentsResponse
- struct: pub::NordeaRefundRequest
- struct: pub::RefundResponse
- struct: pub::NordeaErrorResponse
- enum: pub::NordeaPaymentStatus
- enum: pub::RefundStatus
- impl: impl From<(StringMinorUnit, T)> for NordeaRouterData<T>
- impl: impl TryFrom<&NordeaRouterData<&PaymentsAuthorizeRouterData>> for NordeaPaymentsRequest
- impl: impl TryFrom<&ConnectorAuthType> for NordeaAuthType
- impl: impl From<NordeaPaymentStatus> for common_enums::AttemptStatus
- impl: impl TryFrom<ResponseRouterData<F, NordeaPaymentsResponse, T, PaymentsResponseData>> for RouterData<F, T, PaymentsResponseData>
- impl: impl TryFrom<&NordeaRouterData<&RefundsRouterData<F>>> for NordeaRefundRequest
- impl: impl From<RefundStatus> for enums::RefundStatus
- impl: impl TryFrom<RefundsResponseRouterData<Execute, RefundResponse>> for RefundsRouterData<Execute>
- impl: impl TryFrom<RefundsResponseRouterData<RSync, RefundResponse>> for RefundsRouterData<RSync>
**crates/hyperswitch_connectors/src/default_implementations.rs**
Modify existing code
**crates/hyperswitch_connectors/src/default_implementations_v2.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/configs.rs**
Modify existing code
**crates/router/src/connector.rs**
Modify existing code
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/types/api.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
**crates/router/tests/connectors/main.rs**
Add:
- mod: private::nordea
**crates/router/tests/connectors/nordea.rs**
Add:
- function: private::get_data
- function: private::get_auth_token
- function: private::get_name
- function: private::get_default_payment_info
- function: private::payment_method_details
- function: private::should_only_authorize_payment
- function: private::should_capture_authorized_payment
- function: private::should_partially_capture_authorized_payment
- function: private::should_sync_authorized_payment
- function: private::should_void_authorized_payment
- function: private::should_refund_manually_captured_payment
- function: private::should_partially_refund_manually_captured_payment
- function: private::should_sync_manually_captured_refund
- function: private::should_make_payment
- function: private::should_sync_auto_captured_payment
- function: private::should_refund_auto_captured_payment
- function: private::should_partially_refund_succeeded_payment
- function: private::should_refund_succeeded_payment_multiple_times
- function: private::should_sync_refund
- function: private::should_fail_payment_for_incorrect_cvc
- function: private::should_fail_payment_for_invalid_exp_month
- function: private::should_fail_payment_for_incorrect_expiry_year
- function: private::should_fail_void_payment_for_auto_capture
- function: private::should_fail_capture_for_invalid_payment
- function: private::should_fail_for_refund_amount_higher_than_payment_amount
- struct: private::NordeaTest
- impl: impl ConnectorActions for NordeaTest
- impl: impl utils::Connector for NordeaTest
**crates/test_utils/src/connector_auth.rs**
Modify existing code
|
{"issue_number": 8055, "pr_number": 8056, "commits_count": 1, "files_changed": 24, "response_length": 8717, "file_count": 17, "needs_breakdown": true}
|
[FEATURE] Add delete profile endpoint in v2
### Feature Description
Add delete profile endpoint in v2
### Possible Implementation
Add a new endpoint in routes for delete profile in v2
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(profile): add delete profile endpoint for v2
- Merged: None
- Files changed: 5 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Added profile - delete route in `app.rs`
- Updated openapi spec to include the newly added route
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies applic
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 8715, "pr_number": 8716, "commits_count": 0, "files_changed": 5, "response_length": 763, "file_count": 0, "needs_breakdown": false}
|
refactor(ci): Remove Adyen-specific deprecated PMTs Sofort test cases in Postman
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
**Postman Collection Update**: Removed the Sofort test cases from the Adyen connector in the Postman collection because these payment methods are deprecated by Adyen Connector.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
- The **Postman** test cases for Sofort are no longer valid for the Adyen connector, as Adyen has deprecated these PMTs.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
_**Before**_
<img width="1279" alt="image" src="https://github.com/user-attachments/assets/91073ae0-a62c-40d7-863b-ddda5e2620a8" />
_**After**_
<img width="1093" alt="image" src="https://github.com/user-attachments/assets/f45d07f3-47eb-4331-90d9-b7a2fedf4d2f" />
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [ ] I formatted the code `cargo +nightly fmt --all`
- [ ] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: chore(postman): postman tests fixes
- Merged: 2025-03-06T08:48:47Z
- Files changed: 30 files
- Commits: 13 commits
Implementation approach:
## Type of Change
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
## Motivation and Context
## How did you test it?
### Connector:`adyen_uk`
<img width="1270" alt="image" src="https://github.com/use
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 7099, "pr_number": 7159, "commits_count": 0, "files_changed": 30, "response_length": 767, "file_count": 0, "needs_breakdown": false}
|
Add checks around Cypress mandates payments
Just verifying the payment method status isn't enough. We also need to verify the existence of connector mandate id. this can be done by updating the `mitusingpmid` command.
|
<think>
PR Context:
- Title: ci(cypress): verify mandate id to be `null` if payment id not `succeeded`
- Merged: 2025-04-16T10:47:24Z
- Files changed: 2 files
- Commits: 8 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR adds a check to verify if the `payment_status` is not any of `succeeded`, `partially_captured` or `requires_capture` and if so, then the `connector_mandate_id` should be `null`.
### Additional Changes
- [ ] This PR modifies the
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 7748, "pr_number": 7749, "commits_count": 0, "files_changed": 2, "response_length": 803, "file_count": 0, "needs_breakdown": false}
|
[FIX]: Take merchant ID from headers in API Key Revoke (v2)
For `API Key - Revoke` in v2, the merchant ID is currently being passed in the path. We need to instead read the `X-Merchant-ID` header to get the merchant ID.
|
<think>
PR Context:
- Title: fix(router): Take merchant ID from headers in API Key - Revoke (v2)
- Merged: 2025-08-05T08:25:19Z
- Files changed: 2 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Removed merchant ID from path in `API Keys - Revoke`
- Changed auth to read merchant ID from headers
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies ap
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(router): Take merchant ID from headers in API Key - Revoke (v2) (#8808)
Files to modify:
**crates/router/src/core/api_keys.rs**
Modify existing code
**crates/router/src/routes/api_keys.rs**
Modify existing code
|
{"issue_number": 8807, "pr_number": 8808, "commits_count": 1, "files_changed": 2, "response_length": 1021, "file_count": 4, "needs_breakdown": false}
|
Add onboarding flow for VSAAS
- Support for endpoint to create a platform
- Create platform org and platform merchant account
- Support to create connected merchant account inside platform org
- Modify existing list responses for org and merchant, to distinguish platform from standard.
|
<think>
PR Context:
- Title: feat(vsaas): integrate onboarding flow for vertical saas
- Merged: 2025-05-12T15:02:09Z
- Files changed: 22 files
- Commits: 11 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
The PR supports onboarding for new VSAAS merchants.
- Creating Platform Org
- Creation of Platform, and connected merchant accounts
- Change List response of merchant and organization list.
### Additional Changes
- [ ] This PR modifies the API contract
- [x] This PR modifie
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(vsaas): integrate onboarding flow for vertical saas (#7884)
Files to modify:
**crates/api_models/src/events/user.rs**
Modify existing code
**crates/api_models/src/organization.rs**
Modify existing code
**crates/api_models/src/user.rs**
Add:
- struct: pub::PlatformAccountCreateRequest
- struct: pub::PlatformAccountCreateResponse
**crates/common_enums/src/enums.rs**
Modify existing code
**crates/common_enums/src/enums/accounts.rs**
Add:
- enum: pub::MerchantAccountType
- enum: pub::OrganizationType
**crates/diesel_models/src/merchant_account.rs**
Modify existing code
**crates/diesel_models/src/organization.rs**
Add:
- function: pub::get_organization_type
- function: pub::get_organization_type
**crates/diesel_models/src/schema.rs**
Modify existing code
**crates/diesel_models/src/schema_v2.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/merchant_account.rs**
Modify existing code
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/user.rs**
Add:
- function: pub::create_platform_account
**crates/router/src/db/organization.rs**
Modify existing code
**crates/router/src/routes/app.rs**
Modify existing code
**crates/router/src/routes/lock_utils.rs**
Modify existing code
**crates/router/src/routes/user.rs**
Add:
- function: pub::create_platform
**crates/router/src/types/domain/user.rs**
Add:
- function: private::from
- function: private::try_from
- impl: impl From<user_api::PlatformAccountCreateRequest> for NewUserOrganization
- impl: impl TryFrom<user_api::PlatformAccountCreateRequest> for NewUserMerchant
**crates/router/src/types/transformers.rs**
Modify existing code
**crates/router/src/utils/user.rs**
Add:
- function: pub::generate_env_specific_merchant_id
**crates/router_env/src/logger/types.rs**
Modify existing code
|
{"issue_number": 7889, "pr_number": 7884, "commits_count": 1, "files_changed": 22, "response_length": 2696, "file_count": 22, "needs_breakdown": true}
|
ci(hotfix-branch-creation): rename `hotfix-branch-creation` workflow to `create-hotfix-branch`
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
rename `hotfix-branch-creation` workflow to `create-hotfix-branch`
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [ ] I formatted the code `cargo +nightly fmt --all`
- [ ] I addressed lints thrown by `cargo clippy`
- [ ] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: feat(vsaas): modify api key auth to support vsaas cases
- Merged: 2025-04-16T10:50:02Z
- Files changed: 24 files
- Commits: 17 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Modified api key auth to support control over VSAAS operations.
The PR provides fine grained control over routes authentication
- allowing Platform to perform payments in V1 (MVP case)
- disallowing all the operations in v2
- disallowing all other operations other than payments, f
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(vsaas): modify api key auth to support vsaas cases (#7593)
Co-authored-by: hyperswitch-bot[bot]
Files to modify:
**crates/router/src/compatibility/stripe/customers.rs**
Modify existing code
**crates/router/src/compatibility/stripe/payment_intents.rs**
Modify existing code
**crates/router/src/compatibility/stripe/refunds.rs**
Modify existing code
**crates/router/src/compatibility/stripe/setup_intents.rs**
Modify existing code
**crates/router/src/routes/blocklist.rs**
Modify existing code
**crates/router/src/routes/cards_info.rs**
Modify existing code
**crates/router/src/routes/currency.rs**
Modify existing code
**crates/router/src/routes/customers.rs**
Modify existing code
**crates/router/src/routes/disputes.rs**
Modify existing code
**crates/router/src/routes/ephemeral_key.rs**
Modify existing code
**crates/router/src/routes/files.rs**
Modify existing code
**crates/router/src/routes/fraud_check.rs**
Modify existing code
**crates/router/src/routes/mandates.rs**
Modify existing code
**crates/router/src/routes/payment_link.rs**
Modify existing code
**crates/router/src/routes/payment_methods.rs**
Modify existing code
**crates/router/src/routes/payments.rs**
Modify existing code
**crates/router/src/routes/payouts.rs**
Modify existing code
**crates/router/src/routes/pm_auth.rs**
Modify existing code
**crates/router/src/routes/profiles.rs**
Modify existing code
**crates/router/src/routes/refunds.rs**
Modify existing code
**crates/router/src/routes/relay.rs**
Modify existing code
**crates/router/src/routes/routing.rs**
Modify existing code
**crates/router/src/routes/verification.rs**
Modify existing code
**crates/router/src/services/authentication.rs**
Remove:
- struct: pub::ApiKeyAuth
- struct: pub::V2ApiKeyAuth
Add:
- struct: pub::ApiKeyAuth
- struct: pub::V2ApiKeyAuth
|
{"issue_number": 2540, "pr_number": 7593, "commits_count": 1, "files_changed": 24, "response_length": 2679, "file_count": 26, "needs_breakdown": true}
|
chore(codeowners): add codeowners data for PR reviews
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
## Description
Adding a CODEOWNERS file for facilitating PR reviews for teams
### Additional Changes
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!-- Provide links to the files with corresponding changes -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless its an obvious bug or documentation fix
that will have little conversation).
-->
This leads to better ownership boundaries & increased efficiency for reviewers
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
Doesn't need to be tested
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a [CHANGELOG](/CHANGELOG.md) entry if applicable
|
<think>
PR Context:
- Title: feat(payments): [Payment links] Add config for changing button text for payment links
- Merged: 2024-12-19T13:28:25Z
- Files changed: 11 files
- Commits: 2 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [X] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Added config for changing text of confirm button for payment links
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the fil
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(payments): [Payment links] Add config for changing button text for payment links (#6860)
Co-aut
Files to modify:
**crates/api_models/src/admin.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/diesel_models/src/business_profile.rs**
Modify existing code
**crates/diesel_models/src/payment_intent.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/lib.rs**
Modify existing code
**crates/router/src/core/payment_link.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
|
{"issue_number": 1, "pr_number": 6860, "commits_count": 1, "files_changed": 11, "response_length": 1485, "file_count": 10, "needs_breakdown": false}
|
feat(roles): edge cases for multi-tenancy - I
Add tenant_id in custom roles
Add generic query to search across all tenants
Close https://github.com/juspay/hyperswitch-cloud/issues/7998
Close https://github.com/juspay/hyperswitch-cloud/issues/7998
Close https://github.com/juspay/hyperswitch-cloud/issues/8026
|
<think>
PR Context:
- Title: feat(users): handle edge features for users in tenancy
- Merged: 2025-01-08T09:34:23Z
- Files changed: 18 files
- Commits: 9 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR
- add tenant_id in roles table
- add support for genenric query to serach user across all tenancies
- Fixes custom roles creates by tenant_level user
- List view for tenant level user
- Fix bug to search across envs for tenant admin
### Additional Changes
- [ ] This
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(users): handle edge features for users in tenancy (#6990)
Files to modify:
**crates/diesel_models/src/query/role.rs**
Modify existing code
**crates/diesel_models/src/query/user_role.rs**
Add:
- function: pub::list_user_roles_by_user_id_across_tenants
**crates/diesel_models/src/role.rs**
Modify existing code
**crates/diesel_models/src/schema.rs**
Modify existing code
**crates/diesel_models/src/schema_v2.rs**
Modify existing code
**crates/router/src/analytics.rs**
Modify existing code
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/core/user_role.rs**
Modify existing code
**crates/router/src/core/user_role/role.rs**
Modify existing code
**crates/router/src/db/kafka_store.rs**
Add:
- function: private::list_user_roles_by_user_id_across_tenants
**crates/router/src/db/role.rs**
Modify existing code
**crates/router/src/db/user_role.rs**
Add:
- function: private::list_user_roles_by_user_id_across_tenants
- function: private::list_user_roles_by_user_id_across_tenants
**crates/router/src/services/authorization.rs**
Modify existing code
**crates/router/src/services/authorization/roles.rs**
Modify existing code
**crates/router/src/utils/user.rs**
Modify existing code
**crates/router/src/utils/user_role.rs**
Modify existing code
|
{"issue_number": 6999, "pr_number": 6990, "commits_count": 1, "files_changed": 18, "response_length": 2122, "file_count": 18, "needs_breakdown": true}
|
[REFACTOR] Worldpay payments integration
### Feature Description
WorldPay payments integration currently makes use of modular APIs which gives more control over the integration. This approach is not best compatible with HyperSwitch due to WP's 3DS flows - which requires sending PAN (card numbers) in multiple places. For `on_session` transactions, this would contribute to the added complexity since data is not stored in such transactions (or stored for ~15mins in redis cache).
Migrating to WP's standard payments API follows payment resource creation in an uniform way.
### Possible Implementation
Migrate from modular APIs [[ref](https://developer.worldpay.com/products/access/card-payments)] to standard payment APIs [[ref](https://developer.worldpay.com/products/access/payments/openapi)].
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(connector): [worldpay] add support for mandates
- Merged: 2024-11-08T13:37:39Z
- Files changed: 9 files
- Commits: 16 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #6316 point `#6`
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
F
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): [worldpay] add support for mandates (#6479)
Co-authored-by: hyperswitch-bot[bot] <1
Files to modify:
**crates/hyperswitch_connectors/src/connectors/worldpay.rs**
Add:
- function: private::validate_mandate_payment
- function: private::is_webhook_source_verification_mandatory
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
**crates/hyperswitch_connectors/src/connectors/worldpay/requests.rs**
Add:
- struct: pub::TokenCreation
- struct: pub::CustomerAgreement
- enum: pub::TokenCreationType
- enum: pub::CustomerAgreementType
- enum: pub::StoredCardUsageType
- enum: pub::ThreeDsPreference
**crates/hyperswitch_connectors/src/connectors/worldpay/response.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay/transformers.rs**
Add:
- function: private::try_from
- function: private::get_settlement_info
- function: private::get_return_url
- function: private::get_auth_type
- function: private::get_browser_info
- function: private::get_payment_method_data
- function: private::get_setup_future_usage
- function: private::get_off_session
- function: private::get_mandate_id
- function: private::get_currency
- function: private::get_optional_billing_address
- function: private::get_connector_meta_data
- function: private::get_payment_method
- function: private::get_payment_method_type
- function: private::get_connector_request_reference_id
- function: private::get_is_mandate_payment
- function: private::get_return_url
- function: private::get_auth_type
- function: private::get_browser_info
- function: private::get_payment_method_data
- function: private::get_setup_future_usage
- function: private::get_off_session
- function: private::get_mandate_id
- function: private::get_currency
- function: private::get_optional_billing_address
- function: private::get_connector_meta_data
- function: private::get_payment_method
- function: private::get_payment_method_type
- function: private::get_connector_request_reference_id
- function: private::get_is_mandate_payment
- function: private::get_settlement_info
- function: private::create_three_ds_request
- function: private::get_token_and_agreement
- impl: impl TryFrom<Option<&pii::SecretSerdeValue>> for WorldpayConnectorMetadataObject
- impl: impl WorldpayPaymentsRequestData for RouterData<SetupMandate, SetupMandateRequestData, PaymentsResponseData>
- impl: impl WorldpayPaymentsRequestData for RouterData<Authorize, PaymentsAuthorizeData, PaymentsResponseData>
**crates/hyperswitch_connectors/src/utils.rs**
Add:
- function: private::get_router_return_url
**crates/hyperswitch_domain_models/src/errors/api_error_response.rs**
Modify existing code
**crates/router/src/consts.rs**
Modify existing code
**crates/router/src/core/payments/operations/payment_response.rs**
Modify existing code
**crates/router/src/lib.rs**
Modify existing code
|
{"issue_number": 6316, "pr_number": 6479, "commits_count": 1, "files_changed": 9, "response_length": 3943, "file_count": 11, "needs_breakdown": false}
|
chore: address Rust 1.83.0 clippy lints
### Description
Address the clippy lints stabilized / enabled in Rust version 1.83.0.
See #3391 for more information.
|
<think>
PR Context:
- Title: chore: address Rust 1.83.0 clippy lints and enable more clippy lints
- Merged: 2024-12-02T14:57:14Z
- Files changed: 30 files
- Commits: 5 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR addresses clippy lints stabilized / enabled in Rust 1.83.0. The major warnings being thrown due to the version bump were [`empty_line_after_doc_comments`](https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** chore: address Rust 1.83.0 clippy lints and enable more clippy lints (#6705)
Files to modify:
**crates/api_models/src/admin.rs**
Modify existing code
**crates/api_models/src/analytics.rs**
Modify existing code
**crates/api_models/src/api_keys.rs**
Remove:
- impl: impl serde::de::Visitor<'de> for NeverVisitor
Add:
- impl: impl serde::de::Visitor<'_> for NeverVisitor
**crates/api_models/src/conditional_configs.rs**
Modify existing code
**crates/api_models/src/enums.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/api_models/src/pm_auth.rs**
Modify existing code
**crates/api_models/src/routing.rs**
Modify existing code
**crates/api_models/src/user/sample_data.rs**
Modify existing code
**crates/cards/src/validate.rs**
Modify existing code
**crates/common_enums/src/transformers.rs**
Modify existing code
**crates/common_utils/src/crypto.rs**
Modify existing code
**crates/common_utils/src/custom_serde.rs**
Modify existing code
**crates/common_utils/src/errors.rs**
Modify existing code
**crates/common_utils/src/ext_traits.rs**
Modify existing code
**crates/common_utils/src/pii.rs**
Modify existing code
**crates/common_utils/src/signals.rs**
Modify existing code
**crates/common_utils/src/types.rs**
Remove:
- impl: impl Visitor<'de> for ClientSecretVisitor
Add:
- impl: impl Visitor<'_> for ClientSecretVisitor
**crates/common_utils/src/types/keymanager.rs**
Modify existing code
**crates/connector_configs/src/common_config.rs**
Modify existing code
**crates/connector_configs/src/connector.rs**
Modify existing code
**crates/diesel_models/src/configs.rs**
Modify existing code
**crates/diesel_models/src/lib.rs**
Modify existing code
**crates/diesel_models/src/organization.rs**
Modify existing code
**crates/diesel_models/src/payment_attempt.rs**
Modify existing code
**crates/diesel_models/src/reverse_lookup.rs**
Modify existing code
**crates/diesel_models/src/services/logger.rs**
Modify existing code
**crates/drainer/src/services.rs**
Modify existing code
**crates/euclid/src/dssa/analyzer.rs**
Modify existing code
**crates/euclid/src/dssa/graph.rs**
Modify existing code
**crates/euclid/src/dssa/types.rs**
Remove:
- impl: impl CtxValueKind<'a>
Add:
- impl: impl CtxValueKind<'_>
**crates/euclid/src/frontend/ast.rs**
Modify existing code
**crates/euclid/src/frontend/ast/lowering.rs**
Modify existing code
**crates/euclid/src/frontend/ast/parser.rs**
Modify existing code
**crates/events/src/lib.rs**
Modify existing code
**crates/external_services/src/file_storage.rs**
Modify existing code
**crates/external_services/src/file_storage/file_system.rs**
Modify existing code
**crates/external_services/src/hashicorp_vault/core.rs**
Modify existing code
**crates/external_services/src/managers/encryption_management.rs**
Modify existing code
**crates/external_services/src/managers/secrets_management.rs**
Modify existing code
**crates/external_services/src/no_encryption.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/multisafepay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/nexinets/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/razorpay/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/tsys/transformers.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors/worldpay.rs**
Modify existing code
**crates/hyperswitch_connectors/src/utils.rs**
Modify existing code
**crates/hyperswitch_constraint_graph/src/graph.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/merchant_account.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/payment_method_data.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/secrets_interface.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/secrets_interface/secret_state.rs**
Modify existing code
**crates/kgraph_utils/src/types.rs**
Modify existing code
**crates/masking/src/abs.rs**
Modify existing code
**crates/masking/src/boxed.rs**
Modify existing code
**crates/masking/src/diesel.rs**
Remove:
- impl: impl AsExpression<T> for &'expr Secret<S, I>
Add:
- impl: impl AsExpression<T> for &Secret<S, I>
**crates/masking/src/lib.rs**
Modify existing code
**crates/masking/src/maskable.rs**
Modify existing code
**crates/masking/src/secret.rs**
Modify existing code
**crates/masking/src/serde.rs**
Modify existing code
**crates/masking/src/string.rs**
Modify existing code
**crates/masking/src/strong_secret.rs**
Modify existing code
**crates/masking/src/vec.rs**
Modify existing code
**crates/openapi/src/routes/payments.rs**
Modify existing code
**crates/openapi/src/routes/routing.rs**
Modify existing code
**crates/pm_auth/src/connector/plaid/transformers.rs**
Modify existing code
**crates/redis_interface/src/commands.rs**
Modify existing code
**crates/redis_interface/src/errors.rs**
Modify existing code
**crates/redis_interface/src/types.rs**
Modify existing code
**crates/router/src/connector/adyen/transformers.rs**
Remove:
- impl: impl TryFrom<(&domain::BankDebitData, &types::PaymentsAuthorizeRouterData)> for AdyenPaymentMethod<'a>
- impl: impl TryFrom<(&domain::VoucherData, &types::PaymentsAuthorizeRouterData)> for AdyenPaymentMethod<'a>
- impl: impl TryFrom<(&domain::WalletData, &types::PaymentsAuthorizeRouterData)> for AdyenPaymentMethod<'a>
Add:
- impl: impl TryFrom<(&domain::BankDebitData, &types::PaymentsAuthorizeRouterData)> for AdyenPaymentMethod<'_>
- impl: impl TryFrom<(&domain::VoucherData, &types::PaymentsAuthorizeRouterData)> for AdyenPaymentMethod<'_>
**crates/router/src/connector/braintree/transformers.rs**
Modify existing code
**crates/router/src/connector/datatrans.rs**
Modify existing code
**crates/router/src/connector/globalpay/requests.rs**
Modify existing code
**crates/router/src/connector/paypal/transformers.rs**
Modify existing code
**crates/router/src/connector/riskified/transformers/api.rs**
Modify existing code
**crates/router/src/connector/signifyd/transformers/api.rs**
Modify existing code
**crates/router/src/connector/utils.rs**
Modify existing code
**crates/router/src/connector/wellsfargopayout.rs**
Modify existing code
**crates/router/src/core/admin.rs**
Modify existing code
**crates/router/src/core/payment_methods/cards.rs**
Modify existing code
**crates/router/src/core/payment_methods/utils.rs**
Modify existing code
**crates/router/src/core/payments.rs**
Modify existing code
**crates/router/src/core/payments/helpers.rs**
Modify existing code
**crates/router/src/core/pm_auth/transformers.rs**
Modify existing code
**crates/router/src/core/refunds.rs**
Modify existing code
**crates/router/src/core/routing/helpers.rs**
Remove:
- impl: impl RoutingAlgorithmHelpers<'h>
Add:
- impl: impl RoutingAlgorithmHelpers<'_>
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/core/user_role/role.rs**
Modify existing code
**crates/router/src/db/user_authentication_method.rs**
Modify existing code
**crates/router/src/routes/payment_link.rs**
Modify existing code
**crates/router/src/routes/payments.rs**
Modify existing code
**crates/router/src/services/api/client.rs**
Modify existing code
**crates/router/src/services/authentication/decision.rs**
Modify existing code
**crates/router/src/services/kafka.rs**
Modify existing code
**crates/router/src/services/kafka/authentication.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaAuthentication<'a>
Add:
- impl: impl super::KafkaMessage for KafkaAuthentication<'_>
**crates/router/src/services/kafka/authentication_event.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaAuthenticationEvent<'a>
Add:
- impl: impl super::KafkaMessage for KafkaAuthenticationEvent<'_>
**crates/router/src/services/kafka/dispute.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaDispute<'a>
Add:
- impl: impl super::KafkaMessage for KafkaDispute<'_>
**crates/router/src/services/kafka/dispute_event.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaDisputeEvent<'a>
Add:
- impl: impl super::KafkaMessage for KafkaDisputeEvent<'_>
**crates/router/src/services/kafka/fraud_check.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaFraudCheck<'a>
Add:
- impl: impl super::KafkaMessage for KafkaFraudCheck<'_>
**crates/router/src/services/kafka/fraud_check_event.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaFraudCheckEvent<'a>
Add:
- impl: impl super::KafkaMessage for KafkaFraudCheckEvent<'_>
**crates/router/src/services/kafka/payment_attempt.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaPaymentAttempt<'a>
Add:
- impl: impl super::KafkaMessage for KafkaPaymentAttempt<'_>
**crates/router/src/services/kafka/payment_attempt_event.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaPaymentAttemptEvent<'a>
Add:
- impl: impl super::KafkaMessage for KafkaPaymentAttemptEvent<'_>
**crates/router/src/services/kafka/payment_intent.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaPaymentIntent<'a>
Add:
- impl: impl super::KafkaMessage for KafkaPaymentIntent<'_>
**crates/router/src/services/kafka/payment_intent_event.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaPaymentIntentEvent<'a>
Add:
- impl: impl super::KafkaMessage for KafkaPaymentIntentEvent<'_>
**crates/router/src/services/kafka/payout.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaPayout<'a>
Add:
- impl: impl super::KafkaMessage for KafkaPayout<'_>
**crates/router/src/services/kafka/refund.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaRefund<'a>
Add:
- impl: impl super::KafkaMessage for KafkaRefund<'_>
**crates/router/src/services/kafka/refund_event.rs**
Remove:
- impl: impl super::KafkaMessage for KafkaRefundEvent<'a>
Add:
- impl: impl super::KafkaMessage for KafkaRefundEvent<'_>
**crates/router/src/services/logger.rs**
Modify existing code
**crates/router/src/types/storage/payment_link.rs**
Modify existing code
**crates/router/src/types/transformers.rs**
Modify existing code
**crates/router/src/utils/user_role.rs**
Modify existing code
**crates/router/src/workflows/payment_sync.rs**
Modify existing code
**crates/router/tests/connectors/aci.rs**
Modify existing code
**crates/router_derive/src/lib.rs**
Modify existing code
**crates/router_derive/src/macros/operation.rs**
Modify existing code
**crates/router_env/src/lib.rs**
Modify existing code
**crates/router_env/src/logger/config.rs**
Modify existing code
**crates/router_env/src/logger/formatter.rs**
Modify existing code
**crates/router_env/src/logger/setup.rs**
Modify existing code
**crates/router_env/src/logger/storage.rs**
Modify existing code
**crates/router_env/src/logger/types.rs**
Modify existing code
**crates/router_env/tests/logger.rs**
Modify existing code
**crates/router_env/tests/test_module/mod.rs**
Remove:
- mod: pub::some_module
**crates/storage_impl/src/mock_db.rs**
Modify existing code
**crates/storage_impl/src/redis/cache.rs**
Remove:
- impl: impl TryFrom<RedisValue> for CacheRedact<'a>
Add:
- impl: impl TryFrom<RedisValue> for CacheRedact<'_>
**crates/storage_impl/src/redis/kv_store.rs**
Modify existing code
|
{"issue_number": 6704, "pr_number": 6705, "commits_count": 1, "files_changed": 30, "response_length": 12574, "file_count": 129, "needs_breakdown": true}
|
Get Plans
**Request to Subscription Povider to get plans**
/api/v2/items?limit=5&type[is]=plan&item_family_id[is]=cbdemo_omnisupport-solutions'
**Response from Subscription Provider**
```
{
"list": [
{
"item": {
"id": "cbdemo_enterprise-suite",
"name": "Enterprise Suite",
"external_name": "Enterprise Suite",
"description": "High-end customer support suite with enterprise-grade solutions.",
"status": "active",
"resource_version": 1754897340100,
"updated_at": 1754897340,
"item_family_id": "cbdemo_omnisupport-solutions",
"type": "plan",
"is_shippable": false,
"is_giftable": false,
"enabled_for_checkout": true,
"enabled_in_portal": true,
"item_applicability": "all",
"metered": false,
"channel": "web",
"bundle_items": [],
"deleted": false,
"object": "item"
}
},
{
"item": {
"id": "cbdemo_business-suite",
"name": "Business Suite",
"external_name": "Business Suite",
"description": "Advanced customer support plan with premium features.",
"status": "active",
"resource_version": 1754897339947,
"updated_at": 1754897339,
"item_family_id": "cbdemo_omnisupport-solutions",
"type": "plan",
"is_shippable": false,
"is_giftable": false,
"enabled_for_checkout": true,
"enabled_in_portal": true,
"item_applicability": "all",
"metered": false,
"channel": "web",
"bundle_items": [],
"deleted": false,
"object": "item"
}
},
{
"item": {
"id": "cbdemo_professional-suite",
"name": "Professional Suite",
"external_name": "Professional Suite",
"description": "Comprehensive customer support plan with extended capabilities.",
"status": "active",
"resource_version": 1754897339843,
"updated_at": 1754897339,
"item_family_id": "cbdemo_omnisupport-solutions",
"type": "plan",
"is_shippable": false,
"is_giftable": false,
"enabled_for_checkout": true,
"enabled_in_portal": true,
"item_applicability": "all",
"metered": false,
"channel": "web",
"bundle_items": [],
"deleted": false,
"object": "item"
}
},
{
"item": {
"id": "cbdemo_essential-support",
"name": "Essential Support",
"external_name": "Essential Support",
"description": "Basic customer support plan with core features.",
"status": "active",
"resource_version": 1754897339723,
"updated_at": 1754897339,
"item_family_id": "cbdemo_omnisupport-solutions",
"type": "plan",
"is_shippable": false,
"is_giftable": false,
"enabled_for_checkout": true,
"enabled_in_portal": true,
"item_applicability": "all",
"metered": false,
"channel": "web",
"bundle_items": [],
"deleted": false,
"object": "item"
}
}
]
}
```
|
<think>
PR Context:
- Title: feat(connector): Add support for get plans for Chargebee
- Merged: 2025-09-16T12:57:45Z
- Files changed: 21 files
- Commits: 27 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR adds support for the get plans endpoint for Chargebee
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variab
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(connector): Add support for get plans for Chargebee (#9281)
Co-authored-by: hyperswitch-bot[bot
Files to modify:
**crates/hyperswitch_connectors/src/connectors/chargebee.rs**
Add:
- function: private::get_chargebee_plans_query_params
- function: private::get_headers
- function: private::get_url
- function: private::get_content_type
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- impl: impl api::subscriptions::Subscriptions for Chargebee
- impl: impl api::subscriptions::GetSubscriptionPlansFlow for Chargebee
- impl: impl ConnectorIntegration<
GetSubscriptionPlans,
GetSubscriptionPlansRequest,
GetSubscriptionPlansResponse,
> for Chargebee
- impl: impl GetSubscriptionPlansV2 for Chargebee
- impl: impl ConnectorIntegrationV2<
GetSubscriptionPlans,
hyperswitch_domain_models::router_data_v2::flow_common_types::GetSubscriptionPlansData,
GetSubscriptionPlansRequest,
GetSubscriptionPlansResponse,
> for Chargebee
**crates/hyperswitch_connectors/src/connectors/chargebee/transformers.rs**
Add:
- function: private::try_from
- struct: pub::ChargebeeListPlansResponse
- struct: pub::ChargebeeItemList
- struct: pub::ChargebeeItem
- impl: impl TryFrom<ResponseRouterData<F, ChargebeeListPlansResponse, T, GetSubscriptionPlansResponse>> for RouterData<F, T, GetSubscriptionPlansResponse>
**crates/hyperswitch_connectors/src/connectors/recurly.rs**
Add:
- impl: impl api::subscriptions_v2::SubscriptionsV2 for Recurly
- impl: impl api::subscriptions_v2::GetSubscriptionPlansV2 for Recurly
- impl: impl ConnectorIntegrationV2<
GetSubscriptionPlans,
GetSubscriptionPlansData,
GetSubscriptionPlansRequest,
GetSubscriptionPlansResponse,
> for Recurly
**crates/hyperswitch_connectors/src/constants.rs**
Modify existing code
**crates/hyperswitch_connectors/src/default_implementations.rs**
Add:
- impl: impl GetSubscriptionPlansFlow for connectors::DummyConnector<T>
- impl: impl ConnectorIntegration<
GetSubscriptionPlans,
GetSubscriptionPlansRequest,
GetSubscriptionPlansResponse,
> for connectors::DummyConnector<T>
- impl: impl Subscriptions for connectors::DummyConnector<T>
**crates/hyperswitch_domain_models/src/router_data_v2/flow_common_types.rs**
Add:
- struct: pub::GetSubscriptionPlansData
**crates/hyperswitch_domain_models/src/router_flow_types.rs**
Add:
- mod: pub::subscriptions
**crates/hyperswitch_domain_models/src/router_flow_types/subscriptions.rs**
Add:
- struct: pub::GetSubscriptionPlans
**crates/hyperswitch_domain_models/src/router_request_types.rs**
Add:
- mod: pub::subscriptions
**crates/hyperswitch_domain_models/src/router_request_types/subscriptions.rs**
Add:
- struct: pub::GetSubscriptionPlansRequest
**crates/hyperswitch_domain_models/src/router_response_types.rs**
Add:
- mod: pub::subscriptions
**crates/hyperswitch_domain_models/src/router_response_types/subscriptions.rs**
Add:
- struct: pub::GetSubscriptionPlansResponse
- struct: pub::SubscriptionPlans
**crates/hyperswitch_domain_models/src/types.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/api.rs**
Add:
- mod: pub::subscriptions
- mod: pub::subscriptions_v2
**crates/hyperswitch_interfaces/src/api/subscriptions.rs**
Add:
- trait: pub::GetSubscriptionPlansFlow
- trait: pub::Subscriptions
- trait: pub::Subscriptions
- trait: pub::GetSubscriptionPlansFlow
**crates/hyperswitch_interfaces/src/api/subscriptions_v2.rs**
Add:
- trait: pub::SubscriptionsV2
- trait: pub::GetSubscriptionPlansV2
**crates/hyperswitch_interfaces/src/connector_integration_v2.rs**
Modify existing code
**crates/hyperswitch_interfaces/src/conversion_impls.rs**
Add:
- function: private::from_old_router_data
- function: private::to_old_router_data
- impl: impl RouterDataConversion<T, Req, Resp> for GetSubscriptionPlansData
**crates/hyperswitch_interfaces/src/types.rs**
Modify existing code
**crates/router/src/core/connector_validation.rs**
Modify existing code
**crates/router/src/services/api.rs**
Modify existing code
|
{"issue_number": 9053, "pr_number": 9281, "commits_count": 1, "files_changed": 21, "response_length": 5123, "file_count": 23, "needs_breakdown": true}
|
[FEATURE] add cypress tests for void payment in v2
### Feature Description
This implementation adds comprehensive V2 API testing for payment void/cancel operations across different payment states. The feature introduces a new Cypress test suite that validates three critical scenarios: successfully voiding a payment in the requires_capture state `after manual capture confirmation`, attempting to void a payment in the `requires_payment_method` state, and attempting to void a completed payment in the `succeeded` state.
### Possible Implementation
A new test file `VoidPayments.cy.js` contains three separate test contexts that verify void behavior across payment states using both manual and automatic capture flows.
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: test(cypress): add cypress tests for void payment in v2
- Merged: 2025-10-07T17:28:46Z
- Files changed: 9 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This implementation adds comprehensive V2 API testing for payment void/cancel operations across different payment states. The feature introduces a new Cypress test suite that validates three critical scenarios: successfully voiding a payment i
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 9638, "pr_number": 9646, "commits_count": 0, "files_changed": 9, "response_length": 785, "file_count": 0, "needs_breakdown": false}
|
[FEATURE] Implement `PaymentAttemptInterface` for `MockDb`
Spin out from #172. Please refer to that issue for more information.
|
<think>
PR Context:
- Title: Implement PaymentAttemptInterface for MockDb
- Merged: None
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
Fixes #1329
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 1329, "pr_number": 6372, "commits_count": 0, "files_changed": 1, "response_length": 271, "file_count": 0, "needs_breakdown": false}
|
feat(router): Include `payment_experience` in PML for payments response (v2)
Required by SDK
|
<think>
PR Context:
- Title: feat(router): Return payment_experience in PML for payment (v2)
- Merged: 2025-06-05T16:40:31Z
- Files changed: 3 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Added `payment_experience` in Payment Method List for Payments Response
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environm
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(router): Return payment_experience in PML for payment (v2) (#8255)
Files to modify:
**crates/api_models/src/payments.rs**
Modify existing code
**crates/router/src/core/payments/payment_methods.rs**
Modify existing code
|
{"issue_number": 8254, "pr_number": 8255, "commits_count": 1, "files_changed": 3, "response_length": 1026, "file_count": 4, "needs_breakdown": false}
|
feat(core): implemented platform merchant account
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
#### About the feature
- This the first PR for the Platform Account feature.
- Feature is under development and behind the feature flag.
- Feature is supposed to be disabled for sandbox and production environments.
#### Enabling the platform account.
- New API has been created to enable platform account.
- API requires Admin API auth.
- Once enabled, there is no way of disabling platform account as of now.
#### How it works
- A new special header is to be sent by the platform called `x-connected-merchant-id`.
- Platform will use its own API key irrespective of the merchant id present in the above header.
- Value of this header is supposed to be the merchant id of the merchant account on behalf of which the platform is performing the operation.
- **If the platform has `is_platform` true and the merchant account on behalf of which operation is performed belongs to the same organisation as platform** then the operation is allowed.
#### Payment Intent
- Operation will be performed for merchant id present in the `x-connected-merchant-id` header.
- `platform_merchant_id` column for the payment intent will be populated with platforms merchant id.
#### Other operations
- Will add context of `platform_merchant_id` in other operations as well.
<!-- Describe your changes in detail -->
### Additional Changes
- [x] This PR modifies the API contract
- [x] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
## Motivation and Context
#6883
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
## How did you test it?
1. Create a merchant account(m1).
2. Use below api to convert it into platform account.
```sh
curl --location --request POST '<BASE URL>/accounts/{merchant_id}/platform' \
--header 'api-key:<ADMIN API KEY>'
```
3. Create another merchant account in the same organisation(m2).
4. Do a payment using platform's(m1) API key for connected merchant account(m2) by passing header `x-connected-merchant-id` with value as connected merchant account's merchant id.
5. Check if payment is created for connected merchant account.
6. Check if `platform_merchant_id` is populated with platform's merchant id.
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [X] I formatted the code `cargo +nightly fmt --all`
- [X] I addressed lints thrown by `cargo clippy`
- [X] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: feat(core): add platform_account creation API
- Merged: None
- Files changed: 13 files
- Commits: 20 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
#### Precursor PR
#6882 (This PR has the context of platform merchant account and initial code changes).
#### Enabling the platform account.
- New API has been created to enable platform account.
- API requires `JWTAuth` with `OrganizationAccountWrite` permissions.
- Once enable
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 6882, "pr_number": 7213, "commits_count": 0, "files_changed": 13, "response_length": 762, "file_count": 0, "needs_breakdown": false}
|
[FEATURE] Support Platform Account to Make Payments for Connected Accounts in VSAAS
### Feature Description
- Enable support for payments processed by a platform merchant on behalf of a connected account.
- Update the MerchantContext enum to accommodate this new flow.
- Adjust how merchant and key store information are accessed and attributed.
- Ensure payments initiated by a platform merchant, but using a connected account’s credentials, are correctly processed.
### Possible Implementation
- Changing Merchant Context to have context for Platform and Connected Accounts as well
- Using Details of merchant context to know about merchant initiating payments and merchant whose connected credentials are getting used.
### Have you spent some time checking if this feature request has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes
|
<think>
PR Context:
- Title: feat(vsaas): support payments via platform for connected accounts
- Merged: None
- Files changed: 30 files
- Commits: 16 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR introduces a new feature enabling platform merchants to process payments for their connected accounts. This involves adding new context and logic to handle payments initiated by a platform merchant on behalf of a different merchant account (the connected account), supporting a
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 8305, "pr_number": 8290, "commits_count": 0, "files_changed": 30, "response_length": 781, "file_count": 0, "needs_breakdown": false}
|
refactor(customers_v2): address panics and some bugs in customers v2 endpoints
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR addresses panics and some bugs in customers v2 endpoints. This PR includes the following changes:
- Fixes the customers v2 update and retrieve endpoints to use the correct HTTP methods (`PUT` and `GET` respectively).
- Adds the `#[serde(deny_unknown_fields)]` to customer v2 request types.
- Moves the `id` field to be at the beginning of the `CustomerResponse` and `CustomerDeleteResponse` structs, so that the JSON serialization also follows the same.
- Introduces the `GlobalCustomerId` type and updates existing customer v2 (and other v2 modules like payment methods, payments, mandates) to use the `GlobalCustomerId` type instead of strings.
- Removes some of the wrappers around the customer ID types (`CustomerId`, `GlobalId` and `UpdateCustomerId` defined in the `api_models` crate), and implements the methods / traits on the underlying ID types instead.
- This was done since the underlying ID types and thus the field names differed, and it didn't make much difference as compared to implementing the methods / traits directly on the underlying ID type.
- Removes the `customer_id` / `id` field from `CustomerUpdateRequest` type in both v1 and v2. This field was never expected to be passed in the request body, but only there for the purpose of API events. This PR introduces a `CustomerUpdateRequestInternal` type instead which wraps around the request and the ID type, and is used internally, not part of the public API interface.
- Adds missing pieces of code to have the customers v2 create, retrieve, update, delete, list endpoints working.
### Additional Changes
- [x] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
- Moves the `id` field to be at the beginning of the `CustomerResponse` and `CustomerDeleteResponse` structs.
- Updates the `customer_id` field in the payment methods and payments v2 API types to use `GlobalCustomerId` instead of `CustomerId`.
- Removes the `customer_id` / `id` field from `CustomerUpdateRequest` type in both v1 and v2.
- A few OpenAPI spec related fixes.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unless it is an obvious bug or documentation fix
that will have little conversation).
-->
The changes included in this PR help ensure that the customers v2 endpoints run without causing panics. This should also help unblock other tasks that depend on the customers v2 endpoints.
## How did you test it?
<!--
Did you write an integration/unit/API test to verify the code changes?
Or did you test this change manually (provide relevant screenshots)?
-->
- Create customer v2:
```shell
curl --location 'http://localhost:8080/v2/customers' \
--header 'x-profile-id: pro_E6JIGLUJ0YUOCeyhbczu' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_fun38x9Yy3LoxGzdu0YK6KwO06xJT9aGfnm52FW6EL8hwNBKSXC3iilT8nDCEfOB' \
--data-raw '{
"merchant_reference_id": "customer_1734263771",
"name": "John Doe",
"email": "guest@example.com",
"phone": "999999999",
"phone_country_code": "+65",
"description": "First customer",
"default_billing_address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "joseph",
"last_name": "Doe"
},
"default_shipping_address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "joseph",
"last_name": "Doe"
},
"metadata": {
"udf1": "value1",
"new_customer": "true",
"login_date": "2019-09-10T10:11:12Z"
}
}'
```
- Retrieve customer v2:
```shell
curl --location 'http://localhost:8080/v2/customers/12345_cus_0193ca2bc9e170e282ca121616ebec7a' \
--header 'x-profile-id: pro_E6JIGLUJ0YUOCeyhbczu' \
--header 'api-key: dev_fun38x9Yy3LoxGzdu0YK6KwO06xJT9aGfnm52FW6EL8hwNBKSXC3iilT8nDCEfOB'
```
- Update customer v2:
```shell
curl --location --request PUT 'http://localhost:8080/v2/customers/12345_cus_0193ca2bc9e170e282ca121616ebec7a' \
--header 'x-profile-id: pro_E6JIGLUJ0YUOCeyhbczu' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_fun38x9Yy3LoxGzdu0YK6KwO06xJT9aGfnm52FW6EL8hwNBKSXC3iilT8nDCEfOB' \
--data-raw '{
"merchant_reference_id": "customer_1734263927",
"name": "Jane Doe",
"email": "guest@example.com",
"phone": "999999999",
"phone_country_code": "+65",
"description": "Second customer",
"default_billing_address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "joseph",
"last_name": "Doe"
},
"default_shipping_address": {
"line1": "1467",
"line2": "Harrison Street",
"line3": "Harrison Street",
"city": "San Fransico",
"state": "California",
"zip": "94122",
"country": "US",
"first_name": "joseph",
"last_name": "Doe"
},
"metadata": {
"udf1": "value1",
"new_customer": "true",
"login_date": "2019-09-10T10:11:12Z"
}
}'
```
- Delete customer v2:
```shell
curl --location --request DELETE 'http://localhost:8080/v2/customers/12345_cus_0193ca2bc9e170e282ca121616ebec7a' \
--header 'x-profile-id: pro_E6JIGLUJ0YUOCeyhbczu' \
--header 'api-key: dev_fun38x9Yy3LoxGzdu0YK6KwO06xJT9aGfnm52FW6EL8hwNBKSXC3iilT8nDCEfOB'
```
- Customer list v2:
```shell
curl --location 'http://localhost:8080/v2/customers/list' \
--header 'x-profile-id: pro_E6JIGLUJ0YUOCeyhbczu' \
--header 'api-key: dev_fun38x9Yy3LoxGzdu0YK6KwO06xJT9aGfnm52FW6EL8hwNBKSXC3iilT8nDCEfOB'
```
### Known Bugs / Issues
1. The `default_billing_address` and `default_shipping_address` fields seem to be correctly encrypted and populated in the database, but not in the response (during customer create, update and retrieve). This is due to the way in which encryption is being handled in our code.
2. The `merchant_reference_id` is accepted in the customers update request, but it is not being accessed anywhere in the customers update flow. Moreover, the behavior once this is fixed should be such that it allows updating the reference ID from a null value to a non-null value, but does not allow updating the reference ID once set.
3. Customer delete v2 may not have redacted address completely, because of encryption issues (slightly related to 1).
I'll be addressing these bugs in a separate PR, since 1 and 3 may need changes to the `ToEncryption` macro.
## Checklist
<!-- Put an `x` in the boxes that apply -->
- [x] I formatted the code `cargo +nightly fmt --all`
- [x] I addressed lints thrown by `cargo clippy`
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
|
<think>
PR Context:
- Title: refactor(customers_v2): include minor fixes for customer v2 flows
- Merged: 2024-12-20T08:30:05Z
- Files changed: 5 files
- Commits: 4 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR includes minor fixes suggested in my previous PR #6836. This PR includes the following changes:
- Import `CustomerUpdateRequestInternal` instead of fully qualifying it.
- Renames the `fetch_domain_model_and_update_and_generate_de
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(customers_v2): include minor fixes for customer v2 flows (#6876)
Files to modify:
**crates/api_models/src/events/customer.rs**
Modify existing code
**crates/api_models/src/payments.rs**
Modify existing code
**crates/router/src/core/customers.rs**
Modify existing code
**crates/router/src/core/payments/transformers.rs**
Modify existing code
|
{"issue_number": 6836, "pr_number": 6876, "commits_count": 1, "files_changed": 5, "response_length": 1160, "file_count": 6, "needs_breakdown": false}
|
[BUG] Logging sensitive information on deserialization failure
### Bug Description
In `common_utils/src/ext_traits.rs` we are logging serde_json Values in plaintext when deserialization fails. This is a problem in cases where the JSON objects contain sensitive data.
### Expected Behavior
Sensitive data is not logged. Values are logged after masking.
### Actual Behavior
Sensitive information is logged.
### Steps To Reproduce
Supply malformed data to the `parse_value` method in `ValueExt` trait.
### Context For The Bug
_No response_
### Environment
Are you using hyperswitch hosted version? Yes
### Have you spent some time checking if this bug has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: fix(common_utils): Prevent logging sensitive information on deserialization failure
- Merged: 2025-09-24T13:24:48Z
- Files changed: 1 files
- Commits: 6 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
- Modified `parse_value` method in `ValueExt` trait to log the JSON object after masking on deserialization failure.
- Modified `parse_struct` method in `BytesExt`, `ByteSliceExt` and `StringExt` to log values after converting them into a `serde_json::Value` and then masking
### A
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** fix(common_utils): Prevent logging sensitive information on deserialization failure (#8970)
Files to modify:
**crates/common_utils/src/ext_traits.rs**
Modify existing code
|
{"issue_number": 8969, "pr_number": 8970, "commits_count": 1, "files_changed": 1, "response_length": 991, "file_count": 3, "needs_breakdown": false}
|
[BUG] mandate details are not persisted for Adyen connector
### Bug Description
This is specific to Adyen's connector integration.
In case mandate details were not present in the response of payment sync with Adyen, these details are sent through webhooks. However, these details are not being persisted in DB leading to MIT failures.
### Expected Behavior
Mandate details sent in the webhook's request should be persisted in payment_methods table for future MITs
### Actual Behavior
Mandate details sent in the webhook's request are not persisted in `payment_methods` table.
### Steps To Reproduce
Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to reproduce, if relevant.
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
### Context For The Bug
_No response_
### Environment
Are you using hyperswitch hosted version? Yes/No
If yes, please provide the value of the `x-request-id` response header to help us debug your issue.
If not (or if building/running locally), please provide the following details:
1. Operating System or Linux distribution:
2. Rust version (output of `rustc --version`): ``
3. App version (output of `cargo r --features vergen -- --version`): ``
### Have you spent some time checking if this bug has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: feat(webhooks): adyen - consume and update connector's network_transaction_id in payment_methods
- Merged: 2024-12-05T13:34:59Z
- Files changed: 7 files
- Commits: 10 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Described in #6719
This PR introduces below changes
- `get_network_txn_id` fn in IncomingWebhook trait
- implement this new fn for Adyen for retrieving the network txn ID
- consume this fn in core flows for updating `network_transaction_id` in `payment_methods` table
### Add
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(webhooks): adyen - consume and update connector's network_transaction_id in payment_methods (#6
Files to modify:
**crates/diesel_models/src/payment_method.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/router_flow_types/webhooks.rs**
Add:
- function: pub::new
- function: pub::get_id
- struct: pub::ConnectorNetworkTxnId
- impl: impl ConnectorNetworkTxnId
**crates/hyperswitch_interfaces/src/webhooks.rs**
Add:
- function: private::get_network_txn_id
**crates/router/src/connector/adyen.rs**
Add:
- function: private::get_network_txn_id
**crates/router/src/connector/adyen/transformers.rs**
Modify existing code
**crates/router/src/core/webhooks/incoming.rs**
Modify existing code
**crates/router/src/services/connector_integration_interface.rs**
Add:
- function: private::get_network_txn_id
|
{"issue_number": 6719, "pr_number": 6738, "commits_count": 1, "files_changed": 7, "response_length": 1694, "file_count": 9, "needs_breakdown": false}
|
Missing next steps after deployment setup on Readme
Next steps after deployment setup on Readme are missing
|
<think>
PR Context:
- Title: docs: Updated next steps after deployment setup on Readme
- Merged: 2025-04-03T03:28:38Z
- Files changed: 1 files
- Commits: 4 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [X] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Updated next steps after deployment setup on Readme
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
<!-
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 7685, "pr_number": 7686, "commits_count": 0, "files_changed": 1, "response_length": 787, "file_count": 0, "needs_breakdown": false}
|
feat(core): Implement UCS based upi for paytm and phonepe
## Feature Request: Implement UPI Intent and QR Code Payment Flows for UCS Integration
### Description
Add support for UPI Intent and QR code payment methods through the Unified Connector Service (UCS) for Paytm and PhonePe payment gateways.
### Background
UPI is a critical payment method in India. Currently, Hyperswitch lacks support for UPI Intent (for mobile apps) and QR code flows through the UCS integration. This limits merchants' ability to accept UPI payments through these popular payment gateways.
### Requirements
- Add default implementations for Paytm and PhonePe connectors
- Support UPI Intent payment method for mobile app integrations
- Support QR code generation and payment flow for UPI
- Route payment requests through UCS (actual payment processing handled by UCS)
- Add necessary configuration entries for both connectors
### Technical Details
- The implementation should follow the existing UCS architecture pattern
- No direct API integration with Paytm/PhonePe required (handled by UCS)
- Need to add routing logic and connector definitions
- Should support standard payment operations: create, sync, refund
### Acceptance Criteria
- Successfully create UPI Intent payments through Paytm and PhonePe via UCS
- QR code generation works for UPI payments
- Payment status sync operations function correctly
- Configuration properly set up across all environments
|
<think>
PR Context:
- Title: feat(core): Implement UCS based upi for paytm and phonepe
- Merged: 2025-07-31T14:18:08Z
- Files changed: 30 files
- Commits: 22 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Fixed #8734
## Description
<!-- Describe your changes in detail -->
This PR implements UPI Intent and QR code payment flows for the Unified Connector Service (UCS) integration, adding default implementations for Paytm and PhonePe connectors.
### Key Changes:
- **Default Connector Implem
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat(core): Implement UCS based upi for paytm and phonepe (#8732)
Co-authored-by: hyperswitch-bot[
Files to modify:
**crates/common_enums/src/connector_enums.rs**
Modify existing code
**crates/connector_configs/src/connector.rs**
Modify existing code
**crates/external_services/src/grpc_client/unified_connector_service.rs**
Modify existing code
**crates/hyperswitch_connectors/src/connectors.rs**
Add:
- mod: pub::paytm
- mod: pub::phonepe
**crates/hyperswitch_connectors/src/connectors/paytm.rs**
Add:
- function: pub::new
- function: private::build_headers
- function: private::id
- function: private::get_currency_unit
- function: private::common_get_content_type
- function: private::base_url
- function: private::get_auth_header
- function: private::build_error_response
- function: private::validate_mandate_payment
- function: private::validate_psync_reference_id
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_webhook_object_reference_id
- function: private::get_webhook_event_type
- function: private::get_webhook_resource_object
- function: private::get_connector_about
- function: private::get_supported_payment_methods
- function: private::get_supported_webhook_flows
- struct: pub::Paytm
- impl: impl Paytm
- impl: impl api::Payment for Paytm
- impl: impl api::PaymentSession for Paytm
- impl: impl api::ConnectorAccessToken for Paytm
- impl: impl api::MandateSetup for Paytm
- impl: impl api::PaymentAuthorize for Paytm
- impl: impl api::PaymentSync for Paytm
- impl: impl api::PaymentCapture for Paytm
- impl: impl api::PaymentVoid for Paytm
- impl: impl api::Refund for Paytm
- impl: impl api::RefundExecute for Paytm
- impl: impl api::RefundSync for Paytm
- impl: impl api::PaymentToken for Paytm
- impl: impl ConnectorIntegration<PaymentMethodToken, PaymentMethodTokenizationData, PaymentsResponseData> for Paytm
- impl: impl ConnectorCommonExt<Flow, Request, Response> for Paytm
- impl: impl ConnectorCommon for Paytm
- impl: impl ConnectorValidation for Paytm
- impl: impl ConnectorIntegration<Session, PaymentsSessionData, PaymentsResponseData> for Paytm
- impl: impl ConnectorIntegration<AccessTokenAuth, AccessTokenRequestData, AccessToken> for Paytm
- impl: impl ConnectorIntegration<SetupMandate, SetupMandateRequestData, PaymentsResponseData> for Paytm
- impl: impl ConnectorIntegration<Authorize, PaymentsAuthorizeData, PaymentsResponseData> for Paytm
- impl: impl ConnectorIntegration<PSync, PaymentsSyncData, PaymentsResponseData> for Paytm
- impl: impl ConnectorIntegration<Capture, PaymentsCaptureData, PaymentsResponseData> for Paytm
- impl: impl ConnectorIntegration<Void, PaymentsCancelData, PaymentsResponseData> for Paytm
- impl: impl ConnectorIntegration<Execute, RefundsData, RefundsResponseData> for Paytm
- impl: impl ConnectorIntegration<RSync, RefundsData, RefundsResponseData> for Paytm
- impl: impl webhooks::IncomingWebhook for Paytm
- impl: impl ConnectorSpecifications for Paytm
- mod: pub::transformers
**crates/hyperswitch_connectors/src/connectors/paytm/transformers.rs**
Add:
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- struct: pub::PaytmRouterData
- struct: pub::PaytmPaymentsRequest
- struct: pub::PaytmCard
- struct: pub::PaytmAuthType
- struct: pub::PaytmPaymentsResponse
- struct: pub::PaytmRefundRequest
- struct: pub::RefundResponse
- struct: pub::PaytmErrorResponse
- enum: pub::PaytmPaymentStatus
- enum: pub::RefundStatus
- impl: impl From<(StringMinorUnit, T)> for PaytmRouterData<T>
- impl: impl TryFrom<&PaytmRouterData<&PaymentsAuthorizeRouterData>> for PaytmPaymentsRequest
- impl: impl TryFrom<&ConnectorAuthType> for PaytmAuthType
- impl: impl From<PaytmPaymentStatus> for common_enums::AttemptStatus
- impl: impl TryFrom<ResponseRouterData<F, PaytmPaymentsResponse, T, PaymentsResponseData>> for RouterData<F, T, PaymentsResponseData>
- impl: impl TryFrom<&PaytmRouterData<&RefundsRouterData<F>>> for PaytmRefundRequest
- impl: impl From<RefundStatus> for enums::RefundStatus
- impl: impl TryFrom<RefundsResponseRouterData<Execute, RefundResponse>> for RefundsRouterData<Execute>
- impl: impl TryFrom<RefundsResponseRouterData<RSync, RefundResponse>> for RefundsRouterData<RSync>
**crates/hyperswitch_connectors/src/connectors/phonepe.rs**
Add:
- function: pub::new
- function: private::build_headers
- function: private::id
- function: private::get_currency_unit
- function: private::common_get_content_type
- function: private::base_url
- function: private::get_auth_header
- function: private::build_error_response
- function: private::validate_mandate_payment
- function: private::validate_psync_reference_id
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::get_request_body
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_headers
- function: private::get_content_type
- function: private::get_url
- function: private::build_request
- function: private::handle_response
- function: private::get_error_response
- function: private::get_webhook_object_reference_id
- function: private::get_webhook_event_type
- function: private::get_webhook_resource_object
- function: private::get_connector_about
- function: private::get_supported_payment_methods
- function: private::get_supported_webhook_flows
- struct: pub::Phonepe
- impl: impl Phonepe
- impl: impl api::Payment for Phonepe
- impl: impl api::PaymentSession for Phonepe
- impl: impl api::ConnectorAccessToken for Phonepe
- impl: impl api::MandateSetup for Phonepe
- impl: impl api::PaymentAuthorize for Phonepe
- impl: impl api::PaymentSync for Phonepe
- impl: impl api::PaymentCapture for Phonepe
- impl: impl api::PaymentVoid for Phonepe
- impl: impl api::Refund for Phonepe
- impl: impl api::RefundExecute for Phonepe
- impl: impl api::RefundSync for Phonepe
- impl: impl api::PaymentToken for Phonepe
- impl: impl ConnectorIntegration<PaymentMethodToken, PaymentMethodTokenizationData, PaymentsResponseData> for Phonepe
- impl: impl ConnectorCommonExt<Flow, Request, Response> for Phonepe
- impl: impl ConnectorCommon for Phonepe
- impl: impl ConnectorValidation for Phonepe
- impl: impl ConnectorIntegration<Session, PaymentsSessionData, PaymentsResponseData> for Phonepe
- impl: impl ConnectorIntegration<AccessTokenAuth, AccessTokenRequestData, AccessToken> for Phonepe
- impl: impl ConnectorIntegration<SetupMandate, SetupMandateRequestData, PaymentsResponseData> for Phonepe
- impl: impl ConnectorIntegration<Authorize, PaymentsAuthorizeData, PaymentsResponseData> for Phonepe
- impl: impl ConnectorIntegration<PSync, PaymentsSyncData, PaymentsResponseData> for Phonepe
- impl: impl ConnectorIntegration<Capture, PaymentsCaptureData, PaymentsResponseData> for Phonepe
- impl: impl ConnectorIntegration<Void, PaymentsCancelData, PaymentsResponseData> for Phonepe
- impl: impl ConnectorIntegration<Execute, RefundsData, RefundsResponseData> for Phonepe
- impl: impl ConnectorIntegration<RSync, RefundsData, RefundsResponseData> for Phonepe
- impl: impl webhooks::IncomingWebhook for Phonepe
- impl: impl ConnectorSpecifications for Phonepe
- mod: pub::transformers
**crates/hyperswitch_connectors/src/connectors/phonepe/transformers.rs**
Add:
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- function: private::from
- function: private::try_from
- function: private::try_from
- struct: pub::PhonepeRouterData
- struct: pub::PhonepePaymentsRequest
- struct: pub::PhonepeCard
- struct: pub::PhonepeAuthType
- struct: pub::PhonepePaymentsResponse
- struct: pub::PhonepeRefundRequest
- struct: pub::RefundResponse
- struct: pub::PhonepeErrorResponse
- enum: pub::PhonepePaymentStatus
- enum: pub::RefundStatus
- impl: impl From<(StringMinorUnit, T)> for PhonepeRouterData<T>
- impl: impl TryFrom<&PhonepeRouterData<&PaymentsAuthorizeRouterData>> for PhonepePaymentsRequest
- impl: impl TryFrom<&ConnectorAuthType> for PhonepeAuthType
- impl: impl From<PhonepePaymentStatus> for common_enums::AttemptStatus
- impl: impl TryFrom<ResponseRouterData<F, PhonepePaymentsResponse, T, PaymentsResponseData>> for RouterData<F, T, PaymentsResponseData>
- impl: impl TryFrom<&PhonepeRouterData<&RefundsRouterData<F>>> for PhonepeRefundRequest
- impl: impl From<RefundStatus> for enums::RefundStatus
- impl: impl TryFrom<RefundsResponseRouterData<Execute, RefundResponse>> for RefundsRouterData<Execute>
- impl: impl TryFrom<RefundsResponseRouterData<RSync, RefundResponse>> for RefundsRouterData<RSync>
**crates/hyperswitch_connectors/src/default_implementations.rs**
Modify existing code
**crates/hyperswitch_connectors/src/default_implementations_v2.rs**
Modify existing code
**crates/hyperswitch_domain_models/src/connector_endpoints.rs**
Modify existing code
**crates/payment_methods/src/configs/payment_connector_required_fields.rs**
Modify existing code
**crates/router/src/connector.rs**
Modify existing code
**crates/router/src/core/connector_validation.rs**
Modify existing code
**crates/router/src/core/unified_connector_service.rs**
Modify existing code
**crates/router/src/core/unified_connector_service/transformers.rs**
Modify existing code
**crates/router/src/types/api/connector_mapping.rs**
Modify existing code
**crates/router/src/types/connector_transformers.rs**
Modify existing code
**crates/router/tests/connectors/main.rs**
Add:
- mod: private::paytm
- mod: private::phonepe
**crates/router/tests/connectors/paytm.rs**
Add:
- function: private::get_data
- function: private::get_auth_token
- function: private::get_name
- function: private::get_default_payment_info
- function: private::payment_method_details
- function: private::should_only_authorize_payment
- function: private::should_capture_authorized_payment
- function: private::should_partially_capture_authorized_payment
- function: private::should_sync_authorized_payment
- function: private::should_void_authorized_payment
- function: private::should_refund_manually_captured_payment
- function: private::should_partially_refund_manually_captured_payment
- function: private::should_sync_manually_captured_refund
- function: private::should_make_payment
- function: private::should_sync_auto_captured_payment
- function: private::should_refund_auto_captured_payment
- function: private::should_partially_refund_succeeded_payment
- function: private::should_refund_succeeded_payment_multiple_times
- function: private::should_sync_refund
- function: private::should_fail_payment_for_incorrect_cvc
- function: private::should_fail_payment_for_invalid_exp_month
- function: private::should_fail_payment_for_incorrect_expiry_year
- function: private::should_fail_void_payment_for_auto_capture
- function: private::should_fail_capture_for_invalid_payment
- function: private::should_fail_for_refund_amount_higher_than_payment_amount
- struct: private::PaytmTest
- impl: impl ConnectorActions for PaytmTest
- impl: impl utils::Connector for PaytmTest
**crates/router/tests/connectors/phonepe.rs**
Add:
- function: private::get_data
- function: private::get_auth_token
- function: private::get_name
- function: private::get_default_payment_info
- function: private::payment_method_details
- function: private::should_only_authorize_payment
- function: private::should_capture_authorized_payment
- function: private::should_partially_capture_authorized_payment
- function: private::should_sync_authorized_payment
- function: private::should_void_authorized_payment
- function: private::should_refund_manually_captured_payment
- function: private::should_partially_refund_manually_captured_payment
- function: private::should_sync_manually_captured_refund
- function: private::should_make_payment
- function: private::should_sync_auto_captured_payment
- function: private::should_refund_auto_captured_payment
- function: private::should_partially_refund_succeeded_payment
- function: private::should_refund_succeeded_payment_multiple_times
- function: private::should_sync_refund
- function: private::should_fail_payment_for_incorrect_cvc
- function: private::should_fail_payment_for_invalid_exp_month
- function: private::should_fail_payment_for_incorrect_expiry_year
- function: private::should_fail_void_payment_for_auto_capture
- function: private::should_fail_capture_for_invalid_payment
- function: private::should_fail_for_refund_amount_higher_than_payment_amount
- struct: private::PhonepeTest
- impl: impl ConnectorActions for PhonepeTest
- impl: impl utils::Connector for PhonepeTest
**crates/test_utils/src/connector_auth.rs**
Modify existing code
|
{"issue_number": 8734, "pr_number": 8732, "commits_count": 1, "files_changed": 30, "response_length": 16679, "file_count": 24, "needs_breakdown": true}
|
feat(authn): Use cookies for authentication
Currently we use auth headers and local storage in FE for transfer JWT from FE to BE.
Cookies is a better way to do this, as it is handled by browser and JavaScript doesn't have access to.
First we will test this in Integ and slowly move it to sandbox and production.
|
<think>
PR Context:
- Title: refactor(authn): Enable cookies in Integ
- Merged: 2024-11-26T12:42:14Z
- Files changed: 11 files
- Commits: 7 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR will add logging for cookies and also make signout API accessible by any SPT.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [x] This PR modifies application configur
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(authn): Enable cookies in Integ (#6599)
Files to modify:
**crates/router/src/configs/settings.rs**
Modify existing code
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/routes/user.rs**
Modify existing code
**crates/router/src/services/authentication.rs**
Add:
- function: private::authenticate_and_fetch
- struct: pub::AnyPurposeOrLoginTokenAuth
- impl: impl AuthenticateAndFetch<UserIdFromAuth, A> for AnyPurposeOrLoginTokenAuth
|
{"issue_number": 6598, "pr_number": 6599, "commits_count": 1, "files_changed": 11, "response_length": 1265, "file_count": 6, "needs_breakdown": false}
|
[ENHANCE] create_user_authentication_method API response to include created entity details
Currently, the [create_user_authentication_method](https://github.com/juspay/hyperswitch/blob/cf30da2df05aac69fd82b676e639b2fbc85dcae5/crates/router/src/core/user.rs#L2482) API endpoint (`POST /user/auth`) returns a generic `200 OK` status with an empty body upon successful creation. This is not informative for API clients, who would benefit from receiving the complete details of the newly created resource in the response, rather than just a success status.
### __Proposed Solution:__
To improve the API's usability and provide immediate access to the created resource's data, the endpoint should return a JSON response containing all the relevant fields of the new user authentication method. This aligns with common REST API practices where a `POST` request to a collection resource returns the representation of the newly created resource.
### __Implementation Plan:__
1. __Define a New Comprehensive Response Struct:__
- In the file `crates/api_models/src/user.rs`, define a new public struct named `CreateUserAuthenticationMethodResponse`.
- This struct should derive `Debug`, `serde::Serialize` and any other traits if required.
- It should contain the following public fields with their respective types:
- `id`, `auth_id`, `owner_id`,`owner_type`, `auth_type`, `email_domain`,`allow_signup`
- Place this new struct definition logically near the existing `CreateUserAuthenticationMethodRequest` struct.
2. __Update the Core Function:__
- In the file `crates/router/src/core/user.rs`, locate the `create_user_authentication_method` async function.
- Update the function's return type from `UserResponse<()>` to `UserResponse<CreateUserAuthenticationMethodResponse>`.
- Add the necessary import statement at the top of the file: `use api_models::user::CreateUserAuthenticationMethodResponse;`.
- Modify the function's success return statement. Instead of `Ok(ApplicationResponse::StatusOk)`, it should return `CreateUserAuthenticationMethodResponse`. This uses the variables already available or computed within the function to populate the response struct.
### __How to Test:__
1. Run the Hyperswitch application locally.
2. Make a `POST` request to the `/user/authentication_method` endpoint.
3. Use the admin API key for authorization. For local development, the key is typically `test_admin`.
4. The request body should be a valid `CreateUserAuthenticationMethodRequest` JSON object.
5. Verify that the response status is `200 OK` and the response body is a JSON object containing the `id`, `auth_id`, `owner_id`, `owner_type`, `auth_type`, `email_domain`, and `allow_signup` of the newly created authentication method.
Curl
```
curl --location '<hyperswitch-backend-base-url>/user/auth' \
--header 'Content-Type: application/json' \
--header 'api-key: <admin-api-key>' \
--data '
{
"owner_type": "organization",
"owner_id": "test_123",
"auth_method": {
"auth_type": "open_id_connect",
"private_config": {
"base_url": "hello.com",
"client_id": "something_client",
"client_secret": "something_client",
"private_key": "something"
},
"public_config": {
"name": "okta"
}
},
"allow_signup": true,
"email_domain": "None"
}'
```
### __Expected Outcome:__
After these changes, a successful request to `POST /user/auth` will yield a `200 OK` response with a JSON body similar to the following:
```json
{
"id": "5500",
"auth_id": "a1b2c3d4-0-1234-567890abcdef",
"owner_id": "merchant_123",
"owner_type": "Merchant",
"auth_type": "OpenIdConnect",
"email_domain": "example.com",
"allow_signup": true
}
```
This provides a much more robust and developer-friendly API experience by giving clients full visibility into the created resource immediately.
|
<think>
PR Context:
- Title: feat: include response body for create_user_authentication_method
- Merged: 2025-10-15T16:19:48Z
- Files changed: 3 files
- Commits: 12 commits
Implementation approach:
#9643
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Currently the API Call to the /user/auth endpoint displays only a 200::OK response code without providing a proper response body containing the authentication details for proper debugging.This PR Introduces a Response body of type CreateUserAuthenticationMethodReponse which co
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** feat: include response body for create_user_authentication_method (#9653)
Files to modify:
**crates/api_models/src/events/user.rs**
Modify existing code
**crates/api_models/src/user.rs**
Add:
- struct: pub::CreateUserAuthenticationMethodResponse
**crates/router/src/core/user.rs**
Modify existing code
|
{"issue_number": 9643, "pr_number": 9653, "commits_count": 1, "files_changed": 3, "response_length": 1114, "file_count": 5, "needs_breakdown": false}
|
[BUG] Setup fail : migration_runner exits with code 1 during standalone setup
### Bug Description
While setting up Hyperswitch locally using the scripts/setup.sh script, the setup consistently fails during the migration_runner step.
The database (pg) and Redis services start successfully and report as Healthy, but the migration_runner container exits with code 1, causing the setup process to stop.
This blocks local development/testing on Windows environments.
Below is the ss of error :
<img width="930" height="942" alt="Image" src="https://github.com/user-attachments/assets/1578a5d6-323b-4858-8599-fb2cac588804" />
### Expected Behavior
All the containers should have been started and compiled successfully
### Actual Behavior
The error mentioned above occurred
### Steps To Reproduce
Clone the Repo and run `scripts/setup.sh`
### Context For The Bug
This is my first time setting up a project this big locally , so i might have miss something , or this might be an actual bug . Either way , i request some help in this matter
### Environment
OS : Windows
### Have you spent some time checking if this bug has been raised before?
- [x] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
### Are you willing to submit a PR?
Yes, I am willing to submit a PR!
|
<think>
PR Context:
- Title: fix(gitattributes): enforce LF for `.patch` files to avoid CRLF parsing errors on Windows
- Merged: 2025-09-17T10:03:30Z
- Files changed: 1 files
- Commits: 1 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR adds the following rule to `.gitattributes` to ensure `.patch` files always use LF line endings, regardless of developer OS:
```gitattributes
*.patch text eol=lf
```
This rule overrides Windows’ default `core.autocrlf` behavi
</think>
To implement this, you'll need to modify:
(No detailed commit information available)
|
{"issue_number": 9120, "pr_number": 9333, "commits_count": 0, "files_changed": 1, "response_length": 819, "file_count": 0, "needs_breakdown": false}
|
refactor(users): Make `profile_id` in the JWT non-optional
- We kept the `profile_id` in the JWT optional for backwards compatibility.
- Now we have `profile_id` in all the JWT and this field no longer needs to be optional in JWT.
|
<think>
PR Context:
- Title: refactor(users): Make `profile_id` in the JWT non-optional
- Merged: 2024-11-18T07:57:18Z
- Files changed: 8 files
- Commits: 3 commits
Implementation approach:
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Currently `profile_id` in the JWT is optional, this PR makes it non-optional.
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/
</think>
To implement this, you'll need to modify:
**Detailed Implementation:**
**Commit 1:** refactor(users): Make `profile_id` in the JWT non-optional (#6537)
Files to modify:
**crates/diesel_models/src/query/user_role.rs**
Modify existing code
**crates/router/src/core/user.rs**
Modify existing code
**crates/router/src/core/user_role.rs**
Modify existing code
**crates/router/src/db/kafka_store.rs**
Modify existing code
**crates/router/src/db/user_role.rs**
Modify existing code
**crates/router/src/services/authentication.rs**
Modify existing code
**crates/router/src/types/domain/user/decision_manager.rs**
Modify existing code
**crates/router/src/utils/user.rs**
Modify existing code
|
{"issue_number": 6534, "pr_number": 6537, "commits_count": 1, "files_changed": 8, "response_length": 1413, "file_count": 10, "needs_breakdown": false}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.