added test for framing

.gitignore

@@ -0,0 +1,87 @@
+# Byte-compiled / optimized / DLL files
+__pycache__/
+*.py[cod]
+*$py.class
+
+# C extensions
+*.so
+
+# Distribution / packaging
+.Python
+build/
+develop-eggs/
+dist/
+downloads/
+eggs/
+.eggs/
+lib/
+lib64/
+parts/
+sdist/
+var/
+wheels/
+*.egg-info/
+.installed.cfg
+*.egg
+
+# Virtual environment
+venv/
+env/
+ENV/
+.venv/
+.env/
+pip-wheel-metadata/
+
+# PyInstaller
+*.manifest
+*.spec
+
+# Unit test / coverage reports
+htmlcov/
+.tox/
+.nox/
+.coverage
+.coverage.*
+.cache
+nosetests.xml
+coverage.xml
+*.cover
+*.py,cover
+
+# Pytest
+.pytest_cache/
+
+# MyPy
+.mypy_cache/
+.dmypy.json
+dmypy.json
+
+# Pyre
+.pyre/
+
+# Pytype
+.pytype/
+
+# Cython debug symbols
+cython_debug/
+
+# VS Code settings
+.vscode/
+
+# Jupyter Notebook checkpoints
+.ipynb_checkpoints/
+
+# dotenv environment files
+*.env
+*.env.*
+
+# IDEs
+.idea/
+*.sublime-project
+*.sublime-workspace
+
+# Logs
+*.log
+
+# macOS
+.DS_Store

assets/test_video.mp4

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:f831e2c34ef1167c7eea14e6673069c1a2b5b6c8e9ec9b360ef5bce6ef0ecbc0
+size 1064736

src/.gitignore

@@ -1 +0,0 @@
-.env

src/app.py

@@ -27,6 +27,7 @@ model = Gemma3ForConditionalGeneration.from_pretrained(
 )
 
 def get_frames(video_path: str, max_images: int) -> list[tuple[Image.Image, float]]:
+    frames: list[tuple[Image.Image, float]] = []
     capture = cv2.VideoCapture(video_path)
     if not capture.isOpened():
         raise ValueError(f"Could not open video file: {video_path}")
@@ -35,7 +36,6 @@ def get_frames(video_path: str, max_images: int) -> list[tuple[Image.Image, floa
     total_frames = int(capture.get(cv2.CAP_PROP_FRAME_COUNT))
 
     frame_interval = max(total_frames // max_images, 1)
-    frames: list[tuple[Image.Image, float]] = []
 
     for i in range(0, min(total_frames, max_images * frame_interval), frame_interval):
         if len(frames) >= max_images:

tests/__init__.py

@@ -0,0 +1 @@
+'''This file is intentionally left empty to mark the directory as a package.'''

tests/test_video.py

@@ -0,0 +1,27 @@
+import pytest
+import os
+import cv2
+from PIL import Image
+from pathlib import Path
+
+from src.app import get_frames
+
+# Get the project root directory
+ROOT_DIR = Path(__file__).parent.parent
+
+def test_correct_frame_return():
+    """Test that get_frames returns a list of (Image, float) tuples."""
+    # Path to a test video file
+    video_path = os.path.join(ROOT_DIR, "assets", "test_video.mp4")
+    
+    # Ensure the test video exists
+    assert os.path.exists(video_path), f"Test video not found at {video_path}"
+    
+    # Test with a small number of frames
+    max_images = 3
+    frames = get_frames(video_path, max_images)
+    
+    # Check return type
+    assert isinstance(frames, list)
+    assert all(isinstance(item, tuple) and len(item) == 2 for item in frames)
+    assert all(isinstance(img, Image.Image) and isinstance(ts, float) for img, ts in frames)