Enh quiz mode #2

routes/quiz.py

@@ -175,15 +175,21 @@ async def get_document_summaries(user_id: str, project_id: str, documents: List[
                 summaries.append(f"[{doc}] {file_data['summary']}")
             
             # Get additional chunks for more context
-            chunks = rag.get_file_chunks(user_id=user_id, project_id=project_id, filename=doc, limit=30)
+            chunks = rag.get_file_chunks(user_id=user_id, project_id=project_id, filename=doc, limit=50)
             if chunks:
-                chunk_text = "\n".join([chunk.get("content", "") for chunk in chunks[:15]])
-                summaries.append(f"[{doc} - Additional Content] {chunk_text[:3000]}...")
+                # Filter out very short chunks and prioritize longer, more informative ones
+                meaningful_chunks = [chunk for chunk in chunks if len(chunk.get("content", "")) > 100]
+                if meaningful_chunks:
+                    chunk_text = "\n".join([chunk.get("content", "") for chunk in meaningful_chunks[:20]])
+                    summaries.append(f"[{doc} - Detailed Content] {chunk_text[:4000]}...")
                 
         except Exception as e:
             logger.warning(f"[QUIZ] Failed to get summary for {doc}: {e}")
             continue
     
+    if not summaries:
+        raise HTTPException(400, detail="No content found in selected documents. Please ensure documents contain text content.")
+    
     # Use NVIDIA_LARGE for comprehensive analysis if content is long
     combined_summaries = "\n\n".join(summaries)
     if len(combined_summaries) > 5000:
@@ -364,21 +370,31 @@ async def generate_questions_and_answers(plan: List[Dict], document_summaries: s
 
 async def generate_task_questions(task: Dict, document_summaries: str, nvidia_rotator, complexity: str = None) -> List[Dict]:
     """Generate questions for a specific task using appropriate model based on complexity"""
-    system_prompt = f"""You are an expert quiz question generator.
+    system_prompt = f"""You are an expert quiz question generator creating high-quality educational questions.
     Generate {task.get('number_mcq', 0)} multiple choice questions and {task.get('number_sr', 0)} self-reflection questions.
     
     For MCQ questions:
-    - Create clear, well-structured questions
-    - Provide 4 answer options (A, B, C, D)
-    - Mark the correct answer
-    - Make distractors plausible but incorrect
+    - Create clear, well-structured questions that test understanding
+    - Provide 4 answer options (A, B, C, D) that are plausible
+    - Mark the correct answer (0-3 index)
+    - Make distractors plausible but clearly incorrect
     - Focus on the specific topic: {task.get('topic', 'General')}
+    - Ensure questions are answerable from the provided content
+    - Avoid trivial or overly obvious questions
     
     For self-reflection questions:
     - Create open-ended questions that require critical thinking
     - Focus on analysis, evaluation, and synthesis
     - Encourage personal reflection and application
     - Relate to the specific topic: {task.get('topic', 'General')}
+    - Make questions thought-provoking but not overly complex
+    - Ensure they can be answered based on the provided content
+    
+    Quality Requirements:
+    - Questions must be directly answerable from the provided content
+    - Avoid questions that require external knowledge
+    - Ensure clarity and proper grammar
+    - Make questions educational and meaningful
     
     Return a JSON array of question objects with this format:
     {{
@@ -392,9 +408,9 @@ async def generate_task_questions(task: Dict, document_summaries: str, nvidia_ro
     """
     
     user_prompt = f"""Task: {task}
-    Document content: {document_summaries[:4000]}...
+    Document content: {document_summaries[:5000]}...
     
-    Generate questions:"""
+    Generate high-quality questions based ONLY on the provided content:"""
     
     try:
         # Use appropriate model based on complexity
@@ -416,13 +432,55 @@ async def generate_task_questions(task: Dict, document_summaries: str, nvidia_ro
         )
         
         questions = json.loads(response.strip())
-        return questions if isinstance(questions, list) else []
+        
+        # Validate questions
+        validated_questions = []
+        for question in questions:
+            if validate_question(question):
+                validated_questions.append(question)
+            else:
+                logger.warning(f"[QUIZ] Invalid question filtered out: {question}")
+        
+        return validated_questions
         
     except Exception as e:
         logger.warning(f"[QUIZ] Failed to generate questions for task: {e}")
         return []
 
 
+def validate_question(question: Dict) -> bool:
+    """Validate that a question meets quality standards"""
+    try:
+        # Check required fields
+        if not question.get("type") or question["type"] not in ["mcq", "self_reflect"]:
+            return False
+        
+        if not question.get("question") or len(question["question"]) < 10:
+            return False
+        
+        if not question.get("topic"):
+            return False
+        
+        # Validate MCQ questions
+        if question["type"] == "mcq":
+            options = question.get("options", [])
+            if len(options) != 4:
+                return False
+            
+            correct_answer = question.get("correct_answer")
+            if correct_answer is None or not isinstance(correct_answer, int) or correct_answer < 0 or correct_answer > 3:
+                return False
+            
+            # Check for empty options
+            if any(not option or len(option.strip()) < 1 for option in options):
+                return False
+        
+        return True
+        
+    except Exception:
+        return False
+
+
 async def mark_quiz_answers(questions: List[Dict], user_answers: Dict, nvidia_rotator) -> Dict:
     """Mark quiz answers and provide feedback"""
     results = {

static/quiz.js

@@ -195,7 +195,7 @@
     const currentProject = window.__sb_get_current_project && window.__sb_get_current_project();
     
     if (!user || !currentProject) {
-      alert('Please sign in and select a project');
+      showNotification('Please sign in and select a project', 'error');
       return;
     }
 
@@ -208,17 +208,24 @@
       .map(input => input.value);
 
     if (selectedDocs.length === 0) {
-      alert('Please select at least one document');
+      showNotification('Please select at least one document', 'warning');
       return;
     }
 
     if (!questionsInput) {
-      alert('Please specify how many questions you want');
+      showNotification('Please specify how many questions you want', 'warning');
       return;
     }
 
-    // Show loading
+    // Validate questions input
+    if (questionsInput.length < 10) {
+      showNotification('Please provide more details about your question requirements', 'warning');
+      return;
+    }
+
+    // Show loading with progress updates
     showLoading('Creating quiz...');
+    updateLoadingProgress('Parsing your requirements...', 20);
 
     try {
       // Create quiz
@@ -229,6 +236,8 @@
       formData.append('time_limit', timeLimit.toString());
       formData.append('documents', JSON.stringify(selectedDocs));
 
+      updateLoadingProgress('Analyzing documents...', 40);
+      
       const response = await fetch('/quiz/create', {
         method: 'POST',
         body: formData
@@ -237,6 +246,11 @@
       const data = await response.json();
 
       if (response.ok) {
+        updateLoadingProgress('Generating questions...', 80);
+        
+        // Simulate processing time for better UX
+        await new Promise(resolve => setTimeout(resolve, 1000));
+        
         hideLoading();
         closeQuizSetup();
         
@@ -246,15 +260,16 @@
         quizAnswers = {};
         timeRemaining = timeLimit * 60; // Convert to seconds
         
+        showNotification(`Quiz created successfully! ${currentQuiz.questions.length} questions generated.`, 'success');
         startQuiz();
       } else {
         hideLoading();
-        alert(data.detail || 'Failed to create quiz');
+        showNotification(data.detail || 'Failed to create quiz', 'error');
       }
     } catch (error) {
       hideLoading();
       console.error('Quiz creation failed:', error);
-      alert('Failed to create quiz. Please try again.');
+      showNotification('Failed to create quiz. Please try again.', 'error');
     }
   }
 
@@ -408,13 +423,31 @@
       clearInterval(quizTimer);
     }
 
-    // Show loading
+    // Validate that all questions are answered
+    const unansweredQuestions = [];
+    for (let i = 0; i < currentQuiz.questions.length; i++) {
+      if (quizAnswers[i] === undefined || quizAnswers[i] === null || quizAnswers[i] === '') {
+        unansweredQuestions.push(i + 1);
+      }
+    }
+
+    if (unansweredQuestions.length > 0) {
+      const confirmSubmit = confirm(`You have ${unansweredQuestions.length} unanswered questions (${unansweredQuestions.join(', ')}). Do you want to submit anyway?`);
+      if (!confirmSubmit) {
+        return;
+      }
+    }
+
+    // Show loading with progress
     showLoading('Submitting quiz...');
+    updateLoadingProgress('Processing your answers...', 30);
 
     try {
       const user = window.__sb_get_user();
       const currentProject = window.__sb_get_current_project && window.__sb_get_current_project();
 
+      updateLoadingProgress('Marking your answers...', 60);
+
       const formData = new FormData();
       formData.append('user_id', user.user_id);
       formData.append('project_id', currentProject.project_id);
@@ -429,17 +462,22 @@
       const data = await response.json();
 
       if (response.ok) {
+        updateLoadingProgress('Generating feedback...', 90);
+        
+        // Simulate processing time for better UX
+        await new Promise(resolve => setTimeout(resolve, 1500));
+        
         hideLoading();
         closeQuizModal();
         showQuizResults(data.results);
       } else {
         hideLoading();
-        alert(data.detail || 'Failed to submit quiz');
+        showNotification(data.detail || 'Failed to submit quiz', 'error');
       }
     } catch (error) {
       hideLoading();
       console.error('Quiz submission failed:', error);
-      alert('Failed to submit quiz. Please try again.');
+      showNotification('Failed to submit quiz. Please try again.', 'error');
     }
   }
 
@@ -451,22 +489,37 @@
     const incorrectAnswers = results.questions.filter(q => q.status === 'incorrect').length;
     const score = Math.round((correctAnswers + partialAnswers * 0.5) / totalQuestions * 100);
 
+    // Determine performance level
+    let performanceLevel = 'Needs Improvement';
+    let performanceColor = 'var(--error)';
+    if (score >= 90) {
+      performanceLevel = 'Excellent';
+      performanceColor = 'var(--success)';
+    } else if (score >= 80) {
+      performanceLevel = 'Good';
+      performanceColor = 'var(--accent)';
+    } else if (score >= 70) {
+      performanceLevel = 'Satisfactory';
+      performanceColor = 'var(--warning)';
+    }
+
     quizResultsContent.innerHTML = `
       <div class="quiz-result-summary">
-        <div class="quiz-result-stat">
-          <div class="quiz-result-stat-value">${score}%</div>
+        <div class="quiz-result-stat quiz-result-score">
+          <div class="quiz-result-stat-value" style="color: ${performanceColor}">${score}%</div>
           <div class="quiz-result-stat-label">Score</div>
+          <div class="quiz-result-performance">${performanceLevel}</div>
         </div>
         <div class="quiz-result-stat">
-          <div class="quiz-result-stat-value">${correctAnswers}</div>
+          <div class="quiz-result-stat-value" style="color: var(--success)">${correctAnswers}</div>
           <div class="quiz-result-stat-label">Correct</div>
         </div>
         <div class="quiz-result-stat">
-          <div class="quiz-result-stat-value">${partialAnswers}</div>
+          <div class="quiz-result-stat-value" style="color: var(--warning)">${partialAnswers}</div>
           <div class="quiz-result-stat-label">Partial</div>
         </div>
         <div class="quiz-result-stat">
-          <div class="quiz-result-stat-value">${incorrectAnswers}</div>
+          <div class="quiz-result-stat-value" style="color: var(--error)">${incorrectAnswers}</div>
           <div class="quiz-result-stat-label">Incorrect</div>
         </div>
       </div>
@@ -483,12 +536,14 @@
             ${question.type === 'mcq' ? `
               <div class="quiz-result-answer">
                 <div class="quiz-result-answer-label">Your Answer:</div>
-                <div class="quiz-result-answer-content">${question.options[question.user_answer] || 'No answer'}</div>
-              </div>
-              <div class="quiz-result-answer">
-                <div class="quiz-result-answer-label">Correct Answer:</div>
-                <div class="quiz-result-answer-content">${question.options[question.correct_answer]}</div>
+                <div class="quiz-result-answer-content ${question.status === 'correct' ? 'correct' : question.status === 'incorrect' ? 'incorrect' : ''}">${question.options[question.user_answer] || 'No answer'}</div>
               </div>
+              ${question.status === 'incorrect' ? `
+                <div class="quiz-result-answer">
+                  <div class="quiz-result-answer-label">Correct Answer:</div>
+                  <div class="quiz-result-answer-content correct">${question.options[question.correct_answer]}</div>
+                </div>
+              ` : ''}
             ` : `
               <div class="quiz-result-answer">
                 <div class="quiz-result-answer-label">Your Answer:</div>
@@ -507,6 +562,9 @@
     `;
 
     quizResultsModal.classList.remove('hidden');
+    
+    // Show success notification
+    showNotification(`Quiz completed! You scored ${score}% (${performanceLevel})`, 'success');
   }
 
   function closeQuizModal() {
@@ -533,6 +591,19 @@
     }
   }
 
+  function updateLoadingProgress(message, progress) {
+    const loadingOverlay = document.getElementById('loading-overlay');
+    const loadingMessage = document.getElementById('loading-message');
+    const loadingProgress = document.getElementById('loading-progress');
+    
+    if (loadingOverlay && loadingMessage) {
+      loadingMessage.textContent = message;
+      if (loadingProgress) {
+        loadingProgress.style.width = `${progress}%`;
+      }
+    }
+  }
+
   function hideLoading() {
     const loadingOverlay = document.getElementById('loading-overlay');
     if (loadingOverlay) {
@@ -540,6 +611,33 @@
     }
   }
 
+  function showNotification(message, type = 'info') {
+    // Create notification element
+    const notification = document.createElement('div');
+    notification.className = `notification notification-${type}`;
+    notification.innerHTML = `
+      <div class="notification-content">
+        <span class="notification-message">${message}</span>
+        <button class="notification-close">&times;</button>
+      </div>
+    `;
+    
+    // Add to page
+    document.body.appendChild(notification);
+    
+    // Auto remove after 5 seconds
+    setTimeout(() => {
+      if (notification.parentNode) {
+        notification.remove();
+      }
+    }, 5000);
+    
+    // Close button
+    notification.querySelector('.notification-close').addEventListener('click', () => {
+      notification.remove();
+    });
+  }
+
   // Expose functions globally
   window.__sb_open_quiz_setup = openQuizSetup;
   window.__sb_close_quiz_setup = closeQuizSetup;

static/styles.css

@@ -2428,14 +2428,36 @@
 
 /* Quiz Styles */
 .quiz-modal-content {
-  max-width: 800px;
+  max-width: 900px;
   width: 90vw;
   max-height: 90vh;
   overflow-y: auto;
+  animation: slideInUp 0.3s ease-out;
+}
+
+@keyframes slideInUp {
+  from {
+    opacity: 0;
+    transform: translateY(30px);
+  }
+  to {
+    opacity: 1;
+    transform: translateY(0);
+  }
 }
 
 .quiz-step {
   margin-bottom: 24px;
+  opacity: 0;
+  transform: translateX(20px);
+  animation: fadeInSlide 0.4s ease-out forwards;
+}
+
+@keyframes fadeInSlide {
+  to {
+    opacity: 1;
+    transform: translateX(0);
+  }
 }
 
 .document-checkbox-list {
@@ -2515,8 +2537,26 @@
 .quiz-progress-fill {
   height: 100%;
   background: var(--gradient-accent);
-  transition: width 0.3s ease;
+  transition: width 0.5s cubic-bezier(0.4, 0, 0.2, 1);
   width: 0%;
+  position: relative;
+  overflow: hidden;
+}
+
+.quiz-progress-fill::after {
+  content: '';
+  position: absolute;
+  top: 0;
+  left: -100%;
+  width: 100%;
+  height: 100%;
+  background: linear-gradient(90deg, transparent, rgba(255, 255, 255, 0.3), transparent);
+  animation: progressShimmer 2s infinite;
+}
+
+@keyframes progressShimmer {
+  0% { left: -100%; }
+  100% { left: 100%; }
 }
 
 .quiz-progress-text {
@@ -2561,7 +2601,24 @@
   border: 2px solid var(--border);
   border-radius: var(--radius);
   cursor: pointer;
-  transition: all 0.2s ease;
+  transition: all 0.3s cubic-bezier(0.4, 0, 0.2, 1);
+  position: relative;
+  overflow: hidden;
+}
+
+.quiz-answer-option::before {
+  content: '';
+  position: absolute;
+  top: 0;
+  left: -100%;
+  width: 100%;
+  height: 100%;
+  background: linear-gradient(90deg, transparent, rgba(255, 255, 255, 0.1), transparent);
+  transition: left 0.5s ease;
+}
+
+.quiz-answer-option:hover::before {
+  left: 100%;
 }
 
 .quiz-answer-option:hover {
@@ -2657,6 +2714,20 @@
   letter-spacing: 0.5px;
 }
 
+.quiz-result-performance {
+  font-size: 12px;
+  font-weight: 600;
+  margin-top: 4px;
+  text-transform: uppercase;
+  letter-spacing: 0.5px;
+}
+
+.quiz-result-score {
+  border: 2px solid var(--border);
+  border-radius: var(--radius);
+  background: var(--card);
+}
+
 .quiz-result-questions {
   margin-top: 24px;
 }
@@ -2728,6 +2799,24 @@
   line-height: 1.5;
 }
 
+.quiz-result-answer-content.correct {
+  color: var(--success);
+  font-weight: 600;
+  background: rgba(16, 185, 129, 0.1);
+  padding: 8px;
+  border-radius: 4px;
+  border-left: 3px solid var(--success);
+}
+
+.quiz-result-answer-content.incorrect {
+  color: var(--error);
+  font-weight: 600;
+  background: rgba(239, 68, 68, 0.1);
+  padding: 8px;
+  border-radius: 4px;
+  border-left: 3px solid var(--error);
+}
+
 .quiz-result-explanation {
   margin-top: 12px;
   padding: 12px;
@@ -2758,4 +2847,81 @@
   .quiz-result-summary {
     grid-template-columns: 1fr;
   }
+}
+
+/* Notification Styles */
+.notification {
+  position: fixed;
+  top: 20px;
+  right: 20px;
+  z-index: 10000;
+  max-width: 400px;
+  padding: 16px;
+  border-radius: var(--radius);
+  box-shadow: var(--shadow-lg);
+  animation: slideInRight 0.3s ease-out;
+  border-left: 4px solid;
+}
+
+.notification-success {
+  background: var(--card);
+  border-left-color: var(--success);
+  color: var(--text);
+}
+
+.notification-error {
+  background: var(--card);
+  border-left-color: var(--error);
+  color: var(--text);
+}
+
+.notification-warning {
+  background: var(--card);
+  border-left-color: var(--warning);
+  color: var(--text);
+}
+
+.notification-info {
+  background: var(--card);
+  border-left-color: var(--accent);
+  color: var(--text);
+}
+
+.notification-content {
+  display: flex;
+  align-items: center;
+  justify-content: space-between;
+  gap: 12px;
+}
+
+.notification-message {
+  flex: 1;
+  font-weight: 500;
+}
+
+.notification-close {
+  background: none;
+  border: none;
+  font-size: 18px;
+  cursor: pointer;
+  color: var(--text-secondary);
+  padding: 4px;
+  border-radius: 4px;
+  transition: all 0.2s ease;
+}
+
+.notification-close:hover {
+  background: var(--bg-secondary);
+  color: var(--text);
+}
+
+@keyframes slideInRight {
+  from {
+    opacity: 0;
+    transform: translateX(100%);
+  }
+  to {
+    opacity: 1;
+    transform: translateX(0);
+  }
 }