fix: fixed graphs display bugs

front/tabs/tab_ipcc.py

@@ -1,11 +1,9 @@
-from operator import index
 from random import choices
 import gradio as gr
-from typing import TypedDict, List, Optional
-import pandas as pd
-import os
+from typing import TypedDict
 from climateqa.engine.talk_to_data.main import ask_ipcc
-from climateqa.engine.talk_to_data.ipcc.config import IPCC_MODELS, IPCC_UI_TEXT
+from climateqa.engine.talk_to_data.ipcc.config import IPCC_MODELS, IPCC_SCENARIO, IPCC_UI_TEXT
+import uuid
 
 class ipccUIElements(TypedDict):
     tab: gr.Tab
@@ -30,6 +28,15 @@ async def ask_ipcc_query(query: str, index_state: int, user_id: str):
     result = await ask_ipcc(query, index_state, user_id)
     return result
 
+def hide_outputs():
+    """Hide all outputs initially."""
+    return (
+        gr.update(visible=True),  # Show the result text
+        gr.update(visible=False),  # Hide the query accordion
+        gr.update(visible=False),  # Hide the table accordion
+        gr.update(visible=False),  # Hide the chart accordion
+        gr.update(visible=False),  # Hide table names
+    )
 
 def show_results(sql_queries_state, dataframes_state, plots_state, table_names):
     if not sql_queries_state or not dataframes_state or not plots_state:
@@ -55,12 +62,15 @@ def show_results(sql_queries_state, dataframes_state, plots_state, table_names):
 def show_filter_by_scenario(table_names, index_state, dataframes):
     if len(table_names) > 0 and table_names[index_state].startswith("Choropleth Map"):
         df = dataframes[index_state]
-        return gr.update(visible=True, choices=sorted(df["scenario"].unique()), value=df["scenario"].unique()[0])
+        scenarios = sorted(df["scenario"].unique())
+        return gr.update(visible=True, choices=scenarios, value=scenarios[0])
     else:
         return gr.update(visible=False)
         
-def filter_by_scenario(dataframes, figures, index_state, scenario):
+def filter_by_scenario(dataframes, figures, table_names, index_state, scenario):
     df = dataframes[index_state]
+    if not table_names[index_state].startswith("Choropleth Map"):
+        return df, figures[index_state](df)
     if df.empty:
         return df, None
     if "scenario" not in df.columns:
@@ -82,6 +92,7 @@ def display_table_names(table_names, index_state):
 def on_table_click(selected_label, table_names, sql_queries, dataframes, plot_informations, plots):
     index = table_names.index(selected_label)
     figure = plots[index](dataframes[index])
+
     return (
         sql_queries[index],
         dataframes[index],
@@ -149,7 +160,7 @@ def create_ipcc_ui() -> ipccUIElements:
             
             with gr.Row():
                 scenario_selection = gr.Dropdown(
-                    label="Scenario", choices=IPCC_MODELS, value="ALL", interactive=True, visible=False
+                    label="Scenario", choices=IPCC_SCENARIO, value=IPCC_SCENARIO[0], interactive=True, visible=False
                 )
 
                 with gr.Accordion(label="Informations about the plot", open=False):
@@ -195,6 +206,13 @@ def setup_ipcc_events(ui_elements: ipccUIElements, share_client=None, user_id=No
     table_names_list = gr.State([])
     user_id = gr.State(user_id)
 
+    # Handle direct question submission - trigger the same workflow by setting examples_hidden
+    ui_elements["ipcc_direct_question"].submit(
+        lambda x: gr.update(value=x),
+        inputs=[ui_elements["ipcc_direct_question"]],
+        outputs=[ui_elements["examples_hidden"]],
+    )
+
     # Handle example selection
     ui_elements["examples_hidden"].change(
         lambda x: (gr.Accordion(open=False), gr.Textbox(value=x)),
@@ -205,49 +223,18 @@ def setup_ipcc_events(ui_elements: ipccUIElements, share_client=None, user_id=No
         inputs=None,
         outputs=ui_elements["image_examples"]
     ).then(
-        ask_ipcc_query,
-        inputs=[ui_elements["examples_hidden"], index_state, user_id],
-        outputs=[
-            ui_elements["ipcc_sql_query"],
-            ui_elements["ipcc_table"],
-            ui_elements["ipcc_display"],
-            ui_elements["plot_information"],
-            sql_queries_state,
-            dataframes_state,
-            plots_state,
-            plot_informations_state,
-            index_state,
-            table_names_list,
-            ui_elements["result_text"],
-        ],
-    ).then(
-        show_results,
-        inputs=[sql_queries_state, dataframes_state, plots_state, table_names_list],
+        hide_outputs,
+        inputs=None,
         outputs=[
             ui_elements["result_text"],
             ui_elements["query_accordion"],
             ui_elements["table_accordion"],
             ui_elements["chart_accordion"],
             ui_elements["table_names_display"],
-        ],
-    ).then(
-        show_filter_by_scenario,
-        inputs=[table_names_list, index_state, dataframes_state],
-        outputs=[ui_elements["scenario_selection"]],
-    )
-
-    # Handle direct question submission
-    ui_elements["ipcc_direct_question"].submit(
-        lambda: gr.Accordion(open=False),
-        inputs=None,
-        outputs=[ui_elements["details_accordion"]]
-    ).then(
-        lambda: gr.update(visible=False),
-        inputs=None,
-        outputs=ui_elements["image_examples"]
+        ]
     ).then(
         ask_ipcc_query,
-        inputs=[ui_elements["ipcc_direct_question"], index_state, user_id],
+        inputs=[ui_elements["examples_hidden"], index_state, user_id],
         outputs=[
             ui_elements["ipcc_sql_query"],
             ui_elements["ipcc_table"],
@@ -275,12 +262,17 @@ def setup_ipcc_events(ui_elements: ipccUIElements, share_client=None, user_id=No
         show_filter_by_scenario,
         inputs=[table_names_list, index_state, dataframes_state],
         outputs=[ui_elements["scenario_selection"]],
+    ).then(
+        filter_by_scenario,
+        inputs=[dataframes_state, plots_state, table_names_list, index_state, ui_elements["scenario_selection"]],
+        outputs=[ui_elements["ipcc_table"], ui_elements["ipcc_display"]],
     )
 
+
     # Handle model selection change
     ui_elements["scenario_selection"].change(
         filter_by_scenario,
-        inputs=[dataframes_state, plots_state, index_state, ui_elements["scenario_selection"]],
+        inputs=[dataframes_state, plots_state, table_names_list, index_state, ui_elements["scenario_selection"]],
         outputs=[ui_elements["ipcc_table"], ui_elements["ipcc_display"]],
     )
 
@@ -293,8 +285,13 @@ def setup_ipcc_events(ui_elements: ipccUIElements, share_client=None, user_id=No
         show_filter_by_scenario,
         inputs=[table_names_list, index_state, dataframes_state],
         outputs=[ui_elements["scenario_selection"]],
+    ).then(
+        filter_by_scenario,
+        inputs=[dataframes_state, plots_state, table_names_list, index_state, ui_elements["scenario_selection"]],
+        outputs=[ui_elements["ipcc_table"], ui_elements["ipcc_display"]],
     )
 
+
 def create_ipcc_tab(share_client=None, user_id=None):
     """Create the ipcc tab with all its components and event handlers."""
     ui_elements = create_ipcc_ui()