clean up design

app.py

@@ -1,16 +1,3 @@
-# import os
-# _LOCAL_TMP = "/fsx/guilherme/tmp"
-# try:
-#     os.makedirs(_LOCAL_TMP, exist_ok=True)
-#     os.environ.setdefault("TMPDIR", _LOCAL_TMP)
-#     os.environ.setdefault("TEMP", _LOCAL_TMP)
-#     os.environ.setdefault("TMP", _LOCAL_TMP)
-#     _GRADIO_TMP = os.path.join(_LOCAL_TMP, "gradio")
-#     os.makedirs(_GRADIO_TMP, exist_ok=True)
-#     os.environ.setdefault("GRADIO_TEMP_DIR", _GRADIO_TMP)
-# except Exception:
-#     pass
-
 import gradio as gr
 from datatrove.pipeline.readers import ParquetReader
 from default_wiki_pipeline import _parse_and_clean_wikicode, mwparserfromhell
@@ -39,7 +26,7 @@ def matches_filters(doc, require_has_math: bool | None, require_has_infobox: boo
     meta = doc.metadata or {}
     if require_has_math and not bool(meta.get("has_math")):
         return False
-    if require_has_infobox and not meta.get("infoboxes"):
+    if require_has_infobox and not meta.get("infoboxes") and len(meta.get("infoboxes", [])) == 0:
         return False
     return True
 
@@ -243,6 +230,18 @@ def on_next(docs_cache, idx: int, reader_iter, require_has_math: bool, require_h
     return new_idx, docs_cache, reader_iter, left, left_meta, header, md, info, right
 
 
+SCROLL_TO_TOP_JS = """
+() => {
+  const ids = ["left_text_box", "right_markdown_box"]; 
+  for (const id of ids) {
+    const root = document.getElementById(id);
+    if (!root) continue;
+    const ta = root.querySelector('textarea');
+    if (ta) ta.scrollTop = 0;
+  }
+}
+"""
+
 with gr.Blocks() as demo:
     idx_state = gr.State(value=-1, time_to_live=900)
     docs_state = gr.State(value=[], time_to_live=900)
@@ -256,8 +255,6 @@ with gr.Blocks() as demo:
             with gr.Row():
                 prev_btn = gr.Button("Previous")
                 next_btn = gr.Button("Next")
-            left_text = gr.Textbox(label="FineWiki extraction", lines=30)
-            left_meta = gr.JSON(label="Metadata")
 
         with gr.Column():  
             with gr.Row():      
@@ -266,55 +263,40 @@ with gr.Blocks() as demo:
                 with gr.Column(scale=1):
                     require_has_math = gr.Checkbox(label="Has math", value=False)
                     require_has_infobox = gr.Checkbox(label="Has infobox", value=False)
+    with gr.Row():
+        with gr.Column():
+            with gr.Tab("FineWiki"):
+                left_text = gr.Textbox(label="FineWiki extraction", lines=30, elem_id="left_text_box")
+            with gr.Tab("Metadata"):
+                left_meta = gr.JSON(label="Metadata")
+            with gr.Tab("Infoboxes"):
+                right_infoboxes = gr.JSON(label="Infoboxes")
+            
+            with gr.Row():
+                prev_btn2 = gr.Button("Previous")
+                next_btn2 = gr.Button("Next")
+        with gr.Column():
             with gr.Tab("Preview"):
                 right_iframe = gr.HTML(label="Original Page")
             with gr.Tab("wikimedia/wikipedia"):
-                right_markdown = gr.Textbox(label="wikimedia/wikipedia extraction", lines=30)
-            right_infoboxes = gr.JSON(label="Infoboxes")
-
-
-
-    # with gr.Row():
-    #     with gr.Column(scale=1):
-    #         language_select = gr.Dropdown(choices=lang_list, value="en", label="Language")
-    #     with gr.Column(scale=1):
-    #         require_has_math = gr.Checkbox(label="Has math", value=False)
-    #         require_has_infobox = gr.Checkbox(label="Has infobox", value=False)
-    # with gr.Row():
-    #     with gr.Column():
-    #         with gr.Row():
-    #             prev_btn = gr.Button("Previous")
-    #             next_btn = gr.Button("Next")
-    #     with gr.Column():
-    #         header_md = gr.Markdown()
-    #         # with gr.Row():
-    #         #     id_input = gr.Textbox(label="Wikidata ID/URL/Page ID", placeholder="e.g., Q42 or https://... or 12345", lines=1)
-    #         #     find_btn = gr.Button("Find")
-    #         # with gr.Row():
-    #             # show_preview = gr.Checkbox(label="Show preview", value=True)
-    #             # show_wiki = gr.Checkbox(label="Show `wikimedia/wikipedia` extraction", value=False)
-    #             # show_infoboxes = gr.Checkbox(label="Show infoboxes", value=True)
-    # with gr.Row():
-    #     with gr.Column():
-    #         left_text = gr.Textbox(label="FineWiki extraction", lines=30)
-    #         left_meta = gr.JSON(label="Metadata")
-    #     with gr.Column():
-    #         with gr.Tab("Preview"):
-    #             right_iframe = gr.HTML(label="Original Page")
-    #         with gr.Tab("wikimedia/wikipedia"):
-    #             right_markdown = gr.Textbox(label="wikimedia/wikipedia extraction", lines=30)
-    #         right_infoboxes = gr.JSON(label="Infoboxes")
-
-    language_select.change(on_select_language, inputs=[language_select, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
-    demo.load(on_select_language, inputs=[language_select, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
+                right_markdown = gr.Textbox(label="wikimedia/wikipedia extraction", lines=30, elem_id="right_markdown_box")
+
+
+    _ev1 = language_select.change(on_select_language, inputs=[language_select, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
+    _ev1.then(js=SCROLL_TO_TOP_JS)
+    _ev2 = demo.load(on_select_language, inputs=[language_select, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
+    _ev2.then(js=SCROLL_TO_TOP_JS)
     # find_btn.click(on_find, inputs=[docs_state, idx_state, iter_state, id_input, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
 
     # Visibility toggles driven directly by checkbox changes
-    # show_wiki.change(lambda v: gr.update(visible=v), inputs=[show_wiki], outputs=[right_markdown])
-    # show_preview.change(lambda v: gr.update(visible=v), inputs=[show_preview], outputs=[right_iframe])
-    # show_infoboxes.change(lambda v: gr.update(visible=v), inputs=[show_infoboxes], outputs=[right_infoboxes])
-    prev_btn.click(on_prev, inputs=[docs_state, idx_state, iter_state, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
-    next_btn.click(on_next, inputs=[docs_state, idx_state, iter_state, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
+    _ev4 = prev_btn.click(on_prev, inputs=[docs_state, idx_state, iter_state, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
+    _ev4.then(js=SCROLL_TO_TOP_JS)
+    _ev5 = next_btn.click(on_next, inputs=[docs_state, idx_state, iter_state, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
+    _ev5.then(js=SCROLL_TO_TOP_JS)
+    _ev4 = prev_btn2.click(on_prev, inputs=[docs_state, idx_state, iter_state, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
+    _ev4.then(js=SCROLL_TO_TOP_JS)
+    _ev5 = next_btn2.click(on_next, inputs=[docs_state, idx_state, iter_state, require_has_math, require_has_infobox], outputs=[idx_state, docs_state, iter_state, left_text, left_meta, header_md, right_markdown, right_infoboxes, right_iframe], concurrency_limit=1)
+    _ev5.then(js=SCROLL_TO_TOP_JS)
 
     # Enable global queue to coordinate concurrent requests safely
     demo.queue(default_concurrency_limit=1, max_size=128)