add revision textbox

.gitignore

@@ -1 +1,2 @@
 app_ref.py
+DemoFeedback/

app.py

@@ -1,6 +1,6 @@
 import gradio as gr
 import random
-from datasets import load_dataset
+from datasets import load_dataset, Features, Value
 import json 
 import os
 import uuid
@@ -23,10 +23,10 @@ import time
 
 truth_data = load_dataset("commonsense-index-dev/commonsense-candidates", "iter7-0520", split="train")
 
-logs = load_dataset("commonsense-index-dev/DemoFeedback", split="train")
-
 LAST_LOG_UPDATE = time.time()
 
+logs = None 
+
 qa_dataset = {}
 for item in truth_data:
     qa_dataset[item["id"]] = {
@@ -40,8 +40,8 @@ for item in truth_data:
 def update_logs():
     global LAST_LOG_UPDATE
     global logs
-    if time.time() - LAST_LOG_UPDATE > 1800:
-        # update logs for every 30 minutes
+    if logs is None or time.time() - LAST_LOG_UPDATE > 3600:
+        # update logs for every 60 minutes 
         logs = load_dataset("commonsense-index-dev/DemoFeedback", split="train")
         LAST_LOG_UPDATE = time.time()
 
@@ -105,7 +105,7 @@ def show_buttons(choices_markdown):
     return visibility
 
 
-def submit_feedback(question_id, user_reason, example_quality, user_name_text):
+def submit_feedback(question_id, user_reason, user_revision, example_quality, user_name_text):
     if "N/A" in question_id or "N/A" in example_quality:
         # send a message to the user to sample an example and select a choice first 
         return {
@@ -118,6 +118,7 @@ def submit_feedback(question_id, user_reason, example_quality, user_name_text):
         "question_id": question_id,
         "user_name": user_name_text, 
         "user_reason": user_reason,
+        "revision": user_revision,
         "example_quality": example_quality,
     }
     jsonl_str = json.dumps(feedback_item)
@@ -146,7 +147,7 @@ def submit_feedback(question_id, user_reason, example_quality, user_name_text):
     }   
 
 def refresh_feedback(question_id):
-    return gr.update(value="", visible=True), gr.update(value="", visible=True), gr.update(value="", visible=True)
+    return gr.update(value="", visible=True), gr.update(value="", visible=True), gr.update(value="", visible=True), gr.update(value="", visible=True)
 
 with gr.Blocks() as app:
     gr.Markdown("# Commonsense Index Data Viewer")
@@ -166,7 +167,8 @@ with gr.Blocks() as app:
 
     with gr.Row():
         with gr.Column(scale=2):
-            reason_textbox = gr.Textbox(label="Reason", placeholder="Please talk why the correct answer is correct and why the others are wrong. If you think this is a bad example, please explain too.", type="text", elem_classes="", max_lines=5, lines=5, show_copy_button=False, visible=True, scale=4, interactive=True)
+            reason_textbox = gr.Textbox(label="Reason", placeholder="Please talk why the correct answer is correct and why the others are wrong. If you think this is a bad example, please explain too.", type="text", elem_classes="", max_lines=5, lines=3, show_copy_button=False, visible=True, scale=4, interactive=True)
+            revision_textbox = gr.Textbox(label="Revision", placeholder="Please suggest a revision to the question.", type="text", elem_classes="", max_lines=5, lines=3, show_copy_button=False, visible=True, scale=4, interactive=True)
         with gr.Column():
             example_quality = gr.Radio(label="Quality", choices=["Good", "Bad"], interactive=True, visible=True)
             user_name = gr.Textbox(label="Your username", placeholder="Your username", type="text", elem_classes="", max_lines=1, show_copy_button=False, visible=True, interactive=True, show_label=False)
@@ -175,8 +177,8 @@ with gr.Blocks() as app:
      
     random_button.click(fn=load_question, inputs=[user_name], outputs=[question_id, question_display, choices_markdown, result_display, reasoning_display, example_quality, submit_button])
     choices_markdown.change(fn=show_buttons, inputs=choices_markdown, outputs=choice_buttons)
-    question_id.change(fn=refresh_feedback, inputs=[question_id], outputs=[reason_textbox, example_quality])
-    submit_button.click(fn=submit_feedback, inputs=[question_id, reason_textbox, example_quality, user_name], outputs=[submit_button])
+    question_id.change(fn=refresh_feedback, inputs=[question_id], outputs=[reason_textbox, revision_textbox, example_quality])
+    submit_button.click(fn=submit_feedback, inputs=[question_id, reason_textbox, revision_textbox, example_quality, user_name], outputs=[submit_button])
     for i, button in enumerate(choice_buttons):
         button.click(fn=check_answer, inputs=[question_id, button, reasoning_display], outputs=result_display)
 

revise_feedback_jsons.py

@@ -0,0 +1,28 @@
+import json
+import os
+
+# Directory containing the JSON files
+directory = 'DemoFeedback'
+
+# Check each file in the directory
+for filename in os.listdir(directory):
+    if filename.endswith('.json'):
+        file_path = os.path.join(directory, filename)
+        
+        # Open and load the JSON file
+        with open(file_path, 'r+') as file:
+            data = json.load(file)
+            
+            # Check if 'revision' field is missing
+            if 'revision' not in data:
+                data['revision'] = 'N/A'
+                
+                # Move the file pointer to the beginning of the file
+                file.seek(0)
+                # Write the updated data
+                json.dump(data, file, indent=4)
+                # Truncate the file to the new data length
+                file.truncate()
+                print(f"Updated file: {filename}")
+
+print("Files have been checked and updated as needed.")