Add persona usage check so deletions archive in-use personas

src/routes/api/personas/[personaId]/usage/+server.ts

@@ -0,0 +1,37 @@
+import { collections } from "$lib/server/database";
+import { authCondition } from "$lib/server/auth";
+import { z } from "zod";
+
+export async function GET({ locals, params }) {
+	if (!locals.user && !locals.sessionId) {
+		return Response.json({ message: "Unauthorized" }, { status: 401 });
+	}
+
+	const personaId = z.string().min(1).parse(params.personaId);
+	const condition = authCondition(locals);
+
+	const settings = await collections.settings.findOne(
+		{ ...condition, "personas.id": personaId },
+		{ projection: { _id: 1 } }
+	);
+
+	if (!settings) {
+		return Response.json({ message: "Persona not found" }, { status: 404 });
+	}
+
+	const personaUsed = await collections.conversations.findOne(
+		{
+			...condition,
+			$or: [
+				{ personaId },
+				{ branchedFromPersonaId: personaId },
+				{ lockedPersonaId: personaId },
+				{ "messages.personaResponses.personaId": personaId },
+				{ "messages.personaResponses.children.personaId": personaId },
+			],
+		},
+		{ projection: { _id: 1 } }
+	);
+
+	return Response.json({ used: Boolean(personaUsed) });
+}

src/routes/settings/(nav)/personas/[...persona]/+page.svelte

@@ -58,7 +58,7 @@
 		}
 	}
 
-	function deletePersona() {
+	async function deletePersona() {
 		if (!selectedPersona) return;
 
 		// Can't delete if it's locked
@@ -84,23 +84,42 @@
 				`Are you sure you want to remove "${selectedPersona.name}"? Past responses will continue to show their persona details, but this persona will be hidden from future use.`
 			)
 		) {
-			const remainingPersona = $settings.personas.find(
-				(persona) => !persona.archived && persona.id !== selectedPersona.id
-			);
+			try {
+				const usageResponse = await fetch(
+					`${base}/api/personas/${selectedPersona.id}/usage`
+				);
 
-			$settings.personas = $settings.personas.map((persona) =>
-				persona.id === selectedPersona.id
-					? { ...persona, archived: true, updatedAt: new Date() }
-					: persona
-			);
+				if (!usageResponse.ok) {
+					alert("Unable to delete persona right now. Please try again later.");
+					return;
+				}
 
-			const filteredActive = $settings.activePersonas.filter((id) => id !== selectedPersona.id);
-			if (filteredActive.length !== $settings.activePersonas.length) {
-				void settings.instantSet({ activePersonas: filteredActive });
-			}
+				const { used } = (await usageResponse.json()) as { used: boolean };
+				const now = new Date();
+				const filteredActive = $settings.activePersonas.filter((id) => id !== selectedPersona.id);
+				const updatedPersonas = used
+					? $settings.personas.map((persona) =>
+							persona.id === selectedPersona.id
+								? { ...persona, archived: true, updatedAt: now }
+								: persona
+					  )
+					: $settings.personas.filter((persona) => persona.id !== selectedPersona.id);
+
+				await settings.instantSet({
+					personas: updatedPersonas,
+					activePersonas: filteredActive,
+				});
 
-			const targetId = remainingPersona?.id ?? $settings.personas.find((p) => !p.archived)?.id ?? "";
-			goto(`${base}/settings/personas/${targetId}`);
+				const nextCandidate = updatedPersonas.find(
+					(persona) => !persona.archived && persona.id !== selectedPersona.id
+				);
+				const fallbackPersona = updatedPersonas.find((persona) => !persona.archived)?.id ?? "";
+				const targetId = nextCandidate?.id ?? fallbackPersona;
+				goto(`${base}/settings/personas/${targetId}`);
+			} catch (error) {
+				console.error("Failed to delete persona", error);
+				alert("Unable to delete persona right now. Please try again later.");
+			}
 		}
 	}