revert assignment_id change, clean up a comment, fix turk qualifying test bug

app.py

@@ -95,12 +95,12 @@ model_id2model = {chatbot.llm.repo_id: chatbot for chatbot in chatbots}
 demo = gr.Blocks()
 
 with demo:
-    dummy = gr.Textbox(visible=False)  # dummy for passing assignment_id
+    dummy = gr.Textbox(visible=False)  # dummy for passing assignmentId
 
     # We keep track of state as a JSON
     state_dict = {
         "conversation_id": str(uuid.uuid4()),
-        "assignment_id": "",
+        "assignmentId": "",
         "cnt": 0, "data": [],
         "past_user_inputs": [],
         "generated_responses": [],
@@ -149,17 +149,17 @@ with demo:
             # submitted everything now.
             with open(DATA_FILE, "a") as jsonlfile:
                 json_data_with_assignment_id =\
-                    [json.dumps(dict({"assignment_id": state["assignment_id"], "conversation_id": state["conversation_id"]}, **datum)) for datum in state["data"]]
+                    [json.dumps(dict({"assignmentId": state["assignmentId"], "conversation_id": state["conversation_id"]}, **datum)) for datum in state["data"]]
                 jsonlfile.write("\n".join(json_data_with_assignment_id) + "\n")
         toggle_example_submit = gr.update(visible=not done)
         past_conversation_string = "<br />".join(["<br />".join(["😃: " + user_input, "🤖: " + model_response]) for user_input, model_response in zip(state["past_user_inputs"], state["generated_responses"])])
         query = parse_qs(dummy[1:])
-        if "assignment_id" in query and query["assignment_id"][0] != "ASSIGNMENT_ID_NOT_AVAILABLE":
+        if "assignmentId" in query and query["assignmentId"][0] != "ASSIGNMENT_ID_NOT_AVAILABLE":
             # It seems that someone is using this app on mturk. We need to
-            # store the assignment_id in the state before submit_hit_button
+            # store the assignmentId in the state before submit_hit_button
             # is clicked. We can do this here in _predict. We need to save the
-            # assignment_id so that the turker can get credit for their HIT.
-            state["assignment_id"] = query["assignment_id"][0]
+            # assignmentId so that the turker can get credit for their HIT.
+            state["assignmentId"] = query["assignmentId"][0]
             toggle_final_submit = gr.update(visible=done)
             toggle_final_submit_preview = gr.update(visible=False)
         else:
@@ -214,7 +214,7 @@ with demo:
 
     post_hit_js = """
         function(state) {
-            // If there is an assignment_id, then the submitter is on mturk
+            // If there is an assignmentId, then the submitter is on mturk
             // and has accepted the HIT. So, we need to submit their HIT.
             const form = document.createElement('form');
             form.action = 'https://workersandbox.mturk.com/mturk/externalSubmit';

collect.py

@@ -1,6 +1,3 @@
-# Basic example for running MTurk data collection against a Space
-# For more information see https://docs.aws.amazon.com/mturk/index.html
-
 import boto3
 from boto.mturk.question import ExternalQuestion
 
@@ -45,11 +42,11 @@ question = ExternalQuestion(f"https://hf.space/embed/{args.space_name}/+?__theme
 qualification_type_id = open("qualification_type_id.txt", "r").read() if path.exists("qualification_type_id.txt") else None
 if args.refresh_qualification_test or qualification_type_id is None:
     if qualification_type_id is not None:
-        client.delete_qualification_type(
-            QualificationTypeId='string'
+        mturk.delete_qualification_type(
+            QualificationTypeId=qualification_type_id
         )
     response = mturk.create_qualification_type(
-        Name='rlhf-qualification',
+        Name='rlhf--qualification',
         Keywords='RLHF qualification',
         Description='Qualification test for RLHF task.',
         QualificationTypeStatus='Active',