Update tests, width/height must be set now.

lynxkite-app/tests/test_main.py

@@ -44,6 +44,8 @@ def test_save_and_load():
                         "params": {"param1": "value"},
                     },
                     "position": {"x": -493.5496596237119, "y": 20.90123252513356},
+                    "width": 100,
+                    "height": 100,
                 }
             ],
             "edges": [],

lynxkite-core/src/lynxkite/core/workspace.py

@@ -203,27 +203,27 @@ class Workspace(BaseConfig):
                     nc["data"] = pycrdt.Map()
                 np._crdt = nc
 
-    def add_node(self, func):
+    def add_node(self, func=None, **kwargs):
         """For convenience in e.g. tests."""
         random_string = os.urandom(4).hex()
-        node = WorkspaceNode(
-            id=f"{func.__op__.name} {random_string}",
-            type=func.__op__.type,
-            data=WorkspaceNodeData(
-                title=func.__op__.name,
-                params={},
-                display=None,
-                input_metadata=None,
-                error=None,
-                status=NodeStatus.planned,
-            ),
-            position=Position(x=0, y=0),
-        )
+        if func:
+            kwargs["type"] = func.__op__.type
+            kwargs["data"] = WorkspaceNodeData(title=func.__op__.name, params={})
+        kwargs.setdefault("type", "basic")
+        kwargs.setdefault("id", f"{kwargs['data'].title} {random_string}")
+        kwargs.setdefault("position", Position(x=0, y=0))
+        kwargs.setdefault("width", 100)
+        kwargs.setdefault("height", 100)
+        node = WorkspaceNode(**kwargs)
         self.nodes.append(node)
         return node
 
     def add_edge(
-        self, source: WorkspaceNode, sourceHandle: str, target: WorkspaceNode, targetHandle: str
+        self,
+        source: WorkspaceNode,
+        sourceHandle: str,
+        target: WorkspaceNode,
+        targetHandle: str,
     ):
         """For convenience in e.g. tests."""
         edge = WorkspaceEdge(

lynxkite-core/tests/test_workspace.py

@@ -6,21 +6,15 @@ from lynxkite.core import workspace
 
 def test_save_load():
     ws = workspace.Workspace(env="test")
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="1",
-            type="node_type",
-            data=workspace.WorkspaceNodeData(title="Node 1", params={}),
-            position=workspace.Position(x=0, y=0),
-        )
+    ws.add_node(
+        id="1",
+        type="node_type",
+        data=workspace.WorkspaceNodeData(title="Node 1", params={}),
     )
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="2",
-            type="node_type",
-            data=workspace.WorkspaceNodeData(title="Node 2", params={}),
-            position=workspace.Position(x=0, y=0),
-        )
+    ws.add_node(
+        id="2",
+        type="node_type",
+        data=workspace.WorkspaceNodeData(title="Node 2", params={}),
     )
     ws.edges.append(
         workspace.WorkspaceEdge(
@@ -72,21 +66,15 @@ def populate_ops_catalog():
 
 def test_update_metadata():
     ws = workspace.Workspace(env="test")
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="1",
-            type="basic",
-            data=workspace.WorkspaceNodeData(title="Test Operation", params={}),
-            position=workspace.Position(x=0, y=0),
-        )
+    ws.add_node(
+        id="1",
+        type="basic",
+        data=workspace.WorkspaceNodeData(title="Test Operation", params={}),
     )
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="2",
-            type="basic",
-            data=workspace.WorkspaceNodeData(title="Unknown Operation", params={}),
-            position=workspace.Position(x=0, y=0),
-        )
+    ws.add_node(
+        id="2",
+        type="basic",
+        data=workspace.WorkspaceNodeData(title="Unknown Operation", params={}),
     )
     ws.update_metadata()
     assert ws.nodes[0].data.meta.name == "Test Operation"

lynxkite-graph-analytics/tests/test_lynxkite_ops.py

@@ -8,13 +8,11 @@ from lynxkite_graph_analytics.core import Bundle, execute, ENV
 
 async def test_execute_operation_not_in_catalog():
     ws = workspace.Workspace(env=ENV)
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="1",
-            type="node_type",
-            data=workspace.WorkspaceNodeData(title="Non existing op", params={}),
-            position=workspace.Position(x=0, y=0),
-        )
+    ws.add_node(
+        id="1",
+        type="node_type",
+        data=workspace.WorkspaceNodeData(title="Non existing op", params={}),
+        position=workspace.Position(x=0, y=0),
     )
     await execute(ws)
     assert ws.nodes[0].data.error == "Operation not found in catalog"
@@ -43,37 +41,29 @@ async def test_execute_operation_inputs_correct_cast():
         return bundle
 
     ws = workspace.Workspace(env="test")
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="1",
-            type="node_type",
-            data=workspace.WorkspaceNodeData(title="Create Bundle", params={}),
-            position=workspace.Position(x=0, y=0),
-        )
+    ws.add_node(
+        id="1",
+        type="node_type",
+        data=workspace.WorkspaceNodeData(title="Create Bundle", params={}),
+        position=workspace.Position(x=0, y=0),
     )
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="2",
-            type="node_type",
-            data=workspace.WorkspaceNodeData(title="Bundle to Graph", params={}),
-            position=workspace.Position(x=100, y=0),
-        )
+    ws.add_node(
+        id="2",
+        type="node_type",
+        data=workspace.WorkspaceNodeData(title="Bundle to Graph", params={}),
+        position=workspace.Position(x=100, y=0),
     )
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="3",
-            type="node_type",
-            data=workspace.WorkspaceNodeData(title="Graph to Bundle", params={}),
-            position=workspace.Position(x=200, y=0),
-        )
+    ws.add_node(
+        id="3",
+        type="node_type",
+        data=workspace.WorkspaceNodeData(title="Graph to Bundle", params={}),
+        position=workspace.Position(x=200, y=0),
     )
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="4",
-            type="node_type",
-            data=workspace.WorkspaceNodeData(title="Dataframe to Bundle", params={}),
-            position=workspace.Position(x=300, y=0),
-        )
+    ws.add_node(
+        id="4",
+        type="node_type",
+        data=workspace.WorkspaceNodeData(title="Dataframe to Bundle", params={}),
+        position=workspace.Position(x=300, y=0),
     )
     ws.edges = [
         workspace.WorkspaceEdge(
@@ -109,29 +99,23 @@ async def test_multiple_inputs():
         return a < b
 
     ws = workspace.Workspace(env="test")
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="one",
-            type="cool",
-            data=workspace.WorkspaceNodeData(title="One", params={}),
-            position=workspace.Position(x=0, y=0),
-        )
+    ws.add_node(
+        id="one",
+        type="cool",
+        data=workspace.WorkspaceNodeData(title="One", params={}),
+        position=workspace.Position(x=0, y=0),
     )
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="two",
-            type="cool",
-            data=workspace.WorkspaceNodeData(title="Two", params={}),
-            position=workspace.Position(x=100, y=0),
-        )
+    ws.add_node(
+        id="two",
+        type="cool",
+        data=workspace.WorkspaceNodeData(title="Two", params={}),
+        position=workspace.Position(x=100, y=0),
     )
-    ws.nodes.append(
-        workspace.WorkspaceNode(
-            id="smaller",
-            type="cool",
-            data=workspace.WorkspaceNodeData(title="Smaller?", params={}),
-            position=workspace.Position(x=200, y=0),
-        )
+    ws.add_node(
+        id="smaller",
+        type="cool",
+        data=workspace.WorkspaceNodeData(title="Smaller?", params={}),
+        position=workspace.Position(x=200, y=0),
     )
     ws.edges = [
         workspace.WorkspaceEdge(

lynxkite-graph-analytics/tests/test_pytorch_model_ops.py

@@ -9,16 +9,9 @@ def make_ws(env, nodes: dict[str, dict], edges: list[tuple[str, str]]):
     for id, data in nodes.items():
         title = data["title"]
         del data["title"]
-        ws.nodes.append(
-            workspace.WorkspaceNode(
-                id=id,
-                type="basic",
-                data=workspace.WorkspaceNodeData(title=title, params=data),
-                position=workspace.Position(
-                    x=data.get("x", 0),
-                    y=data.get("y", 0),
-                ),
-            )
+        ws.add_node(
+            id=id,
+            data=workspace.WorkspaceNodeData(title=title, params=data),
         )
     ws.edges = [
         workspace.WorkspaceEdge(