fix-trust-remote-code (#1044)

- Refactor model service status mapping and improve validation logs (5ccae0d3fab066f240f805c2965edd89c076f5ec)
- Improve error messages for model validation and gated model handling (d852c46e7b27e6c80ba20422143e8631c4ced3ef)
- Add python-dotenv dependency to backend configuration (eb6e17b451246174a4b6135e210a958130ff9a2f)
- Add datetime module (741988b8e01f511c6cd1f8826871f5931e94b10a)
- Fix weight types (682889985c337f827df7fdb6b43370932a3acc45)

backend/app/services/models.py

@@ -9,8 +9,7 @@ import asyncio
 import time
 from huggingface_hub import HfApi, CommitOperationAdd
 from huggingface_hub.utils import build_hf_headers
-import datasets
-from datasets import load_dataset, disable_progress_bar
+from datasets import disable_progress_bar
 import sys
 import contextlib
 from concurrent.futures import ThreadPoolExecutor
@@ -158,9 +157,9 @@ class ModelService(HuggingFaceService):
             status = content.get("status", "PENDING").upper()
             target_status = None
             status_map = {
-                "PENDING": ["PENDING", "RERUN"],
+                "PENDING": ["PENDING"],
                 "EVALUATING": ["RUNNING"],
-                "FINISHED": ["FINISHED", "PENDING_NEW_EVAL"]
+                "FINISHED": ["FINISHED"]
             }
             
             for target, source_statuses in status_map.items():
@@ -425,6 +424,17 @@ class ModelService(HuggingFaceService):
             logger.error(LogFormatter.error("Failed to check existing submissions", e))
             raise
 
+        # Check that model on hub and valid
+        valid, error, model_config = await self.validator.is_model_on_hub(
+            model_data["model_id"], 
+            model_data["revision"], 
+            test_tokenizer=True
+        )
+        if not valid:
+            logger.error(LogFormatter.error("Model on hub validation failed", error))
+            raise Exception(error)
+        logger.info(LogFormatter.success("Model on hub validation passed"))
+
         # Validate model card
         valid, error, model_card = await self.validator.check_model_card(
             model_data["model_id"]
@@ -541,7 +551,7 @@ class ModelService(HuggingFaceService):
 
         return {
             "status": "success",
-            "message": "Model submitted successfully and vote recorded"
+            "message": "The model was submitted successfully, and the vote has been recorded"
         }
 
     async def get_model_status(self, model_id: str) -> Dict[str, Any]:

backend/app/utils/model_validation.py

@@ -196,15 +196,15 @@ class ModelValidator:
                         token=self.token
                     )
                 except ValueError as e:
-                    return False, f"uses a tokenizer which is not in a transformers release: {e}", None
+                    return False, f"The tokenizer is not available in an official Transformers release: {e}", None
                 except Exception:
-                    return False, "'s tokenizer cannot be loaded. Is your tokenizer class in a stable transformers release, and correctly configured?", None
+                    return False, "The tokenizer cannot be loaded. Ensure the tokenizer class is part of a stable Transformers release and correctly configured.", None
             
             return True, None, config
             
         except ValueError:
-            return False, "needs to be launched with `trust_remote_code=True`. For safety reason, we do not allow these models to be automatically submitted to the leaderboard.", None
+            return False, "The model requires `trust_remote_code=True` to launch, and for safety reasons, we don't accept such models automatically.", None
         except Exception as e:
             if "You are trying to access a gated repo." in str(e):
-                return True, "uses a gated model.", None
-            return False, f"was not found or misconfigured on the hub! Error raised was {e.args[0]}", None
+                return True, "The model is gated and requires special access permissions.", None
+            return False, f"The model was not found or is misconfigured on the Hub. Error: {e.args[0]}", None

backend/pyproject.toml

@@ -18,6 +18,7 @@ transformers = "^4.47.0"
 safetensors = "^0.4.5"
 aiofiles = "^24.1.0"
 fastapi-cache2 = "^0.2.1"
+python-dotenv = "^1.0.1"
 
 [tool.poetry.group.dev.dependencies]
 pytest = "^8.3.4"

backend/utils/analyze_prod_models.py

@@ -1,6 +1,7 @@
 import os
 import json
 import logging
+from datetime import datetime
 from pathlib import Path
 from huggingface_hub import HfApi
 from dotenv import load_dotenv

frontend/src/pages/AddModelPage/components/ModelSubmissionForm/ModelSubmissionForm.js

@@ -26,9 +26,9 @@ import { SUBMISSION_PRECISIONS } from "../../../../pages/LeaderboardPage/compone
 import AuthContainer from "../../../../components/shared/AuthContainer";
 
 const WEIGHT_TYPES = [
-  { value: "original", label: "Original" },
-  { value: "delta", label: "Delta" },
-  { value: "adapter", label: "Adapter" },
+  { value: "Original", label: "Original" },
+  { value: "Delta", label: "Delta" },
+  { value: "Adapter", label: "Adapter" },
 ];
 
 const HELP_TEXTS = {