id
int64 1
37.7k
| comment_id
int64 12.6M
18M
| issue_id
stringlengths 1
4
| user
stringlengths 1
30
| body
stringlengths 1
101k
| created_at
stringdate 2008-06-06 18:03:50-0400
2025-10-01 11:49:43-0400
| updated_at
stringdate 2008-06-06 18:03:50-0400
2025-10-01 11:49:43-0400
| metadata
stringlengths 1.46k
208k
|
|---|---|---|---|---|---|---|---|
1
| 12,608,625
|
47
|
Andrew Kornev
|
But that's exactly what the do_io does! It check if the zhandle_t state is unrecoverable and terminates if it is.
|
2008-06-26T20:05:58.511000-04:00
|
2008-06-26T20:05:58.511000-04:00
|
{"id": 12608625, "body": "But that's exactly what the do_io does! It check if the zhandle_t state is unrecoverable and terminates if it is.", "user": "Andrew Kornev", "created_at": "2008-06-26T20:05:58.511000-04:00", "updated_at": "2008-06-26T20:05:58.511000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398543/comment/12608625", "id": "12608625", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "But that's exactly what the do_io does! It check if the zhandle_t state is unrecoverable and terminates if it is.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-06-27T00:05:58.511+0000", "updated": "2008-06-27T00:05:58.511+0000"}}
|
2
| 12,608,797
|
47
|
Benjamin Reed
|
You're right. I was reading the code wrong.
|
2008-06-27T10:57:22.470000-04:00
|
2008-06-27T10:57:22.470000-04:00
|
{"id": 12608797, "body": "You're right. I was reading the code wrong.", "user": "Benjamin Reed", "created_at": "2008-06-27T10:57:22.470000-04:00", "updated_at": "2008-06-27T10:57:22.470000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398543/comment/12608797", "id": "12608797", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=breed", "name": "breed", "key": "breed", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Benjamin Reed", "active": true, "timeZone": "America/Los_Angeles"}, "body": "You're right. I was reading the code wrong.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=breed", "name": "breed", "key": "breed", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Benjamin Reed", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-06-27T14:57:22.470+0000", "updated": "2008-06-27T14:57:22.470+0000"}}
|
3
| 12,610,414
|
66
|
Anthony Urso
|
Patch attached.
|
2008-07-03T21:53:42.075000-04:00
|
2008-07-03T21:53:42.075000-04:00
|
{"id": 12610414, "body": "Patch attached.", "user": "Anthony Urso", "created_at": "2008-07-03T21:53:42.075000-04:00", "updated_at": "2008-07-03T21:53:42.075000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399583/comment/12610414", "id": "12610414", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=anthonyu", "name": "anthonyu", "key": "anthonyu", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Anthony Urso", "active": true, "timeZone": "Etc/UTC"}, "body": "Patch attached.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=anthonyu", "name": "anthonyu", "key": "anthonyu", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Anthony Urso", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-04T01:53:42.075+0000", "updated": "2008-07-04T01:53:42.075+0000"}}
|
4
| 12,610,417
|
66
|
Anthony Urso
|
Patch attached again.
|
2008-07-03T22:02:19.894000-04:00
|
2008-07-03T22:02:19.894000-04:00
|
{"id": 12610417, "body": "Patch attached again.", "user": "Anthony Urso", "created_at": "2008-07-03T22:02:19.894000-04:00", "updated_at": "2008-07-03T22:02:19.894000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399583/comment/12610417", "id": "12610417", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=anthonyu", "name": "anthonyu", "key": "anthonyu", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Anthony Urso", "active": true, "timeZone": "Etc/UTC"}, "body": "Patch attached again.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=anthonyu", "name": "anthonyu", "key": "anthonyu", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Anthony Urso", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-04T02:02:19.894+0000", "updated": "2008-07-04T02:02:19.894+0000"}}
|
5
| 12,610,748
|
66
|
Flavio Paiva Junqueira
|
I'm not entirely convinced that this is a good idea. The watcher is important for the communication between ZooKeeper and the client, and I can understand if you want to use a null watcher in the case you're implementing a quick program for debugging or perhaps test purposes, but in such cases implementing the Watcher interface and declaring a process method that does nothing doesn't seem like a huge burden to me.
I'm affraid that by adding a null watcher, we'll give the impression to users that implementing a Watcher is not that important.
|
2008-07-06T08:42:10.350000-04:00
|
2008-07-06T08:42:10.350000-04:00
|
{"id": 12610748, "body": "I'm not entirely convinced that this is a good idea. The watcher is important for the communication between ZooKeeper and the client, and I can understand if you want to use a null watcher in the case you're implementing a quick program for debugging or perhaps test purposes, but in such cases implementing the Watcher interface and declaring a process method that does nothing doesn't seem like a huge burden to me. \n\nI'm affraid that by adding a null watcher, we'll give the impression to users that implementing a Watcher is not that important. ", "user": "Flavio Paiva Junqueira", "created_at": "2008-07-06T08:42:10.350000-04:00", "updated_at": "2008-07-06T08:42:10.350000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399583/comment/12610748", "id": "12610748", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "body": "I'm not entirely convinced that this is a good idea. The watcher is important for the communication between ZooKeeper and the client, and I can understand if you want to use a null watcher in the case you're implementing a quick program for debugging or perhaps test purposes, but in such cases implementing the Watcher interface and declaring a process method that does nothing doesn't seem like a huge burden to me. \n\nI'm affraid that by adding a null watcher, we'll give the impression to users that implementing a Watcher is not that important. ", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "created": "2008-07-06T12:42:10.350+0000", "updated": "2008-07-06T12:42:10.350+0000"}}
|
6
| 12,610,882
|
66
|
Andrew Kornev
|
I concur with Flavio: application must implement a watcher. At the very least you'd want to know about the session events such as connect, disconnect, and especially session expiration and athentication failure. The latter two cannot be automatically recovered from and must be handled by the application in a certain way (a new ZooKeeper object must be instantiated).
|
2008-07-06T23:17:43.340000-04:00
|
2008-07-06T23:17:43.340000-04:00
|
{"id": 12610882, "body": "I concur with Flavio: application must implement a watcher. At the very least you'd want to know about the session events such as connect, disconnect, and especially session expiration and athentication failure. The latter two cannot be automatically recovered from and must be handled by the application in a certain way (a new ZooKeeper object must be instantiated).", "user": "Andrew Kornev", "created_at": "2008-07-06T23:17:43.340000-04:00", "updated_at": "2008-07-06T23:17:43.340000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399583/comment/12610882", "id": "12610882", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "I concur with Flavio: application must implement a watcher. At the very least you'd want to know about the session events such as connect, disconnect, and especially session expiration and athentication failure. The latter two cannot be automatically recovered from and must be handled by the application in a certain way (a new ZooKeeper object must be instantiated).", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-07T03:17:43.340+0000", "updated": "2008-07-07T03:17:43.340+0000"}}
|
7
| 12,615,693
|
66
|
Patrick D. Hunt
|
Closing this issue.
We don't want to encourage users to use null watchers. There are very limited cases where a null watcher might be useful - probably just during the initial "kicking the tires" phase of learning ZK.
Implementing a production client requires the developer to implement a full watcher that is able to handle events and status changes (resetting watches if disconnected from the server for example).
|
2008-07-22T13:46:24.470000-04:00
|
2008-07-22T13:46:24.470000-04:00
|
{"id": 12615693, "body": "Closing this issue. \n\nWe don't want to encourage users to use null watchers. There are very limited cases where a null watcher might be useful - probably just during the initial \"kicking the tires\" phase of learning ZK. \n\nImplementing a production client requires the developer to implement a full watcher that is able to handle events and status changes (resetting watches if disconnected from the server for example).\n", "user": "Patrick D. Hunt", "created_at": "2008-07-22T13:46:24.470000-04:00", "updated_at": "2008-07-22T13:46:24.470000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399583/comment/12615693", "id": "12615693", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Closing this issue. \n\nWe don't want to encourage users to use null watchers. There are very limited cases where a null watcher might be useful - probably just during the initial \"kicking the tires\" phase of learning ZK. \n\nImplementing a production client requires the developer to implement a full watcher that is able to handle events and status changes (resetting watches if disconnected from the server for example).\n", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-22T17:46:24.470+0000", "updated": "2008-07-22T17:46:24.470+0000"}}
|
8
| 12,610,415
|
67
|
Anthony Urso
|
Patch attached.
|
2008-07-03T22:01:23.859000-04:00
|
2008-07-03T22:01:23.859000-04:00
|
{"id": 12610415, "body": "Patch attached.", "user": "Anthony Urso", "created_at": "2008-07-03T22:01:23.859000-04:00", "updated_at": "2008-07-03T22:01:23.859000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399584/comment/12610415", "id": "12610415", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=anthonyu", "name": "anthonyu", "key": "anthonyu", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Anthony Urso", "active": true, "timeZone": "Etc/UTC"}, "body": "Patch attached.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=anthonyu", "name": "anthonyu", "key": "anthonyu", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Anthony Urso", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-04T02:01:23.859+0000", "updated": "2008-07-04T02:01:23.859+0000"}}
|
9
| 12,610,416
|
67
|
Anthony Urso
|
Patch attached.
|
2008-07-03T22:01:49.501000-04:00
|
2008-07-03T22:01:49.501000-04:00
|
{"id": 12610416, "body": "Patch attached.", "user": "Anthony Urso", "created_at": "2008-07-03T22:01:49.501000-04:00", "updated_at": "2008-07-03T22:01:49.501000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399584/comment/12610416", "id": "12610416", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=anthonyu", "name": "anthonyu", "key": "anthonyu", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Anthony Urso", "active": true, "timeZone": "Etc/UTC"}, "body": "Patch attached.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=anthonyu", "name": "anthonyu", "key": "anthonyu", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Anthony Urso", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-04T02:01:49.501+0000", "updated": "2008-07-04T02:01:49.501+0000"}}
|
10
| 12,615,470
|
67
|
Patrick D. Hunt
|
Uses the null watcher implementation from ZOOKEEPER-66
|
2008-07-21T19:24:02.944000-04:00
|
2008-07-21T19:24:02.944000-04:00
|
{"id": 12615470, "body": "Uses the null watcher implementation from ZOOKEEPER-66", "user": "Patrick D. Hunt", "created_at": "2008-07-21T19:24:02.944000-04:00", "updated_at": "2008-07-21T19:24:02.944000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399584/comment/12615470", "id": "12615470", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Uses the null watcher implementation from ZOOKEEPER-66", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-21T23:24:02.944+0000", "updated": "2008-07-21T23:24:02.944+0000"}}
|
11
| 12,615,694
|
67
|
Patrick D. Hunt
|
Closing this issue, see ZOOKEEPER-66 for background.
|
2008-07-22T13:46:57.277000-04:00
|
2008-07-22T13:46:57.277000-04:00
|
{"id": 12615694, "body": "Closing this issue, see ZOOKEEPER-66 for background.", "user": "Patrick D. Hunt", "created_at": "2008-07-22T13:46:57.277000-04:00", "updated_at": "2008-07-22T13:46:57.277000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12399584/comment/12615694", "id": "12615694", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Closing this issue, see ZOOKEEPER-66 for background.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-22T17:46:57.277+0000", "updated": "2008-07-22T17:46:57.277+0000"}}
|
12
| 12,614,771
|
81
|
Hiram R. Chirino
|
{code}
Index: src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java
===================================================================
--- src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java (revision 677957)
+++ src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java (working copy)
@@ -143,7 +143,7 @@
private int tokenize(StringBuilder sb, String path, int index){
String[] tokens = path.split("/");
for (String s: tokens) {
- if (s.isEmpty())
+ if (s.length()==0)
continue;
sb.append("name").append(index++)
.append("=").append(s).append(",");
{code}
|
2008-07-18T12:17:28.380000-04:00
|
2008-07-18T12:17:28.380000-04:00
|
{"id": 12614771, "body": "{code}\nIndex: src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java\n===================================================================\n--- src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java\t(revision 677957)\n+++ src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java\t(working copy)\n@@ -143,7 +143,7 @@\n private int tokenize(StringBuilder sb, String path, int index){\n String[] tokens = path.split(\"/\");\n for (String s: tokens) {\n- if (s.isEmpty())\n+ if (s.length()==0)\n continue;\n sb.append(\"name\").append(index++)\n .append(\"=\").append(s).append(\",\");\n{code}", "user": "Hiram R. Chirino", "created_at": "2008-07-18T12:17:28.380000-04:00", "updated_at": "2008-07-18T12:17:28.380000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12614771", "id": "12614771", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "body": "{code}\nIndex: src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java\n===================================================================\n--- src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java\t(revision 677957)\n+++ src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java\t(working copy)\n@@ -143,7 +143,7 @@\n private int tokenize(StringBuilder sb, String path, int index){\n String[] tokens = path.split(\"/\");\n for (String s: tokens) {\n- if (s.isEmpty())\n+ if (s.length()==0)\n continue;\n sb.append(\"name\").append(index++)\n .append(\"=\").append(s).append(\",\");\n{code}", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "created": "2008-07-18T16:17:28.380+0000", "updated": "2008-07-18T16:17:28.380+0000"}}
|
13
| 12,614,772
|
81
|
Hiram R. Chirino
|
attaching patch for the fix.
|
2008-07-18T12:18:07.464000-04:00
|
2008-07-18T12:18:07.464000-04:00
|
{"id": 12614772, "body": "attaching patch for the fix.", "user": "Hiram R. Chirino", "created_at": "2008-07-18T12:18:07.464000-04:00", "updated_at": "2008-07-18T12:18:07.464000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12614772", "id": "12614772", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "body": "attaching patch for the fix.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "created": "2008-07-18T16:18:07.464+0000", "updated": "2008-07-18T16:18:07.464+0000"}}
|
14
| 12,614,780
|
81
|
Mahadev Konar
|
i think the build.xml only allows building of jmx with 1.6? doesnt it?
|
2008-07-18T12:37:05.216000-04:00
|
2008-07-18T12:37:05.216000-04:00
|
{"id": 12614780, "body": "i think the build.xml only allows building of jmx with 1.6? doesnt it?", "user": "Mahadev Konar", "created_at": "2008-07-18T12:37:05.216000-04:00", "updated_at": "2008-07-18T12:37:05.216000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12614780", "id": "12614780", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "body": "i think the build.xml only allows building of jmx with 1.6? doesnt it?", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-18T16:37:05.216+0000", "updated": "2008-07-18T16:37:05.216+0000"}}
|
15
| 12,614,787
|
81
|
Andrew Kornev
|
The JMX instrumentation code relies on the MXBean feature that is available only since Java 6. The build.xml conditionally includes the JMX code only when compiled under Java 6.
|
2008-07-18T13:00:44.056000-04:00
|
2008-07-18T13:00:44.056000-04:00
|
{"id": 12614787, "body": "The JMX instrumentation code relies on the MXBean feature that is available only since Java 6. The build.xml conditionally includes the JMX code only when compiled under Java 6.", "user": "Andrew Kornev", "created_at": "2008-07-18T13:00:44.056000-04:00", "updated_at": "2008-07-18T13:00:44.056000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12614787", "id": "12614787", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "The JMX instrumentation code relies on the MXBean feature that is available only since Java 6. The build.xml conditionally includes the JMX code only when compiled under Java 6.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-18T17:00:44.056+0000", "updated": "2008-07-18T17:00:44.056+0000"}}
|
16
| 12,615,370
|
81
|
Hiram R. Chirino
|
The build lets me build under 1.5 and if I apply that patch it compiles and tests fine. Perhaps that mxbean feature is only needed at runtime?
|
2008-07-21T15:04:34.883000-04:00
|
2008-07-21T15:04:34.883000-04:00
|
{"id": 12615370, "body": "The build lets me build under 1.5 and if I apply that patch it compiles and tests fine. Perhaps that mxbean feature is only needed at runtime?", "user": "Hiram R. Chirino", "created_at": "2008-07-21T15:04:34.883000-04:00", "updated_at": "2008-07-21T15:04:34.883000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615370", "id": "12615370", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "body": "The build lets me build under 1.5 and if I apply that patch it compiles and tests fine. Perhaps that mxbean feature is only needed at runtime?", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "created": "2008-07-21T19:04:34.883+0000", "updated": "2008-07-21T19:04:34.883+0000"}}
|
17
| 12,615,374
|
81
|
Andrew Kornev
|
I don't think you actually build the jmx code under 1.5 -- build.xml silently excludes the java\jmx directory from the build.
|
2008-07-21T15:15:21.262000-04:00
|
2008-07-21T15:15:21.262000-04:00
|
{"id": 12615374, "body": "I don't think you actually build the jmx code under 1.5 -- build.xml silently excludes the java\\jmx directory from the build. ", "user": "Andrew Kornev", "created_at": "2008-07-21T15:15:21.262000-04:00", "updated_at": "2008-07-21T15:15:21.262000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615374", "id": "12615374", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "I don't think you actually build the jmx code under 1.5 -- build.xml silently excludes the java\\jmx directory from the build. ", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-21T19:15:21.262+0000", "updated": "2008-07-21T19:15:21.262+0000"}}
|
18
| 12,615,463
|
81
|
Patrick D. Hunt
|
Assigning to Andrew for followup/resolution.
|
2008-07-21T19:10:40.304000-04:00
|
2008-07-21T19:10:40.304000-04:00
|
{"id": 12615463, "body": "Assigning to Andrew for followup/resolution.", "user": "Patrick D. Hunt", "created_at": "2008-07-21T19:10:40.304000-04:00", "updated_at": "2008-07-21T19:10:40.304000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615463", "id": "12615463", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Assigning to Andrew for followup/resolution.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-21T23:10:40.304+0000", "updated": "2008-07-21T23:10:40.304+0000"}}
|
19
| 12,615,623
|
81
|
Hiram R. Chirino
|
Java 1.5 can compile this for sure with the given patch.
|
2008-07-22T09:29:20.152000-04:00
|
2008-07-22T09:29:20.152000-04:00
|
{"id": 12615623, "body": "Java 1.5 can compile this for sure with the given patch. ", "user": "Hiram R. Chirino", "created_at": "2008-07-22T09:29:20.152000-04:00", "updated_at": "2008-07-22T09:29:20.152000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615623", "id": "12615623", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "body": "Java 1.5 can compile this for sure with the given patch. ", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "created": "2008-07-22T13:29:20.152+0000", "updated": "2008-07-22T13:29:20.152+0000"}}
|
20
| 12,615,704
|
81
|
Andrew Kornev
|
Long story short -- MXBean is a runtime dependency. Some internal machinery for handling user defined MXBeans is missing in Java 5. For details please refer to http://java.sun.com/javase/6/docs/technotes/guides/jmx/enhancements.html. The second bullet on the top says:
??MXBeans have been added. MXBeans are MBeans that provide a convenient way to bundle related values together without requiring clients to be specially configured to handle the bundles. A defined set of MXBeans already existed in the J2SE 5.0 platform, but Java SE 6 introduces an API to allow you to program your own custom MXBeans.??
Although there is absolutely nothing wrong with your patch, would you be terribly disappointed if I leave the things the way they are and simply close this jira as "won't fix"? :-)
|
2008-07-22T14:09:41.265000-04:00
|
2008-07-22T14:09:41.265000-04:00
|
{"id": 12615704, "body": "Long story short -- MXBean is a runtime dependency. Some internal machinery for handling user defined MXBeans is missing in Java 5. For details please refer to http://java.sun.com/javase/6/docs/technotes/guides/jmx/enhancements.html. The second bullet on the top says:\n\n??MXBeans have been added. MXBeans are MBeans that provide a convenient way to bundle related values together without requiring clients to be specially configured to handle the bundles. A defined set of MXBeans already existed in the J2SE 5.0 platform, but Java SE 6 introduces an API to allow you to program your own custom MXBeans.??\n\nAlthough there is absolutely nothing wrong with your patch, would you be terribly disappointed if I leave the things the way they are and simply close this jira as \"won't fix\"? :-)", "user": "Andrew Kornev", "created_at": "2008-07-22T14:09:41.265000-04:00", "updated_at": "2008-07-22T14:09:41.265000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615704", "id": "12615704", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "Long story short -- MXBean is a runtime dependency. Some internal machinery for handling user defined MXBeans is missing in Java 5. For details please refer to http://java.sun.com/javase/6/docs/technotes/guides/jmx/enhancements.html. The second bullet on the top says:\n\n??MXBeans have been added. MXBeans are MBeans that provide a convenient way to bundle related values together without requiring clients to be specially configured to handle the bundles. A defined set of MXBeans already existed in the J2SE 5.0 platform, but Java SE 6 introduces an API to allow you to program your own custom MXBeans.??\n\nAlthough there is absolutely nothing wrong with your patch, would you be terribly disappointed if I leave the things the way they are and simply close this jira as \"won't fix\"? :-)", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-22T18:09:41.265+0000", "updated": "2008-07-22T18:09:41.265+0000"}}
|
21
| 12,615,711
|
81
|
Hiram R. Chirino
|
lol.. I don't understand the aversion to the patch. it changes NOTHING significant and lets the module compile under java 1.5
have you seen that it just changes ONE line? it changes "s.isEmpty()" to "s.length()==0"
please commit.
|
2008-07-22T14:20:14.619000-04:00
|
2008-07-22T14:20:14.619000-04:00
|
{"id": 12615711, "body": "lol.. I don't understand the aversion to the patch. it changes NOTHING significant and lets the module compile under java 1.5\n\nhave you seen that it just changes ONE line? it changes \"s.isEmpty()\" to \"s.length()==0\"\n\nplease commit.", "user": "Hiram R. Chirino", "created_at": "2008-07-22T14:20:14.619000-04:00", "updated_at": "2008-07-22T14:20:14.619000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615711", "id": "12615711", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "body": "lol.. I don't understand the aversion to the patch. it changes NOTHING significant and lets the module compile under java 1.5\n\nhave you seen that it just changes ONE line? it changes \"s.isEmpty()\" to \"s.length()==0\"\n\nplease commit.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "created": "2008-07-22T18:20:14.619+0000", "updated": "2008-07-22T18:20:14.619+0000"}}
|
22
| 12,615,719
|
81
|
Hiram R. Chirino
|
Furthermore, I've been looking at your the MXBean interfaces and I don't see them being actual MXBeans.. they are just standard MBeans. They would only be MXBeans if the methods they defined used complex object types as parameters or return values.
Are you sure that you even have a Java 6 runtime dependency?
|
2008-07-22T14:31:51.815000-04:00
|
2008-07-22T14:31:51.815000-04:00
|
{"id": 12615719, "body": "Furthermore, I've been looking at your the MXBean interfaces and I don't see them being actual MXBeans.. they are just standard MBeans. They would only be MXBeans if the methods they defined used complex object types as parameters or return values.\n\nAre you sure that you even have a Java 6 runtime dependency? ", "user": "Hiram R. Chirino", "created_at": "2008-07-22T14:31:51.815000-04:00", "updated_at": "2008-07-22T14:31:51.815000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615719", "id": "12615719", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "body": "Furthermore, I've been looking at your the MXBean interfaces and I don't see them being actual MXBeans.. they are just standard MBeans. They would only be MXBeans if the methods they defined used complex object types as parameters or return values.\n\nAre you sure that you even have a Java 6 runtime dependency? ", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "created": "2008-07-22T18:31:51.815+0000", "updated": "2008-07-22T18:31:51.815+0000"}}
|
23
| 12,615,741
|
81
|
Andrew Kornev
|
Would you like to verify whether or not there is a Java 6 runtime dependency? Would you be willing to contribute a patch (including this change) to break such a dependency? Would you be interested in implementing additional JMX beans? You can find some ideas here http://sourceforge.net/tracker/index.php?func=detail&aid=1894138&group_id=209147&atid=1008547 .Things like enabling/disabling tracing thru a JMX Console seem to be useful.
|
2008-07-22T15:04:34.150000-04:00
|
2008-07-22T15:04:34.150000-04:00
|
{"id": 12615741, "body": "Would you like to verify whether or not there is a Java 6 runtime dependency? Would you be willing to contribute a patch (including this change) to break such a dependency? Would you be interested in implementing additional JMX beans? You can find some ideas here http://sourceforge.net/tracker/index.php?func=detail&aid=1894138&group_id=209147&atid=1008547 .Things like enabling/disabling tracing thru a JMX Console seem to be useful.", "user": "Andrew Kornev", "created_at": "2008-07-22T15:04:34.150000-04:00", "updated_at": "2008-07-22T15:04:34.150000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615741", "id": "12615741", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "Would you like to verify whether or not there is a Java 6 runtime dependency? Would you be willing to contribute a patch (including this change) to break such a dependency? Would you be interested in implementing additional JMX beans? You can find some ideas here http://sourceforge.net/tracker/index.php?func=detail&aid=1894138&group_id=209147&atid=1008547 .Things like enabling/disabling tracing thru a JMX Console seem to be useful.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-22T19:04:34.150+0000", "updated": "2008-07-22T19:04:34.150+0000"}}
|
24
| 12,615,749
|
81
|
Hiram R. Chirino
|
Sure.. could we get this patch committed first? I really do fail to see what harm could come from it being committed.
|
2008-07-22T15:25:56.205000-04:00
|
2008-07-22T15:25:56.205000-04:00
|
{"id": 12615749, "body": "Sure.. could we get this patch committed first? I really do fail to see what harm could come from it being committed. ", "user": "Hiram R. Chirino", "created_at": "2008-07-22T15:25:56.205000-04:00", "updated_at": "2008-07-22T15:25:56.205000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615749", "id": "12615749", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "body": "Sure.. could we get this patch committed first? I really do fail to see what harm could come from it being committed. ", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=chirino", "name": "chirino", "key": "chirino", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=chirino&avatarId=12659", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=chirino&avatarId=12659", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=chirino&avatarId=12659", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=chirino&avatarId=12659"}, "displayName": "Hiram R. Chirino", "active": true, "timeZone": "America/New_York"}, "created": "2008-07-22T19:25:56.205+0000", "updated": "2008-07-22T19:25:56.205+0000"}}
|
25
| 12,615,760
|
81
|
Andrew Kornev
|
Committed! Thanks Hiram!
|
2008-07-22T15:49:29.061000-04:00
|
2008-07-22T15:49:29.061000-04:00
|
{"id": 12615760, "body": "Committed! Thanks Hiram!", "user": "Andrew Kornev", "created_at": "2008-07-22T15:49:29.061000-04:00", "updated_at": "2008-07-22T15:49:29.061000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615760", "id": "12615760", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "Committed! Thanks Hiram!", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-22T19:49:29.061+0000", "updated": "2008-07-22T19:49:29.061+0000"}}
|
26
| 12,615,762
|
81
|
Mahadev Konar
|
assigning it to hiram ..
|
2008-07-22T15:52:53.644000-04:00
|
2008-07-22T15:52:53.644000-04:00
|
{"id": 12615762, "body": "assigning it to hiram ..", "user": "Mahadev Konar", "created_at": "2008-07-22T15:52:53.644000-04:00", "updated_at": "2008-07-22T15:52:53.644000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12615762", "id": "12615762", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "body": "assigning it to hiram ..", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-22T19:52:53.644+0000", "updated": "2008-07-22T19:52:53.644+0000"}}
|
27
| 12,616,273
|
81
|
Patrick D. Hunt
|
Fixed in 3.0.0
|
2008-07-23T17:48:44.352000-04:00
|
2008-07-23T17:48:44.352000-04:00
|
{"id": 12616273, "body": "Fixed in 3.0.0", "user": "Patrick D. Hunt", "created_at": "2008-07-23T17:48:44.352000-04:00", "updated_at": "2008-07-23T17:48:44.352000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400568/comment/12616273", "id": "12616273", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Fixed in 3.0.0", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-23T21:48:44.352+0000", "updated": "2008-07-23T21:48:44.352+0000"}}
|
28
| 12,616,502
|
88
|
James Strachan
|
I've just submitted an [initial patch at implementing this|http://svn.apache.org/viewvc?rev=679435&view=rev] which could use some more tests and code review
|
2008-07-24T11:23:49.758000-04:00
|
2008-07-24T11:23:49.758000-04:00
|
{"id": 12616502, "body": "I've just submitted an [initial patch at implementing this|http://svn.apache.org/viewvc?rev=679435&view=rev] which could use some more tests and code review", "user": "James Strachan", "created_at": "2008-07-24T11:23:49.758000-04:00", "updated_at": "2008-07-24T11:23:49.758000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400901/comment/12616502", "id": "12616502", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "body": "I've just submitted an [initial patch at implementing this|http://svn.apache.org/viewvc?rev=679435&view=rev] which could use some more tests and code review", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-24T15:23:49.758+0000", "updated": "2008-07-24T15:23:49.758+0000"}}
|
29
| 12,616,653
|
88
|
Patrick D. Hunt
|
Removing from "patch available" - please attach a "svn diff" patch to this jira. thanks.
|
2008-07-24T16:57:27.329000-04:00
|
2008-07-24T16:57:27.329000-04:00
|
{"id": 12616653, "body": "Removing from \"patch available\" - please attach a \"svn diff\" patch to this jira. thanks.", "user": "Patrick D. Hunt", "created_at": "2008-07-24T16:57:27.329000-04:00", "updated_at": "2008-07-24T16:57:27.329000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400901/comment/12616653", "id": "12616653", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Removing from \"patch available\" - please attach a \"svn diff\" patch to this jira. thanks.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-24T20:57:27.329+0000", "updated": "2008-07-24T20:57:27.329+0000"}}
|
30
| 12,605,377
|
39
|
Patrick D. Hunt
|
The java client code is complete, the c client has yet to be implemented. Reassigning to Andrew for c client implementation.
|
2008-06-16T15:00:09.982000-04:00
|
2008-06-16T15:00:09.982000-04:00
|
{"id": 12605377, "body": "The java client code is complete, the c client has yet to be implemented. Reassigning to Andrew for c client implementation.\n", "user": "Patrick D. Hunt", "created_at": "2008-06-16T15:00:09.982000-04:00", "updated_at": "2008-06-16T15:00:09.982000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398004/comment/12605377", "id": "12605377", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "The java client code is complete, the c client has yet to be implemented. Reassigning to Andrew for c client implementation.\n", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-06-16T19:00:09.982+0000", "updated": "2008-06-16T19:00:09.982+0000"}}
|
31
| 12,610,880
|
39
|
Andrew Kornev
|
This patch implements the new watcher "object" API. Internally, it uses a map to maintain the mapping between the znode path and watcher function/context. Every time a watch event arrives the client delegates event processing to an associated watcher object if one exists.
The patch also includes a suite of unit tests for both single- and multithreaded libraries as well as for the Sync and Async APIs.
|
2008-07-06T22:59:48.035000-04:00
|
2008-07-06T22:59:48.035000-04:00
|
{"id": 12610880, "body": "This patch implements the new watcher \"object\" API. Internally, it uses a map to maintain the mapping between the znode path and watcher function/context. Every time a watch event arrives the client delegates event processing to an associated watcher object if one exists.\n\nThe patch also includes a suite of unit tests for both single- and multithreaded libraries as well as for the Sync and Async APIs.", "user": "Andrew Kornev", "created_at": "2008-07-06T22:59:48.035000-04:00", "updated_at": "2008-07-06T22:59:48.035000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398004/comment/12610880", "id": "12610880", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "This patch implements the new watcher \"object\" API. Internally, it uses a map to maintain the mapping between the znode path and watcher function/context. Every time a watch event arrives the client delegates event processing to an associated watcher object if one exists.\n\nThe patch also includes a suite of unit tests for both single- and multithreaded libraries as well as for the Sync and Async APIs.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-07T02:59:48.035+0000", "updated": "2008-07-07T02:59:48.035+0000"}}
|
32
| 12,614,121
|
39
|
Andrew Kornev
|
The watcher processing is now done in multiple steps:
1) when application issues a zokeeper query with watcher enabled, a temporary watcher registration is created and stored along with the completion entry in the completion queue.
2) upon succesful response from the server, the watcher registration is moved from the completion queue to the watcher object map. If the server returns an error the watcher registration is discarded.
3) when a watch event arrives, the client uses the watcher map to determine if there are watchers set on the znode (using the znode path as the key). It then calles the watcher callback passing in the watcher context along with the znode path and the event type info.
4) the watcher object is deleted from the map prior to calling the application watcher in the step 3)
|
2008-07-16T17:59:16.159000-04:00
|
2008-07-16T17:59:16.159000-04:00
|
{"id": 12614121, "body": "The watcher processing is now done in multiple steps: \n1) when application issues a zokeeper query with watcher enabled, a temporary watcher registration is created and stored along with the completion entry in the completion queue.\n2) upon succesful response from the server, the watcher registration is moved from the completion queue to the watcher object map. If the server returns an error the watcher registration is discarded.\n3) when a watch event arrives, the client uses the watcher map to determine if there are watchers set on the znode (using the znode path as the key). It then calles the watcher callback passing in the watcher context along with the znode path and the event type info.\n4) the watcher object is deleted from the map prior to calling the application watcher in the step 3)", "user": "Andrew Kornev", "created_at": "2008-07-16T17:59:16.159000-04:00", "updated_at": "2008-07-16T17:59:16.159000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398004/comment/12614121", "id": "12614121", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "The watcher processing is now done in multiple steps: \n1) when application issues a zokeeper query with watcher enabled, a temporary watcher registration is created and stored along with the completion entry in the completion queue.\n2) upon succesful response from the server, the watcher registration is moved from the completion queue to the watcher object map. If the server returns an error the watcher registration is discarded.\n3) when a watch event arrives, the client uses the watcher map to determine if there are watchers set on the znode (using the znode path as the key). It then calles the watcher callback passing in the watcher context along with the znode path and the event type info.\n4) the watcher object is deleted from the map prior to calling the application watcher in the step 3)", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-16T21:59:16.159+0000", "updated": "2008-07-16T21:59:16.159+0000"}}
|
33
| 12,616,305
|
39
|
Patrick D. Hunt
|
See ZOOKEEPER-50 there is a bug in the java that should be addressed (both java and C should be careful of this)
|
2008-07-23T19:37:02.023000-04:00
|
2008-07-23T19:37:02.023000-04:00
|
{"id": 12616305, "body": "See ZOOKEEPER-50 there is a bug in the java that should be addressed (both java and C should be careful of this)", "user": "Patrick D. Hunt", "created_at": "2008-07-23T19:37:02.023000-04:00", "updated_at": "2008-07-23T19:37:02.023000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398004/comment/12616305", "id": "12616305", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "See ZOOKEEPER-50 there is a bug in the java that should be addressed (both java and C should be careful of this)", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-23T23:37:02.023+0000", "updated": "2008-07-23T23:37:02.023+0000"}}
|
34
| 12,616,581
|
39
|
Mahadev Konar
|
the patch looks good ... andrew is zookeeper-50 taken care of in this patch?
|
2008-07-24T14:46:33.284000-04:00
|
2008-07-24T14:46:33.284000-04:00
|
{"id": 12616581, "body": "the patch looks good ... andrew is zookeeper-50 taken care of in this patch?", "user": "Mahadev Konar", "created_at": "2008-07-24T14:46:33.284000-04:00", "updated_at": "2008-07-24T14:46:33.284000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398004/comment/12616581", "id": "12616581", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "body": "the patch looks good ... andrew is zookeeper-50 taken care of in this patch?", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-24T18:46:33.284+0000", "updated": "2008-07-24T18:46:33.284+0000"}}
|
35
| 12,616,599
|
39
|
Andrew Kornev
|
No, this patch doesn't take care of ZOOKEEPER-50, which is a bug in the Java client code. This patch is for the C client only.
|
2008-07-24T15:14:49.683000-04:00
|
2008-07-24T15:14:49.683000-04:00
|
{"id": 12616599, "body": "No, this patch doesn't take care of ZOOKEEPER-50, which is a bug in the Java client code. This patch is for the C client only.", "user": "Andrew Kornev", "created_at": "2008-07-24T15:14:49.683000-04:00", "updated_at": "2008-07-24T15:14:49.683000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398004/comment/12616599", "id": "12616599", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "No, this patch doesn't take care of ZOOKEEPER-50, which is a bug in the Java client code. This patch is for the C client only.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-24T19:14:49.683+0000", "updated": "2008-07-24T19:14:49.683+0000"}}
|
36
| 12,616,663
|
39
|
Mahadev Konar
|
here is a patch that adds the license file to the hashtable implementation.
+1 for the patch from my side.
|
2008-07-24T17:19:37.028000-04:00
|
2008-07-24T17:19:37.028000-04:00
|
{"id": 12616663, "body": "here is a patch that adds the license file to the hashtable implementation. \n+1 for the patch from my side.", "user": "Mahadev Konar", "created_at": "2008-07-24T17:19:37.028000-04:00", "updated_at": "2008-07-24T17:19:37.028000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398004/comment/12616663", "id": "12616663", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "body": "here is a patch that adds the license file to the hashtable implementation. \n+1 for the patch from my side.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-24T21:19:37.028+0000", "updated": "2008-07-24T21:19:37.028+0000"}}
|
37
| 12,616,664
|
39
|
Andrew Kornev
|
Verified the patch builds and the unit tests run successfully.
|
2008-07-24T17:31:44.504000-04:00
|
2008-07-24T17:31:44.504000-04:00
|
{"id": 12616664, "body": "Verified the patch builds and the unit tests run successfully.", "user": "Andrew Kornev", "created_at": "2008-07-24T17:31:44.504000-04:00", "updated_at": "2008-07-24T17:31:44.504000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398004/comment/12616664", "id": "12616664", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "Verified the patch builds and the unit tests run successfully.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-24T21:31:44.504+0000", "updated": "2008-07-24T21:31:44.504+0000"}}
|
38
| 12,616,673
|
39
|
Andrew Kornev
|
Patch committed
|
2008-07-24T17:56:34.709000-04:00
|
2008-07-24T17:56:34.709000-04:00
|
{"id": 12616673, "body": "Patch committed", "user": "Andrew Kornev", "created_at": "2008-07-24T17:56:34.709000-04:00", "updated_at": "2008-07-24T17:56:34.709000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398004/comment/12616673", "id": "12616673", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "Patch committed", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-24T21:56:34.709+0000", "updated": "2008-07-24T21:56:34.709+0000"}}
|
39
| 12,616,844
|
39
|
Hudson
|
Integrated in ZooKeeper-trunk #33 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/33/])
|
2008-07-25T06:42:06.378000-04:00
|
2008-07-25T06:42:06.378000-04:00
|
{"id": 12616844, "body": "Integrated in ZooKeeper-trunk #33 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/33/])", "user": "Hudson", "created_at": "2008-07-25T06:42:06.378000-04:00", "updated_at": "2008-07-25T06:42:06.378000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12398004/comment/12616844", "id": "12616844", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=hudson", "name": "hudson", "key": "hudson", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Hudson", "active": true, "timeZone": "Etc/UTC"}, "body": "Integrated in ZooKeeper-trunk #33 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/33/])", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=hudson", "name": "hudson", "key": "hudson", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Hudson", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-25T10:42:06.378+0000", "updated": "2008-07-25T10:42:06.378+0000"}}
|
40
| 12,615,680
|
84
|
Mahadev Konar
|
james,
I do not understand where you want ot add a reconnect? Can you explain what this jira is about?
|
2008-07-22T13:15:32.942000-04:00
|
2008-07-22T13:15:32.942000-04:00
|
{"id": 12615680, "body": "james,\n I do not understand where you want ot add a reconnect? Can you explain what this jira is about? ", "user": "Mahadev Konar", "created_at": "2008-07-22T13:15:32.942000-04:00", "updated_at": "2008-07-22T13:15:32.942000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12615680", "id": "12615680", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "body": "james,\n I do not understand where you want ot add a reconnect? Can you explain what this jira is about? ", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-22T17:15:32.942+0000", "updated": "2008-07-22T17:15:32.942+0000"}}
|
41
| 12,615,684
|
84
|
James Strachan
|
about to submit a match - whoops forgot to add it :)
|
2008-07-22T13:20:44.038000-04:00
|
2008-07-22T13:20:44.038000-04:00
|
{"id": 12615684, "body": "about to submit a match - whoops forgot to add it :)", "user": "James Strachan", "created_at": "2008-07-22T13:20:44.038000-04:00", "updated_at": "2008-07-22T13:20:44.038000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12615684", "id": "12615684", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "body": "about to submit a match - whoops forgot to add it :)", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-22T17:20:44.038+0000", "updated": "2008-07-22T17:20:44.038+0000"}}
|
42
| 12,615,686
|
84
|
James Strachan
|
sorry I forgot to add the patch before :) here it is now, hopefully this will make more sense now :)
|
2008-07-22T13:23:13.794000-04:00
|
2008-07-22T13:23:13.794000-04:00
|
{"id": 12615686, "body": "sorry I forgot to add the patch before :) here it is now, hopefully this will make more sense now :)", "user": "James Strachan", "created_at": "2008-07-22T13:23:13.794000-04:00", "updated_at": "2008-07-22T13:23:13.794000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12615686", "id": "12615686", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "body": "sorry I forgot to add the patch before :) here it is now, hopefully this will make more sense now :)", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-22T17:23:13.794+0000", "updated": "2008-07-22T17:23:13.794+0000"}}
|
43
| 12,615,761
|
84
|
Patrick D. Hunt
|
Assigning to James.
|
2008-07-22T15:52:03.625000-04:00
|
2008-07-22T15:52:03.625000-04:00
|
{"id": 12615761, "body": "Assigning to James.", "user": "Patrick D. Hunt", "created_at": "2008-07-22T15:52:03.625000-04:00", "updated_at": "2008-07-22T15:52:03.625000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12615761", "id": "12615761", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Assigning to James.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-22T19:52:03.625+0000", "updated": "2008-07-22T19:52:03.625+0000"}}
|
44
| 12,615,808
|
84
|
Mahadev Konar
|
james,
here is what the current sematics is ---
- there is one on one mapping between a client and a session
- if a session expires the client becomes invalid
- the client can reconnect to the servers if they die only to renew the session. If the session is invalid this client in invalid.
originally we allowed a client to reconnect and create a new session and foudn that our users were getting more and more confused with such kind of sematincs and found that the above sematics made things easier for them. So I think we should not reconnect and try creating a new session with the same client. does that make sense?
|
2008-07-22T17:53:35.915000-04:00
|
2008-07-22T17:53:35.915000-04:00
|
{"id": 12615808, "body": "james,\n here is what the current sematics is --- \n\n- there is one on one mapping between a client and a session\n- if a session expires the client becomes invalid \n- the client can reconnect to the servers if they die only to renew the session. If the session is invalid this client in invalid.\n\n\noriginally we allowed a client to reconnect and create a new session and foudn that our users were getting more and more confused with such kind of sematincs and found that the above sematics made things easier for them. So I think we should not reconnect and try creating a new session with the same client. does that make sense?", "user": "Mahadev Konar", "created_at": "2008-07-22T17:53:35.915000-04:00", "updated_at": "2008-07-22T17:53:35.915000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12615808", "id": "12615808", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "body": "james,\n here is what the current sematics is --- \n\n- there is one on one mapping between a client and a session\n- if a session expires the client becomes invalid \n- the client can reconnect to the servers if they die only to renew the session. If the session is invalid this client in invalid.\n\n\noriginally we allowed a client to reconnect and create a new session and foudn that our users were getting more and more confused with such kind of sematincs and found that the above sematics made things easier for them. So I think we should not reconnect and try creating a new session with the same client. does that make sense?", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-22T21:53:35.915+0000", "updated": "2008-07-22T21:53:35.915+0000"}}
|
45
| 12,615,957
|
84
|
James Strachan
|
I'm kinda confused by that :)
So what am I meant to do if I get a SessionExpiredException? I want to reconnect with a new session; as the current connection is totally useless and invalid.
Right now the only option I can see is to recreate from scratch the entire ZooKeeper object?
If so that means we've gotta introduce a ZooKeeperProxy thingy which wraps the ZooKeeper object and just lets it be recreated if a SessionExpiredException occurs. Seems kinda unnecessary when really a ZooKeeper instance is capable of easily recreating the connection to the ZK server when the session is expired.
Maybe the issue is the phrase reconnect() - maybe a method called recreateNewSession() is better? We could also document it that this is only to be called if your client becomes invalid because the ZK server has expired the session?
|
2008-07-23T07:15:11.523000-04:00
|
2008-07-23T07:15:11.523000-04:00
|
{"id": 12615957, "body": "I'm kinda confused by that :)\n\nSo what am I meant to do if I get a SessionExpiredException? I want to reconnect with a new session; as the current connection is totally useless and invalid.\n\nRight now the only option I can see is to recreate from scratch the entire ZooKeeper object?\n\nIf so that means we've gotta introduce a ZooKeeperProxy thingy which wraps the ZooKeeper object and just lets it be recreated if a SessionExpiredException occurs. Seems kinda unnecessary when really a ZooKeeper instance is capable of easily recreating the connection to the ZK server when the session is expired.\n\nMaybe the issue is the phrase reconnect() - maybe a method called recreateNewSession() is better? We could also document it that this is only to be called if your client becomes invalid because the ZK server has expired the session?", "user": "James Strachan", "created_at": "2008-07-23T07:15:11.523000-04:00", "updated_at": "2008-07-23T07:15:11.523000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12615957", "id": "12615957", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "body": "I'm kinda confused by that :)\n\nSo what am I meant to do if I get a SessionExpiredException? I want to reconnect with a new session; as the current connection is totally useless and invalid.\n\nRight now the only option I can see is to recreate from scratch the entire ZooKeeper object?\n\nIf so that means we've gotta introduce a ZooKeeperProxy thingy which wraps the ZooKeeper object and just lets it be recreated if a SessionExpiredException occurs. Seems kinda unnecessary when really a ZooKeeper instance is capable of easily recreating the connection to the ZK server when the session is expired.\n\nMaybe the issue is the phrase reconnect() - maybe a method called recreateNewSession() is better? We could also document it that this is only to be called if your client becomes invalid because the ZK server has expired the session?", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-23T11:15:11.523+0000", "updated": "2008-07-23T11:15:11.523+0000"}}
|
46
| 12,616,012
|
84
|
James Strachan
|
the ZooKeeper will reconnect by default if the socket fails right? So I'm only really talking about reconectingWithNewSession() in those rare cases that the ZK server times out the session
|
2008-07-23T09:30:13.203000-04:00
|
2008-07-23T09:30:13.203000-04:00
|
{"id": 12616012, "body": "the ZooKeeper will reconnect by default if the socket fails right? So I'm only really talking about reconectingWithNewSession() in those rare cases that the ZK server times out the session", "user": "James Strachan", "created_at": "2008-07-23T09:30:13.203000-04:00", "updated_at": "2008-07-23T09:30:13.203000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12616012", "id": "12616012", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "body": "the ZooKeeper will reconnect by default if the socket fails right? So I'm only really talking about reconectingWithNewSession() in those rare cases that the ZK server times out the session", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-23T13:30:13.203+0000", "updated": "2008-07-23T13:30:13.203+0000"}}
|
47
| 12,616,039
|
84
|
Benjamin Reed
|
The problem with the reconnect method is that it is easy to use but very hard to use correctly. In general, we try to avoid giving programmers methods that make it easy to hang themselves. We provide plenty of rope, and they are free to make a noose; we just don't provide a tieTheKnot method.
The basic problem has to do with clean up that happens when a session dies. Obviously ephemeral nodes will go away. Our watch reestablishment patches could be updated to make watches reestablish on reconnect, but that would be very confusing to have ephemerals disappear but watches get reestablished.
To ZooKeeper an expired session is a dead client, so by making the ZooKeeper service handle die as well we have clear semantics.
As an historical note, session expiration wasn't always a fatal thing. We used to delivered the session expiration event and then get a new session. The earliest problem our users ran into was with multi-threaded applications. If there are multiple threads going, the watcher object will get the session expired event; the other threads may still be trying to use the ZooKeeper object. If you use the same ZooKeeper object to reconnect with, you can easily end up with a thread that uses the object thinking that it is running in the context of an earlier session and really mess things up. The explicit reconnect alleviates this slightly, but you would still need to do synchronization around the ZooKeeper object and it would be very difficult to get working when you are using different libraries using the same ZooKeeper object.
You are working on a lock class; you can imagine someone else does a barrier class. Who is in charge of doing the reconnect() and deciding when it is safe?
Testing applications that use this would also be a pain given the number of race conditions involved.
So the safest thing to do is have the lock object become invalid when it's ZooKeeper object becomes invalid. An expired session is a really bad thing, we can't hide it nicely.
|
2008-07-23T10:20:28.559000-04:00
|
2008-07-23T10:20:28.559000-04:00
|
{"id": 12616039, "body": "The problem with the reconnect method is that it is easy to use but very hard to use correctly. In general, we try to avoid giving programmers methods that make it easy to hang themselves. We provide plenty of rope, and they are free to make a noose; we just don't provide a tieTheKnot method.\n\nThe basic problem has to do with clean up that happens when a session dies. Obviously ephemeral nodes will go away. Our watch reestablishment patches could be updated to make watches reestablish on reconnect, but that would be very confusing to have ephemerals disappear but watches get reestablished.\n\nTo ZooKeeper an expired session is a dead client, so by making the ZooKeeper service handle die as well we have clear semantics.\n\nAs an historical note, session expiration wasn't always a fatal thing. We used to delivered the session expiration event and then get a new session. The earliest problem our users ran into was with multi-threaded applications. If there are multiple threads going, the watcher object will get the session expired event; the other threads may still be trying to use the ZooKeeper object. If you use the same ZooKeeper object to reconnect with, you can easily end up with a thread that uses the object thinking that it is running in the context of an earlier session and really mess things up. The explicit reconnect alleviates this slightly, but you would still need to do synchronization around the ZooKeeper object and it would be very difficult to get working when you are using different libraries using the same ZooKeeper object.\n\nYou are working on a lock class; you can imagine someone else does a barrier class. Who is in charge of doing the reconnect() and deciding when it is safe?\n\nTesting applications that use this would also be a pain given the number of race conditions involved.\n\nSo the safest thing to do is have the lock object become invalid when it's ZooKeeper object becomes invalid. An expired session is a really bad thing, we can't hide it nicely.", "user": "Benjamin Reed", "created_at": "2008-07-23T10:20:28.559000-04:00", "updated_at": "2008-07-23T10:20:28.559000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12616039", "id": "12616039", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=breed", "name": "breed", "key": "breed", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Benjamin Reed", "active": true, "timeZone": "America/Los_Angeles"}, "body": "The problem with the reconnect method is that it is easy to use but very hard to use correctly. In general, we try to avoid giving programmers methods that make it easy to hang themselves. We provide plenty of rope, and they are free to make a noose; we just don't provide a tieTheKnot method.\n\nThe basic problem has to do with clean up that happens when a session dies. Obviously ephemeral nodes will go away. Our watch reestablishment patches could be updated to make watches reestablish on reconnect, but that would be very confusing to have ephemerals disappear but watches get reestablished.\n\nTo ZooKeeper an expired session is a dead client, so by making the ZooKeeper service handle die as well we have clear semantics.\n\nAs an historical note, session expiration wasn't always a fatal thing. We used to delivered the session expiration event and then get a new session. The earliest problem our users ran into was with multi-threaded applications. If there are multiple threads going, the watcher object will get the session expired event; the other threads may still be trying to use the ZooKeeper object. If you use the same ZooKeeper object to reconnect with, you can easily end up with a thread that uses the object thinking that it is running in the context of an earlier session and really mess things up. The explicit reconnect alleviates this slightly, but you would still need to do synchronization around the ZooKeeper object and it would be very difficult to get working when you are using different libraries using the same ZooKeeper object.\n\nYou are working on a lock class; you can imagine someone else does a barrier class. Who is in charge of doing the reconnect() and deciding when it is safe?\n\nTesting applications that use this would also be a pain given the number of race conditions involved.\n\nSo the safest thing to do is have the lock object become invalid when it's ZooKeeper object becomes invalid. An expired session is a really bad thing, we can't hide it nicely.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=breed", "name": "breed", "key": "breed", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Benjamin Reed", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-23T14:20:28.559+0000", "updated": "2008-07-23T14:20:28.559+0000"}}
|
48
| 12,616,065
|
84
|
James Strachan
|
I hear you :)
So an Elect Leader or Write Lock protocol has to deal with expired sessions and create new sessions; at some point someone has to recreate something. You can pass the buck and say we're not gonna allow the ZooKeeper to reconnect. Then say we're not allowed to have the WriteLock reconnect, then the next and next layer of the onion. But eventually there's gonna be something somewhere that recreates a session :)
For now I'll work on the assumption we're gonna have to have an object which is a wrapper around a ZooKeeper so that it can handle reconnections by just discarding one ZooKeeper instance and creating another. This object could be shared across Protocols (we might wanna reuse one connection with ZK to make multiple locks for example).
|
2008-07-23T10:38:16.481000-04:00
|
2008-07-23T10:38:16.481000-04:00
|
{"id": 12616065, "body": "I hear you :)\n\nSo an Elect Leader or Write Lock protocol has to deal with expired sessions and create new sessions; at some point someone has to recreate something. You can pass the buck and say we're not gonna allow the ZooKeeper to reconnect. Then say we're not allowed to have the WriteLock reconnect, then the next and next layer of the onion. But eventually there's gonna be something somewhere that recreates a session :)\n\nFor now I'll work on the assumption we're gonna have to have an object which is a wrapper around a ZooKeeper so that it can handle reconnections by just discarding one ZooKeeper instance and creating another. This object could be shared across Protocols (we might wanna reuse one connection with ZK to make multiple locks for example).\n", "user": "James Strachan", "created_at": "2008-07-23T10:38:16.481000-04:00", "updated_at": "2008-07-23T10:38:16.481000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12616065", "id": "12616065", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "body": "I hear you :)\n\nSo an Elect Leader or Write Lock protocol has to deal with expired sessions and create new sessions; at some point someone has to recreate something. You can pass the buck and say we're not gonna allow the ZooKeeper to reconnect. Then say we're not allowed to have the WriteLock reconnect, then the next and next layer of the onion. But eventually there's gonna be something somewhere that recreates a session :)\n\nFor now I'll work on the assumption we're gonna have to have an object which is a wrapper around a ZooKeeper so that it can handle reconnections by just discarding one ZooKeeper instance and creating another. This object could be shared across Protocols (we might wanna reuse one connection with ZK to make multiple locks for example).\n", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-23T14:38:16.481+0000", "updated": "2008-07-23T14:38:16.481+0000"}}
|
49
| 12,616,114
|
84
|
James Strachan
|
You can mark this issue as RESOLVED/WILL_NOT_FIX if you like now - I've implemented a ZooKeeperFacade to wrap up the reconnectWithNewSession() logic for ZOOKEEPER-78
|
2008-07-23T11:20:01.837000-04:00
|
2008-07-23T11:20:01.837000-04:00
|
{"id": 12616114, "body": "You can mark this issue as RESOLVED/WILL_NOT_FIX if you like now - I've implemented a ZooKeeperFacade to wrap up the reconnectWithNewSession() logic for ZOOKEEPER-78", "user": "James Strachan", "created_at": "2008-07-23T11:20:01.837000-04:00", "updated_at": "2008-07-23T11:20:01.837000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12616114", "id": "12616114", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "body": "You can mark this issue as RESOLVED/WILL_NOT_FIX if you like now - I've implemented a ZooKeeperFacade to wrap up the reconnectWithNewSession() logic for ZOOKEEPER-78", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-23T15:20:01.837+0000", "updated": "2008-07-23T15:20:01.837+0000"}}
|
50
| 12,616,140
|
84
|
Patrick D. Hunt
|
This has been a really interesting discussion, appreciate everyone digging in. Before closing this it would be great if we could capture this somewhere. James isn't going to be the only one encountering these issues.
Ben I'll assign to you, can you document this on the ASF wiki, then close? Thanks.
|
2008-07-23T12:15:31.013000-04:00
|
2008-07-23T12:15:31.013000-04:00
|
{"id": 12616140, "body": "This has been a really interesting discussion, appreciate everyone digging in. Before closing this it would be great if we could capture this somewhere. James isn't going to be the only one encountering these issues.\n\nBen I'll assign to you, can you document this on the ASF wiki, then close? Thanks.\n", "user": "Patrick D. Hunt", "created_at": "2008-07-23T12:15:31.013000-04:00", "updated_at": "2008-07-23T12:15:31.013000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12616140", "id": "12616140", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "This has been a really interesting discussion, appreciate everyone digging in. Before closing this it would be great if we could capture this somewhere. James isn't going to be the only one encountering these issues.\n\nBen I'll assign to you, can you document this on the ASF wiki, then close? Thanks.\n", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-23T16:15:31.013+0000", "updated": "2008-07-23T16:15:31.013+0000"}}
|
51
| 12,616,142
|
84
|
Patrick D. Hunt
|
Assigning to Ben to document on the wiki
|
2008-07-23T12:15:52.554000-04:00
|
2008-07-23T12:15:52.554000-04:00
|
{"id": 12616142, "body": "Assigning to Ben to document on the wiki", "user": "Patrick D. Hunt", "created_at": "2008-07-23T12:15:52.554000-04:00", "updated_at": "2008-07-23T12:15:52.554000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12616142", "id": "12616142", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Assigning to Ben to document on the wiki", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-23T16:15:52.554+0000", "updated": "2008-07-23T16:15:52.554+0000"}}
|
52
| 12,616,144
|
84
|
James Strachan
|
If ZOOKEEPER-78 ever gets committed (hint, hint :) we can just refer folks to the ZooKeeperFacade if ever folks hit the SessionExpiredException
|
2008-07-23T12:20:41.371000-04:00
|
2008-07-23T12:20:41.371000-04:00
|
{"id": 12616144, "body": "If ZOOKEEPER-78 ever gets committed (hint, hint :) we can just refer folks to the ZooKeeperFacade if ever folks hit the SessionExpiredException", "user": "James Strachan", "created_at": "2008-07-23T12:20:41.371000-04:00", "updated_at": "2008-07-23T12:20:41.371000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12616144", "id": "12616144", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "body": "If ZOOKEEPER-78 ever gets committed (hint, hint :) we can just refer folks to the ZooKeeperFacade if ever folks hit the SessionExpiredException", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-23T16:20:41.371+0000", "updated": "2008-07-23T16:20:41.371+0000"}}
|
53
| 12,616,420
|
84
|
James Strachan
|
BTW here is the code for [ZooKeeperFacade|http://svn.apache.org/viewvc/activemq/sandbox/zookeeper/zookeeper-protocols/src/main/java/org/apache/zookeeper/protocols/ZooKeeperFacade.java?view=markup] as I've checked in the patch for ZOOKEEPER-78 into a temporary sandbox area, [details here|https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616391#action_12616391]
|
2008-07-24T05:48:01.758000-04:00
|
2008-07-24T05:48:01.758000-04:00
|
{"id": 12616420, "body": "BTW here is the code for [ZooKeeperFacade|http://svn.apache.org/viewvc/activemq/sandbox/zookeeper/zookeeper-protocols/src/main/java/org/apache/zookeeper/protocols/ZooKeeperFacade.java?view=markup] as I've checked in the patch for ZOOKEEPER-78 into a temporary sandbox area, [details here|https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616391#action_12616391]", "user": "James Strachan", "created_at": "2008-07-24T05:48:01.758000-04:00", "updated_at": "2008-07-24T05:48:01.758000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12616420", "id": "12616420", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "body": "BTW here is the code for [ZooKeeperFacade|http://svn.apache.org/viewvc/activemq/sandbox/zookeeper/zookeeper-protocols/src/main/java/org/apache/zookeeper/protocols/ZooKeeperFacade.java?view=markup] as I've checked in the patch for ZOOKEEPER-78 into a temporary sandbox area, [details here|https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616391#action_12616391]", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=jstrachan", "name": "jstrachan", "key": "jstrachan", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "James Strachan", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-24T09:48:01.758+0000", "updated": "2008-07-24T09:48:01.758+0000"}}
|
54
| 12,616,684
|
84
|
Patrick D. Hunt
|
If I read the comments correctly the attached patch seems to be moot. Also the last comment references a SVN repository, please attach the patch as a "svn diff" and resubmit for review.
|
2008-07-24T18:06:23.371000-04:00
|
2008-07-24T18:06:23.371000-04:00
|
{"id": 12616684, "body": "If I read the comments correctly the attached patch seems to be moot. Also the last comment references a SVN repository, please attach the patch as a \"svn diff\" and resubmit for review.\n", "user": "Patrick D. Hunt", "created_at": "2008-07-24T18:06:23.371000-04:00", "updated_at": "2008-07-24T18:06:23.371000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12616684", "id": "12616684", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "If I read the comments correctly the attached patch seems to be moot. Also the last comment references a SVN repository, please attach the patch as a \"svn diff\" and resubmit for review.\n", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-24T22:06:23.371+0000", "updated": "2008-07-24T22:06:23.371+0000"}}
|
55
| 12,619,410
|
84
|
Mahadev Konar
|
marking this as wont fix -- since we agreed that the one to one correspondence between a zookeeper client and session keeps things simple for the users.
|
2008-08-03T23:23:29.821000-04:00
|
2008-08-03T23:23:29.821000-04:00
|
{"id": 12619410, "body": "marking this as wont fix -- since we agreed that the one to one correspondence between a zookeeper client and session keeps things simple for the users.", "user": "Mahadev Konar", "created_at": "2008-08-03T23:23:29.821000-04:00", "updated_at": "2008-08-03T23:23:29.821000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12619410", "id": "12619410", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "body": "marking this as wont fix -- since we agreed that the one to one correspondence between a zookeeper client and session keeps things simple for the users.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-08-04T03:23:29.821+0000", "updated": "2008-08-04T03:23:29.821+0000"}}
|
56
| 12,619,604
|
84
|
Benjamin Reed
|
I've documented why Facade is a bad idea on the wiki: http://wiki.apache.org/hadoop/ZooKeeper/ErrorHandling
|
2008-08-04T13:37:04.512000-04:00
|
2008-08-04T13:37:04.512000-04:00
|
{"id": 12619604, "body": "I've documented why Facade is a bad idea on the wiki: http://wiki.apache.org/hadoop/ZooKeeper/ErrorHandling", "user": "Benjamin Reed", "created_at": "2008-08-04T13:37:04.512000-04:00", "updated_at": "2008-08-04T13:37:04.512000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400741/comment/12619604", "id": "12619604", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=breed", "name": "breed", "key": "breed", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Benjamin Reed", "active": true, "timeZone": "America/Los_Angeles"}, "body": "I've documented why Facade is a bad idea on the wiki: http://wiki.apache.org/hadoop/ZooKeeper/ErrorHandling", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=breed", "name": "breed", "key": "breed", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Benjamin Reed", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-08-04T17:37:04.512+0000", "updated": "2008-08-04T17:37:04.512+0000"}}
|
57
| 12,619,882
|
91
|
Benjamin Reed
|
+1
|
2008-08-05T09:49:12.789000-04:00
|
2008-08-05T09:49:12.789000-04:00
|
{"id": 12619882, "body": "+1", "user": "Benjamin Reed", "created_at": "2008-08-05T09:49:12.789000-04:00", "updated_at": "2008-08-05T09:49:12.789000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400907/comment/12619882", "id": "12619882", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=breed", "name": "breed", "key": "breed", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Benjamin Reed", "active": true, "timeZone": "America/Los_Angeles"}, "body": "+1", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=breed", "name": "breed", "key": "breed", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Benjamin Reed", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-08-05T13:49:12.789+0000", "updated": "2008-08-05T13:49:12.789+0000"}}
|
58
| 12,616,626
|
26
|
Andrew Kornev
|
This feature was implemented and commited prior to the apache move.
|
2008-07-24T16:14:05.811000-04:00
|
2008-07-24T16:14:05.811000-04:00
|
{"id": 12616626, "body": "This feature was implemented and commited prior to the apache move.", "user": "Andrew Kornev", "created_at": "2008-07-24T16:14:05.811000-04:00", "updated_at": "2008-07-24T16:14:05.811000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397987/comment/12616626", "id": "12616626", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "body": "This feature was implemented and commited prior to the apache move.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=akornev", "name": "akornev", "key": "akornev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Andrew Kornev", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-24T20:14:05.811+0000", "updated": "2008-07-24T20:14:05.811+0000"}}
|
59
| 12,626,226
|
13
|
Patrick D. Hunt
|
Dup of ZOOKEEPER-77
|
2008-08-27T14:28:11.148000-04:00
|
2008-08-27T14:28:11.148000-04:00
|
{"id": 12626226, "body": "Dup of ZOOKEEPER-77", "user": "Patrick D. Hunt", "created_at": "2008-08-27T14:28:11.148000-04:00", "updated_at": "2008-08-27T14:28:11.148000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397972/comment/12626226", "id": "12626226", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Dup of ZOOKEEPER-77", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-08-27T18:28:11.148+0000", "updated": "2008-08-27T18:28:11.148+0000"}}
|
60
| 12,614,007
|
77
|
Patrick D. Hunt
|
According to the stack trace the line causing the problem is:
a_.writeString(path,"path");
in watcher event.
Should it ever be the case that the path can be null?
We should look at the static code analysis output to see if this is flagged.
|
2008-07-16T12:28:55.184000-04:00
|
2008-07-16T12:28:55.184000-04:00
|
{"id": 12614007, "body": "According to the stack trace the line causing the problem is:\n\n a_.writeString(path,\"path\");\n\nin watcher event.\n\nShould it ever be the case that the path can be null?\n\nWe should look at the static code analysis output to see if this is flagged.\n", "user": "Patrick D. Hunt", "created_at": "2008-07-16T12:28:55.184000-04:00", "updated_at": "2008-07-16T12:28:55.184000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400389/comment/12614007", "id": "12614007", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "According to the stack trace the line causing the problem is:\n\n a_.writeString(path,\"path\");\n\nin watcher event.\n\nShould it ever be the case that the path can be null?\n\nWe should look at the static code analysis output to see if this is flagged.\n", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-16T16:28:55.184+0000", "updated": "2008-07-16T16:28:55.184+0000"}}
|
61
| 12,615,818
|
77
|
Patrick D. Hunt
|
Assigning to Ben as this seems related to ZOOKEEPER-16
|
2008-07-22T18:40:54.559000-04:00
|
2008-07-22T18:40:54.559000-04:00
|
{"id": 12615818, "body": "Assigning to Ben as this seems related to ZOOKEEPER-16", "user": "Patrick D. Hunt", "created_at": "2008-07-22T18:40:54.559000-04:00", "updated_at": "2008-07-22T18:40:54.559000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400389/comment/12615818", "id": "12615818", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Assigning to Ben as this seems related to ZOOKEEPER-16", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-22T22:40:54.559+0000", "updated": "2008-07-22T22:40:54.559+0000"}}
|
62
| 12,615,891
|
77
|
Martin Schaaf
|
I can confirm that the reason is a null path. if I set the path to a default string in case it is null the NPE is gone.
|
2008-07-23T02:18:59.179000-04:00
|
2008-07-23T02:18:59.179000-04:00
|
{"id": 12615891, "body": "I can confirm that the reason is a null path. if I set the path to a default string in case it is null the NPE is gone.", "user": "Martin Schaaf", "created_at": "2008-07-23T02:18:59.179000-04:00", "updated_at": "2008-07-23T02:18:59.179000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400389/comment/12615891", "id": "12615891", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=msat101tecdotcom", "name": "msat101tecdotcom", "key": "msat101tecdotcom", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Martin Schaaf", "active": true, "timeZone": "Etc/UTC"}, "body": "I can confirm that the reason is a null path. if I set the path to a default string in case it is null the NPE is gone.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=msat101tecdotcom", "name": "msat101tecdotcom", "key": "msat101tecdotcom", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Martin Schaaf", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-23T06:18:59.179+0000", "updated": "2008-07-23T06:18:59.179+0000"}}
|
63
| 12,626,230
|
77
|
Patrick D. Hunt
|
Dup of ZOOKEEPER-16 - I've updated 16 to make sure that as part of path checking we verify that the path is non-null.
|
2008-08-27T14:30:48.357000-04:00
|
2008-08-27T14:30:48.357000-04:00
|
{"id": 12626230, "body": "Dup of ZOOKEEPER-16 - I've updated 16 to make sure that as part of path checking we verify that the path is non-null.", "user": "Patrick D. Hunt", "created_at": "2008-08-27T14:30:48.357000-04:00", "updated_at": "2008-08-27T14:30:48.357000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12400389/comment/12626230", "id": "12626230", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Dup of ZOOKEEPER-16 - I've updated 16 to make sure that as part of path checking we verify that the path is non-null.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-08-27T18:30:48.357+0000", "updated": "2008-08-27T18:30:48.357+0000"}}
|
64
| 12,627,058
|
129
|
Mahadev Konar
|
chris, would you be willing to provide a complete interface that supports watches? I think it would be good to have this as a part of contrib. If you do decide on creating a complete interface, then two important things that you would need to do is
1) documentation in forrest on how it works and setup.
2) unit tests to test the interface.
|
2008-08-29T14:18:29.280000-04:00
|
2008-08-29T14:18:29.280000-04:00
|
{"id": 12627058, "body": "chris, would you be willing to provide a complete interface that supports watches? I think it would be good to have this as a part of contrib. If you do decide on creating a complete interface, then two important things that you would need to do is \n\n1) documentation in forrest on how it works and setup.\n2) unit tests to test the interface.\n", "user": "Mahadev Konar", "created_at": "2008-08-29T14:18:29.280000-04:00", "updated_at": "2008-08-29T14:18:29.280000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12403378/comment/12627058", "id": "12627058", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "body": "chris, would you be willing to provide a complete interface that supports watches? I think it would be good to have this as a part of contrib. If you do decide on creating a complete interface, then two important things that you would need to do is \n\n1) documentation in forrest on how it works and setup.\n2) unit tests to test the interface.\n", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-08-29T18:18:29.280+0000", "updated": "2008-08-29T18:18:29.280+0000"}}
|
65
| 12,627,109
|
129
|
Patrick D. Hunt
|
+1 on Mahadev's comments (unit tests should live within this contrib module's subdir(s) somewhere)
Having a readme that details how to build/simpleexample would be nice for ppl not already experienced with thrift.
also:
1) *.java/.xml/.thrift files need apache source license headers
2) libthrift.jar needs to be renamed to specify the version
3) libthrift.jar also needs an accompanying libthrift-###.LICENSE.txt file
( see src/java/lib for examples with junit/log4j)
|
2008-08-29T17:01:10.253000-04:00
|
2008-08-29T17:01:10.253000-04:00
|
{"id": 12627109, "body": "+1 on Mahadev's comments (unit tests should live within this contrib module's subdir(s) somewhere)\n\nHaving a readme that details how to build/simpleexample would be nice for ppl not already experienced with thrift.\n\nalso:\n\n1) *.java/.xml/.thrift files need apache source license headers\n2) libthrift.jar needs to be renamed to specify the version\n3) libthrift.jar also needs an accompanying libthrift-###.LICENSE.txt file\n ( see src/java/lib for examples with junit/log4j)\n", "user": "Patrick D. Hunt", "created_at": "2008-08-29T17:01:10.253000-04:00", "updated_at": "2008-08-29T17:01:10.253000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12403378/comment/12627109", "id": "12627109", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "+1 on Mahadev's comments (unit tests should live within this contrib module's subdir(s) somewhere)\n\nHaving a readme that details how to build/simpleexample would be nice for ppl not already experienced with thrift.\n\nalso:\n\n1) *.java/.xml/.thrift files need apache source license headers\n2) libthrift.jar needs to be renamed to specify the version\n3) libthrift.jar also needs an accompanying libthrift-###.LICENSE.txt file\n ( see src/java/lib for examples with junit/log4j)\n", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-08-29T21:01:10.253+0000", "updated": "2008-08-29T21:01:10.253+0000"}}
|
66
| 12,604,070
|
19
|
Patrick D. Hunt
|
Patch submitted on SF at:
http://sourceforge.net/tracker/index.php?func=detail&aid=1986201&group_id=209147&atid=1008546
|
2008-06-10T18:52:55.064000-04:00
|
2008-06-10T18:52:55.064000-04:00
|
{"id": 12604070, "body": "Patch submitted on SF at:\nhttp://sourceforge.net/tracker/index.php?func=detail&aid=1986201&group_id=209147&atid=1008546", "user": "Patrick D. Hunt", "created_at": "2008-06-10T18:52:55.064000-04:00", "updated_at": "2008-06-10T18:52:55.064000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397978/comment/12604070", "id": "12604070", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Patch submitted on SF at:\nhttp://sourceforge.net/tracker/index.php?func=detail&aid=1986201&group_id=209147&atid=1008546", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-06-10T22:52:55.064+0000", "updated": "2008-06-10T22:52:55.064+0000"}}
|
67
| 12,625,664
|
19
|
Flavio Paiva Junqueira
|
What is the status of jute? Is it worth porting this patch? Or should I just close this issue and wait for a replacement to jute?
|
2008-08-26T04:18:24.945000-04:00
|
2008-08-26T04:18:24.945000-04:00
|
{"id": 12625664, "body": "What is the status of jute? Is it worth porting this patch? Or should I just close this issue and wait for a replacement to jute?", "user": "Flavio Paiva Junqueira", "created_at": "2008-08-26T04:18:24.945000-04:00", "updated_at": "2008-08-26T04:18:24.945000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397978/comment/12625664", "id": "12625664", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "body": "What is the status of jute? Is it worth porting this patch? Or should I just close this issue and wait for a replacement to jute?", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "created": "2008-08-26T08:18:24.945+0000", "updated": "2008-08-26T08:18:24.945+0000"}}
|
68
| 12,625,794
|
19
|
Mahadev Konar
|
i would suggest clsoing this patch for now. We intend to replace Jute sometime in the future.
|
2008-08-26T13:16:29.136000-04:00
|
2008-08-26T13:16:29.136000-04:00
|
{"id": 12625794, "body": "i would suggest clsoing this patch for now. We intend to replace Jute sometime in the future.\n", "user": "Mahadev Konar", "created_at": "2008-08-26T13:16:29.136000-04:00", "updated_at": "2008-08-26T13:16:29.136000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397978/comment/12625794", "id": "12625794", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "body": "i would suggest clsoing this patch for now. We intend to replace Jute sometime in the future.\n", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-08-26T17:16:29.136+0000", "updated": "2008-08-26T17:16:29.136+0000"}}
|
69
| 12,629,618
|
19
|
Flavio Paiva Junqueira
|
By Mahadev's suggestion, I'm closing this issue for now.
|
2008-09-09T17:06:55.737000-04:00
|
2008-09-09T17:06:55.737000-04:00
|
{"id": 12629618, "body": "By Mahadev's suggestion, I'm closing this issue for now.", "user": "Flavio Paiva Junqueira", "created_at": "2008-09-09T17:06:55.737000-04:00", "updated_at": "2008-09-09T17:06:55.737000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397978/comment/12629618", "id": "12629618", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "body": "By Mahadev's suggestion, I'm closing this issue for now.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "created": "2008-09-09T21:06:55.737+0000", "updated": "2008-09-09T21:06:55.737+0000"}}
|
70
| 12,604,535
|
2
|
Flavio Paiva Junqueira
|
This is a tentative patch to fix the problems pointed out on QuorumPeer and FastLeaderElection.
1- Makes logicalclock volatile;
2- Creates accessor methods for currentVote and state, and enforce their use;
3- Accessor methods are synchronized.
-F
|
2008-06-12T11:14:25.610000-04:00
|
2008-06-12T11:14:25.610000-04:00
|
{"id": 12604535, "body": "This is a tentative patch to fix the problems pointed out on QuorumPeer and FastLeaderElection.\n\n1- Makes logicalclock volatile;\n2- Creates accessor methods for currentVote and state, and enforce their use;\n3- Accessor methods are synchronized.\n\n-F", "user": "Flavio Paiva Junqueira", "created_at": "2008-06-12T11:14:25.610000-04:00", "updated_at": "2008-06-12T11:14:25.610000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397819/comment/12604535", "id": "12604535", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "body": "This is a tentative patch to fix the problems pointed out on QuorumPeer and FastLeaderElection.\n\n1- Makes logicalclock volatile;\n2- Creates accessor methods for currentVote and state, and enforce their use;\n3- Accessor methods are synchronized.\n\n-F", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "created": "2008-06-12T15:14:25.610+0000", "updated": "2008-06-12T15:14:25.610+0000"}}
|
71
| 12,604,537
|
2
|
Flavio Paiva Junqueira
|
Please check the attached patch.
|
2008-06-12T11:15:43.128000-04:00
|
2008-06-12T11:15:43.128000-04:00
|
{"id": 12604537, "body": "Please check the attached patch.", "user": "Flavio Paiva Junqueira", "created_at": "2008-06-12T11:15:43.128000-04:00", "updated_at": "2008-06-12T11:15:43.128000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397819/comment/12604537", "id": "12604537", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "body": "Please check the attached patch.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "created": "2008-06-12T15:15:43.128+0000", "updated": "2008-06-12T15:15:43.128+0000"}}
|
72
| 12,604,645
|
2
|
Evan Jones
|
A quick look at the patch looks good to me. However there is a "long logicalclock" in AuthFastLeaderElection.java as well. It looks like it should also be volatile.
|
2008-06-12T17:22:01.359000-04:00
|
2008-06-12T17:22:01.359000-04:00
|
{"id": 12604645, "body": "A quick look at the patch looks good to me. However there is a \"long logicalclock\" in AuthFastLeaderElection.java as well. It looks like it should also be volatile.", "user": "Evan Jones", "created_at": "2008-06-12T17:22:01.359000-04:00", "updated_at": "2008-06-12T17:22:01.359000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397819/comment/12604645", "id": "12604645", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=evanj", "name": "evanj", "key": "evanj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Evan Jones", "active": true, "timeZone": "Etc/UTC"}, "body": "A quick look at the patch looks good to me. However there is a \"long logicalclock\" in AuthFastLeaderElection.java as well. It looks like it should also be volatile.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=evanj", "name": "evanj", "key": "evanj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Evan Jones", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-06-12T21:22:01.359+0000", "updated": "2008-06-12T21:22:01.359+0000"}}
|
73
| 12,607,315
|
2
|
Flavio Paiva Junqueira
|
Have made logicalclock on AuthFastLeaderElection volatile as well.
|
2008-06-23T13:56:32.914000-04:00
|
2008-06-23T13:56:32.914000-04:00
|
{"id": 12607315, "body": "Have made logicalclock on AuthFastLeaderElection volatile as well.", "user": "Flavio Paiva Junqueira", "created_at": "2008-06-23T13:56:32.914000-04:00", "updated_at": "2008-06-23T13:56:32.914000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397819/comment/12607315", "id": "12607315", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "body": "Have made logicalclock on AuthFastLeaderElection volatile as well.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "created": "2008-06-23T17:56:32.914+0000", "updated": "2008-06-23T17:56:32.914+0000"}}
|
74
| 12,607,321
|
2
|
Flavio Paiva Junqueira
|
Please review. -F
|
2008-06-23T14:07:31.787000-04:00
|
2008-06-23T14:07:31.787000-04:00
|
{"id": 12607321, "body": "Please review. -F", "user": "Flavio Paiva Junqueira", "created_at": "2008-06-23T14:07:31.787000-04:00", "updated_at": "2008-06-23T14:07:31.787000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397819/comment/12607321", "id": "12607321", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "body": "Please review. -F", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=fpj", "name": "fpj", "key": "fpj", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?ownerId=fpj&avatarId=16030", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&ownerId=fpj&avatarId=16030", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=fpj&avatarId=16030", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&ownerId=fpj&avatarId=16030"}, "displayName": "Flavio Paiva Junqueira", "active": true, "timeZone": "Europe/Berlin"}, "created": "2008-06-23T18:07:31.787+0000", "updated": "2008-06-23T18:07:31.787+0000"}}
|
75
| 12,615,677
|
2
|
Patrick D. Hunt
|
Mahadev please review this patch.
|
2008-07-22T13:11:16.598000-04:00
|
2008-07-22T13:11:16.598000-04:00
|
{"id": 12615677, "body": "Mahadev please review this patch.", "user": "Patrick D. Hunt", "created_at": "2008-07-22T13:11:16.598000-04:00", "updated_at": "2008-07-22T13:11:16.598000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397819/comment/12615677", "id": "12615677", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "Mahadev please review this patch.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-22T17:11:16.598+0000", "updated": "2008-07-22T17:11:16.598+0000"}}
|
76
| 12,615,691
|
2
|
Mahadev Konar
|
assigning this back to flavio since he is working on the patch and I will review it.
|
2008-07-22T13:43:02.750000-04:00
|
2008-07-22T13:43:02.750000-04:00
|
{"id": 12615691, "body": "assigning this back to flavio since he is working on the patch and I will review it.", "user": "Mahadev Konar", "created_at": "2008-07-22T13:43:02.750000-04:00", "updated_at": "2008-07-22T13:43:02.750000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397819/comment/12615691", "id": "12615691", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "body": "assigning this back to flavio since he is working on the patch and I will review it.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=mahadev", "name": "mahadev", "key": "mahadev", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Mahadev Konar", "active": true, "timeZone": "Etc/UTC"}, "created": "2008-07-22T17:43:02.750+0000", "updated": "2008-07-22T17:43:02.750+0000"}}
|
77
| 12,618,847
|
2
|
Patrick D. Hunt
|
I updated flavio's patch for the new directory structure on apache.
|
2008-07-31T16:58:44.535000-04:00
|
2008-07-31T16:58:44.535000-04:00
|
{"id": 12618847, "body": "I updated flavio's patch for the new directory structure on apache.", "user": "Patrick D. Hunt", "created_at": "2008-07-31T16:58:44.535000-04:00", "updated_at": "2008-07-31T16:58:44.535000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397819/comment/12618847", "id": "12618847", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "I updated flavio's patch for the new directory structure on apache.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-31T20:58:44.535+0000", "updated": "2008-07-31T20:58:44.535+0000"}}
|
78
| 12,618,848
|
2
|
Patrick D. Hunt
|
This patch fails "ant test", specifically I see alot of the following in the log:
Exception in thread "QuorumPeer" java.lang.NullPointerException
at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:397)
(I ran the tests 3 times, failed each time in the same way, mainline test passes fine)
This is ubuntu machine with java 1.6.0_06 (single cpu/core)
|
2008-07-31T17:00:25.216000-04:00
|
2008-07-31T17:00:25.216000-04:00
|
{"id": 12618848, "body": "This patch fails \"ant test\", specifically I see alot of the following in the log:\n\nException in thread \"QuorumPeer\" java.lang.NullPointerException\n\tat org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:397)\n\n(I ran the tests 3 times, failed each time in the same way, mainline test passes fine)\nThis is ubuntu machine with java 1.6.0_06 (single cpu/core)", "user": "Patrick D. Hunt", "created_at": "2008-07-31T17:00:25.216000-04:00", "updated_at": "2008-07-31T17:00:25.216000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397819/comment/12618848", "id": "12618848", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "This patch fails \"ant test\", specifically I see alot of the following in the log:\n\nException in thread \"QuorumPeer\" java.lang.NullPointerException\n\tat org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:397)\n\n(I ran the tests 3 times, failed each time in the same way, mainline test passes fine)\nThis is ubuntu machine with java 1.6.0_06 (single cpu/core)", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-31T21:00:25.216+0000", "updated": "2008-07-31T21:00:25.216+0000"}}
|
79
| 12,618,849
|
2
|
Patrick D. Hunt
|
PS, in future please use the <id>.patch naming scheme, ie. ZOOKEEPER-2.patch, thanks.
|
2008-07-31T17:01:09.910000-04:00
|
2008-07-31T17:01:09.910000-04:00
|
{"id": 12618849, "body": "PS, in future please use the <id>.patch naming scheme, ie. ZOOKEEPER-2.patch, thanks.", "user": "Patrick D. Hunt", "created_at": "2008-07-31T17:01:09.910000-04:00", "updated_at": "2008-07-31T17:01:09.910000-04:00", "_provider": "jira", "raw": {"self": "https://issues.apache.org/jira/rest/api/2/issue/12397819/comment/12618849", "id": "12618849", "author": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "body": "PS, in future please use the <id>.patch naming scheme, ie. ZOOKEEPER-2.patch, thanks.", "updateAuthor": {"self": "https://issues.apache.org/jira/rest/api/2/user?username=phunt", "name": "phunt", "key": "phunt", "avatarUrls": {"48x48": "https://issues.apache.org/jira/secure/useravatar?avatarId=10452", "24x24": "https://issues.apache.org/jira/secure/useravatar?size=small&avatarId=10452", "16x16": "https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452", "32x32": "https://issues.apache.org/jira/secure/useravatar?size=medium&avatarId=10452"}, "displayName": "Patrick D. Hunt", "active": true, "timeZone": "America/Los_Angeles"}, "created": "2008-07-31T21:01:09.910+0000", "updated": "2008-07-31T21:01:09.910+0000"}}
|
End of preview. Expand
in Data Studio
README.md exists but content is empty.
- Downloads last month
- 40